dawn-cmake/test/tint/builtins/atomicStore/struct
Antonio Maiorano 06844a5e24 tint/hlsl: remove [loop] attribute on all loops
I added the forcing of the "loop" attribute to all loops to address FXC
failing on uniformity errors related to gradients in loops. Since then,
Tint now implements UA and it recently became an error, so we no longer
need this hack. As a result, FXC is now better able to cope with loops
that it determines executes 0 times.

Most e2e tests are affected because so many use loops, but 27 tests that
were previously failing are now passing with this change:

tint/bug/tint/1538.wgsl.expected.fxc.hlsl
tint/bug/tint/1604.wgsl.expected.fxc.hlsl
tint/bug/tint/1605.wgsl.expected.fxc.hlsl
tint/unittest/reader/spirv/SpvParserCFGTest_ClassifyCFGEdges_LoopBreak_FromLoopHeader_SingleBlockLoop_TrueBranch.spvasm.expected.fxc.hlsl
tint/unittest/reader/spirv/SpvParserCFGTest_ComputeBlockOrder_Loop_HeaderHasBreakUnless.spvasm.expected.fxc.hlsl
tint/unittest/reader/spirv/SpvParserCFGTest_EmitBody_IfSelection_TrueBranch_LoopBreak.spvasm.expected.fxc.hlsl
tint/unittest/reader/spirv/SpvParserCFGTest_FindIfSelectionInternalHeaders_TrueBranch_LoopBreak_Ok.spvasm.expected.fxc.hlsl
tint/unittest/reader/spirv/SpvParserFunctionVarTest_EmitStatement_Phi_MultiBlockLoopIndex.spvasm.expected.fxc.hlsl
tint/unittest/reader/spirv/SpvParserFunctionVarTest_EmitStatement_Phi_SingleBlockLoopIndex.spvasm.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/cov-dead-code-unreachable-merge/0-opt.spvasm.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/cov-dead-code-unreachable-merge/0-opt.wgsl.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/similar-nested-ifs/0-opt.spvasm.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/similar-nested-ifs/0-opt.wgsl.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/spv-load-from-frag-color/1.spvasm.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/spv-load-from-frag-color/1.wgsl.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-false-if-discard-loop/0.spvasm.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-false-if-discard-loop/0.wgsl.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-fragcoord-less-than-zero/0.spvasm.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-fragcoord-less-than-zero/0.wgsl.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-fragcoord-less-than-zero/1.spvasm.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-fragcoord-less-than-zero/1.wgsl.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-with-loop-read-write-global/0-opt.spvasm.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-with-loop-read-write-global/0-opt.wgsl.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-with-loop-read-write-global/1.spvasm.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-with-loop-read-write-global/1.wgsl.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/write-red-after-search/0-opt.spvasm.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/write-red-after-search/0-opt.wgsl.expected.fxc.hlsl

Bug: tint:1522
Bug: tint:1538
Bug: tint:1604
Bug: tint:1605
Change-Id: I530b846b6b8df122ab351ff7b85d3e1c9ac11526
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104121
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-29 16:53:58 +00:00
..
array_of_struct.spvasm
array_of_struct.spvasm.expected.dxc.hlsl tint/hlsl: remove [loop] attribute on all loops 2022-09-29 16:53:58 +00:00
array_of_struct.spvasm.expected.fxc.hlsl tint/hlsl: remove [loop] attribute on all loops 2022-09-29 16:53:58 +00:00
array_of_struct.spvasm.expected.glsl tint: remove LoopToForLoop and FoldTrivialSingleUseLets transforms for HLSL and GLSL 2022-09-19 14:05:21 +00:00
array_of_struct.spvasm.expected.msl
array_of_struct.spvasm.expected.spvasm
array_of_struct.spvasm.expected.wgsl
array_of_struct.wgsl
array_of_struct.wgsl.expected.dxc.hlsl tint/hlsl: remove [loop] attribute on all loops 2022-09-29 16:53:58 +00:00
array_of_struct.wgsl.expected.fxc.hlsl tint/hlsl: remove [loop] attribute on all loops 2022-09-29 16:53:58 +00:00
array_of_struct.wgsl.expected.glsl
array_of_struct.wgsl.expected.msl
array_of_struct.wgsl.expected.spvasm
array_of_struct.wgsl.expected.wgsl
flat_multiple_atomics.spvasm
flat_multiple_atomics.spvasm.expected.dxc.hlsl tint: remove LoopToForLoop and FoldTrivialSingleUseLets transforms for HLSL and GLSL 2022-09-19 14:05:21 +00:00
flat_multiple_atomics.spvasm.expected.fxc.hlsl tint: remove LoopToForLoop and FoldTrivialSingleUseLets transforms for HLSL and GLSL 2022-09-19 14:05:21 +00:00
flat_multiple_atomics.spvasm.expected.glsl tint: remove LoopToForLoop and FoldTrivialSingleUseLets transforms for HLSL and GLSL 2022-09-19 14:05:21 +00:00
flat_multiple_atomics.spvasm.expected.msl
flat_multiple_atomics.spvasm.expected.spvasm
flat_multiple_atomics.spvasm.expected.wgsl
flat_multiple_atomics.wgsl
flat_multiple_atomics.wgsl.expected.dxc.hlsl tint/test-runner: Split expectations for FXC and DXC 2022-07-22 17:43:27 +00:00
flat_multiple_atomics.wgsl.expected.fxc.hlsl tint/test-runner: Split expectations for FXC and DXC 2022-07-22 17:43:27 +00:00
flat_multiple_atomics.wgsl.expected.glsl
flat_multiple_atomics.wgsl.expected.msl
flat_multiple_atomics.wgsl.expected.spvasm
flat_multiple_atomics.wgsl.expected.wgsl
flat_single_atomic.spvasm
flat_single_atomic.spvasm.expected.dxc.hlsl tint: remove LoopToForLoop and FoldTrivialSingleUseLets transforms for HLSL and GLSL 2022-09-19 14:05:21 +00:00
flat_single_atomic.spvasm.expected.fxc.hlsl tint: remove LoopToForLoop and FoldTrivialSingleUseLets transforms for HLSL and GLSL 2022-09-19 14:05:21 +00:00
flat_single_atomic.spvasm.expected.glsl tint: remove LoopToForLoop and FoldTrivialSingleUseLets transforms for HLSL and GLSL 2022-09-19 14:05:21 +00:00
flat_single_atomic.spvasm.expected.msl
flat_single_atomic.spvasm.expected.spvasm
flat_single_atomic.spvasm.expected.wgsl
flat_single_atomic.wgsl
flat_single_atomic.wgsl.expected.dxc.hlsl tint/test-runner: Split expectations for FXC and DXC 2022-07-22 17:43:27 +00:00
flat_single_atomic.wgsl.expected.fxc.hlsl tint/test-runner: Split expectations for FXC and DXC 2022-07-22 17:43:27 +00:00
flat_single_atomic.wgsl.expected.glsl
flat_single_atomic.wgsl.expected.msl
flat_single_atomic.wgsl.expected.spvasm
flat_single_atomic.wgsl.expected.wgsl
nested.spvasm
nested.spvasm.expected.dxc.hlsl tint: remove LoopToForLoop and FoldTrivialSingleUseLets transforms for HLSL and GLSL 2022-09-19 14:05:21 +00:00
nested.spvasm.expected.fxc.hlsl tint: remove LoopToForLoop and FoldTrivialSingleUseLets transforms for HLSL and GLSL 2022-09-19 14:05:21 +00:00
nested.spvasm.expected.glsl tint: remove LoopToForLoop and FoldTrivialSingleUseLets transforms for HLSL and GLSL 2022-09-19 14:05:21 +00:00
nested.spvasm.expected.msl
nested.spvasm.expected.spvasm
nested.spvasm.expected.wgsl
nested.wgsl
nested.wgsl.expected.dxc.hlsl tint/test-runner: Split expectations for FXC and DXC 2022-07-22 17:43:27 +00:00
nested.wgsl.expected.fxc.hlsl tint/test-runner: Split expectations for FXC and DXC 2022-07-22 17:43:27 +00:00
nested.wgsl.expected.glsl
nested.wgsl.expected.msl
nested.wgsl.expected.spvasm
nested.wgsl.expected.wgsl
struct_of_array.spvasm
struct_of_array.spvasm.expected.dxc.hlsl tint/hlsl: remove [loop] attribute on all loops 2022-09-29 16:53:58 +00:00
struct_of_array.spvasm.expected.fxc.hlsl tint/hlsl: remove [loop] attribute on all loops 2022-09-29 16:53:58 +00:00
struct_of_array.spvasm.expected.glsl tint: remove LoopToForLoop and FoldTrivialSingleUseLets transforms for HLSL and GLSL 2022-09-19 14:05:21 +00:00
struct_of_array.spvasm.expected.msl
struct_of_array.spvasm.expected.spvasm
struct_of_array.spvasm.expected.wgsl
struct_of_array.wgsl
struct_of_array.wgsl.expected.dxc.hlsl tint/hlsl: remove [loop] attribute on all loops 2022-09-29 16:53:58 +00:00
struct_of_array.wgsl.expected.fxc.hlsl tint/hlsl: remove [loop] attribute on all loops 2022-09-29 16:53:58 +00:00
struct_of_array.wgsl.expected.glsl
struct_of_array.wgsl.expected.msl
struct_of_array.wgsl.expected.spvasm
struct_of_array.wgsl.expected.wgsl
via_ptr_let.spvasm
via_ptr_let.spvasm.expected.dxc.hlsl tint: remove LoopToForLoop and FoldTrivialSingleUseLets transforms for HLSL and GLSL 2022-09-19 14:05:21 +00:00
via_ptr_let.spvasm.expected.fxc.hlsl tint: remove LoopToForLoop and FoldTrivialSingleUseLets transforms for HLSL and GLSL 2022-09-19 14:05:21 +00:00
via_ptr_let.spvasm.expected.glsl tint: remove LoopToForLoop and FoldTrivialSingleUseLets transforms for HLSL and GLSL 2022-09-19 14:05:21 +00:00
via_ptr_let.spvasm.expected.msl
via_ptr_let.spvasm.expected.spvasm
via_ptr_let.spvasm.expected.wgsl
via_ptr_let.wgsl
via_ptr_let.wgsl.expected.dxc.hlsl tint/test-runner: Split expectations for FXC and DXC 2022-07-22 17:43:27 +00:00
via_ptr_let.wgsl.expected.fxc.hlsl tint/test-runner: Split expectations for FXC and DXC 2022-07-22 17:43:27 +00:00
via_ptr_let.wgsl.expected.glsl
via_ptr_let.wgsl.expected.msl
via_ptr_let.wgsl.expected.spvasm
via_ptr_let.wgsl.expected.wgsl