mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-07-01 02:43:29 +00:00
a594f8fdb4
Dawn used to return "nullptr" when an error happened while creating an object. To match WebGPU we want to return valid pointers but to "error" objects. This commit implements WebGPU error handling for all "descriptorized" objects and changes the nullptr error checks into "ValidateObject" checks. This method is used both to check that the object isn't an error, but also that all objects in a function call are from the same device. New validation is added to objects with methods (apart from Device) so they check they aren't error objects. A large number of ASSERTs were added to check that frontend objects aren't accessed when they are errors, so that missing validation would hit the asserts instead of crashing randomly. The bind group validation tests were modified to test the behavior with both nullptrs and error objects. Future commits will change the CommandBufferBuilder to not be a builder anymore but an "Encoder" instead with special-cased error handling. Then once all objects are descriptorized, the notion of builders will be removed from the code. BUG=dawn:8 Change-Id: I8647712d5de3deb0e99e3bc58f34496f67710edd Reviewed-on: https://dawn-review.googlesource.com/c/4360 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
47 lines
1.4 KiB
C++
47 lines
1.4 KiB
C++
// Copyright 2018 The Dawn Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#ifndef DAWNNATIVE_OBJECTBASE_H_
|
|
#define DAWNNATIVE_OBJECTBASE_H_
|
|
|
|
#include "dawn_native/RefCounted.h"
|
|
|
|
namespace dawn_native {
|
|
|
|
class DeviceBase;
|
|
|
|
class ObjectBase : public RefCounted {
|
|
public:
|
|
struct ErrorTag {};
|
|
static constexpr ErrorTag kError = {};
|
|
|
|
ObjectBase(DeviceBase* device);
|
|
ObjectBase(DeviceBase* device, ErrorTag tag);
|
|
virtual ~ObjectBase();
|
|
|
|
DeviceBase* GetDevice() const;
|
|
bool IsError() const;
|
|
|
|
private:
|
|
DeviceBase* mDevice;
|
|
// TODO(cwallez@chromium.org): This most likely adds 4 bytes to most Dawn objects, see if
|
|
// that bit can be hidden in the refcount once it is a single 64bit refcount.
|
|
// See https://bugs.chromium.org/p/dawn/issues/detail?id=105
|
|
bool mIsError;
|
|
};
|
|
|
|
} // namespace dawn_native
|
|
|
|
#endif // DAWNNATIVE_OBJECTBASE_H_
|