mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-08-07 12:45:57 +00:00
ee23c17345
Use global declaration order for allocating implicit pipeline-overridable constant IDs, instead of iterating over an unordered_map. Bug: tint:1155 Change-Id: Ia5ff534c617b0d57e45fc20dd0a5a591854e6473 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/65522 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Ben Clayton <bclayton@google.com>
110 lines
3.6 KiB
C++
110 lines
3.6 KiB
C++
// Copyright 2021 The Tint Authors.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "src/resolver/resolver.h"
|
|
|
|
#include "src/resolver/resolver_test_helper.h"
|
|
|
|
namespace tint {
|
|
namespace resolver {
|
|
namespace {
|
|
|
|
class ResolverPipelineOverridableConstantTest : public ResolverTest {
|
|
protected:
|
|
/// Verify that the AST node `var` was resolved to an overridable constant
|
|
/// with an ID equal to `id`.
|
|
/// @param var the overridable constant AST node
|
|
/// @param id the expected constant ID
|
|
void ExpectConstantId(const ast::Variable* var, uint16_t id) {
|
|
auto* sem = Sem().Get<sem::GlobalVariable>(var);
|
|
ASSERT_NE(sem, nullptr);
|
|
EXPECT_EQ(sem->Declaration(), var);
|
|
EXPECT_TRUE(sem->IsPipelineConstant());
|
|
EXPECT_EQ(sem->ConstantId(), id);
|
|
}
|
|
};
|
|
|
|
TEST_F(ResolverPipelineOverridableConstantTest, NonOverridable) {
|
|
auto* a = GlobalConst("a", ty.f32(), Construct(ty.f32()));
|
|
|
|
EXPECT_TRUE(r()->Resolve()) << r()->error();
|
|
|
|
auto* sem_a = Sem().Get<sem::GlobalVariable>(a);
|
|
ASSERT_NE(sem_a, nullptr);
|
|
EXPECT_EQ(sem_a->Declaration(), a);
|
|
EXPECT_FALSE(sem_a->IsPipelineConstant());
|
|
}
|
|
|
|
TEST_F(ResolverPipelineOverridableConstantTest, WithId) {
|
|
auto* a = GlobalConst("a", ty.f32(), Construct(ty.f32()), {Override(7u)});
|
|
|
|
EXPECT_TRUE(r()->Resolve()) << r()->error();
|
|
|
|
ExpectConstantId(a, 7u);
|
|
}
|
|
|
|
TEST_F(ResolverPipelineOverridableConstantTest, WithoutId) {
|
|
auto* a = GlobalConst("a", ty.f32(), Construct(ty.f32()), {Override()});
|
|
|
|
EXPECT_TRUE(r()->Resolve()) << r()->error();
|
|
|
|
ExpectConstantId(a, 0u);
|
|
}
|
|
|
|
TEST_F(ResolverPipelineOverridableConstantTest, WithAndWithoutIds) {
|
|
std::vector<ast::Variable*> variables;
|
|
auto* a = GlobalConst("a", ty.f32(), Construct(ty.f32()), {Override()});
|
|
auto* b = GlobalConst("b", ty.f32(), Construct(ty.f32()), {Override()});
|
|
auto* c = GlobalConst("c", ty.f32(), Construct(ty.f32()), {Override(2u)});
|
|
auto* d = GlobalConst("d", ty.f32(), Construct(ty.f32()), {Override(4u)});
|
|
auto* e = GlobalConst("e", ty.f32(), Construct(ty.f32()), {Override()});
|
|
auto* f = GlobalConst("f", ty.f32(), Construct(ty.f32()), {Override(1u)});
|
|
|
|
EXPECT_TRUE(r()->Resolve()) << r()->error();
|
|
|
|
// Verify that constant id allocation order is deterministic.
|
|
ExpectConstantId(a, 0u);
|
|
ExpectConstantId(b, 3u);
|
|
ExpectConstantId(c, 2u);
|
|
ExpectConstantId(d, 4u);
|
|
ExpectConstantId(e, 5u);
|
|
ExpectConstantId(f, 1u);
|
|
}
|
|
|
|
TEST_F(ResolverPipelineOverridableConstantTest, DuplicateIds) {
|
|
GlobalConst("a", ty.f32(), Construct(ty.f32()),
|
|
{Override(Source{{12, 34}}, 7u)});
|
|
GlobalConst("b", ty.f32(), Construct(ty.f32()),
|
|
{Override(Source{{56, 78}}, 7u)});
|
|
|
|
EXPECT_FALSE(r()->Resolve());
|
|
|
|
EXPECT_EQ(r()->error(), R"(56:78 error: pipeline constant IDs must be unique
|
|
12:34 note: a pipeline constant with an ID of 7 was previously declared here:)");
|
|
}
|
|
|
|
TEST_F(ResolverPipelineOverridableConstantTest, IdTooLarge) {
|
|
GlobalConst("a", ty.f32(), Construct(ty.f32()),
|
|
{Override(Source{{12, 34}}, 65536u)});
|
|
|
|
EXPECT_FALSE(r()->Resolve());
|
|
|
|
EXPECT_EQ(r()->error(),
|
|
"12:34 error: pipeline constant IDs must be between 0 and 65535");
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace resolver
|
|
} // namespace tint
|