mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-07-30 08:55:39 +00:00
9a8099eb8b
`a && b` only evaluates b if a is true. `a & b` always evaluates both a and b. If a and b are of type bool, `&&` is usually what you want, so clang now warns on `&` where both arguments are of type bool. From what I can tell, in Dawn it wasn't important if we evaluate both branches or not in the places where this fired, so I went with `&&` everywhere. Bug: chromium:1255745 Change-Id: Ifa196a7150d5bdfb8527fe8b6f40d7e2e957d609 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/66200 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org>