mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-08-21 11:21:39 +00:00
This is a reland of a57c1db878e2f8a7eb352c8f253db5488cdca6f6 in current Dawn implementation RenderPipelineGL and ComputePipelineGL will be destroyed before calling their initialize() function when we can find a proper pipeline object in the front-end cache, so mProgram may not be assigned to a valid GL program ID when the destructor of PipelineGL is called. In this CL we always initialize mProgram to 0 in the constructor of PipelineGL so that it won't be a garbage value in the destructor of PipelineGL (0 is safe for glDeleteProgram() according to OpenGL SPEC). Original change's description: > OpenGL: delete shaders and pipelines when they are not used any longer > > Previously on OpenGL backend the GL pipelines and shaders are never > deleted. With this patch the GL pipelines and shaders will be able to > be destroyed correctly after they are not needed any longer. > > BUG=dawn:529 > > Change-Id: I4f7f22c7b536825363fe1ecc0f5ffd1bb86fd774 > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/65140 > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Reviewed-by: Stephen White <senorblanco@chromium.org> > Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> Bug: dawn:529 Change-Id: Ie04ab069b9d26658f2b0d1b070d86bb650f3c878 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/65486 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Stephen White <senorblanco@chromium.org>