encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-08-28 06:25:46 +00:00
Code Issues Packages Projects Releases Wiki Activity
dawn-cmake/src/dawn/native
History
Takahiro d42a809e8c Record zero-attribute vertex buffer when creating render pipeline 
Currently Dawn ignores all zero-attribute vertex buffer in the given
pipeline descriptor when creating RenderPipelineBase because
zero-attribute vertex buffer is treated as unused slot, however the spec
doesn't state that zero-attribute vertex buffer should be ignored.

To support zero-attribute vertex buffer, this commit has the following
changes.

1. Add VertexBufferNotUsed enum value to wgpu::VertexStepMode to
   represent unused slots
2. Ignore VertexBufferNotUsed  step mode buffers when creating
   RenderPipelineBase and add tests to check it
3. Record zero-attribute vertex buffers when creating RenderPipelineBase
   and add tests to check it
4. Fix VertexStateTest::LastAllowedVertexBuffer broken by the above
   changes

Temporarily we set the enum value of
wgpu::VertexStepMode::VertexBufferNotUsed to 0 to pass the CTS tests
because currently empty vertex buffer slots step mode can be
zero-initialized. We will make a CL to Blink to explicitly set
wgpu::VertexStepMode::VertexBufferNotUsed for empty slots and change
the enum value to 2.

Bug: dawn:1000
Change-Id: Ibd4ab87f2c922e8e460f2311547f13d58f1d5611
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89340
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Takahiro <hogehoge@gachapin.jp>
2022-05-26 01:26:34 +00:00
..
d3d12
Record zero-attribute vertex buffer when creating render pipeline
2022-05-26 01:26:34 +00:00
metal
Record zero-attribute vertex buffer when creating render pipeline
2022-05-26 01:26:34 +00:00
null
[warnings] Add Wsuggest-override and Wsuggest-destructor-override.
2022-05-10 18:44:34 +00:00
opengl
Record zero-attribute vertex buffer when creating render pipeline
2022-05-26 01:26:34 +00:00
utils
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
vulkan
Record zero-attribute vertex buffer when creating render pipeline
2022-05-26 01:26:34 +00:00
Adapter.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
Adapter.h
[chromium-style] Fixup a few chromium-style issues.
2022-05-09 16:26:44 +00:00
AsyncTask.cpp
[chromium-style] Adding/moving constructors and destructors.
2022-05-09 22:22:18 +00:00
AsyncTask.h
[warnings] Add Wsuggest-override and Wsuggest-destructor-override.
2022-05-10 18:44:34 +00:00
AttachmentState.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
AttachmentState.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
BackendConnection.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
BackendConnection.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
BindGroup.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
BindGroup.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
BindGroupLayout.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
BindGroupLayout.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
BindGroupTracker.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
BindingInfo.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
BindingInfo.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
BlobCache.cpp
[chromium-style] Adding/moving constructors and destructors.
2022-05-09 22:22:18 +00:00
BlobCache.h
[chromium-style] Adding/moving constructors and destructors.
2022-05-09 22:22:18 +00:00
BuddyAllocator.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
BuddyAllocator.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
BuddyMemoryAllocator.cpp
[chromium-style] Adding/moving constructors and destructors.
2022-05-09 22:22:18 +00:00
BuddyMemoryAllocator.h
[chromium-style] Adding/moving constructors and destructors.
2022-05-09 22:22:18 +00:00
Buffer.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
Buffer.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
BUILD.gn
Make child objects ref the device and add a mechanism to break cycles
2022-05-20 16:57:01 +00:00
CachedObject.cpp
Adds pipeline cache and implementation for Vulkan backend.
2022-05-03 00:33:33 +00:00
CachedObject.h
Adds pipeline cache and implementation for Vulkan backend.
2022-05-03 00:33:33 +00:00
CacheKey.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
CacheKey.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
CallbackTaskManager.cpp
[chromium-style] Adding/moving constructors and destructors.
2022-05-09 22:22:18 +00:00
CallbackTaskManager.h
[chromium-style] Adding/moving constructors and destructors.
2022-05-09 22:22:18 +00:00
CMakeLists.txt
Make child objects ref the device and add a mechanism to break cycles
2022-05-20 16:57:01 +00:00
CommandAllocator.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
CommandAllocator.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
CommandBuffer.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
CommandBuffer.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
CommandBufferStateTracker.cpp
Dawn: vertex buffer never OOB with zero stride count draw/Indexed
2022-05-19 01:32:48 +00:00
CommandBufferStateTracker.h
[chromium-style] Adding/moving constructors and destructors.
2022-05-09 20:28:54 +00:00
CommandEncoder.cpp
dawn: Validate that depth-stencil attachments encompass all aspects.
2022-05-20 16:16:40 +00:00
CommandEncoder.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
Commands.cpp
Reland "[chromium-style] Adding constructors and destructors."
2022-05-17 06:11:42 +00:00
Commands.h
Reland "[chromium-style] Adding constructors and destructors."
2022-05-17 06:11:42 +00:00
CommandValidation.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
CommandValidation.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
CompilationMessages.cpp
Show diagnostic notes in WGSL compilation messages
2022-05-13 19:04:24 +00:00
CompilationMessages.h
[chromium-style] Adding/moving constructors and destructors.
2022-05-09 20:28:54 +00:00
ComputePassEncoder.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
ComputePassEncoder.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
ComputePipeline.cpp
Adds pipeline cache and implementation for Vulkan backend.
2022-05-03 00:33:33 +00:00
ComputePipeline.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
CopyTextureForBrowserHelper.cpp
Update createView default logic to match spec
2022-05-24 14:57:43 +00:00
CopyTextureForBrowserHelper.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
CreatePipelineAsyncTask.cpp
[chromium-style] Adding/moving constructors and destructors.
2022-05-09 22:22:18 +00:00
CreatePipelineAsyncTask.h
[warnings] Add Wsuggest-override and Wsuggest-destructor-override.
2022-05-10 18:44:34 +00:00
dawn_platform.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
DawnNative.cpp
Fix multiple device leaks in dawn_end2end_tests and dawn_unittests
2022-05-18 13:28:21 +00:00
Device.cpp
Move clearing DeviceBase::mQueue from Destroy() to WillDropLastExternalRef
2022-05-24 07:04:25 +00:00
Device.h
Make child objects ref the device and add a mechanism to break cycles
2022-05-20 16:57:01 +00:00
DynamicUploader.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
DynamicUploader.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
EncodingContext.cpp
Validate if device is alive in EncodeFunction of EncodingContext::TryEncode
2022-05-13 21:05:57 +00:00
EncodingContext.h
Validate if device is alive in EncodeFunction of EncodingContext::TryEncode
2022-05-13 21:05:57 +00:00
EnumClassBitmasks.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
EnumMaskIterator.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
Error.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
Error.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
ErrorData.cpp
[chromium-style] Adding/moving constructors and destructors.
2022-05-09 20:28:54 +00:00
ErrorData.h
[chromium-style] Adding/moving constructors and destructors.
2022-05-09 20:28:54 +00:00
ErrorInjector.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
ErrorInjector.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
ErrorScope.cpp
[chromium-style] Adding/moving constructors and destructors.
2022-05-09 22:22:18 +00:00
ErrorScope.h
[chromium-style] Adding/moving constructors and destructors.
2022-05-09 22:22:18 +00:00
ExternalTexture.cpp
Change External Texture YUV-To-RGB Matrix To Be Optional
2022-05-24 01:41:43 +00:00
ExternalTexture.h
Make External Texture ColorSpace Conversion Configurable
2022-05-19 17:44:29 +00:00
Features.cpp
D3D12: Support feature chromium_experimental_dp4a
2022-05-20 08:21:00 +00:00
Features.h
D3D12: Support feature chromium_experimental_dp4a
2022-05-20 08:21:00 +00:00
Format.cpp
Revert "[chromium-style] Adding constructors and destructors."
2022-05-10 23:32:44 +00:00
Format.h
Enable -Wglobal-constructors for dawn/native
2022-05-17 01:41:41 +00:00
Forward.h
Adds pipeline cache and implementation for Vulkan backend.
2022-05-03 00:33:33 +00:00
IndirectDrawMetadata.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
IndirectDrawMetadata.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
IndirectDrawValidationEncoder.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
IndirectDrawValidationEncoder.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
Instance.cpp
Fix multiple device leaks in dawn_end2end_tests and dawn_unittests
2022-05-18 13:28:21 +00:00
Instance.h
Fix multiple device leaks in dawn_end2end_tests and dawn_unittests
2022-05-18 13:28:21 +00:00
IntegerTypes.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
InternalPipelineStore.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
InternalPipelineStore.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
Limits.cpp
Raise base maxComputeWorkgroupStorageSize limit. 16352 -> 16384
2022-05-11 18:28:46 +00:00
Limits.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
ObjectBase.cpp
Make child objects ref the device and add a mechanism to break cycles
2022-05-20 16:57:01 +00:00
ObjectBase.h
Make child objects ref the device and add a mechanism to break cycles
2022-05-20 16:57:01 +00:00
ObjectContentHasher.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
ObjectContentHasher.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
PassResourceUsage.cpp
[chromium-style] Adding/moving constructors and destructors.
2022-05-09 20:28:54 +00:00
PassResourceUsage.h
[chromium-style] Adding/moving constructors and destructors.
2022-05-09 20:28:54 +00:00
PassResourceUsageTracker.cpp
[chromium-style] Adding/moving constructors and destructors.
2022-05-09 20:28:54 +00:00
PassResourceUsageTracker.h
[chromium-style] Adding/moving constructors and destructors.
2022-05-09 20:28:54 +00:00
PerStage.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
PerStage.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
Pipeline.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
Pipeline.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
PipelineCache.cpp
Hide blob caching behind a toggle on the device for now.
2022-05-03 07:06:33 +00:00
PipelineCache.h
Adds pipeline cache and implementation for Vulkan backend.
2022-05-03 00:33:33 +00:00
PipelineLayout.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
PipelineLayout.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
PooledResourceMemoryAllocator.cpp
[chromium-style] Adding/moving constructors and destructors.
2022-05-09 22:22:18 +00:00
PooledResourceMemoryAllocator.h
[chromium-style] Adding/moving constructors and destructors.
2022-05-09 22:22:18 +00:00
ProgrammableEncoder.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
ProgrammableEncoder.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
QueryHelper.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
QueryHelper.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
QuerySet.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
QuerySet.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
Queue.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
Queue.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
RefCountedWithExternalCount.cpp
Make child objects ref the device and add a mechanism to break cycles
2022-05-20 16:57:01 +00:00
RefCountedWithExternalCount.h
Make child objects ref the device and add a mechanism to break cycles
2022-05-20 16:57:01 +00:00
RenderBundle.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
RenderBundle.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
RenderBundleEncoder.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
RenderBundleEncoder.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
RenderEncoderBase.cpp
Dawn: vertex buffer never OOB with zero stride count draw/Indexed
2022-05-19 01:32:48 +00:00
RenderEncoderBase.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
RenderPassEncoder.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
RenderPassEncoder.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
RenderPipeline.cpp
Record zero-attribute vertex buffer when creating render pipeline
2022-05-26 01:26:34 +00:00
RenderPipeline.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
ResourceHeap.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
ResourceHeapAllocator.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
ResourceMemoryAllocation.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
ResourceMemoryAllocation.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
RingBufferAllocator.cpp
[chromium-style] Adding/moving constructors and destructors.
2022-05-09 22:22:18 +00:00
RingBufferAllocator.h
[chromium-style] Adding/moving constructors and destructors.
2022-05-09 22:22:18 +00:00
Sampler.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
Sampler.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
ScratchBuffer.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
ScratchBuffer.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
ShaderModule.cpp
Record zero-attribute vertex buffer when creating render pipeline
2022-05-26 01:26:34 +00:00
ShaderModule.h
ShaderModule: Don't create an inspector just to reflect exts
2022-05-10 06:41:24 +00:00
SpirvValidation.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
SpirvValidation.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
StagingBuffer.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
StagingBuffer.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
Subresource.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
Subresource.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
SubresourceStorage.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
Surface_metal.mm
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
Surface.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
Surface.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
SwapChain.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
SwapChain.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
Texture.cpp
Update createView default logic to match spec
2022-05-24 14:57:43 +00:00
Texture.h
[chromium-style] Adding/moving constructors and destructors.
2022-05-09 20:28:54 +00:00
TintUtils.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
TintUtils.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
ToBackend.h
Adds pipeline cache and implementation for Vulkan backend.
2022-05-03 00:33:33 +00:00
Toggles.cpp
[chromium-style] Adding/moving constructors and destructors.
2022-05-09 22:22:18 +00:00
Toggles.h
[chromium-style] Adding/moving constructors and destructors.
2022-05-09 22:22:18 +00:00
VertexFormat.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
VertexFormat.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
webgpu_absl_format.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
webgpu_absl_format.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
XlibXcbFunctions.cpp
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00
XlibXcbFunctions.h
Consistent formatting for Dawn/Tint.
2022-05-01 14:40:55 +00:00