Huge compile performance refactor

atdna/main.cpp

@@ -1,4 +1,4 @@
-#include <stdio.h>
+#include <cstdio>
 #include <iostream>
 #include "clang/AST/ASTConsumer.h"
 #include "clang/AST/RecursiveASTVisitor.h"

include/aes.hpp

@@ -1,8 +1,8 @@
 #ifndef __AES_HPP__
 #define __AES_HPP__
 
-#include <stdint.h>
-#include <stdlib.h>
+#include <cstdint>
+#include <cstdlib>
 #include <memory>
 
 namespace athena

include/athena/Checksums.hpp

@@ -3,13 +3,10 @@
 
 #include "athena/Global.hpp"
 
-namespace athena
-{
-namespace Checksums
+namespace athena::Checksums
 {
 atUint32 crc32(const atUint8* data, atUint64 length, atUint32 mask = 0xFFFFFFFF, atUint32 seed = 0xFFFFFFFF);
 atUint16 crc16CCITT(const atUint8* data, atUint64 length, atUint16 seed = 0xFFFF, atUint16 final = 0);
 atUint16 crc16(const atUint8* data, atUint64 length);
 }
-}
 #endif // CHECKSUMS_HPP

include/athena/Compression.hpp

@@ -3,11 +3,7 @@
 
 #include "athena/Global.hpp"
 
-namespace athena
-{
-namespace io
-{
-namespace Compression
+namespace athena::io::Compression
 {
 // Zlib compression
 atInt32 decompressZlib(const atUint8* src, atUint32 srcLen, atUint8* dst, atUint32 dstLen);
@@ -23,6 +19,4 @@ atUint32 yaz0Encode(const atUint8* src, atUint32 srcSize, atUint8* data);
 atUint32 decompressLZ77(const atUint8* src, atUint32 srcLen, atUint8** dst);
 atUint32 compressLZ77(const atUint8* src, atUint32 srcLen, atUint8** dst, bool extended = false);
 }
-}
-}
 #endif // COMPRESSION_HPP

include/athena/DNA.hpp

@@ -13,9 +13,7 @@
 #include <vector>
 #include <memory>
 
-namespace athena
-{
-namespace io
+namespace athena::io
 {
 
 /* forward-declaration dance for recursively-derived types */
@@ -250,7 +248,6 @@ struct WStringAsString : public DNA<VE>, public std::string
 #define DNA_COUNT(cnt) 0
 #endif
 
-}
 }
 
 #endif // DNA_HPP

include/athena/DNAYaml.hpp

@@ -7,15 +7,13 @@
  * Any changes to the types or namespacing must be reflected in 'atdna/main.cpp'
  */
 
-#include <string.h>
+#include <cstring>
 #include <yaml.h>
 #include <utf8proc.h>
 #include "DNA.hpp"
 #include "FileReader.hpp"
 
-namespace athena
-{
-namespace io
+namespace athena::io
 {
 
 struct YAMLNode
@@ -680,6 +678,5 @@ struct WStringAsStringYaml : public DNAYaml<VE>, public std::string
     const char* DNATypeV() const {return DNAType();} \
 
 }
-}
 
 #endif // DNAYAML_HPP

include/athena/Dir.hpp

@@ -2,7 +2,7 @@
 #define DIR_HPP
 
 #include "athena/FileInfo.hpp"
-#include <stdio.h>
+#include <cstdio>
 
 #if _WIN32
 typedef int mode_t;

include/athena/FileReader.hpp

@@ -7,16 +7,14 @@
 #endif
 #include <windows.h>
 #else
-#include <stdio.h>
+#include <cstdio>
 #endif
 
 #include <string>
 #include <memory>
 #include "athena/IStreamReader.hpp"
 
-namespace athena
-{
-namespace io
+namespace athena::io
 {
 class FileReader : public IStreamReader
 {
@@ -75,7 +73,6 @@ protected:
     atUint64     m_offset;
     bool         m_globalErr;
 };
-} // io
 } // Athena
 
 #ifndef FILEREADER_BASE

include/athena/FileWriter.hpp

@@ -7,13 +7,11 @@
 #endif
 #include <windows.h>
 #else
-#include <stdio.h>
+#include <cstdio>
 #endif
 #include "athena/IStreamWriter.hpp"
 
-namespace athena
-{
-namespace io
+namespace athena::io
 {
 class FileWriter : public IStreamWriter
 {
@@ -116,7 +114,6 @@ public:
 
     ~TransactionalFileWriter() { flush(); }
 };
-}
 } // Athena
 
 #ifndef FILEWRITER_BASE

include/athena/IStream.hpp

@@ -3,9 +3,7 @@
 
 #include "Global.hpp"
 
-namespace athena
-{
-namespace io
+namespace athena::io
 {
 std::ostream& operator<<(std::ostream& os, Endian& endian);
 
@@ -34,5 +32,4 @@ protected:
 #endif
 };
 }
-}
 #endif // STREAM_HPP

include/athena/IStreamReader.hpp

@@ -6,9 +6,7 @@
 #include "utf8proc.h"
 #include "IStream.hpp"
 
-namespace athena
-{
-namespace io
+namespace athena::io
 {
 /** @brief The IStreamReader class defines a basic API for reading from streams, Implementors are provided with one pure virtual
  *  function that must be implemented in order to interact with the stream.
@@ -1304,6 +1302,5 @@ IStreamReader& operator>>(IStreamReader& lhs, T& rhs)
     return lhs;
 }
 }
-}
 #endif // ISTREAMREADER
 

include/athena/IStreamWriter.hpp

@@ -5,9 +5,7 @@
 #include "IStream.hpp"
 #include <memory>
 
-namespace athena
-{
-namespace io
+namespace athena::io
 {
 class IStreamWriter : public IStream
 {
@@ -1176,6 +1174,5 @@ IStreamWriter& operator<<(IStreamWriter& lhs, const T& rhs)
     return lhs;
 }
 }
-}
 #endif // STREAMWRITER_HPP
 

include/athena/MemoryReader.hpp

@@ -6,9 +6,7 @@
 #include <functional>
 #include "athena/IStreamReader.hpp"
 
-namespace athena
-{
-namespace io
+namespace athena::io
 {
 /*! \class MemoryReader
  *  \brief A Stream class for reading data from a memory position
@@ -118,7 +116,6 @@ protected:
     std::string   m_filepath; //!< Path to the target file
 };
 
-} // io
 } // Athena
 
 

include/athena/MemoryWriter.hpp

@@ -6,9 +6,7 @@
 #include <functional>
 #include "athena/IStreamWriter.hpp"
 
-namespace athena
-{
-namespace io
+namespace athena::io
 {
 
 /*! @class MemoryWriter
@@ -158,7 +156,6 @@ private:
     void resize(atUint64 newSize);
 };
 
-}
 }
 
 #endif // MEMORYWRITER_HPP

include/athena/PHYSFSFileReader.hpp

@@ -5,9 +5,7 @@
 #include "athena/Stream.hpp"
 #include <physfs.h>
 
-namespace athena
-{
-namespace io
+namespace athena::io
 {
 class PHYSFSFileReader : public Stream
 {
@@ -51,7 +49,6 @@ private:
     PHYSFS_File* m_handle;
 };
 }
-}
 
 #ifndef PHYSFSFILEREADER_BASE
 #define PHYSFSFILEREADER_BASE() \

include/athena/SakuraGlobal.hpp

@@ -3,9 +3,7 @@
 
 #include "athena/Global.hpp"
 
-namespace athena
-{
-namespace Sakura
+namespace athena::Sakura
 {
 template <typename T>
 class Vector2D
@@ -30,6 +28,5 @@ public:
 typedef Vector2D<int> Vector2Di;
 typedef Vector2D<float> Vector2Df;
 } // Sakura
-} // Athena
 
 #endif // SAKURAGLOBAL_HPP

include/athena/Socket.hpp

@@ -8,7 +8,7 @@
 #include <arpa/inet.h>
 #include <netdb.h>
 #include <unistd.h>
-#include <errno.h>
+#include <cerrno>
 #else
 #include <winsock2.h>
 #include <Ws2tcpip.h>
@@ -21,9 +21,7 @@
 
 #include "Global.hpp"
 
-namespace athena
-{
-namespace net
+namespace athena::net
 {
 
 /* Define the low-level send/receive flags, which depend on the OS */
@@ -371,7 +369,6 @@ public:
     SocketTp GetInternalSocket() const { return m_socket; }
 };
 
-}
 }
 
 #endif // ATHENA_SOCKET_HPP

include/athena/Sprite.hpp

@@ -5,9 +5,7 @@
 #include <string>
 #include "athena/SakuraGlobal.hpp"
 
-namespace athena
-{
-namespace Sakura
+namespace athena::Sakura
 {
 class SpriteFile;
 class SpriteFrame;
@@ -69,7 +67,6 @@ private:
     atUint32 m_currentFrame;
 };
 
-} // Sakura
 } // zelda
 
 #endif // SSPRITE_HPP

include/athena/SpriteFile.hpp

@@ -7,9 +7,7 @@
 #include <string>
 #include "athena/SakuraGlobal.hpp"
 
-namespace athena
-{
-namespace Sakura
+namespace athena::Sakura
 {
 struct STexture
 {
@@ -191,7 +189,6 @@ private:
     Vector2Df              m_origin;
     std::unordered_map<std::string, Sprite*> m_sprites;
 };
-} // Sakura
 } // Zelda
 
 #endif // SSPRITE_HPP

include/athena/SpriteFileReader.hpp

@@ -3,9 +3,7 @@
 
 #include "athena/MemoryReader.hpp"
 
-namespace athena
-{
-namespace Sakura
+namespace athena::Sakura
 {
 class SpriteFile;
 } // Sakura
@@ -21,7 +19,6 @@ public:
 
     Sakura::SpriteFile* readFile();
 };
-} // io
 } // zelda
 
 

include/athena/SpriteFrame.hpp

@@ -5,9 +5,7 @@
 #include "athena/SakuraGlobal.hpp"
 
 #include <vector>
-namespace athena
-{
-namespace Sakura
+namespace athena::Sakura
 {
 
 class Sprite;
@@ -48,7 +46,6 @@ private:
     std::vector<SpritePart*> m_parts;
 };
 
-} // Sakura
 } // zelda
 
 #endif // SSPRITEFRAME_HPP

include/athena/SpritePart.hpp

@@ -6,9 +6,7 @@
 
 #include <string>
 
-namespace athena
-{
-namespace Sakura
+namespace athena::Sakura
 {
 class SpriteFrame;
 
@@ -114,6 +112,5 @@ private:
     atUint32 m_frameIndex;
 };
 }
-}
 
 #endif // SSPRITEPART_HPP

include/athena/Types.hpp

@@ -1,7 +1,7 @@
 #ifndef TYPES_HPP
 #define TYPES_HPP
-#include <stdint.h>
-#include <inttypes.h>
+#include <cstdint>
+#include <cinttypes>
 
 using atInt8 = int8_t;
 using atUint8 = uint8_t;

include/athena/Utility.hpp

@@ -4,14 +4,12 @@
 #include <string>
 #include <string_view>
 #include <vector>
-#include <stdarg.h>
-#include <string.h>
+#include <cstdarg>
+#include <cstring>
 #include "athena/Global.hpp"
 #include "athena/Types.hpp"
 
-namespace athena
-{
-namespace utility
+namespace athena::utility
 {
 inline bool isEmpty(atInt8* buf, atUint32 size) {return !memcmp(buf, buf + 1, size - 1);}
 inline bool isSystemBigEndian() {return (*(atUint16*)"\xFE\xFF" == 0xFEFF);}
@@ -217,6 +215,5 @@ std::string wideToUtf8(std::wstring_view src);
 
 std::wstring utf8ToWide(std::string_view src);
 
-} // utility
 } // Athena
 #endif

include/utf8proc.h

@@ -97,8 +97,13 @@ enum {false, true};
 typedef bool utf8proc_bool;
 #  endif
 #else
+#ifdef __cplusplus
+#  include <cstdbool>
+#  include <cinttypes>
+#else
 #  include <stdbool.h>
 #  include <inttypes.h>
+#endif
 typedef int8_t utf8proc_int8_t;
 typedef uint8_t utf8proc_uint8_t;
 typedef int16_t utf8proc_int16_t;
@@ -109,7 +114,11 @@ typedef size_t utf8proc_size_t;
 typedef ssize_t utf8proc_ssize_t;
 typedef bool utf8proc_bool;
 #endif
+#ifdef __cplusplus
+#  include <climits>
+#else
 #  include <limits.h>
+#endif
 
 /** @name Error codes
  * Error codes being returned by almost all functions.

src/LZ77/LZType10.cpp

@@ -1,7 +1,7 @@
 #include "LZ77/LZLookupTable.hpp"
 #include "LZ77/LZType10.hpp"
 #include <athena/MemoryWriter.hpp>
-#include <string.h>
+#include <cstring>
 
 LZType10::LZType10(atInt32 MinimumOffset, atInt32 SlidingWindow, atInt32 MinimumMatch, atInt32 BlockSize)
     : LZBase(MinimumOffset, SlidingWindow, MinimumMatch, BlockSize)

src/LZ77/LZType11.cpp

@@ -1,7 +1,7 @@
 #include "LZ77/LZLookupTable.hpp"
 #include "LZ77/LZType11.hpp"
 #include <athena/MemoryWriter.hpp>
-#include <string.h>
+#include <cstring>
 
 
 LZType11::LZType11(atInt32 minimumOffset, atInt32 slidingWindow, atInt32 minimumMatch, atInt32 blockSize)

src/aes.cpp

@@ -1,6 +1,6 @@
 #include "aes.hpp"
-#include <stdio.h>
-#include <string.h>
+#include <cstdio>
+#include <cstring>
 #if _WIN32
 #include <intrin.h>
 #elif !GEKKO

src/athena/ALTTPFileReader.cpp

@@ -4,9 +4,7 @@
 #include <iostream>
 #include "athena/Global.hpp"
 
-namespace athena
-{
-namespace io
+namespace athena::io
 {
 
 ALTTPFileReader::ALTTPFileReader(atUint8* data, atUint64 length)
@@ -236,4 +234,3 @@ ALTTPDungeonItemFlags ALTTPFileReader::readDungeonFlags()
 }
 
 } // io
-} // zelda

src/athena/Checksums.cpp

@@ -3,9 +3,7 @@
 #include <iostream>
 #include <iomanip>
 
-namespace athena
-{
-namespace Checksums
+namespace athena::Checksums
 {
 
 atUint32 crc32(const atUint8* data, atUint64 length, atUint32 mask, atUint32 seed)
@@ -150,4 +148,3 @@ atUint16 crc16(const atUint8* data, atUint64 length)
 }
 
 } // Checksums
-} // zelda

src/athena/Compression.cpp

@@ -5,11 +5,7 @@
 #include "LZ77/LZType10.hpp"
 #include "LZ77/LZType11.hpp"
 
-namespace athena
-{
-namespace io
-{
-namespace Compression
+namespace athena::io::Compression
 {
 
 atInt32 decompressZlib(const atUint8* src, atUint32 srcLen, atUint8* dst, atUint32 dstLen)
@@ -357,5 +353,3 @@ atUint32 compressLZ77(const atUint8* src, atUint32 srcLen, atUint8** dst, bool e
 }
 
 } // Compression
-} // io
-} // zelda

src/athena/DNAYaml.cpp

@@ -1,8 +1,6 @@
 #include "athena/DNAYaml.hpp"
 
-namespace athena
-{
-namespace io
+namespace athena::io
 {
 
 template <>
@@ -1406,4 +1404,3 @@ std::unique_ptr<atUint8[]> base64_decode(std::string_view encoded_string)
 }
 
 }
-}

src/athena/Dir.cpp

@@ -1,15 +1,15 @@
 #include "athena/Dir.hpp"
 #include <sys/stat.h>
-#include <stdlib.h>
+#include <cstdlib>
 #include <limits.h>
 #define __STDC_FORMAT_MACROS
-#include <inttypes.h>
+#include <cinttypes>
 
 #ifndef _WIN32
 #include <dirent.h>
 #include <unistd.h>
 #else
-#include <time.h>
+#include <ctime>
 #include <direct.h>
 #endif
 

src/athena/FileInfo.cpp

@@ -2,10 +2,10 @@
 #include "athena/Utility.hpp"
 #include "athena/FileWriter.hpp"
 #include "athena/FileReader.hpp"
-#include <time.h>
-#include <stdio.h>
+#include <ctime>
+#include <cstdio>
 #include <limits.h>
-#include <stdlib.h>
+#include <cstdlib>
 
 #ifndef _WIN32
 #include <sys/time.h>
@@ -20,7 +20,7 @@
 
 #ifdef _WIN32
 #include <windows.h>
-#include <wchar.h>
+#include <cwchar>
 #endif
 
 #ifdef _MSC_VER

src/athena/FileReader.cpp

@@ -7,9 +7,7 @@
 #include "osx_largefilewrapper.h"
 #endif
 
-namespace athena
-{
-namespace io
+namespace athena::io
 {
 FileReader::FileReader(std::string_view filename, atInt32 cacheSize, bool globalErr)
     : m_fileHandle(nullptr),
@@ -206,5 +204,4 @@ void FileReader::setCacheSize(const atInt32 blockSize)
         m_cacheData.reset(new atUint8[m_blockSize]);
 }
 
-} // io
 } // Athena

src/athena/FileReaderWin32.cpp

@@ -1,9 +1,7 @@
 #include "athena/FileReader.hpp"
 #include "win32_largefilewrapper.h"
 
-namespace athena
-{
-namespace io
+namespace athena::io
 {
 FileReader::FileReader(std::string_view filename, atInt32 cacheSize, bool globalErr)
     : m_fileHandle(nullptr),
@@ -232,5 +230,4 @@ void FileReader::setCacheSize(const atInt32 blockSize)
         m_cacheData.reset(new atUint8[m_blockSize]);
 }
 
-} // io
 } // Athena

src/athena/FileWriterGeneric.cpp

@@ -1,8 +1,6 @@
 #include "athena/FileWriter.hpp"
 
-namespace athena
-{
-namespace io
+namespace athena::io
 {
 void TransactionalFileWriter::seek(atInt64 pos, SeekOrigin origin)
 {
@@ -32,4 +30,3 @@ void TransactionalFileWriter::writeUBytes(const atUint8* data, atUint64 len)
     m_position += len;
 }
 }
-}

src/athena/FileWriterNix.cpp

@@ -7,9 +7,7 @@
 #include "osx_largefilewrapper.h"
 #endif
 
-namespace athena
-{
-namespace io
+namespace athena::io
 {
 FileWriter::FileWriter(std::string_view filename, bool overwrite, bool globalErr)
     : m_fileHandle(NULL),
@@ -134,5 +132,4 @@ void FileWriter::writeUBytes(const atUint8* data, atUint64 len)
         setError();
     }
 }
-}
 } // Athena

src/athena/FileWriterWin32.cpp

@@ -1,9 +1,7 @@
 #include "athena/FileWriter.hpp"
 #include "win32_largefilewrapper.h"
 
-namespace athena
-{
-namespace io
+namespace athena::io
 {
 FileWriter::FileWriter(std::string_view filename, bool overwrite, bool globalErr)
     : m_fileHandle(0),
@@ -141,5 +139,4 @@ void FileWriter::writeUBytes(const atUint8* data, atUint64 len)
     }
 }
 
-}
 } // Athena

src/athena/Global.cpp

@@ -1,7 +1,7 @@
 #include "athena/Global.hpp"
-#include <stdio.h>
-#include <stdarg.h>
-#include <stdlib.h>
+#include <cstdio>
+#include <cstdarg>
+#include <cstdlib>
 
 std::ostream& operator<<(std::ostream& os, const athena::SeekOrigin& origin)
 {

src/athena/MCFileWriter.cpp

@@ -1,8 +1,6 @@
 #include "athena/MCFileWriter.hpp"
 
-namespace athena
-{
-namespace io
+namespace athena::io
 {
 
 MCFileWriter::MCFileWriter(atUint8* data, atUint64 length)
@@ -48,5 +46,4 @@ atUint16 MCFileWriter::calculateChecksum(atUint8* data, atUint32 length)
     return sum;
 }
 
-} // io
 } // zelda

src/athena/MemoryReader.cpp

@@ -1,7 +1,7 @@
 #include "athena/MemoryReader.hpp"
 
-#include <stdio.h>
-#include <stdlib.h>
+#include <cstdio>
+#include <cstdlib>
 #include <vector>
 #include <iostream>
 #include <cstring>
@@ -14,9 +14,7 @@
 #undef min
 #undef max
 
-namespace athena
-{
-namespace io
+namespace athena::io
 {
 MemoryReader::MemoryReader(const void* data, atUint64 length, bool takeOwnership, bool globalErr)
     : m_data(data),
@@ -213,4 +211,3 @@ void MemoryCopyReader::loadData()
 }
 
 }
-}

src/athena/MemoryWriter.cpp

@@ -1,7 +1,7 @@
 #include "athena/MemoryWriter.hpp"
 
-#include <stdio.h>
-#include <string.h>
+#include <cstdio>
+#include <cstring>
 #include <vector>
 #include <iostream>
 
@@ -9,9 +9,7 @@
 #include <malloc.h>
 #endif // HW_RVL
 
-namespace athena
-{
-namespace io
+namespace athena::io
 {
 
 MemoryWriter::MemoryWriter(atUint8* data, atUint64 length, bool takeOwnership)
@@ -316,5 +314,4 @@ void MemoryCopyWriter::resize(atUint64 newSize)
     m_length = newSize;
 }
 
-} // io
 } // Athena

src/athena/PHYSFSFileReader.cpp

@@ -3,9 +3,7 @@
 #include "athena/FileNotFoundException.hpp"
 #include "athena/IOException.hpp"
 
-namespace athena
-{
-namespace io
+namespace athena::io
 {
 
 PHYSFSFileReader::PHYSFSFileReader(const std::string& path)
@@ -199,7 +197,6 @@ bool PHYSFSFileReader::isLittleEndian() const
     return m_endian == Endian::LittleEndian;
 }
 
-}
 }
 
 #endif

src/athena/SkywardSwordFileReader.cpp

@@ -3,9 +3,7 @@
 #include "athena/SkywardSwordQuest.hpp"
 #include <iostream>
 
-namespace athena
-{
-namespace io
+namespace athena::io
 {
 
 SkywardSwordFileReader::SkywardSwordFileReader(atUint8* data, atUint64 length)
@@ -65,5 +63,4 @@ SkywardSwordFile* SkywardSwordFileReader::read()
     return file;
 }
 
-} // io
 } // zelda

src/athena/SkywardSwordFileWriter.cpp

@@ -2,9 +2,7 @@
 #include "athena/SkywardSwordFile.hpp"
 #include "athena/SkywardSwordQuest.hpp"
 
-namespace athena
-{
-namespace io
+namespace athena::io
 {
 
 SkywardSwordFileWriter::SkywardSwordFileWriter(atUint8* data, atUint64 len)
@@ -62,5 +60,4 @@ void SkywardSwordFileWriter::write(SkywardSwordFile* file)
     save();
 }
 
-} // io
 } // zelda

src/athena/Sprite.cpp

@@ -7,9 +7,7 @@
 #include <QVector>
 #endif
 
-namespace athena
-{
-namespace Sakura
+namespace athena::Sakura
 {
 Sprite::Sprite(SpriteFile* root)
     : m_root(root),
@@ -232,4 +230,3 @@ SpriteFile* Sprite::root() const
     return m_root;
 }
 }
-}

src/athena/SpriteFile.cpp

@@ -3,9 +3,7 @@
 #include "athena/Utility.hpp"
 #include <iostream>
 
-namespace athena
-{
-namespace Sakura
+namespace athena::Sakura
 {
 const atUint32 SpriteFile::Major = 1;
 const atUint32 SpriteFile::Minor = 0;
@@ -216,5 +214,4 @@ void SpriteFile::setTextures(std::vector<STexture*> textures)
     m_textures = textures;
 }
 
-} // Sakura
 } // zelda

src/athena/SpriteFileReader.cpp

@@ -5,9 +5,7 @@
 #include "athena/SpriteFrame.hpp"
 #include "athena/Utility.hpp"
 
-namespace athena
-{
-namespace io
+namespace athena::io
 {
 SpriteFileReader::SpriteFileReader(atUint8* data, atUint64 length)
     : MemoryCopyReader(data, length)
@@ -204,5 +202,4 @@ Sakura::SpriteFile* SpriteFileReader::readFile()
 
     return ret;
 }
-} // io
 } // zelda

src/athena/SpriteFileWriter.cpp

@@ -4,9 +4,7 @@
 #include "athena/SpritePart.hpp"
 #include "athena/SpriteFrame.hpp"
 
-namespace athena
-{
-namespace io
+namespace athena::io
 {
 SpriteFileWriter::SpriteFileWriter(atUint8* data, atUint64 length)
     : MemoryCopyWriter(data, length)
@@ -78,5 +76,4 @@ void SpriteFileWriter::writeFile(Sakura::SpriteFile* file)
     save();
 }
 
-} // io
 } // zelda

src/athena/SpriteFrame.cpp

@@ -2,9 +2,7 @@
 #include "athena/SpritePart.hpp"
 #include "athena/Sprite.hpp"
 
-namespace athena
-{
-namespace Sakura
+namespace athena::Sakura
 {
 
 SpriteFrame::SpriteFrame()
@@ -52,5 +50,4 @@ Sprite* SpriteFrame::root() const
     return m_root;
 }
 
-} // Sakura
 } // zelda

src/athena/SpritePart.cpp

@@ -3,9 +3,7 @@
 #include "athena/Sprite.hpp"
 #include <algorithm>
 
-namespace athena
-{
-namespace Sakura
+namespace athena::Sakura
 {
 
 SpritePart::SpritePart(SpriteFrame* root)
@@ -115,4 +113,3 @@ SpriteFrame* SpritePart::root() const
     return m_root;
 }
 }
-}

src/athena/Utility.cpp

@@ -1,10 +1,10 @@
 #include "athena/Utility.hpp"
 #include <iostream>
-#include <string.h>
-#include <stdlib.h>
+#include <cstring>
+#include <cstdlib>
 #include <sstream>
 #include <algorithm>
-#include <stdarg.h>
+#include <cstdarg>
 #include <iterator>
 #include <cstdio>
 #include <sys/types.h>
@@ -17,9 +17,7 @@
 #include <locale>
 #endif
 
-namespace athena
-{
-namespace utility
+namespace athena::utility
 {
 
 void fillRandom(atUint8* rndArea, atUint64 count)
@@ -255,5 +253,4 @@ std::wstring utf8ToWide(std::string_view src)
     return retval;
 }
 
-} // utility
 } // Athena

src/athena/WiiBanner.cpp

@@ -2,7 +2,7 @@
 #include "athena/WiiImage.hpp"
 
 #include "athena/Utility.hpp"
-#include <string.h>
+#include <cstring>
 
 namespace athena
 {

src/athena/WiiImage.cpp

@@ -1,7 +1,7 @@
 #include "athena/WiiImage.hpp"
 #include "athena/Utility.hpp"
-#include <string.h>
-#include <stdlib.h>
+#include <cstring>
+#include <cstdlib>
 
 namespace athena
 {

src/athena/WiiSave.cpp

@@ -5,9 +5,9 @@
 #include "athena/MemoryWriter.hpp"
 #include "athena/Utility.hpp"
 
-#include <stdio.h>
+#include <cstdio>
 #include <vector>
-#include <string.h>
+#include <cstring>
 #include <sys/stat.h>
 #include <iostream>
 #include <iomanip>

src/athena/WiiSaveReader.cpp

@@ -11,7 +11,7 @@
 #include "sha1.h"
 #include <iostream>
 #include <iomanip>
-#include <string.h>
+#include <cstring>
 
 namespace athena
 {

src/athena/WiiSaveWriter.cpp

@@ -14,9 +14,9 @@
 #include "md5.h"
 #include "sha1.h"
 
-#include <stdio.h>
+#include <cstdio>
 #include <vector>
-#include <string.h>
+#include <cstring>
 #include <sys/stat.h>
 #include <iostream>
 #include <iomanip>

src/athena/ZQuestFile.cpp

@@ -1,6 +1,6 @@
 #include "athena/ZQuestFile.hpp"
 
-#include <string.h>
+#include <cstring>
 
 namespace athena
 {

src/athena/ZQuestFileReader.cpp

@@ -7,9 +7,7 @@
 #include <iostream>
 #include <iomanip>
 
-namespace athena
-{
-namespace io
+namespace athena::io
 {
 
 ZQuestFileReader::ZQuestFileReader(atUint8* data, atUint64 length)
@@ -107,5 +105,4 @@ ZQuestFile* ZQuestFileReader::read()
     return new ZQuestFile(game, BOM == 0xFEFF ? Endian::BigEndian : Endian::LittleEndian, std::move(data), uncompressedLen, gameString);
 }
 
-} // io
 } // zelda

src/athena/ZQuestFileWriter.cpp

@@ -3,9 +3,7 @@
 #include "athena/Compression.hpp"
 #include "athena/Checksums.hpp"
 
-namespace athena
-{
-namespace io
+namespace athena::io
 {
 
 ZQuestFileWriter::ZQuestFileWriter(atUint8* data, atUint64 length)
@@ -75,5 +73,4 @@ void ZQuestFileWriter::write(ZQuestFile* quest, bool compress)
     }
 }
 
-} // io
 } // zelda

src/bn.cpp

@@ -1,4 +1,4 @@
-#include <string.h>
+#include <cstring>
 #include <stdio.h>
 
 #include "bn.hpp"

src/ec.cpp

@@ -1,4 +1,4 @@
-#include <string.h>
+#include <cstring>
 #include "athena/Utility.hpp"
 
 #include "bn.hpp"

src/md5.cpp

@@ -78,9 +78,9 @@
 
 #include <stdint.h>
 #include <stddef.h>
-#include <stdlib.h>
+#include <cstdlib>
 #include <stdio.h>
-#include <string.h>
+#include <cstring>
 #ifndef __APPLE__
 #include <malloc.h>
 #endif

src/sha1.cpp

@@ -39,7 +39,7 @@
  */
 
 #include "sha1.h"
-#include <string.h>
+#include <cstring>
 #include "athena/Utility.hpp"
 
 /*