AxioDL/PrimeWorldEditor
2
0
Fork 0
mirror of https://github.com/AxioDL/PrimeWorldEditor.git synced 2025-12-10 14:07:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

ICreateDeleteDirectoryCommand: std::move strings where applicable

Browse Source 
Same behavior without churning allocations.
This commit is contained in:
Lioncache
2025-12-07 02:32:49 -05:00
parent f577335087
commit 919820bdf7
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/Editor/Undo/ICreateDeleteDirectoryCommand.h
View File

@@ -21,8 +21,8 @@ public:
ICreateDeleteDirectoryCommand(const QString& rkText, CResourceStore *pStore, TString ParentPath, TString DirName)
: IUndoCommand(rkText)
, mpStore(pStore)
, mParentPath(ParentPath)
, mDirName(DirName)
, mParentPath(std::move(ParentPath))
, mDirName(std::move(DirName))
, mpDir(nullptr)
{}
@@ -66,7 +66,7 @@ class CCreateDirectoryCommand : public ICreateDeleteDirectoryCommand
{
public:
CCreateDirectoryCommand(CResourceStore *pStore, TString ParentPath, TString DirName)
: ICreateDeleteDirectoryCommand(QCoreApplication::translate("CCreateDirectoryCommand", "Create Directory"), pStore, ParentPath, DirName)
: ICreateDeleteDirectoryCommand(QCoreApplication::translate("CCreateDirectoryCommand", "Create Directory"), pStore, std::move(ParentPath), std::move(DirName))
{}
void undo() override { DoDelete(); }
@@ -77,9 +77,9 @@ class CDeleteDirectoryCommand : public ICreateDeleteDirectoryCommand
{
public:
CDeleteDirectoryCommand(CResourceStore *pStore, TString ParentPath, TString DirName)
: ICreateDeleteDirectoryCommand(QCoreApplication::translate("CDeleteDirectoryCommand", "Delete Directory"), pStore, ParentPath, DirName)
: ICreateDeleteDirectoryCommand(QCoreApplication::translate("CDeleteDirectoryCommand", "Delete Directory"), pStore, std::move(ParentPath), std::move(DirName))
{
mpDir = pStore->GetVirtualDirectory(ParentPath + DirName, false);
mpDir = pStore->GetVirtualDirectory(mParentPath + mDirName, false);
ASSERT(mpDir);
ASSERT(!mpDir->IsRoot());
}