AxioDL/PrimeWorldEditor
2
0
Fork 0
mirror of https://github.com/AxioDL/PrimeWorldEditor.git synced 2025-12-08 21:17:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

CProgressDialog: Remove redundant future copies

Browse Source 
We can pass by reference here.
This commit is contained in:
Lioncache
2025-12-03 15:34:48 -05:00
parent 449798b16c
commit b13ebc56bb
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Editor/CProgressDialog.cpp
View File

@@ -3,7 +3,7 @@
#include "CEditorApplication.h" #include "CEditorApplication.h"
#include <QCloseEvent> #include <QCloseEvent>
CProgressDialog::CProgressDialog(QString OperationName, bool UseBusyIndicator, bool AlertOnFinish, QWidget *pParent) CProgressDialog::CProgressDialog(const QString& OperationName, bool UseBusyIndicator, bool AlertOnFinish, QWidget *pParent)
: IProgressNotifierUI(pParent) : IProgressNotifierUI(pParent)
, mpUI(std::make_unique<Ui::CProgressDialog>()) , mpUI(std::make_unique<Ui::CProgressDialog>())
, mUseBusyIndicator(UseBusyIndicator) , mUseBusyIndicator(UseBusyIndicator)

8
src/Editor/CProgressDialog.h
View File

@@ -26,7 +26,7 @@ class CProgressDialog : public IProgressNotifierUI
bool mCanceled = false; bool mCanceled = false;
public: public:
explicit CProgressDialog(QString OperationName, bool UseBusyIndicator, bool AlertOnFinish, QWidget *pParent = nullptr); explicit CProgressDialog(const QString& OperationName, bool UseBusyIndicator, bool AlertOnFinish, QWidget *pParent = nullptr);
~CProgressDialog() override; ~CProgressDialog() override;
void DisallowCanceling(); void DisallowCanceling();
@@ -44,7 +44,7 @@ public slots:
// Results // Results
protected: protected:
template<typename RetType> template<typename RetType>
void InternalWaitForResults(QFuture<RetType> Future) void InternalWaitForResults(const QFuture<RetType>& Future)
{ {
gpEdApp->SetEditorTicksEnabled(false); gpEdApp->SetEditorTicksEnabled(false);
@@ -61,7 +61,7 @@ protected:
public: public:
template<typename RetType> template<typename RetType>
RetType WaitForResults(QFuture<RetType> Future) RetType WaitForResults(const QFuture<RetType>& Future)
{ {
InternalWaitForResults(Future); InternalWaitForResults(Future);
return Future.result(); return Future.result();
@@ -69,7 +69,7 @@ public:
}; };
template<> template<>
inline void CProgressDialog::WaitForResults(QFuture<void> Future) inline void CProgressDialog::WaitForResults(const QFuture<void>& Future)
{ {
InternalWaitForResults(Future); InternalWaitForResults(Future);
} }