Commit Graph

235 Commits

Author SHA1 Message Date
Lioncash 99f00a7cba EffectReverb: Make use of std::array where applicable
Makes the array types more strongly typed and allows removing the use of
hardcoded array sizes.
2020-03-27 17:18:40 -04:00
Lioncash 5b6d736cfb EffectChorus: Make use of std::array where applicable
Same behavior, but with stronger typing.
2020-03-27 16:45:04 -04:00
Lioncash be754a44a4 EffectDelay: Make use of std::array where applicable
Makes the arrays more strongly typed and allows dehardcoding some array
sizes.
2020-03-27 16:31:38 -04:00
Lioncash 5de0035adb EffectDelay: Make use of std::make_unique
Same behavior, but without the need for raw new or separately
memsetting.
2020-03-27 15:51:37 -04:00
Phillip Stephens 9c75aeccbe
Fix C header export 2020-03-12 00:54:22 -07:00
Jack Andersen c27bb5c435 Merge branch 'master' of ssh://git.axiodl.com:6431/AxioDL/amuse 2019-09-30 21:36:35 -10:00
Jack Andersen 5d4abb5fb1 Code style improvements 2019-09-30 21:34:12 -10:00
Phillip Stephens ae26ed2fda
Compile fixes 2019-09-14 10:07:52 -07:00
Phillip Stephens 757defee7a
Merge pull request #43 from lioncash/array2
AudioGroupPool: Use std::array where applicable
2019-09-10 23:53:38 -07:00
Phillip Stephens 02da440523
Merge pull request #41 from lioncash/include
VolumeTable: Remove unnecessary Common include
2019-09-10 23:53:29 -07:00
Phillip Stephens 0dca047352
Merge pull request #40 from lioncash/const
Studio: Make _cyclicCheck a const member function
2019-09-10 23:53:19 -07:00
Lioncash 321a229dfd AudioGroupPool: Use std::array where applicable
Makes the array types strongly-typed and also allows for size querying.
2019-09-10 21:09:10 -04:00
Lioncash a8c9d555fe VolumeTable: Use std::array where applicable
Makes the arrays strongly typed.
2019-09-10 20:29:44 -04:00
Lioncash 7bc23b7190 VolumeTable: Remove unnecessary Common include
We can just include <algorithm> directly to eliminate an indirect
include.
2019-09-10 20:27:10 -04:00
Lioncash b92674e127 Studio: std::move studio instance in addStudioSend()
Avoids an unnecessary atomic reference count increment and decrement
2019-09-10 20:23:29 -04:00
Lioncash 04fbc328e9 Studio: Make _cyclicCheck a const member function
This doesn't actually modify the internal state of the studio instance,
so we can mark it as a const member function.
2019-09-10 20:20:37 -04:00
Lioncash 1b37122b12 Sequencer: std::move studio instances in constructor
Avoids an unnecessary atomic reference count increment and decrement
2019-09-10 20:08:38 -04:00
Lioncash 2c75668e0a Sequencer: Default ChannelState's destructor 2019-09-10 20:06:31 -04:00
Lioncash 5f76f0ecbf Sequencer: Use std::array for m_ctrlVals
This is the only array in the header that isn't using std::array.
2019-09-10 20:03:26 -04:00
Lioncash f50d67eff0 Sequencer: Eliminate magic values where applicable
Many of them are just representative of the sizes of an array, so we can
just query the array instead.
2019-09-10 19:48:31 -04:00
Lioncash b6f0201fbb General: Be explicit about athena's Endian type
Allows this code to still compile if the enum is ever changed into an
enum class.
2019-09-08 17:22:38 -04:00
Lioncash d10a0ac7f1 General: Be explicit about athena's SeekOrigin type
Allows the code to still compile if the enum is turned into an enum
class.
2019-09-08 16:59:29 -04:00
Lioncash 29e7d8bc1e Emitter: Use std::array where applicable
Makes the data more strongly-typed and prevents implicit array->pointer
decay
2019-09-07 20:55:26 -04:00
Lioncash 50c4b5cdab General: Amend clamp parameter order
Batch replace on switching to standardized variants assumed common
ordering, which evidently wasn't the case
2019-09-07 06:40:20 -04:00
Phillip Stephens 80da83eb16
Merge pull request #25 from lioncash/array
Envelope: Make lookup table const
2019-08-26 15:54:04 -07:00
Phillip Stephens 8f810e571c
Merge pull request #24 from lioncash/emplace
General: Use emplace_back where applicable
2019-08-26 15:53:55 -07:00
Lioncash eaf62288a2 Common: Replace amuse::clamp with std::clamp
We can use the standardized facility for this now with C++17
2019-08-26 05:14:21 -04:00
Lioncash e31dfc6f98 Envelope: Make lookup table const
This is only ever read from, so we can allow the compiler to toss it
into the read-only segment.
2019-08-26 04:38:36 -04:00
Lioncash 176493c539 General: Use emplace_back where applicable
Same thing, less reading.
2019-08-26 03:41:29 -04:00
Phillip Stephens 6850f0b2c9
Add missing include 2019-08-25 09:25:27 -07:00
Lioncash d7aaff25d0 General: Clean up inclusions
Ensures that each header includes all of its dependencies that can't be
forward declared.
2019-08-25 07:34:27 -04:00
Lioncash 051e4b1704 General: Eliminate instances of shadowing
Avoids instances of local variable shadowing (which also silences some
-Wshadow warnings).
2019-08-25 00:33:58 -04:00
Jack Andersen b0e4973c64 Massive fmtlib refactor 2019-07-19 18:23:25 -10:00
Jack Andersen a74caa5fb0 New lzokay API 2019-06-14 14:36:28 -10:00
Jack Andersen 2a3444400e Better CMake dependency handling 2019-06-11 16:02:52 -10:00
Jack Andersen aeaba9366d Support for compiling against libc++ 2019-04-06 18:55:39 -10:00
Jack Andersen aa5abd5ff5 Multiple StartSample bug fix 2019-03-08 22:58:02 -10:00
Jack Andersen a4b8946ee2 Ensure all ObjectIDs are unique project-wide 2019-02-28 10:34:26 -10:00
Jack Andersen 9f2bb1b371 Implicit switch fallthrough refactor 2019-02-17 19:45:24 -10:00
Jack Andersen 54ef2dd73b Correct SCALEVOLUME behavior 2019-02-07 15:07:46 -10:00
Jack Andersen d80f1346bb Fix unwanted cutoff bug 2019-01-22 21:52:00 -10:00
Jack Andersen 7719459ac7 Switch to lzokay library 2018-12-19 17:45:26 -10:00
Jack Andersen a7a408cc66 New code style refactor 2018-12-07 19:20:09 -10:00
Jack Andersen b4c073c373 More accurate attenuation curve 2018-10-25 21:44:56 -10:00
Jack Andersen 885a2d2154 Windows build fixes 2018-10-14 10:10:33 -10:00
Phillip Stephens 9e6d97564b Switch build fixes 2018-09-25 15:39:22 -07:00
Jack Andersen 81f0a91569 Looping SNG support; bug fixes 2018-09-08 11:34:01 -10:00
Jack Andersen 8fee7a282b Avoid narrowing conversion for panning 2018-09-02 20:33:41 -10:00
Jack Andersen 1312a5fa86 Merge branch 'master' of ssh://git.axiodl.com:6431/AxioDL/amuse 2018-09-02 14:43:26 -10:00
Jack Andersen 6a7f32a29d Bug fixes for MP2 extraction 2018-09-02 14:43:05 -10:00