AxioDL/metaforce
2
0
Fork 0
mirror of https://github.com/AxioDL/metaforce.git synced 2025-12-10 02:27:42 +00:00
Code Issues Projects Releases Wiki Activity

CKnockBackController: Make CalculateExtraHurlVelocity() a const member function

Browse Source 
This doesn't modify internal member state, so it can be marked const

While we're at it we can also invert the conditional to unindent the
main calculation.
This commit is contained in:
Lioncash
2020-04-17 01:05:47 -04:00
parent b55d1e4c77
commit 58040eb53d
2 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
Runtime/World/CKnockBackController.cpp
View File

@@ -473,10 +473,12 @@ void CKnockBackController::ValidateState(const CPatterned& parent) {
}
}
float CKnockBackController::CalculateExtraHurlVelocity(CStateManager& mgr, float magnitude, float kbResistance) {
if (magnitude > kbResistance)
return (1.1f - 0.2f * mgr.GetActiveRandom()->Float()) * 2.f * (magnitude - kbResistance);
return 0.f;
float CKnockBackController::CalculateExtraHurlVelocity(CStateManager& mgr, float magnitude, float kbResistance) const {
if (magnitude <= kbResistance) {
return 0.f;
}
return (1.1f - 0.2f * mgr.GetActiveRandom()->Float()) * 2.f * (magnitude - kbResistance);
}
void CKnockBackController::DoKnockBackAnimation(const zeus::CVector3f& backVec, CStateManager& mgr, CPatterned& parent,