AxioDL
/
metaforce
mirror of https://github.com/AxioDL/metaforce.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
3,428 Commits 26 Branches 15 Tags 52 MiB
Commit Graph

3428 Commits

Author SHA1 Message Date
Lioncash 26a9ceab60 CGunWeapon: Eliminate const_cast usages in DrawMuzzleFx() 
We can just make the temporary variable non-const to eliminate the need
for const_casts.
 2019-10-19 01:11:19 -04:00
Lioncash 271ee6d8c3 CGunWeapon: Make use of algorithms where applicable 
We can leverage these to also eliminate some hardcoded sizes.
 2019-10-19 01:11:05 -04:00
Lioncash c228baf5f7 CGunWeapon: Make use of std::array where applicable 
Makes the arrays strongly typed and also allows us to dehardcode some
loop boundary constants.
 2019-10-19 01:07:01 -04:00
Lioncash c36e6a85b9 CGunWeapon: Organize cpp includes 
Makes the source file consistent with the header.
 2019-10-19 00:03:38 -04:00
Phillip Stephens 6a3eba0091
Merge pull request #103 from lioncash/unique 
CParticleDataFactory: Use unique_ptr where applicable
 2019-10-18 01:01:40 -07:00
Phillip Stephens c63ee167da
Merge pull request #110 from lioncash/override 
MkCastTo: Use override where applicable
 2019-10-18 01:00:31 -07:00
Phillip Stephens 07502c7071
Merge pull request #109 from lioncash/log 
CLogBookScreen: Minor tidying changes
 2019-10-18 01:00:20 -07:00
Lioncash 853df176ed MkCastTo: Use override where applicable 
Generates the derived classes with the override specifier to prevent
warnings.
 2019-10-17 22:15:25 -04:00
Lioncash 3a0daa3ab9 CLogBookScreen: Use forward declarations where applicable 
Allows for avoiding the over exposing of types through the header when
included in other translation units or headers.
 2019-10-15 10:25:43 -04:00
Lioncash 5b8f3f6693 CLogBookScreen: Organize cpp includes 
Tidies them up to be consistent with its header.
 2019-10-15 10:13:30 -04:00
Lioncash 4db0e49851 CLogBookScreen: Invert conditional within UpdateBodyText() 
Allows unindenting the contained code by one level.
 2019-10-15 10:05:53 -04:00
Lioncash b93f7a4ceb CLogBookScreen: Use std::u16string's append() member instead of operator+ 
Appends to the existing buffer instead of constructing a superfluous
temporary.
 2019-10-15 10:03:54 -04:00
Lioncash d64824d3e5 CLogBookScreen: Make use of std::any_of within IsScanCategoryReady() 
Same thing but collapses into a single return.
 2019-10-15 10:00:15 -04:00
Lioncash 251a2a7723 CLogBookScreen: Make use of structured bindings where applicable 
Allows decomposing long pair names into their constituent elements
 2019-10-15 09:57:24 -04:00
Lioncash f21ee0786a CLogBookScreen: Make signed/unsigned/FP conversions explicit 
Silences warnings relating to signed/unsigned comparisons and
conversions to floating-point types.
 2019-10-15 09:36:10 -04:00
Lioncash 3951a07bfa CLogBookScreen: Dehardcode constants where applicable 
We can just query the containers for the iteration value
 2019-10-15 09:16:13 -04:00
Lioncash 4b78d51a85 CLogBookScreen: Use emplace_back where applicable 
Allows simplifying code and constructing elements in place instead of
copying them (which is what would occur with the defautl move
constructor).
 2019-10-15 07:22:01 -04:00
Phillip Stephens 9e2486ba0e
Use `std::string::empty` rather than string comparison 2019-10-13 19:47:24 -07:00
Phillip Stephens 6260708ba4
Cook/cache fixes for unset original IDs 2019-10-13 19:45:43 -07:00
Phillip Stephens 76f90569ca
Merge pull request #108 from lioncash/case 
CAutoMapper: Collapse case statements in ProcessMapZoomInput()
 2019-10-13 13:12:20 -07:00
Lioncash 040c724a8a CAutoMapper: Collapse case statements in ProcessMapZoomInput() 
Same behavior as the game executable, but without the code duplication.
 2019-10-12 13:57:01 -04:00
Phillip Stephens 668f8da97d
Merge pull request #106 from lioncash/find 
CCollisionPrimitive: Simplify the InitAdd* member functions
 2019-10-12 07:29:13 -07:00
Phillip Stephens 6996ebfbec
Merge pull request #105 from lioncash/collision 
CCollisionPrimitive: Minor cleanup
 2019-10-12 07:29:04 -07:00
Phillip Stephens aa956fff55
Merge pull request #104 from lioncash/cuv 
CUVElement: Provide initial value for cv in GetValueUV()
 2019-10-12 07:28:54 -07:00
Phillip Stephens 59da98b991
Merge pull request #107 from lioncash/ball 
CBallCamera: Use bool instead of float for holding boolean value
 2019-10-12 07:26:54 -07:00
Phillip Stephens e1990a686e
Update hecl 2019-10-12 07:13:36 -07:00
Lioncash 21c1ed2940 CBallCamera: Use bool instead of float for holding boolean value 
Using a float is very suspect and also more expensive in terms of
code-gen to access and modify the variable.
 2019-10-12 02:25:24 -04:00
Lioncash 5f4aba60e1 CCollisionPrimitive: Simplify the InitAdd* member functions 
We can extract the duplicated behavior out into its own member function
and then reuse it in order to deduplicate repeated behavior.

This allows simplifying the member functions in a manner that allows
declaring most of the variables const. The lack of mutable behavior
within these functions makes it much nicer to read.
 2019-10-12 00:27:18 -04:00
Lioncash d2a44dbc0b CollidableAABox: Default destructor 
Same behavior, but remains consistent with the rest of the codebase.
 2019-10-11 22:53:01 -04:00
Lioncash da4a33f01a CCollisionPrimitive: Default virtual destructor 
Same behavior, but more consistent with the existing interface, given
a constructor is defaulted.
 2019-10-11 22:39:58 -04:00
Lioncash 9cbe8ba885 CCollisionPrimitive: Use using for type aliases where applicable 
Same behavior, better readability.
 2019-10-11 22:36:57 -04:00
Lioncash af7d8e9095 CUVElement: Provide initial value for cv in GetValueUV() 
The game executable itself sets this variable to an initial value of 1
prior to calling cycleFrames' GetValue() member function.
 2019-10-11 17:05:26 -04:00
Lioncash 35fb0e4911 CUVElement: Use const where applicable 
While we're at it, we can also make conversions to float explicit.
 2019-10-11 17:05:23 -04:00
Lioncash 7430b70b73 CParticleDataFactory: Use unique_ptr where applicable 
Same behavior, but makes the functions a little safer in terms of memory
management.
 2019-10-11 15:16:13 -04:00
Jack Andersen c4ecf972f5
Merge pull request #102 from lioncash/element 
CIntElement: Add class to handle RTOI int elements
 2019-10-06 12:10:15 -10:00
Lioncash 8b58cdc268 CIntElement: Add class to handle RTOI int elements 
Within the int element handling code, there seems to be a missing
implementation (with the FourCC 'RTOI'), which seems to take two 32-bit
floating point values, multiplies them, then converts the result to a 32-bit
integer.
 2019-10-06 08:52:41 -04:00
Phillip Stephens 5f0f3ea45c
More tweak CVars 2019-10-05 07:07:13 -07:00
Phillip Stephens b68acb06e1
Merge pull request #101 from lioncash/element 
CIntElement: Minor clean up
 2019-10-05 01:16:42 -07:00
Lioncash ff940612bc CIntElement: Make use of std::clamp within CIEClamp's overrides 
Same behavior, less code.
 2019-10-04 19:51:38 -04:00
Lioncash 3407a59ad7 CIntElement: Simplify CIEKeyframeEmitter's GetMaxValue() 
We can just use std::max_element here to collapse the loop into an
assignment.
 2019-10-04 19:46:36 -04:00
Lioncash af0c2c41e3 CIntElement: Organize cpp includes 2019-10-04 19:38:31 -04:00
Lioncash 83873b580e CIntElement: Join variable declarations with assignments where applicable 2019-10-04 19:38:26 -04:00
Phillip Stephens 1044b0f1ee
Merge pull request #100 from lioncash/noexcept 
rstl: Make constructors/assignment operators of reserved_vector conditionally noexcept
 2019-10-03 23:08:23 -07:00
Lioncash d4b9124b9f rstl: Allow move constructors and assignment operators to be conditionally noexcept 
Makes the constructors and assignment operators for reserved_vector
noexcept, allowing them to play nicely with standard facilities and
avoid needing to copy construct where avoidable.
 2019-10-04 01:28:27 -04:00
Lioncash b2d9283b3c rstl: Provide full set of type aliases in reserved_vector 
Allows for better integration with standard library facilities and
templates, now that types can be queried.
 2019-10-04 00:43:47 -04:00
Lioncash 00a4df5aa6 rstl: Make use of variable templates where applicable 
While we're at it, we can use if constexpr on some conditional checks.
 2019-10-04 00:20:31 -04:00
Lioncash cbcba6f184 rstl: Organize headers 
We can also make includes a little nicer for the compiler by only
including logvisor headers when performing debug builds.
 2019-10-04 00:08:46 -04:00
Phillip Stephens b9b9eddd1e
Merge pull request #99 from lioncash/typo 
CElementGen: Correct FourCC in SetTranslation()
 2019-10-03 07:01:31 -07:00
Lioncash 66b198d1a4 CElementGen: Correct FourCC in SetTranslation() 
The game executable checks for a FourCC of ELSC within this function,
not SELC.
 2019-10-03 09:45:26 -04:00
Phillip Stephens 6422eec3ce
Merge pull request #98 from lioncash/alpha 
CAtomicAlpha/CAtomicBeta: Minor changes
 2019-10-03 06:41:54 -07:00