Commit Graph

4149 Commits

Author SHA1 Message Date
Lioncash ec5d680be0 CBurstFire: Unindent conditionals where applicable
Makes it nicer to read early-exit conditions.
2020-04-19 00:40:46 -04:00
Luke Street e50d363e88 CPlayerGun: Rename EMissileState; minor CMotionState::Update fix 2020-04-19 00:26:53 -04:00
Luke Street a3e0c42794
Merge pull request #312 from lioncash/explicit
MkCastTo: Make operator bool instances explicit
2020-04-19 00:24:15 -04:00
Luke Street 4659db9844 Update boo 2020-04-19 00:12:35 -04:00
Luke Street 025a989e12 CElementGen: Use x338_moduColor in RenderModels 2020-04-18 23:41:35 -04:00
Lioncash 2c3e5e205f MkCastTo: Make operator bool instances explicit
Prevents error prone implicit conversions.
2020-04-18 23:02:11 -04:00
Luke Street 0a2d0bcfe9
Merge pull request #313 from lioncash/bug
CToken: Amend incorrect return value of TToken's operator=
2020-04-18 18:16:42 -04:00
Luke Street 30f2ac3f26 Merge branch 'master' into omegapirate 2020-04-18 18:14:51 -04:00
Luke Street 81c2e5b03c CTweakGame: Add tweak.game.SplashScreensDisabled CVar 2020-04-18 17:37:02 -04:00
Luke Street 7f15390d4f Editor: Only create Win32 console & redirect logging if not attached 2020-04-18 03:02:44 -04:00
Luke Street 2b62bb9577 Update boo (fix WinUSB scanning) 2020-04-17 21:48:23 -04:00
Luke Street 75f19d174e Add CMakeSettings.json for VS 2020-04-17 21:02:50 -04:00
Luke Street f26e9288bb Update hecl/extern/boo 2020-04-17 20:47:53 -04:00
Phillip Stephens df75c00203
Fix WideScreenFilter crash 2020-04-17 15:32:26 -07:00
Lioncash 76f0b57340 General: Use bool literals where applicable
More indicative of the passed in type compared to raw values.
2020-04-17 17:43:56 -04:00
Lioncash 8e5fc3668c CToken: Amend incorrect return value of TToken's operator=
This should be returning by reference, not the pointer of this.
2020-04-17 17:16:33 -04:00
Luke Street 75e5851e5b Disable exceptions/RTTI for MSVC/clang-cl 2020-04-17 16:42:43 -04:00
Lioncash 0b05c906df CScriptEffect: Eliminate variable shadowing
Avoids clashing names.
2020-04-17 16:31:02 -04:00
Luke Street 8f5caca1e5 CMemoryCardSysWin: Add includes 2020-04-17 15:10:52 -04:00
Luke Street 61e656e732 CDvdFile: Remove const from auto type for MSVC 2020-04-17 15:01:31 -04:00
Luke Street 36bbc5004f CDvdFile: Use auto for string_view::begin 2020-04-17 14:52:25 -04:00
Luke Street 4a8f077d92 MP1: Use _SYS_STR where needed 2020-04-17 14:39:40 -04:00
Luke Street 248e7654fa MP1: char -> boo::SystemChar 2020-04-17 14:31:29 -04:00
Luke Street 73b9d2024b MP1: Use SystemStringConv for printing version string 2020-04-17 14:24:06 -04:00
Phillip Stephens 90877603e6
Update hecl, remove stdbool includes from CTweakPlayerRes and CTweakTargeting 2020-04-17 11:12:47 -07:00
Lioncash 5491f3ff23 CKnockBackController: Simplify initialization of x24_ in constructor
Same behavior, less code.
2020-04-17 13:17:27 -04:00
Lioncash 26ac3b166d CKnockBackController: Make use of braces where applicable
Makes code more consistent.

Where applicable we can also unindent code.
2020-04-17 13:17:27 -04:00
Phillip Stephens acf513c6bf
Merge branch 'master' of ssh+git://git.axiodl.com:6431/AxioDL/urde 2020-04-17 05:54:17 -07:00
Phillip Stephens a06594f404
Fix CAutoMapper strings, disable saving on non-USA/GC versions 2020-04-17 05:53:22 -07:00
Lioncash 58040eb53d CKnockBackController: Make CalculateExtraHurlVelocity() a const member function
This doesn't modify internal member state, so it can be marked const

While we're at it we can also invert the conditional to unindent the
main calculation.
2020-04-17 01:07:41 -04:00
Lioncash b55d1e4c77 CKnockBackController: Make use of const references where applicable
In many cases the CPatterned& parameter is only used for read-only
querying. We can make this explicit in the interface.
2020-04-17 01:03:12 -04:00
Lioncash 49cc019699 CKnockBackController: Make GetKnockBackCharacterState() a const member function
This doesn't modify internal instance state, so this can be made const.
2020-04-17 00:58:29 -04:00
Lioncash 529d7e58bd CFishCloud: Initialize x230_whichModel on construction
Provides a deterministic initial state.
2020-04-17 00:49:06 -04:00
Lioncash fa9f0fdc61 CFishCloud: Brace statements where applicable
Makes the code more uniform and consistent.

While we're in the same area, we can make use of const where applicable.
2020-04-17 00:47:25 -04:00
Lioncash 3715e6dcbb CFlameWarp: Make use of const where applicable
Makes algorithms easier to follow by explicitly marking immutable
state.
2020-04-17 00:27:22 -04:00
Lioncash ed125031f3 CFluidUVMotion: Collapse separate resize and assignment into a constructor call
We can pre-size and insert the elements all at the same time.
2020-04-16 21:11:31 -04:00
Phillip Stephens c85f1a64dd
Merge branch 'master' of ssh+git://git.axiodl.com:6431/AxioDL/urde 2020-04-16 17:20:25 -07:00
Phillip Stephens ba3b23edaa
Disable saving on non-NTSC-U versions 2020-04-16 17:19:55 -07:00
Lioncash 20e5595042 CGameState: Always initialize x80_
Provides a deterministic initial state.
2020-04-16 20:00:26 -04:00
Lioncash a551dbc21d CGameState: Silence implicit truncation warnings
Ensures boolean conditions are used where applicable.
2020-04-16 20:00:20 -04:00
Lioncash f844f2028b CGameOptions: Give all function prototype parameters a name
Makes the interface more self-documenting and also allows better IDE
introspection.
2020-04-16 19:49:35 -04:00
Lioncash e7ef1e0b5e CGameOptions: Make TuneScreenBrightness() a const member function
This member function doesn't modify internal class state.
2020-04-16 19:42:22 -04:00
Phillip Stephens d16e758f07 Include stdbool because AppleClang is weird 2020-04-16 13:43:23 -07:00
Phillip Stephens dea8438f19 Minor fix for macOS 2020-04-16 13:18:44 -07:00
Lioncash c32c42e12b CGameOptions: Amend wonky formatting of VisorOptsNew 2020-04-16 13:00:08 -04:00
Phillip Stephens be45be9d67
Fix FrontEnd options screen 2020-04-16 03:35:51 -07:00
Phillip Stephens 9365c35000
Finish fixing STRG indices 2020-04-16 03:25:59 -07:00
Phillip Stephens 8e2636c14c
Undo debug code 2020-04-15 23:58:00 -07:00
Phillip Stephens c64e3d2ba7
Initial string fixes 2020-04-15 23:57:04 -07:00
Phillip Stephens 582d8a6999
Initial PAL/JP/Trilogy imps, various cleanup 2020-04-15 22:26:14 -07:00