AxioDL
/
metaforce
mirror of https://github.com/AxioDL/metaforce.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
3,202 Commits 26 Branches 15 Tags 52 MiB
Commit Graph

3202 Commits

Author SHA1 Message Date
Lioncash 3a96c574b2 CTransitionDatabaseGame: std::move constructor parameters where applicable 
Same behavior, but allows the parameters to be moved into from calling
code.
 2020-03-09 11:58:10 -04:00
Lioncash 815f492e0f CSequenceHelper: std::move constructor parameters where applicable 
Same behavior, but allows for calling code to move into the interface.
 2020-03-09 11:58:10 -04:00
Lioncash cff12f0986 TAnimSourceInfo: std::move constructor parameter where applicable 
Allows calling code to move into the constructor.
 2020-03-09 11:58:10 -04:00
Lioncash 9fe671af99 CAnimTreeSequence: std::move constructor parameters where applicable 
Allows the constructor arguments to be moved into the constructor.
 2020-03-09 11:58:07 -04:00
Lioncash fa23d0bb9c CAnimTreeLoopIn: std::move constructor parameters where applicable 
Allows the constructor parameters to be moved into.
 2020-03-09 11:31:53 -04:00
Lioncash ab17c1cf2f CAnimationManager: std::move parameters to constructor where applicable 
Allows calling code to move into the respective arguments.
 2020-03-09 11:27:36 -04:00
Lioncash e289643742 CAnimData: std::move constructor arguments where applicable 
Same behavior, but allows calling code to move into the respective
parameters now.
 2020-03-09 11:25:23 -04:00
Lioncash 79565d7f52 CAnimSourceInfo: std::move TSubAnimTypeToken instance in constructor 
Provides the same behavior, but allows calling code to move into the
constructor.
 2020-03-09 11:11:27 -04:00
Lioncash 3cec19437a CAnimSysContext: std::move TToken instance in constructor 
Provides the same interface, but allows for calling code to move into
the constructor.
 2020-03-09 11:08:17 -04:00
Lioncash 280e4ce07d CAnimTreeAnimReaderContainer: std::move shared_ptr in constructor 
Provides the same behavior, but without a redundant atomic reference
count increment and decrement.
 2020-03-09 11:06:20 -04:00
Luke Street 5c9dd55b80 CChozoGhost: Fix IsOnGround 2020-03-09 10:41:34 -04:00
Luke Street 830db8772d Merge remote-tracking branch 'origin/master' into chozoghosts 2020-03-09 10:12:40 -04:00
Phillip Stephens d93df18a37
Fix `CScriptDistanceFog::AcceptScriptMessage` 2020-03-08 23:18:57 -07:00
Luke Street 7b9a037c95
Merge pull request #203 from lioncash/identical 
CBallCamera: Collapse identical switch cases within AvoidGeometry()
 2020-03-08 23:45:52 -04:00
Luke Street 6e9a80de5d CVisorFlare: Rename "near" to avoid MSVC conflict 2020-03-08 23:44:44 -04:00
Lioncash 363386cbd9 CBallCamera: Collapse identical switch cases within AvoidGeometry() 
Same behavior, but less code.

This is identical in behavior to the code within the GM8E v0 binary.
 2020-03-08 23:40:22 -04:00
Phillip Stephens 1a131907ef
Merge pull request #202 from lioncash/bool 
CStaticRes: Make operator bool explicit
 2020-03-08 19:52:08 -07:00
Lioncash 45c1bc9652 CStaticRes: Make use of CAssetId's IsValid() member function within operator bool 
We should be testing against IsValid() here to handle all cases that
indicate invalid values, as opposed to only handling the zero case.
 2020-03-08 22:49:33 -04:00
Phillip Stephens 89f479a824
Merge pull request #201 from lioncash/ref 
CToken: Add HasReference() member function
 2020-03-08 18:20:15 -07:00
Lioncash 209cd4a54e CStaticRes: Make operator bool explicit 
Prevents potentially error-prone conversions to bool. Similar to the
changes recently made to CToken.
 2020-03-08 21:20:08 -04:00
Lioncash 2233a78fe2 CToken: Add HasReference() member function 
Has the same semantics of operator bool(), but explains at the call site
what is actually being tested for in the relation to the object itself.

Aims to make readability slightly better (and removed the need for
casts).
 2020-03-08 21:13:37 -04:00
Phillip Stephens fc5170ede9
Merge pull request #200 from lioncash/temp 
CLogBookScreen: Remove unconditional return true in IsScanComplete()
 2020-03-08 18:03:54 -07:00
Phillip Stephens a28b7a8df7
Merge pull request #199 from lioncash/octree 
CPVSVisOctree: Use static qualifying name for ReadBoundingBoxBig()
 2020-03-08 18:03:44 -07:00
Phillip Stephens f07d4e9630
Merge pull request #198 from lioncash/move 
CResFactory: Resolve use-after-move in AddToLoadList()
 2020-03-08 18:03:28 -07:00
Phillip Stephens b492c91ccf
Merge pull request #197 from lioncash/cond 
CFontRenderState: Collapse common switch cases in RefreshColor()
 2020-03-08 18:03:17 -07:00
Phillip Stephens b01fa0c5bf
Merge pull request #196 from lioncash/saveable 
CSaveableState: Initialize vectors in the constructor initializer list
 2020-03-08 18:03:01 -07:00
Phillip Stephens dd54f93da4
Merge pull request #195 from lioncash/unused 
CPlayer: Make use of unused CCollidableAABox in ProcessInput()
 2020-03-08 18:02:52 -07:00
Phillip Stephens 3011a839eb
Merge pull request #194 from lioncash/init 
CProjectileInfo: Initialize result variable to false within PredictInterceptPos
 2020-03-08 18:02:41 -07:00
Phillip Stephens 51bb2244da
Merge pull request #193 from lioncash/explicit 
CToken: Make operator bool explicit
 2020-03-08 18:02:30 -07:00
Phillip Stephens 3e59f7a455
Prepare for pr-193 2020-03-08 18:01:29 -07:00
Lioncash 2a1df559a9 CLogBookScreen: Remove unconditional return true in IsScanComplete() 
This was temporarily added in for debugging purposes in the past but was
never removed.
 2020-03-08 11:15:13 -04:00
Phillip Stephens f06c26e7d6
Fix infinite loop in CObjectList, and add an assert to detect invalid assignments 2020-03-07 09:14:07 -08:00
Lioncash 8d42eb4287 CPVSVisOctree: Initialize in-class member variables where applicable 
Provides a deterministic initial state for the default constructor.
 2020-03-07 05:01:29 -05:00
Lioncash 4034e3b31f CPVSVisOctree: Make use of std::array where applicable 
Makes the arrays strongly typed.
 2020-03-07 04:50:19 -05:00
Lioncash 969bcdba35 CPVSVisOctree: Use static qualifying name for ReadBoundingBoxBig() 
It looks very odd using the name of the object being initialized to call
through to a static member function. We can disambiguate this by making
use of the qualifying name directly.
 2020-03-07 04:46:19 -05:00
Lioncash 0a47e623fd CResFactory: Resolve use-after-move in AddToLoadList() 
The behavior on the right hand side would occur before the actual
assignment, making the tag value invalidated. Instead, we copy the tag
before the move is performed to keep the data valid when inserting it
into the map.
 2020-03-07 03:56:16 -05:00
Lioncash a490eaf8ff CFontRenderState: Collapse common switch cases in RefreshColor() 
Same behavior, less code.
 2020-03-07 03:44:54 -05:00
Lioncash 815a38288a CSaveableState: Initialize vectors in the constructor initializer list 
Initializes the vectors in place, rather than constructing them and then
resizing.
 2020-03-06 22:47:39 -05:00
Lioncash 830e1c59d2 CPlayer: Make nearby variables const 
Makes nearby variables from the previous change const to make their
immutability explicit.
 2020-03-06 22:08:56 -05:00
Lioncash a2b6b4515d CPlayer: Make use of unused CCollidableAABox in ProcessInput() 
GM8E v0 makes use of the temporary collidable AA box. This amends the
code to make use of it.
 2020-03-06 22:06:44 -05:00
Lioncash 27fb2008dc CProjectileInfo: Initialize result variable to false within PredictInterceptPos() 
GM8E v0 sets this to false before performing any further calculations.
This also prevents accidental uninitialized usages from occurring if
this is ever changed in the future.

While we're in the same area we can make bracing consistent.
 2020-03-06 21:57:39 -05:00
Lioncash a6367c0688 CToken: Make operator bool explicit 
Prevents potential error-prone conversions from occurring
 2020-03-06 21:42:07 -05:00
Phillip Stephens 052aa80bac
Fix initial AI issues 2020-03-06 18:03:13 -08:00
Phillip Stephens 4daa8ac374
CModelBoo: Fix missing cast 2020-03-06 16:27:33 -08:00
Phillip Stephens 17f25457c5
CGameArea::CAreaObjectList fix 2020-03-06 16:20:52 -08:00
Phillip Stephens 76e0a1f8f5
Merge pull request #192 from lioncash/init 
CEyeball: Eliminate unnecessary runtime initializer in Think()
 2020-03-06 16:15:15 -08:00
Phillip Stephens 7358570d51
Merge pull request #191 from lioncash/const 
CObjectList: Make IsQualified() a const member function
 2020-03-06 16:14:59 -08:00
Phillip Stephens 24baafb996
Merge pull request #190 from lioncash/render 
CBooRenderer: Minor cleanup
 2020-03-06 16:14:47 -08:00
Phillip Stephens ae25392d19
Merge pull request #189 from lioncash/model 
CModelBoo: Make static data constexpr where applicable
 2020-03-06 16:14:05 -08:00
Phillip Stephens f8e40e600f
Merge pull request #188 from lioncash/class 
CModelShaders: Make EExtendedShader an enum class
 2020-03-06 16:13:54 -08:00