Commit Graph

40 Commits

Author SHA1 Message Date
Luke Street c1635245b8 Use UTF-8 exclusively internally; replace iconv with OSUTF
Filenames are now unconditionally encoded/decoded as
Shift-JIS, which provides a reasonable fallback to
7-bit ASCII.
2021-06-30 13:47:10 -04:00
Minty-Meeo 3c25647b6e The Encoding Update
While Nintendo's own documents claim GameCube and Wii disc file symbol tables only support 7-bit ASCII, this is far from the truth.  Indeed, even some first-party Nintendo games shipped with Shift-JIS encoded file symbol tables.  My guess?  The locale of whatever Windows machine mastered a GameCube or Wii disc influenced how wide character strings (UCS-2) were converted to narrow character strings.  To account for all possibilites, this update adds extensible multi-byte character set options to NOD-Tool.

A rundown of notable changes:
 - "-c XXXXX" option added to set the encoding of the GameCube / Wii ISO(s) being processed.
 - "SystemStringConv" renamed to "DiscLocToSystemConv"
 - "SystemUTF8Conv" renamed to "SystemToDiscLocConv"
 - Help message updated with new info.
 - Bugfix: AddBuildName had a logic error wherein the length of the SystemString was being used instead of length of the disc locale string.  This would corrupt the File Symbol Table if the disc locale string's length was greater than the SystemString's length.
 - Bugfix: recursiveMergeFST was not keeping track of parent indexes at all, meaning nested folders and their contents would be corrupted.  I simply copied the way recursiveBuildFST did things to fix this.
 - Bugfix (Windows): On Windows, for some reason, Sstat was a typedef for _stat (32-bit) instead of _stat64 (64-bit).  This is confounding, because untrimmed Wii ISOs will always be larger than the unsigned 32-bit integer limit (4,699,979,776 bytes vs 4,294,967,295 bytes), meaning the MergeWii errand has never worked for untrimmed ISOs on Windows.  Was this never tested??
 - Bugfix (Windows): Did you know Windows Command Prompt fully supports Unicode?  Stdio streams are now in _O_U16TEXT mode for Windows only.  Previously, attempting to print any character that could not be narrowed to your locale's encoding would either silently fail (std functions), or throw an exception (fmt functions).  As a minor drawback, narrow character print functions can no longer be used when stdio is in _O_U16TEXT mode, necessitating my PR for Logvisor here: (AxioDL/logvisor#7)
 - ExtractionContext::progressCB now uses SystemStringView because widechar printing works correctly on Windows now.
 - progFunc lambda no longer throws exceptions when printing unicode because widechar printing works correctly on Windows now.
 - Top-level constructors and functions with a Codepage_t parameter have also signatures that default to the US-ASCII codepage.
    - DiscGCN constructor
    - DiscBuilderGCN constructor
    - DiscBuilderGCN::CalculateTotalSizeRequired
    - DiscMergerGCN constructor
    - DiscMergerGCN::CalculateTotalSizeRequired
    - DiscWii constructor
    - DiscBuilderWii constructor
    - DiscBuilderWii::CalculateTotalSizeRequired
    - DiscMergerWii constructor
    - DiscMergerWii::CalculateTotalSizeRequired
    - OpenDiscFromImage
 - Conversion between system encoding and disc locale encoding has checks in place to warn the user if string conversion goes awry.
2021-06-27 03:26:20 -05:00
Jack Andersen 2783337c36 Update fmtlib 2020-04-11 12:45:06 -10:00
Henrique Gemignani Passos Lima 091262ace1 Use std::optional for CalculateTotalSizeBuild 2019-09-06 22:17:06 +02:00
Lioncash 5935e84dab General: Include headers directly where necessary
Ensures includes are explicitly included where necessary to avoid
indirect inclusions.
2019-08-30 04:34:49 -04:00
Jack Andersen 37792ba116 Massive libfmt refactor 2019-07-19 18:21:57 -10:00
Jack Andersen 34b943c40f Solve various signing warnings reported by GCC 2019-06-09 16:49:17 -10:00
Jack Andersen be8409681f New code style refactor 2018-12-07 19:21:47 -10:00
Jack Andersen f87b286ff3 Windows build fixes 2018-10-14 10:11:28 -10:00
Jack Andersen bf00fcd10f Driver fix 2017-12-28 22:38:55 -10:00
Jack Andersen a557f86974 Huge compile performance refactor 2017-12-28 21:57:54 -10:00
Jack Andersen 69e96e3b3c Linux build fixes 2017-11-12 21:21:29 -10:00
Jack Andersen 27a2cb5998 string_view refactor 2017-11-12 20:18:53 -10:00
Jack Andersen 41148a1368 Refactor of extracted directory structure and API simplification 2017-07-01 13:36:16 -10:00
Jack Andersen bc38896a2b Minor progress callback tweak 2017-05-21 23:18:52 -04:00
Jack Andersen dd20c1d255 Add floating point progress to builder callbacks 2017-05-21 23:12:48 -04:00
Phillip Stephens e494dbba9f Add completion percentage to ExtractionContext's callback 2017-05-21 03:26:22 -07:00
Jack Andersen dc474ad156 Major refactor, better error handling and directory/image merge 2017-02-04 20:19:34 -10:00
Phillip Stephens bcfe1a5d33 FreeBSD fixes 2016-10-27 15:49:40 -08:00
Jack Andersen 9d6b6ceb71 Update logvisor 2016-09-17 11:33:14 -10:00
Jack Andersen e55a4322ab Update logvisor 2016-09-07 20:16:22 -10:00
Jack Andersen 556a5868bb Humungous refactor 2016-03-04 13:04:30 -10:00
Jack Andersen 528b5cad0c Minor fixes 2016-01-25 20:39:49 -10:00
Jack Andersen 3de662940b Codebase cleanups and README 2016-01-25 10:21:10 -10:00
Phillip 0819101986 More windows fixes 2016-01-23 22:44:17 -08:00
Phillip 9114be2a4d Various windows fixes (microsoft plz) 2016-01-23 21:12:40 -08:00
Jack Andersen e9bac54e10 Wii image generation fixes 2016-01-22 13:45:58 -10:00
Jack Andersen 7403996ed3 Initial Wii image generation (needs disc header) 2016-01-21 16:30:17 -10:00
Jack Andersen 3fab04ff1a GCN image generation fixes 2016-01-21 10:46:07 -10:00
Jack Andersen fafff92874 Work on GCN image building 2016-01-20 20:30:37 -10:00
Jack Andersen 322d1c48cd Added type-aliases for nested NOD types 2015-10-01 11:47:27 -10:00
Phillip Stephens f4c606c4eb WIP context 2015-09-27 18:55:59 -07:00
Jack Andersen 7fafe3ce0c Removed exceptions 2015-07-25 16:44:44 -10:00
Jack Andersen b6969a82dc removed qt files 2015-07-08 20:45:10 -10:00
Jack Andersen dea4eda76d Added CMakeLists.txt 2015-07-06 17:22:19 -10:00
Jack Andersen a656c5d4c9 Integrated LogVisor for error gathering 2015-07-03 20:02:12 -10:00
Jack Andersen b461f63ae4 wchar_t support for windows 2015-07-02 10:37:07 -10:00
Jack Andersen 5c736af2b0 isolated includes with NOD directory 2015-07-02 08:33:55 -10:00
Jack Andersen a1b2a262bf working file extractor; removed hard-coded paths 2015-06-30 09:38:51 -10:00
Jack Andersen 293b7c0ce6 Initial extractor automation 2015-06-29 20:46:19 -10:00