Lioncash
221bc7c7f2
General: Be explicit about athena's SeekOrigin type
...
Allows this code to function if the enum is turned into an enum class.
2019-09-08 17:29:38 -04:00
Phillip Stephens
acdadaf963
Merge pull request #5 from henriquegemignani/optional
...
Use std::optional for CalculateTotalSizeBuild
2019-09-07 01:18:43 -07:00
Phillip Stephens
d658909948
Update athena
2019-09-06 23:31:44 -07:00
Henrique Gemignani Passos Lima
091262ace1
Use std::optional for CalculateTotalSizeBuild
2019-09-06 22:17:06 +02:00
Phillip Stephens
97cfcea14e
Merge pull request #13 from lioncash/overrun
...
DiscBase: Prevent potential off-by-one case within getPartitonNodeCount()
2019-09-05 19:35:01 -07:00
Lioncash
f5c3cbdcd7
DiscBase: Amend typo within getPartitonNodeCount() name
...
Adds an extra 'i' to correct a typo.
2019-09-05 21:57:44 -04:00
Lioncash
7ddff919c1
DiscBase: Prevent potential off-by-one case within getPartitonNodeCount()
...
We should be comparing with >= instead of >.
2019-09-05 21:56:49 -04:00
Lioncash
4bba7af2c2
DiscBase: std::move std::function instance
...
std::function isn't a trivial type (it's allowed to heap allocate to
store any necessary captures), so we can move it in the constructor to
avoid any unnecessary allocations
2019-09-05 21:52:43 -04:00
Lioncash
f443b60bde
DiscBase: Mark member functions as const where applicable
...
These don't modify instance state, so they can be marked as const.
2019-09-05 21:51:20 -04:00
Lioncash
998d6a77c3
General: Remove redundant inline keyword
...
Functions defined within the class declaration are already inline by
default, so we don't need to specify the keyword here.
2019-09-05 21:48:07 -04:00
Phillip Stephens
55301dd505
Merge pull request #11 from lioncash/make
...
General: Use std::make_unique where applicable
2019-08-30 16:28:53 -07:00
Phillip Stephens
793413540d
Merge pull request #12 from lioncash/fmt
...
FileIOWin32: Amend fmt format strings
2019-08-30 16:28:45 -07:00
Lioncash
f11eb728bf
FileIOWin32: Amend fmt format strings
...
Amends a few stragglers from the transition to fmtlib.
2019-08-30 05:40:00 -04:00
Lioncash
a8753e273f
General: Use std::make_unique where applicable
...
Makes for a little less reading in certain cases.
2019-08-30 05:35:12 -04:00
Phillip Stephens
63264695b0
Merge pull request #9 from lioncash/include
...
General: Include headers directly where necessary
2019-08-30 02:13:24 -07:00
Phillip Stephens
edc31b2107
Merge pull request #10 from lioncash/cmake
...
CMakeLists: Minor cleanup
2019-08-30 02:13:13 -07:00
Lioncash
1b3bb7815d
CMakeLists: Move lib-specific CMake commands into the lib folder
...
Keeps a clear division between the lib and the driver CMake code.
2019-08-30 04:53:05 -04:00
Lioncash
89df98ee96
CMakeLists: Eliminate glob statement
...
Avoids a top-level variable from being defined and adds the source files
explicitly to the target like our other targets.
2019-08-30 04:43:56 -04:00
Lioncash
5935e84dab
General: Include headers directly where necessary
...
Ensures includes are explicitly included where necessary to avoid
indirect inclusions.
2019-08-30 04:34:49 -04:00
Phillip Stephens
df1e450728
Update logvisor
2019-08-26 15:56:48 -07:00
Phillip Stephens
c9bf821285
Update logvisor
2019-08-17 23:00:24 -07:00
Jack Andersen
18b297e312
Merge pull request #8 from lioncash/cmake
...
CMakeLists: Migrate off directly modifying CMAKE_CXX_FLAGS
2019-08-10 09:30:26 -07:00
Phillip Stephens
255a37216f
Merge branch 'override' of git://github.com/lioncash/nod into lioncash-override
2019-08-09 23:14:32 -07:00
Phillip Stephens
7da7761afb
Merge branch 'lioncash-null-term'
2019-08-09 23:14:09 -07:00
Lioncash
876a2ccf81
CMakeLists: Migrate off directly modifying CMAKE_CXX_FLAGS
...
We can simply apply the compilation options directly to the target. We
can perform equivalent behavior for conditionally adding sources to the
target instead of assigning to a variable as well.
2019-08-10 01:52:27 -04:00
Lioncash
2171388b9d
General: Make use of override where applicable
...
Makes it explicit where functions are being overridden in derived
classes/structs.
2019-08-10 01:41:44 -04:00
Lioncash
a572439967
DirectoryEnumerator: Handle non-null-terminated strings in CaseInsensitiveCompare
...
std::string_view instances aren't required to be null terminated. Given
this, we can make the functions a little safer by performing an explicit
bounded comparison on the range of characters, making the code more
generic with regards to handling the underlying string data.
2019-08-10 01:16:21 -04:00
Jack Andersen
ac6f2a1ed2
update logvisor
2019-07-27 15:20:43 -10:00
Jack Andersen
37792ba116
Massive libfmt refactor
2019-07-19 18:21:57 -10:00
Phillip Stephens
d9b6be8446
Compile fixes
2019-06-20 15:45:35 -07:00
Jack Andersen
47322b9496
Refactor of CMake for cleaner dependency handling
2019-06-11 15:54:20 -10:00
Jack Andersen
77013bbd9f
Merge branch 'master' of https://github.com/AxioDL/nod
2019-06-09 16:51:00 -10:00
Jack Andersen
34b943c40f
Solve various signing warnings reported by GCC
2019-06-09 16:49:17 -10:00
Jack Andersen
a1284ae065
Update logvisor
2019-05-25 00:15:37 -10:00
Jack Andersen
4dd0375cae
Adjusted install commands for better CMake compatibility
2019-05-23 14:17:45 -10:00
Jack Andersen
01237372e1
Update logvisor
2019-05-22 18:09:21 -10:00
Jack Andersen
d9638cc60d
Update logvisor
2019-05-22 17:59:34 -10:00
Jack Andersen
0ac7140542
Minor .gitmodules change
2019-05-22 16:04:33 -10:00
Jack Andersen
a5e9166194
Merge branch 'cmake'
2019-05-22 16:03:03 -10:00
Jack Andersen
ca2aeecc64
Ensure exported include dir is correct
2019-05-12 13:16:34 -10:00
Jack Andersen
cd782047c8
Update .gitmodules
2019-05-12 12:48:02 -10:00
Jack Andersen
2b7ea07cae
Remove redundant include path
2019-05-12 12:41:14 -10:00
Jack Andersen
ed28576b99
Update logvisor
2019-05-09 18:06:48 -10:00
Jack Andersen
95ed2ae7dc
Implicit switch fallthrough refactor
2019-02-17 19:46:42 -10:00
Sam Fuller
f1c76a475d
Cmake config support
2019-01-27 21:35:03 -08:00
Jack Andersen
be8409681f
New code style refactor
2018-12-07 19:21:47 -10:00
Jack Andersen
3d380fdc3b
macOS build fixes
2018-10-15 17:16:08 -10:00
Jack Andersen
f87b286ff3
Windows build fixes
2018-10-14 10:11:28 -10:00
Jack Andersen
e964a013fe
Convert to pragma once
2018-10-06 17:39:24 -10:00
Jack Andersen
eb6aa30563
NX build fixes
2018-10-06 16:56:47 -10:00