AxioDL
/
nod
mirror of https://github.com/AxioDL/nod.git
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
250 Commits 3 Branches 1 Tag 599 KiB
Commit Graph

46 Commits

Author SHA1 Message Date
Luke Street c1635245b8 Use UTF-8 exclusively internally; replace iconv with OSUTF 
Filenames are now unconditionally encoded/decoded as
Shift-JIS, which provides a reasonable fallback to
7-bit ASCII.
 2021-06-30 13:47:10 -04:00
Minty-Meeo 3c25647b6e The Encoding Update 
While Nintendo's own documents claim GameCube and Wii disc file symbol tables only support 7-bit ASCII, this is far from the truth.  Indeed, even some first-party Nintendo games shipped with Shift-JIS encoded file symbol tables.  My guess?  The locale of whatever Windows machine mastered a GameCube or Wii disc influenced how wide character strings (UCS-2) were converted to narrow character strings.  To account for all possibilites, this update adds extensible multi-byte character set options to NOD-Tool.

A rundown of notable changes:
 - "-c XXXXX" option added to set the encoding of the GameCube / Wii ISO(s) being processed.
 - "SystemStringConv" renamed to "DiscLocToSystemConv"
 - "SystemUTF8Conv" renamed to "SystemToDiscLocConv"
 - Help message updated with new info.
 - Bugfix: AddBuildName had a logic error wherein the length of the SystemString was being used instead of length of the disc locale string.  This would corrupt the File Symbol Table if the disc locale string's length was greater than the SystemString's length.
 - Bugfix: recursiveMergeFST was not keeping track of parent indexes at all, meaning nested folders and their contents would be corrupted.  I simply copied the way recursiveBuildFST did things to fix this.
 - Bugfix (Windows): On Windows, for some reason, Sstat was a typedef for _stat (32-bit) instead of _stat64 (64-bit).  This is confounding, because untrimmed Wii ISOs will always be larger than the unsigned 32-bit integer limit (4,699,979,776 bytes vs 4,294,967,295 bytes), meaning the MergeWii errand has never worked for untrimmed ISOs on Windows.  Was this never tested??
 - Bugfix (Windows): Did you know Windows Command Prompt fully supports Unicode?  Stdio streams are now in _O_U16TEXT mode for Windows only.  Previously, attempting to print any character that could not be narrowed to your locale's encoding would either silently fail (std functions), or throw an exception (fmt functions).  As a minor drawback, narrow character print functions can no longer be used when stdio is in _O_U16TEXT mode, necessitating my PR for Logvisor here: (AxioDL/logvisor#7)
 - ExtractionContext::progressCB now uses SystemStringView because widechar printing works correctly on Windows now.
 - progFunc lambda no longer throws exceptions when printing unicode because widechar printing works correctly on Windows now.
 - Top-level constructors and functions with a Codepage_t parameter have also signatures that default to the US-ASCII codepage.
    - DiscGCN constructor
    - DiscBuilderGCN constructor
    - DiscBuilderGCN::CalculateTotalSizeRequired
    - DiscMergerGCN constructor
    - DiscMergerGCN::CalculateTotalSizeRequired
    - DiscWii constructor
    - DiscBuilderWii constructor
    - DiscBuilderWii::CalculateTotalSizeRequired
    - DiscMergerWii constructor
    - DiscMergerWii::CalculateTotalSizeRequired
    - OpenDiscFromImage
 - Conversion between system encoding and disc locale encoding has checks in place to warn the user if string conversion goes awry.
 2021-06-27 03:26:20 -05:00
Jack Andersen 2783337c36 Update fmtlib 2020-04-11 12:45:06 -10:00
Henrique Gemignani Passos Lima 091262ace1 Use std::optional for CalculateTotalSizeBuild 2019-09-06 22:17:06 +02:00
Phillip Stephens 55301dd505
Merge pull request #11 from lioncash/make 
General: Use std::make_unique where applicable
 2019-08-30 16:28:53 -07:00
Lioncash a8753e273f General: Use std::make_unique where applicable 
Makes for a little less reading in certain cases.
 2019-08-30 05:35:12 -04:00
Lioncash 5935e84dab General: Include headers directly where necessary 
Ensures includes are explicitly included where necessary to avoid
indirect inclusions.
 2019-08-30 04:34:49 -04:00
Lioncash 2171388b9d General: Make use of override where applicable 
Makes it explicit where functions are being overridden in derived
classes/structs.
 2019-08-10 01:41:44 -04:00
Jack Andersen 37792ba116 Massive libfmt refactor 2019-07-19 18:21:57 -10:00
Jack Andersen 34b943c40f Solve various signing warnings reported by GCC 2019-06-09 16:49:17 -10:00
Jack Andersen be8409681f New code style refactor 2018-12-07 19:21:47 -10:00
Jack Andersen f87b286ff3 Windows build fixes 2018-10-14 10:11:28 -10:00
Aruki 6f777ebb48 Fixes for a couple warnings/errors whene compiling on windows 2018-07-06 01:02:23 -06:00
Jack Andersen d5f5db440c Windows build fixes and warning avoidance 2018-05-24 20:38:06 -10:00
Jack Andersen a557f86974 Huge compile performance refactor 2017-12-28 21:57:54 -10:00
Jack Andersen 27a2cb5998 string_view refactor 2017-11-12 20:18:53 -10:00
Jack Andersen fb2a5c91d2 Explicitly zero-initialize new image files 2017-07-30 16:03:20 -10:00
Jack Andersen 8bdbcf0c90 Fixes to work with directory-blob dolphin branch 2017-07-01 21:16:09 -10:00
Jack Andersen 2a472651ae Proper extract structure for GCN images 2017-07-01 19:39:41 -10:00
Jack Andersen 41148a1368 Refactor of extracted directory structure and API simplification 2017-07-01 13:36:16 -10:00
Phillip Stephens e49568ac83 Initial modifications to support Dolphin's VolumeDirectory 2017-06-30 03:30:10 -07:00
Jack Andersen dd20c1d255 Add floating point progress to builder callbacks 2017-05-21 23:12:48 -04:00
Jack Andersen dc474ad156 Major refactor, better error handling and directory/image merge 2017-02-04 20:19:34 -10:00
Jack Andersen 556a5868bb Humungous refactor 2016-03-04 13:04:30 -10:00
Jack Andersen 48f79b2369 File-size limiting 2016-02-02 11:18:16 -10:00
Jack Andersen 39e9cea094 Image file preallocation 2016-02-02 10:42:17 -10:00
Jack Andersen df5e8d068c Removed direct stdio usage 2016-01-24 19:55:31 -10:00
Jack Andersen c4aaecbc8f Single-pass image creation refactor 2016-01-24 16:00:02 -10:00
Jack Andersen e7f8bbed8a System files added to Wii partition first to keep 32-bit loaders happy 2016-01-22 17:39:38 -10:00
Jack Andersen e9bac54e10 Wii image generation fixes 2016-01-22 13:45:58 -10:00
Jack Andersen 7403996ed3 Initial Wii image generation (needs disc header) 2016-01-21 16:30:17 -10:00
Jack Andersen 3fab04ff1a GCN image generation fixes 2016-01-21 10:46:07 -10:00
Jack Andersen fafff92874 Work on GCN image building 2016-01-20 20:30:37 -10:00
Jack Andersen 3a41af8a91 Initial image building 2016-01-19 17:17:24 -10:00
Jack Andersen 168ff506a3 Major scoped-enum refactor 2015-11-20 15:15:33 -10:00
Jack Andersen 28ed4ba6af removed redundant get() calls 2015-08-05 11:45:25 -10:00
Jack Andersen 993b30e4a5 Fixed WBFS reads with 64-bit addresses 2015-07-13 16:24:17 -10:00
Jack Andersen b8236ba6d7 DOL/Apploader buffer maker 2015-07-09 17:11:30 -10:00
Jack Andersen dea4eda76d Added CMakeLists.txt 2015-07-06 17:22:19 -10:00
Phillip Stephens 306c910710 Fix apploader extraction 2015-07-04 10:30:00 -07:00
Jack Andersen 5c736af2b0 isolated includes with NOD directory 2015-07-02 08:33:55 -10:00
Jack Andersen a1b2a262bf working file extractor; removed hard-coded paths 2015-06-30 09:38:51 -10:00
Jack Andersen 293b7c0ce6 Initial extractor automation 2015-06-29 20:46:19 -10:00
Jack Andersen ec8db1694b FST building/traversal in place 2015-06-29 14:07:46 -10:00
Jack Andersen 03a371b7bf lots of Wii disc parsing in place 2015-06-27 19:43:53 -10:00
Jack Andersen 791056d966 initial class layout 2015-06-26 09:30:03 -10:00