Commit Graph

485 Commits

Author SHA1 Message Date
Lee Thomason ba7d9df976 Merge pull request #272 from Dmitry-Me/properTreatStrchrPostConditions
strchr() can only find what is was asked for
2015-01-12 13:58:15 -08:00
Dmitry-Me 9f56e12c16 strchr() can only find what is was asked for 2015-01-12 10:07:54 +03:00
Lee Thomason d15686653a Merge pull request #269 from Dmitry-Me/makeFormattingConsistent
Fix formatting, get rid of useless if-else chain
2015-01-09 16:57:17 -08:00
Lee Thomason f802660f7d Merge pull request #268 from Dmitry-Me/avoidRepeatedComparisons
Get rid of repeated comparisons
2015-01-09 16:56:40 -08:00
Lee Thomason e4fe285427 Merge pull request #267 from Dmitry-Me/prohibitCopyAndAssignment
Prohibit copy and assigment where they are not supported
2015-01-09 16:55:27 -08:00
Lee Thomason b389252931 Merge pull request #264 from Dmitry-Me/makeProhibitedStuffPrivate
Prohibited operations should be declared private
2015-01-09 16:55:07 -08:00
Lee Thomason e53740ec6a Merge pull request #263 from Dmitry-Me/useProperConstCast
Use explicit const_cast
2015-01-09 14:29:05 -08:00
Dmitry-Me 257e11b25b Fix formatting, get rid of useless if-else chain 2015-01-09 15:50:47 +03:00
Dmitry-Me 3ae4f3eb3c Get rid of repeated comparisons 2015-01-09 15:44:16 +03:00
Dmitry-Me 3e0af3793e Prohibit copy and assigment where they are not supported 2015-01-09 15:30:00 +03:00
Dmitry-Me f547a99619 Prohibited operations should be declared private 2015-01-09 15:17:09 +03:00
Dmitry-Me e28be7530c Use explicit const_cast 2015-01-09 14:59:30 +03:00
Lee Thomason 3cebdc4fac clean up function names. clean up pointer 2015-01-05 17:16:28 -08:00
Lee Thomason 75b4e23957 Merge pull request #260 from Dmitry-Me/placeChecksInMoreNaturalOrder
Rearrange checks in more natural order
2015-01-05 17:07:50 -08:00
Lee Thomason 6e504e9baf Merge pull request #259 from Dmitry-Me/preAndPostAssertsInGetStr
Pointer asserts in GetStr()
2015-01-05 17:07:06 -08:00
Lee Thomason 59946f6f1a Merge pull request #258 from Dmitry-Me/clarifyIsNameStart
Clarify IsNameStartChar() - resolve issue 250
2015-01-05 17:06:30 -08:00
Lee Thomason 625402a01f Merge pull request #257 from Dmitry-Me/reusePreInsertMagic
Reuse pre-insert manipulations
2015-01-05 17:05:23 -08:00
Lee Thomason 56223ddaea Merge pull request #256 from Dmitry-Me/reuseParseAdjustments
Reuse code with pre-parse adjustments
2015-01-05 17:04:04 -08:00
Lee Thomason deccff765f Merge pull request #254 from JayXon/onlyCheckElementPointerOnce
Only check ele pointer once
2015-01-05 17:00:43 -08:00
Dmitry-Me 7a7e5dc525 Rearrange checks in more natural order 2015-01-01 17:58:35 +03:00
Dmitry-Me 5ffa73e979 Pointer asserts in GetStr() 2015-01-01 17:47:40 +03:00
Dmitry-Me ea617f9380 Clarify IsNameStartChar() - resolve issue 250 2015-01-01 16:32:01 +03:00
Dmitry-Me 74e394023a Reuse pre-insert manipulations 2015-01-01 16:26:17 +03:00
Dmitry-Me 97476b7b9e Reuse code with pre-parse adjustments 2015-01-01 16:15:57 +03:00
Lee Thomason b4e81b014e Merge pull request #253 from Dmitry-Me/getRidOfC4127InAssert
Suppress C4127 in asserts
2014-12-26 16:25:14 -08:00
Lee Thomason 6d12b7bc3d Merge pull request #252 from Dmitry-Me/moreAdequateTestForEmpty
Better tests for empty document
2014-12-26 16:22:25 -08:00
Lee Thomason 5f06297230 Merge pull request #248 from JayXon/simplifyParseName
Simplify ParseName
2014-12-26 16:18:46 -08:00
Lee Thomason 9af6ccb3da fix whitespace conflict 2014-12-26 12:22:30 -08:00
Lee Thomason 78120c2a1e Merge pull request #249 from Dmitry-Me/unifySkipWhiteSpaceCallsAddAsserts
Unify SkipWhiteSpace()/ReadBOM() calls, add asserts
2014-12-26 12:22:55 -08:00
Lee Thomason ac503ea88a Merge remote-tracking branch 'origin/master' 2014-12-26 12:20:18 -08:00
Lee Thomason 20806ce4e4 add an extra assert 2014-12-26 12:20:07 -08:00
JayXon e4bf6e360d Only check ele pointer once 2014-12-26 01:00:24 -05:00
Dmitry-Me 4bcbf142a8 Suppress C4127 in asserts 2014-12-25 19:05:18 +03:00
Dmitry-Me 588bb8de49 Better tests for empty document 2014-12-25 18:59:18 +03:00
JayXon ee525dba4d Simplify ParseName
Only the first char needs to be checked with IsNameStartChar, so check
it before the loop.
2014-12-24 04:01:42 -05:00
Dmitry-Me bb836dce57 Unify SkipWhiteSpace()/ReadBOM() calls, add asserts 2014-12-24 11:54:05 +03:00
Lee Thomason 69242c4b9b Merge pull request #247 from Dmitry-Me/combineCheckWithDependentCall
Move the check into dependent call
2014-12-23 13:16:11 -08:00
Lee Thomason ffee345723 Merge pull request #246 from Dmitry-Me/moveVariableDeclaration
Move variable declaration closer to where it's needed
2014-12-23 13:12:38 -08:00
Dmitry-Me a092bc1f5a Move the check into dependent call 2014-12-23 17:57:05 +03:00
Dmitry-Me 5b4a5169e3 Move variable declaration closer to where it's needed 2014-12-23 17:36:28 +03:00
Lee Thomason eaddfd8768 Merge pull request #245 from Dmitry-Me/ensureCapacityPreAsserts
Pre-asserts to ensure no overflow happens
2014-12-22 11:27:43 -08:00
Lee Thomason 4e5900c5e8 Merge pull request #244 from Dmitry-Me/unifyCharacterCasts
Unify character casts, reorganize checks
2014-12-22 11:26:52 -08:00
Lee Thomason 0b4bdd2a47 Merge pull request #243 from JayXon/simplify_node_logic
Simplify node logic
2014-12-22 11:22:47 -08:00
Dmitry-Me 9fae869124 Pre-asserts to ensure no overflow happens 2014-12-22 17:59:59 +03:00
Dmitry-Me 8b67d741d4 Unify character casts, reorganize checks 2014-12-22 11:35:12 +03:00
Lee Thomason ebb0c8f904 fix compiler warning 2014-12-17 10:50:32 -08:00
Lee Thomason 7334f9efab fix a clang warning 2014-12-17 10:43:48 -08:00
Lee Thomason cd011bc1b7 start working through memory bugs 2014-12-17 10:41:34 -08:00
JayXon dbfdd8fdd5 Simplify node logic 2014-12-12 20:07:14 -05:00
Lee Thomason ee2c46928e Merge pull request #240 from Dmitry-Me/simplifyNodeOwnershipTracking
Even more pointer pre-asserts
2014-12-12 15:37:22 -08:00