encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
dawn-cmake/BUILD.gn

807 lines
24 KiB
Plaintext
Raw Normal View History

Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
# Copyright 2018 The Dawn Authors
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
import("scripts/dawn_overrides_with_defaults.gni")
BUILD.gn: Move last third_party deps to third_party/BUILD.gn
2018-08-13 06:31:17 +00:00
import("scripts/dawn_features.gni")
Build with a different gtest harness when in Chromium Running test in a Chromium build requires using their gtest and gmock targets as well as a harness that is in //base. Since we want to run Dawn tests on the Chromium GPU bots, we need to support two configurations both building tests standalone and in Chromium. BUG=chromium:870747 Change-Id: I862e62a607e193a27562ece0f1f6d46d8728e446 Reviewed-on: https://dawn-review.googlesource.com/c/2080 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Stephen White <senorblanco@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-10-31 10:49:21 +00:00
import("//build_overrides/build.gni")
Create new src/tests BUILD.gn file. Move all test-related build stuff into its own BUILD.gn file. This required moving the dawn_generator template into a common file, so it can be called by both BUILD.gn and src/tests/BUILD.gn. Bug: dawn:61 Change-Id: Icaa459270bdaa60306e053b93835812e70dba6f5 Reviewed-on: https://dawn-review.googlesource.com/c/2940 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Stephen White <senorblanco@chromium.org>
2018-12-05 22:42:23 +00:00
import("generator/dawn_generator.gni")
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
Use Chromium's dcheck_always_on when available. This will make GPU tests running on Chromium-based builders respect this configuration, which is important to have the same code run in Release and Debug builds on the GPU FYI waterfall. BUG=chromium:901830 Change-Id: Ia2f6f3585c4b6213fe7f55203c69d0ef4a620a67 Reviewed-on: https://dawn-review.googlesource.com/c/2708 Reviewed-by: Stephen White <senorblanco@chromium.org> Reviewed-by: Kenneth Russell <kbr@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-11-30 12:17:29 +00:00
# Use Chromium's dcheck_always_on when available so that we respect it when
# running tests on the GPU builders
if (build_with_chromium) {
import("//build/config/dcheck_always_on.gni")
} else {
dcheck_always_on = false
}
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
###############################################################################
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
# Common dawn libraries and configs
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
###############################################################################
config("libdawn_public") {
include_dirs = [
target_gen_dir,
"src/include",
]
}
Add correct rpath for dawn samples on linux when using gn build Dawn Samples missing correct rpath settings on linux platform in BUILD.gn. This failed program to find .so like libdawn_native on linux.
2018-08-20 15:36:17 +00:00
# Executable needs an rpath to find our shared libraries on OSX and Linux
config("dawn_shared_library_public") {
if (is_mac) {
ldflags = [
"-rpath",
"@executable_path/",
]
}
if (is_linux) {
configs = [ "//build/config/gcc:rpath_for_built_shared_libraries" ]
}
}
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
config("dawn_internal") {
include_dirs = [ "src" ]
defines = []
Use Chromium's dcheck_always_on when available. This will make GPU tests running on Chromium-based builders respect this configuration, which is important to have the same code run in Release and Debug builds on the GPU FYI waterfall. BUG=chromium:901830 Change-Id: Ia2f6f3585c4b6213fe7f55203c69d0ef4a620a67 Reviewed-on: https://dawn-review.googlesource.com/c/2708 Reviewed-by: Stephen White <senorblanco@chromium.org> Reviewed-by: Kenneth Russell <kbr@google.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-11-30 12:17:29 +00:00
if (dawn_always_assert || dcheck_always_on || is_debug) {
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
defines += [ "DAWN_ENABLE_ASSERTS" ]
}
if (dawn_enable_d3d12) {
defines += [ "DAWN_ENABLE_BACKEND_D3D12" ]
}
if (dawn_enable_metal) {
defines += [ "DAWN_ENABLE_BACKEND_METAL" ]
}
if (dawn_enable_null) {
defines += [ "DAWN_ENABLE_BACKEND_NULL" ]
}
if (dawn_enable_opengl) {
defines += [ "DAWN_ENABLE_BACKEND_OPENGL" ]
}
if (dawn_enable_vulkan) {
defines += [ "DAWN_ENABLE_BACKEND_VULKAN" ]
}
Add correct rpath for dawn samples on linux when using gn build Dawn Samples missing correct rpath settings on linux platform in BUILD.gn. This failed program to find .so like libdawn_native on linux.
2018-08-20 15:36:17 +00:00
configs = [
":libdawn_public",
":dawn_shared_library_public",
]
Add samples to BUILD.gn and their deps to DEPS Also add missing GLFW DEPS entry
2018-08-13 06:23:27 +00:00
# Only internal Dawn targets can use this config, this means only targets in
# this BUILD.gn file.
visibility = [ ":*" ]
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
}
static_library("dawn_common") {
sources = [
"src/common/Assert.cpp",
"src/common/Assert.h",
"src/common/BitSetIterator.h",
"src/common/Compiler.h",
"src/common/DynamicLib.cpp",
"src/common/DynamicLib.h",
"src/common/HashUtils.h",
"src/common/Math.cpp",
"src/common/Math.h",
"src/common/Platform.h",
"src/common/Result.h",
"src/common/Serial.h",
Factor SerialQueue into SerialQueue and SerialMap This change moves most of SerialQueue into SerialStorage and factors it to make SerialMap and SerialQueue. SerialMap does not enforce that items are Enqueue'd in monotonically increasing order. This is useful for implement timeline fences because OnCompletion callbacks may be added in an arbitrary order. Bug: dawn:26 Change-Id: I03376117311112b0b94ed887a31974f36c4a5464 Reviewed-on: https://dawn-review.googlesource.com/c/2720 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-11-28 17:30:12 +00:00
"src/common/SerialMap.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/common/SerialQueue.h",
Factor SerialQueue into SerialQueue and SerialMap This change moves most of SerialQueue into SerialStorage and factors it to make SerialMap and SerialQueue. SerialMap does not enforce that items are Enqueue'd in monotonically increasing order. This is useful for implement timeline fences because OnCompletion callbacks may be added in an arbitrary order. Bug: dawn:26 Change-Id: I03376117311112b0b94ed887a31974f36c4a5464 Reviewed-on: https://dawn-review.googlesource.com/c/2720 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-11-28 17:30:12 +00:00
"src/common/SerialStorage.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/common/SwapChainUtils.h",
"src/common/vulkan_platform.h",
"src/common/windows_with_undefs.h",
]
configs += [ ":dawn_internal" ]
Make Dawn "gn check" by default (except SPIRV-Tools) This required adding some missing dependencies, splitting public headers of libdawn_[native|wire] so they aren't hidden in the libdawn_[native|wire]_sources targets, and making unittests depend on sources directly instead of static libraries (which is almost equivalent). As a byproduct, Empty.cpp is no longer needed and is removed.
2018-08-12 19:07:46 +00:00
deps = [
":dawn_headers",
]
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
}
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
###############################################################################
# Dawn headers and libdawn.so
###############################################################################
BUILD.gn: Remove use of exec_script Chromium's BUILD files try to avoid uses of exec_script when possible because they slow down every GN invocation. In preparation for building Dawn inside Chromium, the calls to exec_script for the code generator are removed. In GN, the generator now outputs a "JSON tarball", a dictionnary mapping filenames to content. This allows us to use the "depfile" feature of GN to avoid the exec_script call to gather the script's inputs. Outputs of the generator are now listed in the BUILD.gn files. To keep it in sync with the generator, GN outputs a file containing "expected outputs" that is checked by the code generator. Finally the dawn_generator GN template doesn't create a target anymore, but users are expected to gather outputs using get_target_outputs.
2018-08-16 13:32:35 +00:00
dawn_generator("dawn_headers_gen") {
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
target = "dawn_headers"
BUILD.gn: Remove use of exec_script Chromium's BUILD files try to avoid uses of exec_script when possible because they slow down every GN invocation. In preparation for building Dawn inside Chromium, the calls to exec_script for the code generator are removed. In GN, the generator now outputs a "JSON tarball", a dictionnary mapping filenames to content. This allows us to use the "depfile" feature of GN to avoid the exec_script call to gather the script's inputs. Outputs of the generator are now listed in the BUILD.gn files. To keep it in sync with the generator, GN outputs a file containing "expected outputs" that is checked by the code generator. Finally the dawn_generator GN template doesn't create a target anymore, but users are expected to gather outputs using get_target_outputs.
2018-08-16 13:32:35 +00:00
outputs = [
"dawn/dawncpp.h",
"dawn/dawn.h",
"dawn/dawncpp_traits.h",
]
}
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
BUILD.gn: Remove use of exec_script Chromium's BUILD files try to avoid uses of exec_script when possible because they slow down every GN invocation. In preparation for building Dawn inside Chromium, the calls to exec_script for the code generator are removed. In GN, the generator now outputs a "JSON tarball", a dictionnary mapping filenames to content. This allows us to use the "depfile" feature of GN to avoid the exec_script call to gather the script's inputs. Outputs of the generator are now listed in the BUILD.gn files. To keep it in sync with the generator, GN outputs a file containing "expected outputs" that is checked by the code generator. Finally the dawn_generator GN template doesn't create a target anymore, but users are expected to gather outputs using get_target_outputs.
2018-08-16 13:32:35 +00:00
source_set("dawn_headers") {
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
public_configs = [ ":libdawn_public" ]
BUILD.gn: Remove use of exec_script Chromium's BUILD files try to avoid uses of exec_script when possible because they slow down every GN invocation. In preparation for building Dawn inside Chromium, the calls to exec_script for the code generator are removed. In GN, the generator now outputs a "JSON tarball", a dictionnary mapping filenames to content. This allows us to use the "depfile" feature of GN to avoid the exec_script call to gather the script's inputs. Outputs of the generator are now listed in the BUILD.gn files. To keep it in sync with the generator, GN outputs a file containing "expected outputs" that is checked by the code generator. Finally the dawn_generator GN template doesn't create a target anymore, but users are expected to gather outputs using get_target_outputs.
2018-08-16 13:32:35 +00:00
deps = [
":dawn_headers_gen",
]
sources = get_target_outputs(":dawn_headers_gen")
sources += [
Make Dawn "gn check" by default (except SPIRV-Tools) This required adding some missing dependencies, splitting public headers of libdawn_[native|wire] so they aren't hidden in the libdawn_[native|wire]_sources targets, and making unittests depend on sources directly instead of static libraries (which is almost equivalent). As a byproduct, Empty.cpp is no longer needed and is removed.
2018-08-12 19:07:46 +00:00
"src/include/dawn/EnumClassBitmasks.h",
"src/include/dawn/dawn_export.h",
"src/include/dawn/dawn_wsi.h",
]
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
}
BUILD.gn: Remove use of exec_script Chromium's BUILD files try to avoid uses of exec_script when possible because they slow down every GN invocation. In preparation for building Dawn inside Chromium, the calls to exec_script for the code generator are removed. In GN, the generator now outputs a "JSON tarball", a dictionnary mapping filenames to content. This allows us to use the "depfile" feature of GN to avoid the exec_script call to gather the script's inputs. Outputs of the generator are now listed in the BUILD.gn files. To keep it in sync with the generator, GN outputs a file containing "expected outputs" that is checked by the code generator. Finally the dawn_generator GN template doesn't create a target anymore, but users are expected to gather outputs using get_target_outputs.
2018-08-16 13:32:35 +00:00
dawn_generator("libdawn_gen") {
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
target = "libdawn"
BUILD.gn: Remove use of exec_script Chromium's BUILD files try to avoid uses of exec_script when possible because they slow down every GN invocation. In preparation for building Dawn inside Chromium, the calls to exec_script for the code generator are removed. In GN, the generator now outputs a "JSON tarball", a dictionnary mapping filenames to content. This allows us to use the "depfile" feature of GN to avoid the exec_script call to gather the script's inputs. Outputs of the generator are now listed in the BUILD.gn files. To keep it in sync with the generator, GN outputs a file containing "expected outputs" that is checked by the code generator. Finally the dawn_generator GN template doesn't create a target anymore, but users are expected to gather outputs using get_target_outputs.
2018-08-16 13:32:35 +00:00
outputs = [
"dawn/dawncpp.cpp",
"dawn/dawn.c",
]
}
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
Don't use shared libraries in the wire fuzzer. Otherwise UBSan complains that C++ types are different between the shared libraries because libc++ is linked statically. BUG=chromium:904736 Change-Id: I51ef40d1f7910fd693a4585c74ff404812472d2e Reviewed-on: https://dawn-review.googlesource.com/c/2380 Reviewed-by: Dan Sinclair <dsinclair@google.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-11-14 21:04:26 +00:00
config("libdawn_export") {
defines = [ "DAWN_IMPLEMENTATION" ]
}
source_set("libdawn_sources") {
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
public_deps = [
":dawn_headers",
]
BUILD.gn: Remove use of exec_script Chromium's BUILD files try to avoid uses of exec_script when possible because they slow down every GN invocation. In preparation for building Dawn inside Chromium, the calls to exec_script for the code generator are removed. In GN, the generator now outputs a "JSON tarball", a dictionnary mapping filenames to content. This allows us to use the "depfile" feature of GN to avoid the exec_script call to gather the script's inputs. Outputs of the generator are now listed in the BUILD.gn files. To keep it in sync with the generator, GN outputs a file containing "expected outputs" that is checked by the code generator. Finally the dawn_generator GN template doesn't create a target anymore, but users are expected to gather outputs using get_target_outputs.
2018-08-16 13:32:35 +00:00
deps = [
":libdawn_gen",
]
sources = get_target_outputs(":libdawn_gen")
Don't use shared libraries in the wire fuzzer. Otherwise UBSan complains that C++ types are different between the shared libraries because libc++ is linked statically. BUG=chromium:904736 Change-Id: I51ef40d1f7910fd693a4585c74ff404812472d2e Reviewed-on: https://dawn-review.googlesource.com/c/2380 Reviewed-by: Dan Sinclair <dsinclair@google.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-11-14 21:04:26 +00:00
# Put the export config public so that dependents use the same declspec.
public_configs = [ ":libdawn_export" ]
}
shared_library("libdawn") {
public_deps = [
":dawn_headers",
]
deps = [
":libdawn_sources",
]
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
# Tell dependents where to find this shared library
if (is_mac) {
ldflags = [
"-install_name",
"@rpath/${target_name}.dylib",
]
}
}
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
###############################################################################
# libdawn_native.so
###############################################################################
config("libdawn_native_internal") {
configs = [ ":dawn_internal" ]
# Suppress warnings that Metal isn't in the deployment target of Chrome
if (is_mac) {
cflags_objcc = [ "-Wno-unguarded-availability" ]
}
}
Don't use shared libraries in the wire fuzzer. Otherwise UBSan complains that C++ types are different between the shared libraries because libc++ is linked statically. BUG=chromium:904736 Change-Id: I51ef40d1f7910fd693a4585c74ff404812472d2e Reviewed-on: https://dawn-review.googlesource.com/c/2380 Reviewed-by: Dan Sinclair <dsinclair@google.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-11-14 21:04:26 +00:00
config("libdawn_native_export") {
defines = [ "DAWN_NATIVE_IMPLEMENTATION" ]
}
BUILD.gn: Remove use of exec_script Chromium's BUILD files try to avoid uses of exec_script when possible because they slow down every GN invocation. In preparation for building Dawn inside Chromium, the calls to exec_script for the code generator are removed. In GN, the generator now outputs a "JSON tarball", a dictionnary mapping filenames to content. This allows us to use the "depfile" feature of GN to avoid the exec_script call to gather the script's inputs. Outputs of the generator are now listed in the BUILD.gn files. To keep it in sync with the generator, GN outputs a file containing "expected outputs" that is checked by the code generator. Finally the dawn_generator GN template doesn't create a target anymore, but users are expected to gather outputs using get_target_outputs.
2018-08-16 13:32:35 +00:00
dawn_generator("libdawn_native_utils_gen") {
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
target = "dawn_native_utils"
BUILD.gn: Remove use of exec_script Chromium's BUILD files try to avoid uses of exec_script when possible because they slow down every GN invocation. In preparation for building Dawn inside Chromium, the calls to exec_script for the code generator are removed. In GN, the generator now outputs a "JSON tarball", a dictionnary mapping filenames to content. This allows us to use the "depfile" feature of GN to avoid the exec_script call to gather the script's inputs. Outputs of the generator are now listed in the BUILD.gn files. To keep it in sync with the generator, GN outputs a file containing "expected outputs" that is checked by the code generator. Finally the dawn_generator GN template doesn't create a target anymore, but users are expected to gather outputs using get_target_outputs.
2018-08-16 13:32:35 +00:00
outputs = [
"dawn_native/ProcTable.cpp",
"dawn_native/dawn_structs_autogen.h",
"dawn_native/dawn_structs_autogen.cpp",
"dawn_native/ValidationUtils_autogen.h",
"dawn_native/ValidationUtils_autogen.cpp",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
]
}
Make Dawn "gn check" by default (except SPIRV-Tools) This required adding some missing dependencies, splitting public headers of libdawn_[native|wire] so they aren't hidden in the libdawn_[native|wire]_sources targets, and making unittests depend on sources directly instead of static libraries (which is almost equivalent). As a byproduct, Empty.cpp is no longer needed and is removed.
2018-08-12 19:07:46 +00:00
# Public libdawn_native headers so they can be publically visible for
# dependencies of libdawn_native
source_set("libdawn_native_headers") {
public_deps = [
":dawn_headers",
]
sources = [
"src/include/dawn_native/DawnNative.h",
"src/include/dawn_native/dawn_native_export.h",
# Include all backend's public headers so that dependencies can include
# them even when the backends are disabled.
"src/include/dawn_native/D3D12Backend.h",
"src/include/dawn_native/MetalBackend.h",
"src/include/dawn_native/NullBackend.h",
"src/include/dawn_native/OpenGLBackend.h",
"src/include/dawn_native/VulkanBackend.h",
]
}
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
# The meat of the compilation for libdawn_native so that we can cheaply have
# shared_library / static_library / component versions of it.
source_set("libdawn_native_sources") {
deps = [
":dawn_common",
BUILD.gn: Remove use of exec_script Chromium's BUILD files try to avoid uses of exec_script when possible because they slow down every GN invocation. In preparation for building Dawn inside Chromium, the calls to exec_script for the code generator are removed. In GN, the generator now outputs a "JSON tarball", a dictionnary mapping filenames to content. This allows us to use the "depfile" feature of GN to avoid the exec_script call to gather the script's inputs. Outputs of the generator are now listed in the BUILD.gn files. To keep it in sync with the generator, GN outputs a file containing "expected outputs" that is checked by the code generator. Finally the dawn_generator GN template doesn't create a target anymore, but users are expected to gather outputs using get_target_outputs.
2018-08-16 13:32:35 +00:00
":libdawn_native_utils_gen",
Validate SPIR-V code when creating ShaderModules This integrates spirv-val in dawn_native so that regular and WebGPU-specific validation of shaders is done. Also adds tests to check OpUndef is correctly rejected so we know WebGPU-specific validation is working. Change-Id: If49d276c98bca8cd3c6c1a420903fe34923a2942
2018-09-06 15:25:46 +00:00
"${dawn_spirv_tools_dir}:spvtools_val",
BUILD.gn: Move last third_party deps to third_party/BUILD.gn
2018-08-13 06:31:17 +00:00
"third_party:spirv_cross",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
]
BUILD.gn: Fix libdawn_native missing dep on its own headers BUG=chromium:904736 BUG=chromium:905442 TBR=kainino@chromium.org Change-Id: Ie08b9c82f189e12ba42411e492190731daad5aca Reviewed-on: https://dawn-review.googlesource.com/c/2441 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-11-15 12:38:12 +00:00
public_deps = [
":libdawn_native_headers",
]
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
Don't use shared libraries in the wire fuzzer. Otherwise UBSan complains that C++ types are different between the shared libraries because libc++ is linked statically. BUG=chromium:904736 Change-Id: I51ef40d1f7910fd693a4585c74ff404812472d2e Reviewed-on: https://dawn-review.googlesource.com/c/2380 Reviewed-by: Dan Sinclair <dsinclair@google.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-11-14 21:04:26 +00:00
# Put the export config public so that dependents use the same declspec.
public_configs = [ ":libdawn_native_export" ]
Make Dawn "gn check" by default (except SPIRV-Tools) This required adding some missing dependencies, splitting public headers of libdawn_[native|wire] so they aren't hidden in the libdawn_[native|wire]_sources targets, and making unittests depend on sources directly instead of static libraries (which is almost equivalent). As a byproduct, Empty.cpp is no longer needed and is removed.
2018-08-12 19:07:46 +00:00
Don't use shared libraries in the wire fuzzer. Otherwise UBSan complains that C++ types are different between the shared libraries because libc++ is linked statically. BUG=chromium:904736 Change-Id: I51ef40d1f7910fd693a4585c74ff404812472d2e Reviewed-on: https://dawn-review.googlesource.com/c/2380 Reviewed-by: Dan Sinclair <dsinclair@google.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-11-14 21:04:26 +00:00
configs += [ ":libdawn_native_internal" ]
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
libs = []
BUILD.gn: Remove use of exec_script Chromium's BUILD files try to avoid uses of exec_script when possible because they slow down every GN invocation. In preparation for building Dawn inside Chromium, the calls to exec_script for the code generator are removed. In GN, the generator now outputs a "JSON tarball", a dictionnary mapping filenames to content. This allows us to use the "depfile" feature of GN to avoid the exec_script call to gather the script's inputs. Outputs of the generator are now listed in the BUILD.gn files. To keep it in sync with the generator, GN outputs a file containing "expected outputs" that is checked by the code generator. Finally the dawn_generator GN template doesn't create a target anymore, but users are expected to gather outputs using get_target_outputs.
2018-08-16 13:32:35 +00:00
sources = get_target_outputs(":libdawn_native_utils_gen")
sources += [
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/BindGroup.cpp",
"src/dawn_native/BindGroup.h",
"src/dawn_native/BindGroupLayout.cpp",
"src/dawn_native/BindGroupLayout.h",
"src/dawn_native/BlendState.cpp",
"src/dawn_native/BlendState.h",
"src/dawn_native/Buffer.cpp",
"src/dawn_native/Buffer.h",
"src/dawn_native/Builder.cpp",
"src/dawn_native/Builder.h",
"src/dawn_native/CommandAllocator.cpp",
"src/dawn_native/CommandAllocator.h",
"src/dawn_native/CommandBuffer.cpp",
"src/dawn_native/CommandBuffer.h",
"src/dawn_native/CommandBufferStateTracker.cpp",
"src/dawn_native/CommandBufferStateTracker.h",
"src/dawn_native/Commands.cpp",
"src/dawn_native/Commands.h",
Introduce [Render|Compute]PassEncoder. This splits off part of CommandBufferBuilder in separate RenderPassEncoder and ComputePassEncoder objects. To match the WebGPU IDL and factor some code, both these encoders inherit from ProgrammablePassEncoder. These encoders are pure frontend objects and record into the CommandBufferBuilder command allocator objects, so no changes to the backends were needed. Error handling is still ew, because the "builder" mechanism we had doesn't allow for "split builders". Nicer error handling will have to wait on Dawn matching WebGPU. All the tests and samples were updated to the new structure. BUG=dawn:5 Change-Id: I5f5d4ad866e2c07fedd1ba7a122258c6610941f1 Reviewed-on: https://dawn-review.googlesource.com/1543 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2018-09-21 00:24:37 +00:00
"src/dawn_native/ComputePassEncoder.cpp",
"src/dawn_native/ComputePassEncoder.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/ComputePipeline.cpp",
"src/dawn_native/ComputePipeline.h",
"src/dawn_native/DawnNative.cpp",
"src/dawn_native/DepthStencilState.cpp",
"src/dawn_native/DepthStencilState.h",
"src/dawn_native/Device.cpp",
"src/dawn_native/Device.h",
"src/dawn_native/Error.cpp",
"src/dawn_native/Error.h",
"src/dawn_native/ErrorData.cpp",
"src/dawn_native/ErrorData.h",
Implement timeline fences in Dawn This change implements timeline fences in Dawn. It includes methods and descriptor members to eventually support multi-queue, but does not implement them. Bug: dawn:26 Change-Id: I81d5fee6acef402fe099227a034d9669a89ab6c3 Reviewed-on: https://dawn-review.googlesource.com/c/2460 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2018-12-03 16:57:34 +00:00
"src/dawn_native/Fence.cpp",
"src/dawn_native/Fence.h",
"src/dawn_native/FenceSignalTracker.cpp",
"src/dawn_native/FenceSignalTracker.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/Forward.h",
"src/dawn_native/InputState.cpp",
"src/dawn_native/InputState.h",
Put the reference to DeviceBase in a new ObjectBase ObjectBase will contain data that all WebGPU objects have such as a pointer back to the device, a refcount (via inheriting from RefCounted), a name, an error status etc. BUG=dawn:24 Change-Id: I919e1a6d4a68811ceb6e503b2a793815c92f2528 Reviewed-on: https://dawn-review.googlesource.com/c/1620 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2018-10-15 12:54:30 +00:00
"src/dawn_native/ObjectBase.cpp",
"src/dawn_native/ObjectBase.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/PassResourceUsage.h",
"src/dawn_native/PerStage.cpp",
"src/dawn_native/PerStage.h",
"src/dawn_native/Pipeline.cpp",
"src/dawn_native/Pipeline.h",
"src/dawn_native/PipelineLayout.cpp",
"src/dawn_native/PipelineLayout.h",
Introduce [Render|Compute]PassEncoder. This splits off part of CommandBufferBuilder in separate RenderPassEncoder and ComputePassEncoder objects. To match the WebGPU IDL and factor some code, both these encoders inherit from ProgrammablePassEncoder. These encoders are pure frontend objects and record into the CommandBufferBuilder command allocator objects, so no changes to the backends were needed. Error handling is still ew, because the "builder" mechanism we had doesn't allow for "split builders". Nicer error handling will have to wait on Dawn matching WebGPU. All the tests and samples were updated to the new structure. BUG=dawn:5 Change-Id: I5f5d4ad866e2c07fedd1ba7a122258c6610941f1 Reviewed-on: https://dawn-review.googlesource.com/1543 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2018-09-21 00:24:37 +00:00
"src/dawn_native/ProgrammablePassEncoder.cpp",
"src/dawn_native/ProgrammablePassEncoder.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/Queue.cpp",
"src/dawn_native/Queue.h",
"src/dawn_native/RefCounted.cpp",
"src/dawn_native/RefCounted.h",
"src/dawn_native/RenderPassDescriptor.cpp",
"src/dawn_native/RenderPassDescriptor.h",
Introduce [Render|Compute]PassEncoder. This splits off part of CommandBufferBuilder in separate RenderPassEncoder and ComputePassEncoder objects. To match the WebGPU IDL and factor some code, both these encoders inherit from ProgrammablePassEncoder. These encoders are pure frontend objects and record into the CommandBufferBuilder command allocator objects, so no changes to the backends were needed. Error handling is still ew, because the "builder" mechanism we had doesn't allow for "split builders". Nicer error handling will have to wait on Dawn matching WebGPU. All the tests and samples were updated to the new structure. BUG=dawn:5 Change-Id: I5f5d4ad866e2c07fedd1ba7a122258c6610941f1 Reviewed-on: https://dawn-review.googlesource.com/1543 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2018-09-21 00:24:37 +00:00
"src/dawn_native/RenderPassEncoder.cpp",
"src/dawn_native/RenderPassEncoder.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/RenderPipeline.cpp",
"src/dawn_native/RenderPipeline.h",
"src/dawn_native/Sampler.cpp",
"src/dawn_native/Sampler.h",
"src/dawn_native/ShaderModule.cpp",
"src/dawn_native/ShaderModule.h",
"src/dawn_native/SwapChain.cpp",
"src/dawn_native/SwapChain.h",
"src/dawn_native/Texture.cpp",
"src/dawn_native/Texture.h",
"src/dawn_native/ToBackend.h",
"src/dawn_native/dawn_platform.h",
]
if (dawn_enable_d3d12) {
D3D12: Dynamically load D3D12, DXGI and D3DCompiler Linking against their .lib makes loading Dawn fail on systems that don't have the DLLs. This happens for example on Windows7 that doesn't have d3d12.dll. Instead we dynamically load functions pointers from these DLLs at d3d12::Device startup. Change-Id: I4d01a12d0f91bec45bf125450d2c08aaa9ff9fac
2018-08-30 12:20:28 +00:00
libs += [ "dxguid.lib" ]
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
sources += [
"src/dawn_native/d3d12/BindGroupD3D12.cpp",
"src/dawn_native/d3d12/BindGroupD3D12.h",
"src/dawn_native/d3d12/BindGroupLayoutD3D12.cpp",
"src/dawn_native/d3d12/BindGroupLayoutD3D12.h",
"src/dawn_native/d3d12/BlendStateD3D12.cpp",
"src/dawn_native/d3d12/BlendStateD3D12.h",
"src/dawn_native/d3d12/BufferD3D12.cpp",
"src/dawn_native/d3d12/BufferD3D12.h",
"src/dawn_native/d3d12/CommandAllocatorManager.cpp",
"src/dawn_native/d3d12/CommandAllocatorManager.h",
"src/dawn_native/d3d12/CommandBufferD3D12.cpp",
"src/dawn_native/d3d12/CommandBufferD3D12.h",
"src/dawn_native/d3d12/ComputePipelineD3D12.cpp",
"src/dawn_native/d3d12/ComputePipelineD3D12.h",
"src/dawn_native/d3d12/DepthStencilStateD3D12.cpp",
"src/dawn_native/d3d12/DepthStencilStateD3D12.h",
"src/dawn_native/d3d12/DescriptorHeapAllocator.cpp",
"src/dawn_native/d3d12/DescriptorHeapAllocator.h",
"src/dawn_native/d3d12/DeviceD3D12.cpp",
"src/dawn_native/d3d12/DeviceD3D12.h",
"src/dawn_native/d3d12/Forward.h",
"src/dawn_native/d3d12/InputStateD3D12.cpp",
"src/dawn_native/d3d12/InputStateD3D12.h",
"src/dawn_native/d3d12/NativeSwapChainImplD3D12.cpp",
"src/dawn_native/d3d12/NativeSwapChainImplD3D12.h",
"src/dawn_native/d3d12/PipelineLayoutD3D12.cpp",
"src/dawn_native/d3d12/PipelineLayoutD3D12.h",
D3D12: Dynamically load D3D12, DXGI and D3DCompiler Linking against their .lib makes loading Dawn fail on systems that don't have the DLLs. This happens for example on Windows7 that doesn't have d3d12.dll. Instead we dynamically load functions pointers from these DLLs at d3d12::Device startup. Change-Id: I4d01a12d0f91bec45bf125450d2c08aaa9ff9fac
2018-08-30 12:20:28 +00:00
"src/dawn_native/d3d12/PlatformFunctions.cpp",
"src/dawn_native/d3d12/PlatformFunctions.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
"src/dawn_native/d3d12/QueueD3D12.cpp",
"src/dawn_native/d3d12/QueueD3D12.h",
"src/dawn_native/d3d12/RenderPassDescriptorD3D12.cpp",
"src/dawn_native/d3d12/RenderPassDescriptorD3D12.h",
"src/dawn_native/d3d12/RenderPipelineD3D12.cpp",
"src/dawn_native/d3d12/RenderPipelineD3D12.h",
"src/dawn_native/d3d12/ResourceAllocator.cpp",
"src/dawn_native/d3d12/ResourceAllocator.h",
"src/dawn_native/d3d12/ResourceUploader.cpp",
"src/dawn_native/d3d12/ResourceUploader.h",
"src/dawn_native/d3d12/SamplerD3D12.cpp",
"src/dawn_native/d3d12/SamplerD3D12.h",
"src/dawn_native/d3d12/ShaderModuleD3D12.cpp",
"src/dawn_native/d3d12/ShaderModuleD3D12.h",
"src/dawn_native/d3d12/SwapChainD3D12.cpp",
"src/dawn_native/d3d12/SwapChainD3D12.h",
"src/dawn_native/d3d12/TextureCopySplitter.cpp",
"src/dawn_native/d3d12/TextureCopySplitter.h",
"src/dawn_native/d3d12/TextureD3D12.cpp",
"src/dawn_native/d3d12/TextureD3D12.h",
"src/dawn_native/d3d12/d3d12_platform.h",
]
}
if (dawn_enable_metal) {
libs += [
"Metal.framework",
"Cocoa.framework",
Collect device information on Metal Becuase CGDisplayIOServicePort is deprecated in OSX >= 10.9, we create an alternative function which manually finding a service port with matching vendor and product IDs. BUG=dawn:10 TEST=dawn_end2end_tests Change-Id: I94ff65911e159c2b7075209d8902c1551560ed47 Reviewed-on: https://dawn-review.googlesource.com/c/2541 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2018-11-29 10:54:03 +00:00
"IOKit.framework",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
]
sources += [
"src/dawn_native/metal/BlendStateMTL.h",
"src/dawn_native/metal/BlendStateMTL.mm",
"src/dawn_native/metal/BufferMTL.h",
"src/dawn_native/metal/BufferMTL.mm",
"src/dawn_native/metal/CommandBufferMTL.h",
"src/dawn_native/metal/CommandBufferMTL.mm",
"src/dawn_native/metal/ComputePipelineMTL.h",
"src/dawn_native/metal/ComputePipelineMTL.mm",
"src/dawn_native/metal/DepthStencilStateMTL.h",
"src/dawn_native/metal/DepthStencilStateMTL.mm",
"src/dawn_native/metal/DeviceMTL.h",
"src/dawn_native/metal/DeviceMTL.mm",
"src/dawn_native/metal/Forward.h",
"src/dawn_native/metal/InputStateMTL.h",
"src/dawn_native/metal/InputStateMTL.mm",
"src/dawn_native/metal/PipelineLayoutMTL.h",
"src/dawn_native/metal/PipelineLayoutMTL.mm",
"src/dawn_native/metal/QueueMTL.h",
"src/dawn_native/metal/QueueMTL.mm",
"src/dawn_native/metal/RenderPipelineMTL.h",
"src/dawn_native/metal/RenderPipelineMTL.mm",
"src/dawn_native/metal/ResourceUploader.h",
"src/dawn_native/metal/ResourceUploader.mm",
"src/dawn_native/metal/SamplerMTL.h",
"src/dawn_native/metal/SamplerMTL.mm",
"src/dawn_native/metal/ShaderModuleMTL.h",
"src/dawn_native/metal/ShaderModuleMTL.mm",
"src/dawn_native/metal/SwapChainMTL.h",
"src/dawn_native/metal/SwapChainMTL.mm",
"src/dawn_native/metal/TextureMTL.h",
"src/dawn_native/metal/TextureMTL.mm",
]
}
if (dawn_enable_null) {
sources += [
"src/dawn_native/null/NullBackend.cpp",
"src/dawn_native/null/NullBackend.h",
]
}
if (dawn_enable_opengl) {
BUILD.gn: Move last third_party deps to third_party/BUILD.gn
2018-08-13 06:31:17 +00:00
deps += [ "third_party:glad" ]
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
sources += [
"src/dawn_native/opengl/BlendStateGL.cpp",
"src/dawn_native/opengl/BlendStateGL.h",
"src/dawn_native/opengl/BufferGL.cpp",
"src/dawn_native/opengl/BufferGL.h",
"src/dawn_native/opengl/CommandBufferGL.cpp",
"src/dawn_native/opengl/CommandBufferGL.h",
"src/dawn_native/opengl/ComputePipelineGL.cpp",
"src/dawn_native/opengl/ComputePipelineGL.h",
"src/dawn_native/opengl/DepthStencilStateGL.cpp",
"src/dawn_native/opengl/DepthStencilStateGL.h",
"src/dawn_native/opengl/DeviceGL.cpp",
"src/dawn_native/opengl/DeviceGL.h",
"src/dawn_native/opengl/Forward.h",
"src/dawn_native/opengl/InputStateGL.cpp",
"src/dawn_native/opengl/InputStateGL.h",
"src/dawn_native/opengl/PersistentPipelineStateGL.cpp",
"src/dawn_native/opengl/PersistentPipelineStateGL.h",
"src/dawn_native/opengl/PipelineGL.cpp",
"src/dawn_native/opengl/PipelineGL.h",
"src/dawn_native/opengl/PipelineLayoutGL.cpp",
"src/dawn_native/opengl/PipelineLayoutGL.h",
"src/dawn_native/opengl/QueueGL.cpp",
"src/dawn_native/opengl/QueueGL.h",
"src/dawn_native/opengl/RenderPipelineGL.cpp",
"src/dawn_native/opengl/RenderPipelineGL.h",
"src/dawn_native/opengl/SamplerGL.cpp",
"src/dawn_native/opengl/SamplerGL.h",
"src/dawn_native/opengl/ShaderModuleGL.cpp",
"src/dawn_native/opengl/ShaderModuleGL.h",
"src/dawn_native/opengl/SwapChainGL.cpp",
"src/dawn_native/opengl/SwapChainGL.h",
"src/dawn_native/opengl/TextureGL.cpp",
"src/dawn_native/opengl/TextureGL.h",
]
}
if (dawn_enable_vulkan) {
BUILD.gn: Move last third_party deps to third_party/BUILD.gn
2018-08-13 06:31:17 +00:00
deps += [ "third_party:vulkan_headers" ]
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
sources += [
"src/dawn_native/vulkan/BindGroupLayoutVk.cpp",
"src/dawn_native/vulkan/BindGroupLayoutVk.h",
"src/dawn_native/vulkan/BindGroupVk.cpp",
"src/dawn_native/vulkan/BindGroupVk.h",
"src/dawn_native/vulkan/BlendStateVk.cpp",
"src/dawn_native/vulkan/BlendStateVk.h",
"src/dawn_native/vulkan/BufferUploader.cpp",
"src/dawn_native/vulkan/BufferUploader.h",
"src/dawn_native/vulkan/BufferVk.cpp",
"src/dawn_native/vulkan/BufferVk.h",
"src/dawn_native/vulkan/CommandBufferVk.cpp",
"src/dawn_native/vulkan/CommandBufferVk.h",
"src/dawn_native/vulkan/ComputePipelineVk.cpp",
"src/dawn_native/vulkan/ComputePipelineVk.h",
"src/dawn_native/vulkan/DepthStencilStateVk.cpp",
"src/dawn_native/vulkan/DepthStencilStateVk.h",
"src/dawn_native/vulkan/DeviceVk.cpp",
"src/dawn_native/vulkan/DeviceVk.h",
"src/dawn_native/vulkan/FencedDeleter.cpp",
"src/dawn_native/vulkan/FencedDeleter.h",
"src/dawn_native/vulkan/Forward.h",
"src/dawn_native/vulkan/InputStateVk.cpp",
"src/dawn_native/vulkan/InputStateVk.h",
"src/dawn_native/vulkan/MemoryAllocator.cpp",
"src/dawn_native/vulkan/MemoryAllocator.h",
"src/dawn_native/vulkan/NativeSwapChainImplVk.cpp",
"src/dawn_native/vulkan/NativeSwapChainImplVk.h",
"src/dawn_native/vulkan/PipelineLayoutVk.cpp",
"src/dawn_native/vulkan/PipelineLayoutVk.h",
"src/dawn_native/vulkan/QueueVk.cpp",
"src/dawn_native/vulkan/QueueVk.h",
"src/dawn_native/vulkan/RenderPassCache.cpp",
"src/dawn_native/vulkan/RenderPassCache.h",
"src/dawn_native/vulkan/RenderPassDescriptorVk.cpp",
"src/dawn_native/vulkan/RenderPassDescriptorVk.h",
"src/dawn_native/vulkan/RenderPipelineVk.cpp",
"src/dawn_native/vulkan/RenderPipelineVk.h",
"src/dawn_native/vulkan/SamplerVk.cpp",
"src/dawn_native/vulkan/SamplerVk.h",
"src/dawn_native/vulkan/ShaderModuleVk.cpp",
"src/dawn_native/vulkan/ShaderModuleVk.h",
"src/dawn_native/vulkan/SwapChainVk.cpp",
"src/dawn_native/vulkan/SwapChainVk.h",
"src/dawn_native/vulkan/TextureVk.cpp",
"src/dawn_native/vulkan/TextureVk.h",
"src/dawn_native/vulkan/VulkanFunctions.cpp",
"src/dawn_native/vulkan/VulkanFunctions.h",
"src/dawn_native/vulkan/VulkanInfo.cpp",
"src/dawn_native/vulkan/VulkanInfo.h",
]
}
}
# The shared library for libdawn_native for use by samples, tests, etc.
shared_library("libdawn_native") {
deps = [
":libdawn_native_sources",
]
Make Dawn "gn check" by default (except SPIRV-Tools) This required adding some missing dependencies, splitting public headers of libdawn_[native|wire] so they aren't hidden in the libdawn_[native|wire]_sources targets, and making unittests depend on sources directly instead of static libraries (which is almost equivalent). As a byproduct, Empty.cpp is no longer needed and is removed.
2018-08-12 19:07:46 +00:00
#Make headers publically visible
public_deps = [
":libdawn_native_headers",
]
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
public_configs = [ ":libdawn_public" ]
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
# Tell dependents where to find this shared library
if (is_mac) {
ldflags = [
"-install_name",
"@rpath/${target_name}.dylib",
]
}
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
}
Make Dawn "gn check" by default (except SPIRV-Tools) This required adding some missing dependencies, splitting public headers of libdawn_[native|wire] so they aren't hidden in the libdawn_[native|wire]_sources targets, and making unittests depend on sources directly instead of static libraries (which is almost equivalent). As a byproduct, Empty.cpp is no longer needed and is removed.
2018-08-12 19:07:46 +00:00
###############################################################################
# libdawn_wire.so
###############################################################################
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
Make Dawn "gn check" by default (except SPIRV-Tools) This required adding some missing dependencies, splitting public headers of libdawn_[native|wire] so they aren't hidden in the libdawn_[native|wire]_sources targets, and making unittests depend on sources directly instead of static libraries (which is almost equivalent). As a byproduct, Empty.cpp is no longer needed and is removed.
2018-08-12 19:07:46 +00:00
# Public libdawn_wire headers so they can be publically visible for
# dependencies of libdawn_wire
source_set("libdawn_wire_headers") {
public_deps = [
":dawn_headers",
]
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
sources = [
Make Dawn "gn check" by default (except SPIRV-Tools) This required adding some missing dependencies, splitting public headers of libdawn_[native|wire] so they aren't hidden in the libdawn_[native|wire]_sources targets, and making unittests depend on sources directly instead of static libraries (which is almost equivalent). As a byproduct, Empty.cpp is no longer needed and is removed.
2018-08-12 19:07:46 +00:00
"src/include/dawn_wire/Wire.h",
"src/include/dawn_wire/dawn_wire_export.h",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
]
}
Don't use shared libraries in the wire fuzzer. Otherwise UBSan complains that C++ types are different between the shared libraries because libc++ is linked statically. BUG=chromium:904736 Change-Id: I51ef40d1f7910fd693a4585c74ff404812472d2e Reviewed-on: https://dawn-review.googlesource.com/c/2380 Reviewed-by: Dan Sinclair <dsinclair@google.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-11-14 21:04:26 +00:00
config("libdawn_wire_export") {
defines = [ "DAWN_WIRE_IMPLEMENTATION" ]
}
BUILD.gn: Remove use of exec_script Chromium's BUILD files try to avoid uses of exec_script when possible because they slow down every GN invocation. In preparation for building Dawn inside Chromium, the calls to exec_script for the code generator are removed. In GN, the generator now outputs a "JSON tarball", a dictionnary mapping filenames to content. This allows us to use the "depfile" feature of GN to avoid the exec_script call to gather the script's inputs. Outputs of the generator are now listed in the BUILD.gn files. To keep it in sync with the generator, GN outputs a file containing "expected outputs" that is checked by the code generator. Finally the dawn_generator GN template doesn't create a target anymore, but users are expected to gather outputs using get_target_outputs.
2018-08-16 13:32:35 +00:00
dawn_generator("libdawn_wire_gen") {
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
target = "dawn_wire"
BUILD.gn: Remove use of exec_script Chromium's BUILD files try to avoid uses of exec_script when possible because they slow down every GN invocation. In preparation for building Dawn inside Chromium, the calls to exec_script for the code generator are removed. In GN, the generator now outputs a "JSON tarball", a dictionnary mapping filenames to content. This allows us to use the "depfile" feature of GN to avoid the exec_script call to gather the script's inputs. Outputs of the generator are now listed in the BUILD.gn files. To keep it in sync with the generator, GN outputs a file containing "expected outputs" that is checked by the code generator. Finally the dawn_generator GN template doesn't create a target anymore, but users are expected to gather outputs using get_target_outputs.
2018-08-16 13:32:35 +00:00
outputs = [
"dawn_wire/WireServer.cpp",
"dawn_wire/WireCmd_autogen.h",
"dawn_wire/WireClient.cpp",
"dawn_wire/WireCmd_autogen.cpp",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
]
}
Don't use shared libraries in the wire fuzzer. Otherwise UBSan complains that C++ types are different between the shared libraries because libc++ is linked statically. BUG=chromium:904736 Change-Id: I51ef40d1f7910fd693a4585c74ff404812472d2e Reviewed-on: https://dawn-review.googlesource.com/c/2380 Reviewed-by: Dan Sinclair <dsinclair@google.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-11-14 21:04:26 +00:00
source_set("libdawn_wire_sources") {
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
deps = [
BUILD.gn: Remove use of exec_script Chromium's BUILD files try to avoid uses of exec_script when possible because they slow down every GN invocation. In preparation for building Dawn inside Chromium, the calls to exec_script for the code generator are removed. In GN, the generator now outputs a "JSON tarball", a dictionnary mapping filenames to content. This allows us to use the "depfile" feature of GN to avoid the exec_script call to gather the script's inputs. Outputs of the generator are now listed in the BUILD.gn files. To keep it in sync with the generator, GN outputs a file containing "expected outputs" that is checked by the code generator. Finally the dawn_generator GN template doesn't create a target anymore, but users are expected to gather outputs using get_target_outputs.
2018-08-16 13:32:35 +00:00
":dawn_common",
":libdawn_wire_gen",
":libdawn_wire_headers",
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
]
Make Dawn "gn check" by default (except SPIRV-Tools) This required adding some missing dependencies, splitting public headers of libdawn_[native|wire] so they aren't hidden in the libdawn_[native|wire]_sources targets, and making unittests depend on sources directly instead of static libraries (which is almost equivalent). As a byproduct, Empty.cpp is no longer needed and is removed.
2018-08-12 19:07:46 +00:00
BUILD.gn: Remove use of exec_script Chromium's BUILD files try to avoid uses of exec_script when possible because they slow down every GN invocation. In preparation for building Dawn inside Chromium, the calls to exec_script for the code generator are removed. In GN, the generator now outputs a "JSON tarball", a dictionnary mapping filenames to content. This allows us to use the "depfile" feature of GN to avoid the exec_script call to gather the script's inputs. Outputs of the generator are now listed in the BUILD.gn files. To keep it in sync with the generator, GN outputs a file containing "expected outputs" that is checked by the code generator. Finally the dawn_generator GN template doesn't create a target anymore, but users are expected to gather outputs using get_target_outputs.
2018-08-16 13:32:35 +00:00
configs += [ ":dawn_internal" ]
sources = get_target_outputs(":libdawn_wire_gen")
sources += [ "src/dawn_wire/WireCmd.h" ]
Don't use shared libraries in the wire fuzzer. Otherwise UBSan complains that C++ types are different between the shared libraries because libc++ is linked statically. BUG=chromium:904736 Change-Id: I51ef40d1f7910fd693a4585c74ff404812472d2e Reviewed-on: https://dawn-review.googlesource.com/c/2380 Reviewed-by: Dan Sinclair <dsinclair@google.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-11-14 21:04:26 +00:00
# Make headers publically visible
public_deps = [
":libdawn_wire_headers",
]
public_configs = [ ":libdawn_public" ]
# Put the export config public so that dependents use the same declspec.
public_configs += [ ":libdawn_wire_export" ]
}
shared_library("libdawn_wire") {
BUILD.gn: Fix libdawn_native missing dep on its own headers BUG=chromium:904736 BUG=chromium:905442 TBR=kainino@chromium.org Change-Id: Ie08b9c82f189e12ba42411e492190731daad5aca Reviewed-on: https://dawn-review.googlesource.com/c/2441 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-11-15 12:38:12 +00:00
deps = [
":libdawn_wire_sources",
]
Don't use shared libraries in the wire fuzzer. Otherwise UBSan complains that C++ types are different between the shared libraries because libc++ is linked statically. BUG=chromium:904736 Change-Id: I51ef40d1f7910fd693a4585c74ff404812472d2e Reviewed-on: https://dawn-review.googlesource.com/c/2380 Reviewed-by: Dan Sinclair <dsinclair@google.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-11-14 21:04:26 +00:00
# Make headers publically visible
Make Dawn "gn check" by default (except SPIRV-Tools) This required adding some missing dependencies, splitting public headers of libdawn_[native|wire] so they aren't hidden in the libdawn_[native|wire]_sources targets, and making unittests depend on sources directly instead of static libraries (which is almost equivalent). As a byproduct, Empty.cpp is no longer needed and is removed.
2018-08-12 19:07:46 +00:00
public_deps = [
":libdawn_wire_headers",
]
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
public_configs = [ ":libdawn_public" ]
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
# Tell dependents where to find this shared library
if (is_mac) {
ldflags = [
"-install_name",
"@rpath/${target_name}.dylib",
]
}
}
###############################################################################
# Utils for tests and samples
###############################################################################
static_library("dawn_utils") {
configs += [ ":dawn_internal" ]
sources = [
"src/utils/BackendBinding.cpp",
"src/utils/BackendBinding.h",
"src/utils/DawnHelpers.cpp",
"src/utils/DawnHelpers.h",
"src/utils/SystemUtils.cpp",
"src/utils/SystemUtils.h",
"src/utils/TerribleCommandBuffer.cpp",
"src/utils/TerribleCommandBuffer.h",
]
deps = [
":dawn_common",
":libdawn_native",
Make Dawn "gn check" by default (except SPIRV-Tools) This required adding some missing dependencies, splitting public headers of libdawn_[native|wire] so they aren't hidden in the libdawn_[native|wire]_sources targets, and making unittests depend on sources directly instead of static libraries (which is almost equivalent). As a byproduct, Empty.cpp is no longer needed and is removed.
2018-08-12 19:07:46 +00:00
":libdawn_wire",
Roll shaderc and glslang and use their BUILD.gn This rolls glslang and shaderc to be able to use their BUILD.gn files, and also rolls SPIRV-Tools and spirv-headers to have compatible versions. BUG=chromium:870747 Change-Id: I13c615f6f3d148c9b69f06547992bf5910e04e62 Reviewed-on: https://dawn-review.googlesource.com/c/1680 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-10-04 17:17:57 +00:00
"${dawn_shaderc_dir}:libshaderc",
Support creating default texture view on 2D array textures This patch intends to implement creating default texture view on 2D array textures. BUG=dawn:16 Change-Id: I4321c9506b2e875146645ad60291196dcfcc8ea0 Reviewed-on: https://dawn-review.googlesource.com/c/1660 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
2018-10-09 00:31:58 +00:00
"third_party:glfw",
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
]
BUILD.gn: Remove use of exec_script Chromium's BUILD files try to avoid uses of exec_script when possible because they slow down every GN invocation. In preparation for building Dawn inside Chromium, the calls to exec_script for the code generator are removed. In GN, the generator now outputs a "JSON tarball", a dictionnary mapping filenames to content. This allows us to use the "depfile" feature of GN to avoid the exec_script call to gather the script's inputs. Outputs of the generator are now listed in the BUILD.gn files. To keep it in sync with the generator, GN outputs a file containing "expected outputs" that is checked by the code generator. Finally the dawn_generator GN template doesn't create a target anymore, but users are expected to gather outputs using get_target_outputs.
2018-08-16 13:32:35 +00:00
libs = []
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
if (dawn_enable_d3d12) {
sources += [ "src/utils/D3D12Binding.cpp" ]
}
if (dawn_enable_metal) {
sources += [ "src/utils/MetalBinding.mm" ]
libs += [
"Metal.framework",
"QuartzCore.framework",
]
# Suppress warnings that Metal isn't in the deployment target of Chrome
if (is_mac) {
cflags_objcc = [ "-Wno-unguarded-availability" ]
}
}
if (dawn_enable_null) {
sources += [ "src/utils/NullBinding.cpp" ]
}
if (dawn_enable_opengl) {
sources += [ "src/utils/OpenGLBinding.cpp" ]
BUILD.gn: Move last third_party deps to third_party/BUILD.gn
2018-08-13 06:31:17 +00:00
deps += [ "third_party:glad" ]
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
}
if (dawn_enable_vulkan) {
sources += [ "src/utils/VulkanBinding.cpp" ]
BUILD.gn: Move last third_party deps to third_party/BUILD.gn
2018-08-13 06:31:17 +00:00
deps += [ "third_party:vulkan_headers" ]
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
}
}
###############################################################################
# Dawn test targets
###############################################################################
Create new src/tests BUILD.gn file. Move all test-related build stuff into its own BUILD.gn file. This required moving the dawn_generator template into a common file, so it can be called by both BUILD.gn and src/tests/BUILD.gn. Bug: dawn:61 Change-Id: Icaa459270bdaa60306e053b93835812e70dba6f5 Reviewed-on: https://dawn-review.googlesource.com/c/2940 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Stephen White <senorblanco@chromium.org>
2018-12-05 22:42:23 +00:00
# FIXME: Temporary proxies until Chrome references src/tests directly.
group("dawn_unittests") {
testonly = true
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
deps = [
Create new src/tests BUILD.gn file. Move all test-related build stuff into its own BUILD.gn file. This required moving the dawn_generator template into a common file, so it can be called by both BUILD.gn and src/tests/BUILD.gn. Bug: dawn:61 Change-Id: Icaa459270bdaa60306e053b93835812e70dba6f5 Reviewed-on: https://dawn-review.googlesource.com/c/2940 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Stephen White <senorblanco@chromium.org>
2018-12-05 22:42:23 +00:00
"src/tests:dawn_unittests",
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
]
}
Create new src/tests BUILD.gn file. Move all test-related build stuff into its own BUILD.gn file. This required moving the dawn_generator template into a common file, so it can be called by both BUILD.gn and src/tests/BUILD.gn. Bug: dawn:61 Change-Id: Icaa459270bdaa60306e053b93835812e70dba6f5 Reviewed-on: https://dawn-review.googlesource.com/c/2940 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Stephen White <senorblanco@chromium.org>
2018-12-05 22:42:23 +00:00
group("dawn_end2end_tests") {
testonly = true
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
deps = [
Create new src/tests BUILD.gn file. Move all test-related build stuff into its own BUILD.gn file. This required moving the dawn_generator template into a common file, so it can be called by both BUILD.gn and src/tests/BUILD.gn. Bug: dawn:61 Change-Id: Icaa459270bdaa60306e053b93835812e70dba6f5 Reviewed-on: https://dawn-review.googlesource.com/c/2940 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Stephen White <senorblanco@chromium.org>
2018-12-05 22:42:23 +00:00
"src/tests:dawn_end2end_tests",
Add GN build for tests and their third party deps.
2018-08-03 13:57:43 +00:00
]
Add initial BUILD.gn files for libdawn[|_native|_wire]
2018-07-31 16:50:03 +00:00
}
Add samples to BUILD.gn and their deps to DEPS Also add missing GLFW DEPS entry
2018-08-13 06:23:27 +00:00
###############################################################################
# Dawn samples, only in standalone builds
###############################################################################
if (dawn_standalone) {
# Static library to contain code and dependencies common to all samples
static_library("dawn_sample_utils") {
sources = [
"examples/SampleUtils.cpp",
"examples/SampleUtils.h",
]
# Export all of these as public deps so that `gn check` allows includes
public_deps = [
":dawn_common",
":dawn_utils",
":libdawn",
":libdawn_native",
":libdawn_wire",
"third_party:glfw",
]
public_configs = [ ":dawn_internal" ]
}
# Template for samples to avoid listing dawn_sample_utils as a dep every time
template("dawn_sample") {
executable(target_name) {
deps = [
":dawn_sample_utils",
]
forward_variables_from(invoker, "*", [ "deps" ])
if (defined(invoker.deps)) {
deps += invoker.deps
}
}
}
dawn_sample("CppHelloTriangle") {
sources = [
"examples/CppHelloTriangle.cpp",
]
}
dawn_sample("CHelloTriangle") {
sources = [
"examples/CHelloTriangle.cpp",
]
}
dawn_sample("ComputeBoids") {
sources = [
"examples/ComputeBoids.cpp",
]
deps = [
"third_party:glm",
]
}
dawn_sample("Animometer") {
sources = [
"examples/Animometer.cpp",
]
}
dawn_sample("CubeReflection") {
sources = [
"examples/CubeReflection.cpp",
]
deps = [
"third_party:glm",
]
}
dawn_sample("glTFViewer") {
sources = [
"examples/glTFViewer/Camera.inl",
"examples/glTFViewer/glTFViewer.cpp",
]
deps = [
"third_party:glm",
"third_party:tiny_gltf_loader",
]
}
BUILD.gn: Add a dawn_samples group BUG= Change-Id: I328bdc960bfc28a1ea16ca0c6705cb60b929109f Reviewed-on: https://dawn-review.googlesource.com/1542 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Stephen White <senorblanco@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-09-20 21:17:14 +00:00
group("dawn_samples") {
deps = [
Fix for D3D12 re-used bindgroup bug. If a bindgroup was re-used in multiple command buffers in a single call to queue.Submit(), it was skipping the creation of the corresponding descriptor heap for that bind group in the second command buffer. The fix is to use the command buffer's index into the submit command as part of the key for the bind group's descriptor heap. Change-Id: Ie66a0e772b10cc72bf040f090dac4c4a10f24266 Reviewed-on: https://dawn-review.googlesource.com/c/1740 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
2018-10-04 16:59:05 +00:00
":Animometer",
BUILD.gn: Add a dawn_samples group BUG= Change-Id: I328bdc960bfc28a1ea16ca0c6705cb60b929109f Reviewed-on: https://dawn-review.googlesource.com/1542 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Stephen White <senorblanco@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-09-20 21:17:14 +00:00
":CHelloTriangle",
":ComputeBoids",
Fix for D3D12 re-used bindgroup bug. If a bindgroup was re-used in multiple command buffers in a single call to queue.Submit(), it was skipping the creation of the corresponding descriptor heap for that bind group in the second command buffer. The fix is to use the command buffer's index into the submit command as part of the key for the bind group's descriptor heap. Change-Id: Ie66a0e772b10cc72bf040f090dac4c4a10f24266 Reviewed-on: https://dawn-review.googlesource.com/c/1740 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
2018-10-04 16:59:05 +00:00
":CppHelloTriangle",
BUILD.gn: Add a dawn_samples group BUG= Change-Id: I328bdc960bfc28a1ea16ca0c6705cb60b929109f Reviewed-on: https://dawn-review.googlesource.com/1542 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Stephen White <senorblanco@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-09-20 21:17:14 +00:00
":CubeReflection",
":glTFViewer",
]
}
Add samples to BUILD.gn and their deps to DEPS Also add missing GLFW DEPS entry
2018-08-13 06:23:27 +00:00
}
Add fuzzers for SPIRV-Cross This CL adds in fuzzers for SPIRV-Cross for HLSL, GLSL, and MSL outputs. These fuzzers live in Dawn because there is not appropriate location in the Chromium source repo for them and it is unlikely they would be land-able in the SPIRV-Cross repo, because it is not coupled with Chromium's build system and thus Clusterfuzz so would be effectively dead code. Dawn depends on this code, but it is also integrated into the Chromium build system, so this was the best place I could find for them The code under fuzz unfortunately uses exceptions/aborting as its error reporting mechanism. This is an acknowledge short coming and there are efforts to remove this behaviour. To work around this and reduce the number of false positives found by the fuzzers, a signal trap has been implemented which will be removed once the code under fuzz has been updated. The trap replaces the existing signal handler and silencing signals while running the code under test. This allows the code under test to call abort() and not crash the fuzzing process. Theoretically, only SIGABRT should need to be trapped, but something is causing the signal from abort() to be converted to SIGSEGV when running under ASAN. This signal trap has been tested with the fuzzing/sanitizers by intentionally inserting bad calls that will occur after a few thousand test cases. It was confirmed that the fuzzer detected the issue and stops fuzzing. The alternate to implementing this signal trap would be to turn on exceptions for the fuzzer. This was attempted, but proved to be fruitless due to what was reported as an ODR issue, but couldn't couldn't be silenced. The likely underlying issue was a pre-built library or other object being built without exceptions was causing different versions of symbols or the exception version of the standard library not being instrumented by ASAN. Given the majority of Chromium eco-system turns off exceptions, fixing this issue would not be helpful to the larger community and was looking like it would require significant effort. BUG=chromium:903380 Change-Id: I63a5595383f99b7a0e150d72bb04c89b8d722631 Reviewed-on: https://dawn-review.googlesource.com/c/2260 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Max Moroz <mmoroz@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2018-11-12 12:20:21 +00:00
###############################################################################
# Fuzzers
###############################################################################
Build fuzzer tests in standalone builds too. This will avoid compilation to break, and adds standalone reproducers for the fuzzer_tests. BUG=chromium:903380 BUG=dawn:34 Change-Id: I9995a852076d9f6d1ebdee5b999989c2d74d4709 Reviewed-on: https://dawn-review.googlesource.com/c/2321 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Ryan Harrison <rharrison@chromium.org> Reviewed-by: Dan Sinclair <dsinclair@google.com>
2018-11-12 18:09:56 +00:00
group("dawn_fuzzers") {
testonly = true
deps = [
"src/fuzzers:dawn_spirv_cross_glsl_fast_fuzzer",
"src/fuzzers:dawn_spirv_cross_glsl_full_fuzzer",
"src/fuzzers:dawn_spirv_cross_hlsl_fast_fuzzer",
"src/fuzzers:dawn_spirv_cross_hlsl_full_fuzzer",
"src/fuzzers:dawn_spirv_cross_msl_fast_fuzzer",
"src/fuzzers:dawn_spirv_cross_msl_full_fuzzer",
"src/fuzzers:dawn_wire_server_and_frontend_fuzzer",
]
Add fuzzers for SPIRV-Cross This CL adds in fuzzers for SPIRV-Cross for HLSL, GLSL, and MSL outputs. These fuzzers live in Dawn because there is not appropriate location in the Chromium source repo for them and it is unlikely they would be land-able in the SPIRV-Cross repo, because it is not coupled with Chromium's build system and thus Clusterfuzz so would be effectively dead code. Dawn depends on this code, but it is also integrated into the Chromium build system, so this was the best place I could find for them The code under fuzz unfortunately uses exceptions/aborting as its error reporting mechanism. This is an acknowledge short coming and there are efforts to remove this behaviour. To work around this and reduce the number of false positives found by the fuzzers, a signal trap has been implemented which will be removed once the code under fuzz has been updated. The trap replaces the existing signal handler and silencing signals while running the code under test. This allows the code under test to call abort() and not crash the fuzzing process. Theoretically, only SIGABRT should need to be trapped, but something is causing the signal from abort() to be converted to SIGSEGV when running under ASAN. This signal trap has been tested with the fuzzing/sanitizers by intentionally inserting bad calls that will occur after a few thousand test cases. It was confirmed that the fuzzer detected the issue and stops fuzzing. The alternate to implementing this signal trap would be to turn on exceptions for the fuzzer. This was attempted, but proved to be fruitless due to what was reported as an ODR issue, but couldn't couldn't be silenced. The likely underlying issue was a pre-built library or other object being built without exceptions was causing different versions of symbols or the exception version of the standard library not being instrumented by ASAN. Given the majority of Chromium eco-system turns off exceptions, fixing this issue would not be helpful to the larger community and was looking like it would require significant effort. BUG=chromium:903380 Change-Id: I63a5595383f99b7a0e150d72bb04c89b8d722631 Reviewed-on: https://dawn-review.googlesource.com/c/2260 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Max Moroz <mmoroz@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2018-11-12 12:20:21 +00:00
}