encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Suppress two -Wunreachable-code warnings. 

Bug: chromium:346399
Change-Id: Ieb76cf99022230dcfb0bc6b17f95ea544040a796
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/17040
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
This commit is contained in:
Nico Weber 2020-03-16 10:59:56 +00:00 committed by Commit Bot service account
parent 1a56ce54e0
commit 022952303c
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/tests/unittests/validation/GetBindGroupLayoutValidationTests.cpp
View File

@ -258,6 +258,7 @@ TEST_F(GetBindGroupLayoutTests, Multisampled) {
// TODO: Support multisampling
GTEST_SKIP() << "Multisampling unimplemented";
#if 0
{
binding.multisampled = true;
wgpu::RenderPipeline pipeline = RenderPipelineFromFragmentShader(R"(
@ -267,6 +268,7 @@ TEST_F(GetBindGroupLayoutTests, Multisampled) {
void main() {})");
EXPECT_EQ(device.CreateBindGroupLayout(&desc).Get(), pipeline.GetBindGroupLayout(0).Get());
}
#endif
}
// Test that texture view dimension matches the shader.
@ -497,10 +499,8 @@ TEST_F(GetBindGroupLayoutTests, ConflictingBindingType) {
}
// Test it is invalid to have conflicting binding texture multisampling in the shaders.
TEST_F(GetBindGroupLayoutTests, ConflictingBindingTextureMultisampling) {
// TODO: Support multisampling
GTEST_SKIP() << "Multisampling unimplemented";
// TODO: Support multisampling
TEST_F(GetBindGroupLayoutTests, DISABLED_ConflictingBindingTextureMultisampling) {
wgpu::ShaderModule vsModule =
utils::CreateShaderModule(device, utils::SingleShaderStage::Vertex, R"(
#version 450