encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Re-enable disabled unit tests 

The issues causing these tests to fail with the Inspector enabled have
been resolved.

BUG=dawn:578

Change-Id: Ie0b7b4d6b2d1a3b432f4eed7542c64e31bf44fdb
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/35680
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
This commit is contained in:
Ryan Harrison 2020-12-14 20:45:08 +00:00 committed by Commit Bot service account
parent 12c78cbc82
commit 43c39a1ba4
2 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/tests/unittests/validation/RenderPipelineValidationTests.cpp
View File

@ -480,9 +480,6 @@ TEST_F(RenderPipelineValidationTest, TextureViewDimensionCompatibility) {
// Test that declaring a storage buffer in the vertex shader without setting pipeline layout won't // Test that declaring a storage buffer in the vertex shader without setting pipeline layout won't
// cause crash. // cause crash.
TEST_F(RenderPipelineValidationTest, StorageBufferInVertexShaderNoLayout) { TEST_F(RenderPipelineValidationTest, StorageBufferInVertexShaderNoLayout) {
// TODO(rharrison): Re-enable once tint:383 is resolved.
DAWN_SKIP_TEST_IF(HasToggleEnabled("use_tint_inspector"));
wgpu::ShaderModule vsModuleWithStorageBuffer = utils::CreateShaderModuleFromWGSL(device, R"( wgpu::ShaderModule vsModuleWithStorageBuffer = utils::CreateShaderModuleFromWGSL(device, R"(
[[block]] struct Dst { [[block]] struct Dst {
[[offset(0)]] data : [[stride(4)]] array<u32, 100>; [[offset(0)]] data : [[stride(4)]] array<u32, 100>;

6
src/tests/unittests/validation/StorageTextureValidationTests.cpp
View File

@ -122,9 +122,6 @@ class StorageTextureValidationTests : public ValidationTest {
// Validate read-only storage textures can be declared in vertex and fragment shaders, while // Validate read-only storage textures can be declared in vertex and fragment shaders, while
// writeonly storage textures cannot be used in vertex shaders. // writeonly storage textures cannot be used in vertex shaders.
TEST_F(StorageTextureValidationTests, RenderPipeline) { TEST_F(StorageTextureValidationTests, RenderPipeline) {
// TODO(rharrison): Re-enable once https://dawn-review.googlesource.com/c/tint/+/34424 lands
DAWN_SKIP_TEST_IF(HasToggleEnabled("use_tint_inspector"));
// Readonly storage texture can be declared in a vertex shader. // Readonly storage texture can be declared in a vertex shader.
{ {
wgpu::ShaderModule vsModule = utils::CreateShaderModuleFromWGSL(device, R"( wgpu::ShaderModule vsModule = utils::CreateShaderModuleFromWGSL(device, R"(
@ -197,9 +194,6 @@ TEST_F(StorageTextureValidationTests, RenderPipeline) {
// Validate both read-only and write-only storage textures can be declared in // Validate both read-only and write-only storage textures can be declared in
// compute shaders. // compute shaders.
TEST_F(StorageTextureValidationTests, ComputePipeline) { TEST_F(StorageTextureValidationTests, ComputePipeline) {
// TODO(rharrison): Re-enable once https://dawn-review.googlesource.com/c/tint/+/34424 lands
DAWN_SKIP_TEST_IF(HasToggleEnabled("use_tint_inspector"));
// Read-only storage textures can be declared in a compute shader. // Read-only storage textures can be declared in a compute shader.
{ {
wgpu::ShaderModule csModule = utils::CreateShaderModuleFromWGSL(device, R"( wgpu::ShaderModule csModule = utils::CreateShaderModuleFromWGSL(device, R"(