encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-12-16 00:17:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

GLSL: special-case BinaryOp::kModulo for floating point.

Browse Source 
The '%' operator in GLSL is integer-only. Use the full OpFRem
expression: (a - b * trunc(a / b)).

Bug: tint:1270
Change-Id: I0a969983bef132e004ce456d4a738488e400a61b
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/68760
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>
This commit is contained in:
Stephen White
2022-02-28 21:15:02 +00:00
committed by Tint LUCI CQ
parent 9b152e655f
commit 59f1e8d06c
29 changed files with 246 additions and 235 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
test/tint/vk-gl-cts/graphicsfuzz/cov-mod-uint-bits-float/0-opt.wgsl.expected.glsl
View File

@@ -1,5 +1,3 @@
SKIP: FAILED
vk-gl-cts/graphicsfuzz/cov-mod-uint-bits-float/0-opt.wgsl:1:13 warning: use of deprecated language feature: the @stride attribute is deprecated; use a larger type if necessary
type Arr = @stride(16) array<f32, 3>;
^^^^^^
@@ -7,6 +5,11 @@ type Arr = @stride(16) array<f32, 3>;
#version 310 es
precision mediump float;
float tint_float_modulo(float lhs, float rhs) {
return (lhs - rhs * trunc(lhs / rhs));
}
layout(location = 0) out vec4 x_GLF_color_1_1;
struct tint_padded_array_element {
float el;
@@ -23,7 +26,7 @@ layout(binding = 0) uniform buf0_1 {
void main_1() {
float a = 0.0f;
a = (uintBitsToFloat(1u) % 1.0f);
a = tint_float_modulo(uintBitsToFloat(1u), 1.0f);
float x_29 = x_6.x_GLF_uniform_float_values[1].el;
x_GLF_color = vec4(x_29, x_29, x_29, x_29);
float x_31 = a;
@@ -53,10 +56,3 @@ void main() {
x_GLF_color_1_1 = inner_result.x_GLF_color_1;
return;
}
Error parsing GLSL shader:
ERROR: 0:20: '%' : wrong operand types: no operation '%' exists that takes a left-hand operand of type ' global highp float' and a right operand of type ' const float' (or there is no acceptable conversion)
ERROR: 0:20: '' : compilation terminated
ERROR: 2 compilation errors. No code generated.