encounter/dawn-cmake
1
0
Fork 0
mirror of https://github.com/encounter/dawn-cmake.git synced 2025-07-04 12:16:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Add test setting the locale."

Browse Source 
This reverts commit 9cdc3343ff2f88e44bbc2f43feb2c0f05b3e03ad.

Reason for revert: For some reason, Windows kokoro bots are now taking objection to this test.

Original change's description:
> Add test setting the locale.
>
> This CL adds a test which sets the locale to one which uses `1,00`
> instead of `1.00`. This ensures the float emission will get the right
> format.
>
> Bug: tint:1686
> Change-Id: Ib87235c7beac351b7dcbf37534df07135da377e5
> Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/120881
> Reviewed-by: Ben Clayton <bclayton@google.com>
> Kokoro: Kokoro <noreply+kokoro@google.com>
> Commit-Queue: Dan Sinclair <dsinclair@chromium.org>

TBR=dsinclair@chromium.org,bclayton@google.com,noreply+kokoro@google.com,dawn-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I2ace266871958a2d467855d55079aae467195ce0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: tint:1686
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/121462
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: James Price <jrprice@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
This commit is contained in:
Ben Clayton 2023-02-24 17:03:59 +00:00 committed by Dawn LUCI CQ
parent 9ec746e3b9
commit 7052cb57ff
1 changed files with 0 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/tint/writer/float_to_string_test.cc
View File

@ -17,7 +17,6 @@
#include <math.h>
#include <cstring>
#include <limits>
#include <locale>
#include "gtest/gtest.h"
#include "src/tint/utils/bitcast.h"
@ -80,16 +79,6 @@ TEST(FloatToStringTest, Precision) {
EXPECT_EQ(FloatToString(1e-20f), "9.99999968e-21");
}
#if !defined(__linux__)
TEST(FloatToStringTest, Locale) {
std::locale::global(std::locale("sv_SE.UTF-8"));
EXPECT_EQ(FloatToString(1e-9f), "0.000000001");
std::locale::global(std::locale::classic());
}
#endif // !defined(__linux__)
////////////////////////////////////////////////////////////////////////////////
// FloatToBitPreservingString //
////////////////////////////////////////////////////////////////////////////////