encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Reenable D3D12 tests that failed with 'runtime array not supported yet' 

Replace TODOs for those tests that now fail with another issue.

Fixed: tint:682
Change-Id: I2665f0d4f495e4efc5adef4cf46a965df7c8936c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/46451
Auto-Submit: Ben Clayton <bclayton@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
This commit is contained in:
Ben Clayton 2021-04-12 18:45:14 +00:00 committed by Commit Bot service account
parent 10ec9a706f
commit b06b89e9c2
6 changed files with 3 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/tests/end2end/BufferZeroInitTests.cpp
View File

@ -1186,7 +1186,7 @@ TEST_P(BufferZeroInitTest, IndirectBufferForDispatchIndirect) {
// Test the buffer will be lazily initialized correctly when its first use is in resolveQuerySet
TEST_P(BufferZeroInitTest, ResolveQuerySet) {
// TODO(crbug.com/tint/682): error: runtime array not supported yet
// TODO(crbug.com/tint/683): internal compiler error: TINT_UNIMPLEMENTED
DAWN_SKIP_TEST_IF(IsD3D12() && HasToggleEnabled("use_tint_generator"));
// Timestamp query is not supported on OpenGL

3
src/tests/end2end/ComputeCopyStorageBufferTests.cpp
View File

@ -141,9 +141,6 @@ TEST_P(ComputeCopyStorageBufferTests, SizedArrayOfStruct) {
// Test that a trivial compute-shader memcpy implementation works.
TEST_P(ComputeCopyStorageBufferTests, UnsizedArrayOfBasic) {
// TODO(crbug.com/tint/682): error: runtime array not supported yet
DAWN_SKIP_TEST_IF(IsD3D12() && HasToggleEnabled("use_tint_generator"));
BasicTest(R"(
[[block]] struct Buf1 {
s : array<vec4<u32>>;

3
src/tests/end2end/CopyTextureForBrowserTests.cpp
View File

@ -113,9 +113,6 @@ class CopyTextureForBrowserTests : public DawnTest {
void SetUp() override {
DawnTest::SetUp();
// TODO(crbug.com/tint/682): error: runtime array not supported yet
DAWN_SKIP_TEST_IF(IsD3D12() && HasToggleEnabled("use_tint_generator"));
testPipeline = MakeTestPipeline();
uint32_t uniformBufferData[] = {

3
src/tests/end2end/OpArrayLengthTests.cpp
View File

@ -23,9 +23,6 @@ class OpArrayLengthTest : public DawnTest {
void SetUp() {
DawnTest::SetUp();
// TODO(crbug.com/tint/682): error: runtime array not supported yet
DAWN_SKIP_TEST_IF(IsD3D12() && HasToggleEnabled("use_tint_generator"));
// Create buffers of various size to check the length() implementation
wgpu::BufferDescriptor bufferDesc;
bufferDesc.size = 4;

2
src/tests/end2end/QueryTests.cpp
View File

@ -512,7 +512,7 @@ class TimestampQueryTests : public QueryTests {
void SetUp() override {
DawnTest::SetUp();
// TODO(crbug.com/tint/682): error: runtime array not supported yet
// TODO(crbug.com/tint/683): internal compiler error: TINT_UNIMPLEMENTED
DAWN_SKIP_TEST_IF(IsD3D12() && HasToggleEnabled("use_tint_generator"));
// Skip all tests if timestamp extension is not supported

2
src/tests/white_box/QueryInternalShaderTests.cpp
View File

@ -86,7 +86,7 @@ class QueryInternalShaderTests : public DawnTest {};
// timestamp period (here use GPU frequency (HZ) on Intel D3D12 to calculate the period in
// ns for testing).
TEST_P(QueryInternalShaderTests, TimestampComputeShader) {
// TODO(crbug.com/tint/682): error: runtime array not supported yet
// TODO(crbug.com/tint/683): internal compiler error: TINT_UNIMPLEMENTED
DAWN_SKIP_TEST_IF(IsD3D12() && HasToggleEnabled("use_tint_generator"));
// TODO(crbug.com/dawn/741): Test output is wrong with D3D12 + WARP.
DAWN_SKIP_TEST_IF(IsD3D12() && IsWARP());