encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Set depthWriteEnabled to default in ExpectAttachmentDepthStencilTestData 

This patch sets depthWriteEnabled to its default value (false) in the
helper function DawnTest::ExpectAttachmentDepthStencilTestData() as all
the tests can pass with depthWriteEnabled == false on the Linux Intel
bots now.

Note that previously using depthWriteEnabled == false and writing into
FragDepth will cause Linux Intel Mesa driver crash on Mesa 19.0.2.

BUG=dawn:821
TEST=dawn_end2end_tests
Change-Id: I22cc0dcdb8521fd8eae436d99a7c06167af89b09

Change-Id: Id0dd1c31099c6aafad175bde038ba9662b02a160
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85322
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
This commit is contained in:
Jiawei Shao 2022-03-31 23:37:05 +00:00 committed by Dawn LUCI CQ
parent f09b03bfee
commit eab5300e87
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/dawn/tests/DawnTest.cpp
View File

@ -1375,11 +1375,6 @@ std::ostringstream& DawnTestBase::ExpectAttachmentDepthStencilTestData(
if (depthDataTexture) { if (depthDataTexture) {
// Pass the depth test only if the depth is equal. // Pass the depth test only if the depth is equal.
depthStencil->depthCompare = wgpu::CompareFunction::Equal; depthStencil->depthCompare = wgpu::CompareFunction::Equal;
// TODO(jiawei.shao@intel.com): The Intel Mesa Vulkan driver can't set gl_FragDepth unless
// depthWriteEnabled == true. This either needs to be fixed in the driver or restricted by
// the WebGPU API.
depthStencil->depthWriteEnabled = true;
} }
if (expectedStencil != nullptr) { if (expectedStencil != nullptr) {