Commit Graph

8745 Commits

Author SHA1 Message Date
Dawn Autoroller ea5ad06289 Roll Tint from 98facb28ab to 73e7988694 (2 revisions)
https://dawn.googlesource.com/tint.git/+log/98facb28abc8..73e79886943c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-dawn
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: amaiorano@google.com
Change-Id: I778fab44614b4cbee0580023e600f0df6cd2211c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/80280
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-11 14:23:01 +00:00
Stephen White 723f999ac2 GLSL: fix frexp and modf builtins.
These still had vestiges of HLSL.

Bug: tint:1222
Change-Id: I5f93f75e7384db641f0c5421dca24a3e8f2b716e
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/80140
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2022-02-11 13:41:23 +00:00
Ben Clayton 73e7988694 fuzzers: Shuffle module scope declarations
For the tint_all_transforms_fuzzer. Exercises the fact we now allow
declarations in any order.

Bug: tint:1266
Change-Id: I9ddfac90aaafe213cd860944f210718216cb3d13
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79770
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-02-11 12:59:08 +00:00
Ben Clayton 6688b0a3c7 resolver: Enable support of out of order declarations
Allow module-scope declarations to be made in any order.

Bug: tint:1266
Change-Id: Ib2607b6c33fad7c83e2c36f85b0a965eac922ec5
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79769
Reviewed-by: David Neto <dneto@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-02-11 12:59:08 +00:00
Dawn Autoroller daff392705 Roll ANGLE from 118ce6aae027 to d5df233189ca (6 revisions)
118ce6aae0..d5df233189

2022-02-11 cclao@google.com Vulkan: Disable EGLContextSharingTestNoSyncTextureUploads on Pixel6
2022-02-10 syoussefi@chromium.org Vulkan: Render the overlay in the graphics pipeline
2022-02-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from b594e2aabae9 to 071bfca11aa9 (1 revision)
2022-02-10 cclao@google.com Vulkan: Use Vulkan API directly for BufferPool's buffer allocation
2022-02-10 m.maiya@samsung.com Update GL_MAX_CLIP_DISTANCES_EXT validation
2022-02-10 steven@valvesoftware.com Vulkan: improve command buffer reset performance

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: amaiorano@google.com
Change-Id: I4ea55973653adb90587bb2b11b2e86706bc3a14e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/80220
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-11 08:26:01 +00:00
Stephen White a52abab38c Nuke SPIRV-Cross.
Change-Id: I1fc58d50ba3999e3a9b6f4e30a0799be301893de
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79481
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2022-02-11 00:45:51 +00:00
Dawn Autoroller 0778a4285a Roll Tint from 0b3dfef469 to 98facb28ab (3 revisions)
https://dawn.googlesource.com/tint.git/+log/0b3dfef4698f..98facb28abc8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-dawn
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: amaiorano@google.com
Change-Id: I942fb1d5a72697fd0c19d649b3d796e64080d933
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/80160
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-10 23:49:11 +00:00
Stephen White 96b72c262c OpenGL: use Tint for GLSL generation.
Change-Id: Ibced679fa6568f1eb33707f0157d03505e6f8a1c
Bug: dawn:1263
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/67540
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2022-02-10 22:17:41 +00:00
Brandon Jones 31f60e3a40 Remove accidental unused Transform Manager
Removes an unused tint::Transform::Manager that was accidentally merged
as part of commit "Integrate Multiplanar External Texture Transform".

Bug: dawn:1082
Change-Id: I55b5eec8b17f27df22658a90912dec4d6d583cbb
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/80100
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Brandon1 Jones <brandon1.jones@intel.com>
2022-02-10 21:56:51 +00:00
Ryan Harrison 98facb28ab Add my @chromium.org account to OWNERS
Change-Id: Ib61ff92d373b63c39bbf664a2c67d5f0b8e9bd2e
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/80080
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: David Neto <dneto@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
2022-02-10 19:57:53 +00:00
Austin Eng e710706858 Remove old src/tests/BUILD.gn
Bug: dawn:1275
Change-Id: I1da086fb291551b0a437411b13285a097557e7de
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/80060
Auto-Submit: Austin Eng <enga@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-02-10 19:41:24 +00:00
Brandon Jones cff04b4d3f Integrate Multiplanar External Texture Transform
Introduces the majority of the logic associated with enabling
multiplanar external textures. Removes most backend logic associated
with external textures in favor of expanding them into their components
in the frontend. Includes a basic e2e test demonstrating multiplanar
YUV-to-RGB conversion.

Bug: dawn:1082
Change-Id: Ib5c042e5639b1a8efe2954680abc346c8c6c76d7
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/78248
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Brandon1 Jones <brandon1.jones@intel.com>
2022-02-10 19:31:13 +00:00
Dawn Autoroller e6e2bcf436 Roll ANGLE from 670a6e476ea4 to 118ce6aae027 (4 revisions)
670a6e476e..118ce6aae0

2022-02-10 sweeper1203@gmail.com Support to open d3d12 shared handles
2022-02-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 0915ab4bddf7 to cbd31d271e4c (3 revisions)
2022-02-10 ynovikov@chromium.org Revert "Don't build dEQP tests on MSVC temporarily"
2022-02-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 60719c9cd084 to bf99b2cc0f6b (543 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: amaiorano@google.com
Change-Id: Ida55abe25676edfaabf038f66d91ad504f413318
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/80041
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-10 18:59:21 +00:00
Antonio Maiorano 0bb04c2057 Split back out two transforms previously combined into PromoteSideEffectsToDeclTest
That is, bring back both VarForDynamicIndex and
PromoteInitializersToConstVar. This is not a complete revert, though:
*  VarForDynamicIndex no longer depends on ForLoopToLoop
* Both can cope with hoisting from "else if"
* More unit tests were added in the interim

Delete PromoteSideEffectsToDecl for now. This may be brought back to
handle ensuring order of evaluation.

Bug: tint:1300
Change-Id: I8bbae46377ec4603cc02c1eb3f0661a8461a19fa
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79940
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2022-02-10 18:50:38 +00:00
Vadim Shtayura 3ce05348e7 Generate shorter bucket names in luci-scheduler.cfg.
This is an ongoing LUCI config format migration.

R=jrprice@google.com

Change-Id: I12c2913b61f97ea1a4108ac9e5cc0b46f0be3765
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79960
Auto-Submit: Vadim Shtayura <vadimsh@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Ryan Harrison (use @chromium.org) <rharrison@google.com>
Commit-Queue: Ryan Harrison (use @chromium.org) <rharrison@google.com>
2022-02-10 18:42:18 +00:00
Dawn Autoroller d513b69680 Roll Tint from 8bbdda7e89 to 0b3dfef469 (1 revision)
https://dawn.googlesource.com/tint.git/+log/8bbdda7e89dd..0b3dfef4698f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-dawn
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: amaiorano@google.com
Change-Id: I57298f05c18ffdb7254a789fed5eff2a392bd464
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/80040
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-10 18:34:41 +00:00
Dawn Autoroller 13152e7dbb Roll SwiftShader from cbd31d271e4c to a7f412ebb116 (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/cbd31d271e4c..a7f412ebb116

2022-02-10 swiftshader.regress@gmail.com Regres: Update test lists @ cbd31d27

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: amaiorano@google.com
Change-Id: I2f6dcf15360f4d9f1cf4c30170af1926c85cee82
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/80000
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-10 16:56:21 +00:00
Stephen White 0b3dfef469 GLSL: call renamer transform from GLSL transform.
This significantly simplifies the calling code from Dawn.
It does require moving the SingleEntryPoint transform above the
renamer, since we need to call SEP with the original name. That is
probably also an optimization, since we do the subsequent transforms
with a culled AST.

Bug: tint:1268
Change-Id: I1f48ec0238ea76310742c60b119311747dd3dbac
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/80020
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2022-02-10 16:22:28 +00:00
Vadim Shtayura 040bfe2518 Generate shorter bucket names in luci-scheduler.cfg.
This is an ongoing LUCI config format migration.

Change-Id: Id01a7a1461c78f8e7147fb314e0379ab9835e528
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79981
Auto-Submit: Vadim Shtayura <vadimsh@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-02-10 09:02:02 +00:00
Dawn Autoroller 1d39cb13cc Roll Tint from 597fc4cdbe to 8bbdda7e89 (3 revisions)
https://dawn.googlesource.com/tint.git/+log/597fc4cdbe07..8bbdda7e89dd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-dawn
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: amaiorano@google.com
Change-Id: Ic0b83beaec1a3f596646b3a204afd04cac482652
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79924
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-10 05:16:22 +00:00
Dawn Autoroller 74d9fe10ac Roll ANGLE from 9cfd872447fd to 670a6e476ea4 (7 revisions)
9cfd872447..670a6e476e

2022-02-10 m.maiya@samsung.com Ignore invalid texture type error
2022-02-10 kpiddington@apple.com Metal: Fix multisample resolves.
2022-02-09 cclao@google.com Vulkan: Fix incorrect DescriptorSet's bufferInfo in XFB emulation path
2022-02-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 97ceb2222747 to b594e2aabae9 (64 revisions)
2022-02-09 cnorthrop@google.com Test: Add Lords Mobile trace
2022-02-09 jmadill@chromium.org Fix perf test runner script.
2022-02-09 jonahr@google.com Add keying on backend to ANGLE Display caching.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: amaiorano@google.com
Change-Id: I9b613edb64b3625ec19dd326b8d96637dcf49e28
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79925
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-10 05:09:42 +00:00
Jiawei Shao 47f051984b D3D12: Only set root parameters for dynamic storage buffers when needed
This patch skips setting the items for dynamic storage buffer lengths
in root signatures when there is no dynamic storage buffer in the
pipeline layout so that we can avoid adding a root constant with
Num32BitValues == 0 in the root signature.

BUG=dawn:1262

Change-Id: I7d698425c94092299aefaf8cb6ef465745c8d194
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79742
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
2022-02-10 00:05:01 +00:00
Ben Clayton 8bbdda7e89 transform: Update MultiplanarExternalTexture to support OOO-decls
MultiplanarExternalTexture cannot deal with out-of-order declarations.
Re-work things so that it can.

Bug: tint:1266
Change-Id: Ie2c8237be4f6ddb91120cbeb25f3c186b572ba59
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79768
Reviewed-by: David Neto <dneto@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-02-09 23:55:51 +00:00
Ben Clayton 8ec32a6ec9 writers: Use the new sem::Module::DependencyOrderedDeclarations
As the resolver currently enforces in-order declarations, this does not
change the declaration order from iterating over the
ast::Module::GlobalDeclarations.

The MSL backend has been changed to use the
sem::Module::DependencyOrderedDeclarations list instead of looping over
different declaration types separately.

Bug: tint:1266
Change-Id: I698d612032285311017bfceab3c42adae1928a0e
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79767
Reviewed-by: James Price <jrprice@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-02-09 23:55:51 +00:00
Ben Clayton a52be6c9ec Add sem::Module
Holds `DependencyOrderedDeclarations()`, which will hold the
sorted dependency-graph ordered list of global declarations.

Bug: tint:1266
Change-Id: I9840fae8689abd214973ea4785f71c3ae2587bbc
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79766
Reviewed-by: James Price <jrprice@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-02-09 23:55:51 +00:00
Dawn Autoroller 311e20e5de Roll Tint from 35cc663130 to 597fc4cdbe (4 revisions)
https://dawn.googlesource.com/tint.git/+log/35cc6631307c..597fc4cdbe07

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-dawn
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: amaiorano@google.com
Change-Id: Iab13a68106a7b2c60adee73689852903439b8007
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79923
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-09 23:54:01 +00:00
Dawn Autoroller 8d4fc76d17 Roll SwiftShader from 0915ab4bddf7 to cbd31d271e4c (3 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/0915ab4bddf7..cbd31d271e4c

2022-02-09 sugoi@google.com Dynamic state refactor
2022-02-09 sugoi@google.com VK_EXT_subgroup_size_control support
2022-02-09 capn@google.com Add compute benchmarks

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: amaiorano@google.com
Change-Id: I57bf38eaff7f0b8116cb988687bc3ee577f8c4de
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79922
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-09 22:42:51 +00:00
Ben Clayton 597fc4cdbe resolver: Replace ICEs with proper errors
If you attempted to:
 * Use a function as a type
 * Use a variable as a type
 * Use a variable as a call target

You would get an ICE. Replace these with proper error diagnostics.

Change-Id: Ibbe4cd1b59b1aadd451aa0445ad137859aa071eb
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79765
Reviewed-by: James Price <jrprice@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-02-09 22:23:17 +00:00
Ben Clayton 88d1a433aa Castable: Have Switch() support nullptr objects.
Change-Id: I7635b01707e80c2d2e0b79148e07874f2fa2b5ff
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79764
Auto-Submit: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2022-02-09 21:37:57 +00:00
Ryan Harrison 6839cba568 Add toggle to control if validity is expected in fuzzer
This toggle controls if the fuzzer will throw a fatal error in the
case that the shader becomes invalid.

Currently the fuzzers do no guarantee that the options that are
provided are correct/valid, so there are many uninteresting cases that
become invalid due to the limited nature of the fuzzers, not due to
bugs in the code. The default off state of this toggle will suppress
this noise.

Once https://bugs.chromium.org/p/tint/issues/detail?id=1356 is
implemented this toggle can be default on.

BUG=tint:1357,chromium:1294533

Change-Id: I7170e5a30691105c97e20d8337aadf81ac2bc3bc
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79840
Reviewed-by: Ben Clayton <bclayton@google.com>
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
2022-02-09 19:45:17 +00:00
Shrek Shao 71a363bcf9 Add error directives for api.h/api_cpp.h #ifdef __EMSCRIPTEN__
This could avoid including dawn's version of webgpu headers
and confusion at runtime when build with emscripten.
Emscripten's system/include/webgpu headers should be used.

Bug: None
Change-Id: Ie8c6ebc23f28a56b1cb887ae7f11d3f738151aec
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79740
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Shrek Shao <shrekshao@google.com>
2022-02-09 19:42:51 +00:00
Dawn Autoroller b626409c4b Roll Tint from d21ebe74bd to 35cc663130 (1 revision)
https://dawn.googlesource.com/tint.git/+log/d21ebe74bd9c..35cc6631307c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-dawn
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: amaiorano@google.com
Change-Id: Id7d21f1b6c85927d35e3847ff42da3110181ddbe
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79921
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-09 18:46:11 +00:00
Corentin Wallez 82ca6096ac Mark 1D textures as safe.
Fixed: dawn:814
Change-Id: I216ebdb68cfb1634cfad8b44de998c2f1a87edaf
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79320
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2022-02-09 18:40:51 +00:00
Antonio Maiorano dba215cd16 Add sem::Expression::HasSideEffects()
Will be used to implement order of execution.

Bug: tint:1300
Change-Id: I027295e482da7a3f9d7ca930b5303e8f89d7fe09
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79824
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2022-02-09 18:30:27 +00:00
Stephen White 19bb9563f8 Set vulkan_loader_shared to false on Mac.
This is the same configuation that ANGLE uses. Without this, Release
builds of Dawn on Mac can't find libvulkan.dylib.

Bug: angleproject:6981

Change-Id: Ib5eddd0f694d1b960e16341578427fa4f0a009c5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79560
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2022-02-09 17:45:51 +00:00
Stephen White 35cc663130 GLSL: implement desktop GLSL support.
Introduce a glsl::Version, to allow the client to specify ES or
Desktop, as well as the desired GLSL major and minor version.

Bug: tint:1422

Change-Id: I4116bc2da40ae6a553dc2522d042dda1464a0c05
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79700
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2022-02-09 17:44:17 +00:00
Dawn Autoroller c6d343d18b Roll ANGLE from 1b9774f57784 to 9cfd872447fd (4 revisions)
1b9774f577..9cfd872447

2022-02-09 sergeyu@google.com Allow surface creation in DisplayVkNull
2022-02-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from e576ca6011cd to 0915ab4bddf7 (6 revisions)
2022-02-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 817a527fde8c to 60719c9cd084 (571 revisions)
2022-02-09 syoussefi@chromium.org Vulkan: Fix vkCmdClearAttachments vs multiview

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: amaiorano@google.com
Change-Id: I03bf3136c6385bbbe2f15d3c12fa8ed71883750d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79920
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-09 16:09:01 +00:00
Corentin Wallez 9fc28cf3b6 Metal: Fix leak of MTLVertexDescriptor when using vertex pulling
Bug: dawn:1175
Change-Id: I1fd833fef830de4165a397e07c3ddaae0d7bdca8
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79762
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-02-09 15:56:32 +00:00
Austin Eng 189b0cec37 tint->dawn: Move src/dawn_tests -> src/dawn/tests
Bug: dawn:1275
Change-Id: I79f2aeb0c54a74dd5becd90c46792705a28e87da
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79100
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-02-09 14:54:31 +00:00
Dawn Autoroller 962c4ea5d5 Roll SwiftShader from 8ccc63f045d5 to 0915ab4bddf7 (2 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/8ccc63f045d5..0915ab4bddf7

2022-02-08 capn@google.com Fix validation layer error for ClearImage benchmarks
2022-02-08 capn@google.com Fix non-x86 build of LLVM Reactor

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: amaiorano@google.com
Change-Id: I25256077df04c9886794c9d90d67877d8b6e6cda
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79880
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-09 09:27:41 +00:00
Dawn Autoroller 73b577e9c6 Roll ANGLE from 8622810c4fae to 1b9774f57784 (8 revisions)
8622810c4f..1b9774f577

2022-02-08 m.maiya@samsung.com Vulkan: Force submit updates to immutable textures
2022-02-08 jmadill@chromium.org Vulkan: Bind aligned default uniform buffer size.
2022-02-08 jmadill@chromium.org Vulkan: Minor cleanup to DynamicDescriptorPool.
2022-02-08 syoussefi@chromium.org Overlay: Rearrange the font image
2022-02-08 jmadill@chromium.org Vulkan: Use common storage for descriptor set descs.
2022-02-08 jmadill@chromium.org Expand SwiftShader Win/ASAN suppression.
2022-02-08 cclao@google.com Vulkan: StreamVertexDataWithDivisor write beyond buffer boundary
2022-02-08 grt@chromium.org [fuchsia] Tests using additional_manifest_fragments are CFv1.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: amaiorano@google.com
Change-Id: Ie0323d20db89412f75d70154a1e1b1f7be18c7cd
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79860
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-09 03:06:40 +00:00
Dawn Autoroller 2a1f4dc5b1 Roll Tint from c6d8cadd33 to d21ebe74bd (1 revision)
https://dawn.googlesource.com/tint.git/+log/c6d8cadd3300..d21ebe74bd9c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-dawn
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: amaiorano@google.com
Change-Id: I604503db4bdff31d8f49e09cf5a0334b5d7a799b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79823
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-08 22:39:20 +00:00
Austin Eng 7fd6b996f4 tint->dawn: Add proxy groups and temp targets for Dawn tests
Needed so that Chromium can reference the temp groups and
targets while we move Dawn's test build targets.

Bug: dawn:1275
Change-Id: Ia26769adfb3714e78ebd058ffcec50f3ccfa1a05
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79821
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-02-08 22:15:50 +00:00
Ryan Harrison d21ebe74bd Suppress "Wreserved-identifier" for the AST Fuzzer
This is a check that has been added to newer versions of clang and is
tripping for me locally. The actual issue is in code being generated
by protobuf.

Updating protobufs has cross-dependency issues with spriv-tools, so is
non-trivial. There is already a special case suppression for internal
protobuf issues, so I am just adding to the carve out.

BUG=tint:1419

Change-Id: I3ecd111a778fb4c65a113382ded8d6160deab462
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79841
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
2022-02-08 21:37:56 +00:00
Shrek Shao ee50bc060a dawn.json changes for the upstream webgpu.h
- Fix power preference undefined value
- Remove 'upstream' tagged content from emscripten-bits generation
  explicitly tag 'emscripten' to things still needed

Bug: None
Change-Id: If575823ff1d99237d7c2cb0e784c24a7299b4a31
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79220
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Shrek Shao <shrekshao@google.com>
2022-02-08 20:21:40 +00:00
Dawn Autoroller 98d4a01bc1 Roll SwiftShader from e576ca6011cd to 8ccc63f045d5 (4 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/e576ca6011cd..8ccc63f045d5

2022-02-08 kramerb@google.com Avoid deprecated llvm::IRBuilder::CreateShuffleVector overload
2022-02-08 capn@google.com Unroll transcendentals benchmarks by 10x
2022-02-08 swiftshader.regress@gmail.com Regres: Update test lists @ e576ca60
2022-02-08 capn@google.com Remove Vulkan structure enum to integer casts

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: amaiorano@google.com
Change-Id: I2424df1eb78797f0e61beaf2277ea56140cf2a40
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79820
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-08 20:19:20 +00:00
Stephen White 25b3ed12e3 Enable the Tint/GLSL backend in the CMake build.
Don't build the Tint samples, because they require glslang.

Change-Id: I04ac6bb313fa8926bd161b91488d30c2c26ebb67
Bug: dawn:1217
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79660
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2022-02-08 15:32:00 +00:00
Dawn Autoroller 10e58e8a90 Roll ANGLE from 8b81742dd8d1 to 8622810c4fae (5 revisions)
8b81742dd8..8622810c4f

2022-02-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from ad6d7f84f2a1 to e576ca6011cd (19 revisions)
2022-02-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 26dacbf4b527 to 817a527fde8c (500 revisions)
2022-02-08 yuxinhu@google.com Add instructions to enable Debug Overlay On Android
2022-02-08 cnorthrop@google.com Tests: Add Dead Trigger 2 trace
2022-02-08 cnorthrop@google.com Test: Add Last Shelter: Survival trace

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: amaiorano@google.com
Change-Id: I449f267bf788c6c8980627b48532290a24b5475f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79780
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-08 14:11:41 +00:00
Dawn Autoroller 14c23850ac Roll SwiftShader from c9e8f23b0fb8 to e576ca6011cd (17 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/c9e8f23b0fb8..e576ca6011cd

2022-02-08 natsu@google.com Fix `WARNING: UNSUPPORTED:` warnings related to Android swapchain
2022-02-08 natsu@google.com Fix `WARNING: UNSUPPORTED: ... EXTERNAL_FORMAT_ANDROID` warnings
2022-02-07 capn@google.com Benchmark optimized SPIR-V transcendental instructions
2022-02-07 capn@google.com Copy Reactor transcendentals benchmarks to new PipelineBenchmarks
2022-02-07 capn@google.com Test building benchmarks with Kokoro
2022-02-07 swiftshader.regress@gmail.com Regres: Update test lists @ 45f7fdc3
2022-02-07 capn@google.com Ignore VK_STRUCTURE_TYPE_IMAGE_VIEW_MIN_LOD_CREATE_INFO_EXT usage
2022-02-07 capn@google.com Eliminate EmulatedIntrinsics
2022-02-07 capn@google.com Remove OptimalIntrinsics source and header
2022-02-07 capn@google.com Eliminate rr::Precision
2022-02-07 capn@google.com Use full-precision transcendental function implementations in Reactor
2022-02-07 capn@google.com Update dEQP-VK and Cherry usage documentation
2022-02-07 capn@google.com Use ShaderCore functions to implement GLSL.std.450 transcendentals
2022-02-07 capn@google.com Copy optimized transcendental intrinsics to ShaderCore
2022-02-07 dvet@google.com Add an option to control where ASM listings are dumped.
2022-02-07 capn@google.com Make the Reactor build target an alias
2022-02-07 swiftshader.regress@gmail.com Regres: Update test lists @ ad6d7f84

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: amaiorano@google.com
Change-Id: I292eaed7ebbdf99e1ddc447ebce185339e3465c8
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79723
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-08 06:35:50 +00:00
Dawn Autoroller f994c5637c Roll Tint from bf0180bcee to c6d8cadd33 (2 revisions)
https://dawn.googlesource.com/tint.git/+log/bf0180bcee90..c6d8cadd3300

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-dawn
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: amaiorano@google.com
Change-Id: I82a9ae1b476ea06ea956042f7b5ff6eb51ba4ae9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79722
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-08 03:28:43 +00:00