Commit Graph

128 Commits

Author SHA1 Message Date
Austin Eng 9087a5c28d Revert "Update WebGPU expectations.txt"
This reverts commit 8b7a83b85e.

Reason for revert: Failing Dawn->Chromium roll
https://chromium-review.googlesource.com/c/chromium/src/+/3911684/

Original change's description:
> Update WebGPU expectations.txt
>
> Bug: chromium:1344876, chromium:1359106, dawn:1250
> Change-Id: I80aedd357f3e067064bc0c7c73c83036cb5c3b4c
> Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103301
> Reviewed-by: Loko Kung <lokokung@google.com>
> Kokoro: Kokoro <noreply+kokoro@google.com>
> Commit-Queue: Austin Eng <enga@chromium.org>

TBR=enga@chromium.org,noreply+kokoro@google.com,dawn-scoped@luci-project-accounts.iam.gserviceaccount.com,lokokung@google.com

Change-Id: Ie41d2f43f9e6372b076acff9f0bbc28f18d673c3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1344876, chromium:1359106, dawn:1250
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103342
Commit-Queue: Austin Eng <enga@chromium.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
2022-09-21 23:46:35 +00:00
Austin Eng 8b7a83b85e Update WebGPU expectations.txt
Bug: chromium:1344876, chromium:1359106, dawn:1250
Change-Id: I80aedd357f3e067064bc0c7c73c83036cb5c3b4c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103301
Reviewed-by: Loko Kung <lokokung@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-09-21 21:30:35 +00:00
Zhaoming Jiang 849dff2ada Expectation: Clean up built-in constant evaluation and timestampWrites
This CL organizes the expectation of new added built-in constant
evaluation and timestampWrties test cases.

Bug: dawn:1250, tint:1613
Change-Id: I380129098873a543aeb72b1d4b8973ae92465c19
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102108
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Zhaoming Jiang <zhaoming.jiang@intel.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-21 14:49:14 +00:00
Ben Clayton 7fe75f4a68 expectations.txt: Remove inputSource="const" [ Skip ] expectations
The new heartbeat logic can now detect that these are just slow, and no longer trigger the timeout failures.

Fixed: tint:1613
Change-Id: I2e29b0e2b7002f29984841ed4f421ec6e47be83f
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102960
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-20 20:34:04 +00:00
Austin Eng 21920ec7f7 Remove most of the Slow test expectations
Change-Id: I31a1cedd36fd755aa226c3e03d3bdc81702f2653
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102821
Auto-Submit: Austin Eng <enga@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
2022-09-20 09:41:31 +00:00
Ben Clayton 4f8ed34b94 Roll third_party/webgpu-cts/ dec4d77ee..0fee76f32 (3 commits)
Update:
 - expectations.txt
 - ts_sources.txt
 - resource_files.txt
 - webtest .html files


dec4d77ee3..0fee76f32e
 - 0fee76 Overrides: add operation tests for compute pipeline (#1842)
 - 120c34 Add the buffer_dynamic_offsets test to setBindGroup.spec.ts (#1849)
 - fc6864 Add pipeline overridable constants validation tests (#1830)

Created with './tools/run cts roll'

Change-Id: I31e8afdfdb5fcfbf55682f69b67af1e2ca78d247
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102643
Auto-Submit: Ben Clayton <bclayton@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-19 15:00:01 +00:00
Ben Clayton aad2e9c0b5 tools/cts: Add `cts validate`, improvements & fixes
• Add `cts validate` command used to check for expectation collisions.
  Can be used as a presubmit check.
  This is more tightly checked than the previous logic, as this works on just
  the expectations, instead of results.

• Fix an issue where the test result reduction could introduce collisions with
  'Skip' expectations.
  To fix this, the update process first adds 'consumed' results for the skipped
  tests, preventing test tree reduction for that part of the tree.

• Fix a bug in the generation of 'New failures' and 'New flakes' which produced
  more expectations than was necessary.
  The issue here was that the tree roots could contain overlaps, and roots could
  be processed before sub-trees, resulting in inefficient expectations.

• Fix collisions in the expectations file, and update with results from
  the most recent roll.

Change-Id: I7b64553408998fb4416458ce564fc49c8f6d4d07
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101860
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-09-17 19:30:29 +00:00
Austin Eng 91fc1fd57e Roll third_party/webgpu-cts/ 5e70787c4..dec4d77ee (6 commits)
Update:
 - expectations.txt
 - ts_sources.txt
 - resource_files.txt
 - webtest .html files


5e70787c4d..dec4d77ee3
 - dec4d7 Implement `normalize` f32 tests (#1841)
 - 691143 not_lost_on_gc: use assertNotSettledWithinTime instead of raceWithRejectOnTimeout (#1844)
 - 087838 fix dev server for float16.js (#1843)
 - 372985 Add 'buffer,resource_binding_size' to createBindGroup.spec.ts (#1826)
 - 399c52 Add RENDER_ATTACHMENT usage in createBindGroup:multisampled_validation:* (#1839)
 - d33144 Fix f16 hex literal testcases of having suffix "h" without "p" (#1831)

Created with './tools/run cts roll'

Change-Id: Iaaf8882e9acfe7612c060cf1f81b2c4b52b9733c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102600
Commit-Queue: Austin Eng <enga@chromium.org>
Auto-Submit: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Shrek Shao <shrekshao@google.com>
Reviewed-by: Shrek Shao <shrekshao@google.com>
2022-09-16 20:37:58 +00:00
Austin Eng 505e1a9368 Revert "Make it invalid to use sampleType "float" with multisampled textures"
This reverts commit 9b2f273d36.

Reason for revert: Breaking change needs deprecation period.

Original change's description:
> Make it invalid to use sampleType "float" with multisampled textures
>
> Fixed: dawn:1540
> Change-Id: I31f197d802c20ed7e6ef2ae00d4e107ab6f94278
> Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102420
> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
> Kokoro: Kokoro <noreply+kokoro@google.com>
> Commit-Queue: Austin Eng <enga@chromium.org>

TBR=cwallez@chromium.org,enga@chromium.org,shrekshao@google.com,noreply+kokoro@google.com,dawn-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I5ac4b5691b0c4fb0ce76223c1997855e1b3485f3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102500
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
2022-09-16 01:14:28 +00:00
Jiawei Shao 233d64066c Make the validation on inter-stage shader variables match latest WebGPU SPEC
This patch updates the validations on the inter-stage shader variables to
match the latest WebGPU SPEC (in chapter "validating-inter-stage-interfaces").

With this patch the below validation tests in WebGPU CTS will pass:
- render_pipeline,inter_stage:max_shader_variable_location:*
- render_pipeline,inter_stage:max_components_count,*

Fixed: dawn:1448
Test: dawn_unittests
Change-Id: I3e4d98f03ec18e5d1642a4d7ecd3eed1b7ae04d0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102104
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-16 00:30:38 +00:00
Austin Eng 9b2f273d36 Make it invalid to use sampleType "float" with multisampled textures
Fixed: dawn:1540
Change-Id: I31f197d802c20ed7e6ef2ae00d4e107ab6f94278
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102420
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-09-15 23:03:38 +00:00
Jiawei Shao ee1996ba9e Enable validation tests about createBindGroupLayout:storage_texture,*
This patch enables the below validation tests in WebGPU CTS after a
fix in chromium:

- webgpu:api,validation,createBindGroupLayout:storage_texture,*
- webgpu:api,validation,createBindGroupLayout:visibility,
  VERTEX_shader_stage_storage_texture_access:*

Fixed: chromium:1363484
Change-Id: If23dc242f0c38dec4e11de0fd8434ab32e0822f9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102341
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2022-09-15 14:07:49 +00:00
Austin Eng e2bdb5edd7 Update CTS docs
Update with additional argument docs, and docs on uploading builds
to Swarming. I've found this particularly useful lately.

Bug: none
Change-Id: Iee04043b7260c505d4d63025c4038e3eb50db338
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102106
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2022-09-14 17:13:17 +00:00
Austin Eng a659937918 Roll third_party/webgpu-cts/ a6451cc67..5e70787c4 (7 commits)
Update:
 - expectations.txt
 - ts_sources.txt
 - resource_files.txt
 - webtest .html files

a6451cc673..5e70787c4d
 - 5e7078 Add global option noRaceWithRejectOnTimeout (#1836)
 - cf51bc Add a 'storage_texture,format' test to createBindGroup.spec.ts (#1829)
 - 446c22 Fix type error when trying to .writeBuffer a Float16Array (#1833)
 - a0408e shader/execution: Add heartbeats to expression tests
 - 3c579b Add `length` F32 tests (#1815)
 - fee036 Make `make*ToF32IntervalCase`s more idiomatic (#1816)
 - a20c0a Implement `quantizeToF16` f32 tests (#1828)

Created with './tools/run cts roll'

Change-Id: I98bb79ac57585a5b57d3e4303bd7a2c4ca576598
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102150
Auto-Submit: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-09-14 16:01:37 +00:00
Yan,Shaobo 876bd3bf87 Enable external_texture/* cts
Change-Id: Ieb153292c78ea8197b4309d796d352ce820646d1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/99241
Commit-Queue: Shaobo Yan <shaobo.yan@intel.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-09-14 01:09:42 +00:00
Austin Eng e0cbb0cfe9 CTS: set noRaceWithRejectOnTimeout
Following https://github.com/gpuweb/cts/pull/1836, this will let Chrome's
CTS runner bypass the builtin CTS timeouts in favor of our own harness
timeouts.

Bug: chromium:1340602
Change-Id: I09f25de26f28f4595c6d277050f2a71969566fdb
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102200
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-09-13 22:16:42 +00:00
Austin Eng 26ffcd1768 CTS: Allow sync code to interrupt and cancel a scheduled heartbeat
Bug: chromium:1340602
Change-Id: Id6f8d58bd283c8232af533cf2a0fe74adb704336
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102180
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-13 18:28:31 +00:00
Austin Eng ddc53ea856 Update expectations in preparation for removing --retry-limit=3
Ensure that all actually known flaky tests are marked RetryOnFailure.
Generated with some manual changes, then `./tools/run cts update`
pointing at the Chromium CL to disable retries.

Bug: chromium:1343969, chromium:1344876, chromium:1359106, dawn:1500
Change-Id: Ia92a83e55bd64f39ecd8ff1be194dca95febd9bb
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101801
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-09-09 22:37:19 +00:00
Ben Clayton 1524d9e1bf Roll third_party/webgpu-cts/ 27dc745ca..a6451cc67 (19 commits)
Update:
 - expectations.txt
 - ts_sources.txt
 - resource_files.txt
 - webtest .html files


27dc745ca1..a6451cc673
 - a6451c Update 'buffer,usage' test in createBindGroup.spec.ts (#1824)
 - 0007e6 Add 'buffer,resource_offset' to createBindGroup.spec.ts (#1825)
 - a40f43 shader/execution: Fix shader creation errors (#1827)
 - 25c9f4 Add 'buffer,usage' test to createBindGroup.spec.ts (#1820)
 - 888ada slightly broaden/simplify pipeline_output_targets (#1823)
 - 708441 test ~all cases of pipeline_output_targets,blend (#1822)
 - 399cd2 Fix a wrong bit operation to decide the validation in indirect_dispatch_buffer,usage (#1819)
 - 73c9e8 Add storage_texture,mip_level_count test to createBindGroup.spec.ts (#1818)
 - 65fdb8 Minor clean up in life_of.md (#1608)
 - e53aff Add storage_texture,usage test to createVindGroup.spec.ts (#1813)
 - 39f597 Add `smoothstep` F32 Tests (#1811)
 - e97d14 Add tests to fullI32Range (#1792)
 - 7c4e02 Remove old implementation of correctlyRounded (#1796)
 - e93c41 Add 'multisampled_validation' test to createBindGroup.spec.ts (#1810)
 - cc7a40 Use trackForCleanup() for dst texture in copyToTexture cases (#1809)
 - 3c353f Adds remaining adapter.requestDevice tests. (#1798)
 - fd9cf4 Implement 'texture_buffer_usage' test to buffer_texture_copies.spec.ts (#1807)
 - f7f601 Add RENDER_ATTACHMENT usage when creating multisampled textures (#1806)
 - 63c716 Add 'texture_buffer_usage' test to buffer_texture_copies.spec.ts (#1803)

Created with './tools/run cts roll'

Change-Id: I608a519f30d75d18efd9edb6b1ece61e856ac2f5
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101681
Auto-Submit: Ben Clayton <bclayton@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-09-09 16:14:19 +00:00
Corentin Wallez aa93cb8d5a Suppress tests failing to due VVL error on depthStencilReadOnly
Bug: dawn:1512
Change-Id: Id0b281735604dbb226893d05879af5417e15a672
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101120
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-09-08 17:23:46 +00:00
Ben Clayton d7f9836a30 cts: Remove collisions in expectations.txt
Change-Id: I854c975650ec471466467fe47797242016f81f1f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101580
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-09-08 01:09:04 +00:00
Austin Eng 183c87e4f6 Mark error scope stackDepth=100000 tests as slow
These tests regularly take 7+ seconds to complete due to their size

Change-Id: I5ee554610275ed68f4eab7a821c4278a2c478595
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100820
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-08-31 03:25:18 +00:00
Loko Kung 79334fedce Manual cleanup of CTS expectations.
Change-Id: I4ce31d6cadd4506385d39b4754347fa4838ea757
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100501
Auto-Submit: Loko Kung <lokokung@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-08-27 04:27:18 +00:00
Austin Eng b00c50edc6 CTS: Hook into CTS heartbeat mechanism instead of wrapping TestCaseRecorder
Bug: chromium:1340602
Change-Id: I6272432c69c65fa45cbae9bedc02aec82ba68c8a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100561
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2022-08-26 22:34:27 +00:00
Austin Eng a993e1913e Roll third_party/webgpu-cts/ c0c5cce30..27dc745ca (20 commits)
c0c5cce305..27dc745ca1

$ git log c0c5cce30..27dc745ca --date=short --no-merges --format='%ad %ae %s'
2022-08-26 gyuyoung Add sample_count test to buffer_texture_copies.spec.ts (#1800)
2022-08-26 gyuyoung Implement 'texture,device_mismatch' test in writeTexture.spec.ts (#1793)
2022-08-26 gyuyoung Add 'maximum_binding_limit' test to createBindGroupLayout.spec.ts (#1790)
2022-08-25 enga Add global test config (#1801)
2022-08-25 enga Mark root .eslintrc.json as "root: true" (#1802)
2022-08-25 bajones Address Kai's feedback
2022-08-24 tojiro Style fixes
2022-08-24 tojiro Refactor image_copy and unified data generator between the two test files.
2022-08-23 bajones Optimizing GetInitialData function
2022-08-25 kainino fix merge error
2022-08-25 rharrison Clarify comments in ULP code (#1795)
2022-08-23 kainino tweak to make safer against accidental awaits
2022-08-23 bclayton webgpu/shader/execution: Check validation before testing results
2022-08-24 rharrison Linearly spread `f32FullRange` values over possible f32 values (#1786)
2022-08-24 rharrison Implement `remainder (%)` f32 test (#1765)
2022-08-24 rharrison Rename `make*F32IntervalCase` to `make*ToF32IntervalCase` (#1775)
2022-08-24 zhaoming.jiang Revert "Use let declarations for literal input in shader,execution,expression tests (#1788)" (#1789)
2022-08-24 zhaoming.jiang Use let declarations for literal input in shader,execution,expression tests (#1788)
2022-08-24 gyuyoung Add storage_texture,formats test to createBindGroupLayout.spec.ts (#1776)
2022-08-23 rharrison Refactor binary arithmetic tests to use common test values (#1783)

Change-Id: I75a810698616f74d02480ccee369564030aa4a32
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100462
Auto-Submit: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Loko Kung <lokokung@google.com>
2022-08-26 19:48:25 +00:00
Ben Clayton 98d7eb4009 Roll third_party/webgpu-cts/ e204a3c37..c0c5cce30 (7 commits)
Update:
 - expectations.txt
 - ts_sources.txt
 - resource_files.txt
 - webtest .html files


e204a3c377..c0c5cce305
 - c0c5cc Remove pushing lists of numbers through Set to guarantee uniqueness (#1779)
 - 3d958d wgsl: Replace module-scope 'let' with 'const' (#1721)
 - 4827c0 Add storage_texture,layout_dimension test to createBindGroupLayout.spec.ts (#1772)
 - dcdeec Add visibility,VERTEX_shader_stage_storage_texture_access test to createBindGroupLayout.spec.ts (#1770)
 - f4db91 Make F32Interval unittests more idiomatic (#1773)
 - d82d4e Updates error scope tests and remove outdated README. (#1766)
 - f102e6 Add brackets to robust buffer access test.

Created with './tools/run cts roll'

Change-Id: Ib5ca02d41a7638c06361e8e33b23f1ceb32db884
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100200
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
2022-08-24 15:24:45 +00:00
Ben Clayton bace05e499 Roll third_party/webgpu-cts/ ed11c6ba3..e204a3c37 (24 commits)
Update:
 - expectations.txt
 - ts_sources.txt
 - resource_files.txt
 - webtest .html files


ed11c6ba35..e204a3c377
 - e204a3 Add visibility,VERTEX_shader_stage_buffer_type test to createBindGroupLayout.spec.ts (#1767)
 - 2d7291 Change sourceOrigin in GPUImageCopyTexture from 3D to 2D (#1768)
 - fef5f1 Fix f16 and u32 testcases in webgpu:shader,validation,parse,literal:* (#1769)
 - 32bacf Add timestamp_query_set,device_mismatch test to beginRenderPass tests (#1761)
 - c48887 Add _mimeType for input videos in external_texture cases (#1759)
 - 8bd50a Use common `sparseF32Range` instead of defining it multiple different places (#1754)
 - 4e8df0 Add timestamp_query_set,device_mismatch test to beginComputePass tests (#1760)
 - 168bc9 Refactor *SubnormalNumber functions to not depends on *SubnormalScalar functions (#1755)
 - 581498 Implementing dot f32 tests (#1748)
 - 30e9e0 Add indirect_dispatch_buffer,usage validation test (#1756)
 - dd0150 Update compositingAlphaMode -> alphaMode (#1667)
 - 8a9afc Add a query_set_type test to beginComputePass tests (#1751)
 - 19aecd Track all the resources with trackForCleanup in copy and resource ini… (#1753)
 - 147d16 Add more texture usages to image_copy,texture_related:usage test (#1742)
 - 78ba78 Add beginComputePass validation test (#1744)
 - 2fe73f Implement `asinh` f32 tests (#1746)
 - 727a39 Implement `atanh` f32 tests (#1741)
 - e1795b Implement `acosh` f32 tests (#1737)
 - 583eaa Implementat `tanh` f32 tests (#1736)
 - b36ce1 Use containerss for alternate interval generators (#1740)
 - 242105 Update val:CopyExternalImageToTexture:OOB,source (#1739)
 - 40e52d upgrade typescript to 4.7.4 (#1713)
 - 2c9134 Implement GPURenderPassDescriptor.maxDrawCount test (#1693)
 - 05b229 Add 'VideoFrame' in 'SourceType' for external_texture cts (#1733)

Created with './tools/run cts roll'

Change-Id: Ib8bb7e412fd597ed7d56c493b40a227223f23765
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100040
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
2022-08-23 13:32:24 +00:00
Austin Eng 9de123fc85 Suppress Win Intel x86 tests failing after parallelization disabled
These tests used to be flaky, and now fail consistently after jobs
is set to 1 instead of 4. Suppressing so parallelization can be
disabled to make test results more consistent.

Bug: chromium:1353938
Change-Id: Ia99445ddd43d55d7ac3f67dd8e177b0fd34d51f3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/99762
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
2022-08-19 05:36:21 +00:00
Austin Eng caa9baed54 Send test heartbeats from the CTS runner
Heartbeats are rate-limited to 1 every 500ms.
They are sent at the following checkpoints:
 - Before a log is recorded in TestCaseRecorder
 - Just before an async WebGPU operation
 - Immediately following completion of a async WebGPU op
 - After a then/catch handler waiting on an async WebGPU op

Bug: chromium:1340602
Change-Id: I4d5c864dabd3f4215dac2e78d7658df0f6a7b0b7
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/99360
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-18 22:49:10 +00:00
Brian Sheedy ced4c0d2cd Add test list to deps
Adds the generated CTS test list to the existing gn/webgpu-cts group
so that Chromium tests properly include the generated file.

Also updates some existing BUILD.gn file paths to be consistent with
Chromium styling: relative paths without the leading ./ for files
under the current directory and directories before and separate from
individual files.

Bug: dawn:1479
Change-Id: Icce70e7fcee874b6b33c21230c8a4429a1f7ab6c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98801
Commit-Queue: Austin Eng <enga@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-08-11 15:16:38 +00:00
Brian Sheedy 0653501212 Switch to message protocol
Switches the WebGPU CTS test runner JavaScript code to use the defined
message protocol instead of the ad-hoc solution we were using before.

Bug: chromium:1340602
Change-Id: Ieaf26b5b2409f69d7859d3db4ce7757780de6712
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98684
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@google.com>
2022-08-11 14:39:51 +00:00
Loko Kung 8812809ea7 Roll third_party/webgpu-cts/ 94fd83896..ed11c6ba3 (3 commits)
Update:
 - expectations.txt
 - ts_sources.txt
 - resource_files.txt
 - webtest .html files

94fd83896c..ed11c6ba35
 - ed11c6 Implement `cosh` f32 tests (#1735)
 - 3fac1b Implement `sinh` f32 tests (#1734)
 - d36896 Implement `sqrt` f32 tests (#1732)

Created with './tools/run cts roll'

Change-Id: I6604dc66ea7d7d43fb441f3f0092e7afd746266f
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98360
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Loko Kung <lokokung@google.com>
2022-08-09 18:29:22 +00:00
Loko Kung eaca2ebd4c Update cts expectations to be sorted by bug first.
- Run format on the current expectations file to make it up to date.
- It's a lot easier to read the failures when they are grouped by the bug.

Change-Id: I333a0b237ccd405d204e47809eb7ab723824fddd
No-Try: True
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98241
Auto-Submit: Loko Kung <lokokung@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Loko Kung <lokokung@google.com>
2022-08-09 16:40:32 +00:00
Alexis Hetu c8f03f9f99 Remove unused "swiftshader-gl" tag
This is a follow-up of the chromium side cleanup here:
https://chromium-review.googlesource.com/c/chromium/src/+/3799192

Bug: chromium:1099959
Change-Id: I6cd442d8512afe6b845c1f1e6d06406ed27d61db
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98261
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2022-08-07 11:21:00 +00:00
Austin Eng c20fa4eae5 Triage some entries in expectations.txt
Change-Id: I51db1f499db3037a0ff572434efd141610dd0542
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98066
Commit-Queue: Austin Eng <enga@chromium.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
2022-08-04 03:39:07 +00:00
Loko Kung e40bd8e964 Suppresses failing CTS tests for tint:1632
Bug: tint:1632
Change-Id: Ic21ce0e401a4af2f7b3aebc6d1823fad7e3b9643
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/98067
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Loko Kung <lokokung@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-08-03 22:06:36 +00:00
Li Hao e37f0a1943 cts: Use intel-gen-9 instead of intel-hd-630-family tag
There are many devices in Intel HD630 family, we cannot enumerate all
their device ids in the tag. We want cts to run as expected on other
Intel devices of the same architecture, add generation-based tag
intel-gen-9 to include a broad range of devices in the expectations.

Bug: dawn:1444
Change-Id: I80b6ae64ea2efc41bcc68e1c917919a86ec87f44
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/97760
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-08-02 17:32:44 +00:00
Loko Kung cbadf96e79 Roll third_party/webgpu-cts/ 65130c197..94fd83896 (9 commits)
Update:
 - expectations.txt
 - ts_sources.txt
 - resource_files.txt
 - webtest .html files


65130c1970..94fd83896c
 - 94fd83 Expand readbackFromWebGPUCanvas test with alphaMode (#1673)
 - 7af1f6 Implement `mix` f32 tests (#1719)
 - 3fefce Validate a shader without an entry point is valid. (#1729)
 - 3dc2fe Add non-entrypoint tests to the builtin validation. (#1728)
 - 573361 Add test to validate parsing of `@builtin` (#1726)
 - c660f5 Trailing comma in `@align` should be valid. (#1727)
 - d1c579 Add test to allow builtin values as identifiers (#1725)
 - bab564 Implement `trunc` f32 tests (#1724)
 - 8fd9d5 Add `frag_depth` builtin validation. (#1723)

Created with './tools/run cts roll'

Change-Id: I55c38e9b2b32f6fdebd3d7d9fc5d29ef8f8054ee
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/97862
Commit-Queue: Loko Kung <lokokung@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-02 00:49:14 +00:00
Ben Clayton 271ba0edb3 Roll third_party/webgpu-cts/ e88fcf99d..65130c197 (8 commits)
Update:
 - expectations.txt
 - ts_sources.txt
 - resource_files.txt
 - webtest .html files


e88fcf99da..65130c1970
 - 65130c shader/execution: Optimize "const" shader exeuction
 - c8964b Implement `round` f32 tests (#1718)
 - 62ea12 Implement `step` f32 tests (#1717)
 - f2ab44 Implement `sign` f32 tests (#1701)
 - 8fed55 Implement `saturate` f32 tests (#1700)
 - 0eee5f Implement f32 `radians` tests (#1676)
 - a37fad Add WebCodec VideoFrame as input source for GPUExternalTexture cases (#1711)
 - 41f838 Add validation tests for @align. (#1664)

Created with './tools/run cts roll'

Change-Id: I3d16fefab8f70e858284792fb127a8e4ea673363
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/97580
Reviewed-by: Austin Eng <enga@chromium.org>
Auto-Submit: Ben Clayton <bclayton@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-07-28 19:43:01 +00:00
Brian Sheedy 2aea0e957f Add type to CTS runner message
Adds the "type" field to the websocket message sent
by the CTS JavaScript code with a value of
"TEST_FINISHED". This is in preparation for the
switch to using a heartbeat system for test timeouts
instead of a fixed timeout.

Bug: chromium:1340602
Change-Id: I886d89dbdfb1e3946dd8c59ecf23f9b18385b65e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/97280
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@google.com>
Auto-Submit: Brian Sheedy <bsheedy@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-07-27 01:04:35 +00:00
Yuly Novikov 7e33dcba5b Remove Linux Intel suppressions fixed in Mesa 20.0.8
Bug: dawn:1111, dawn:1050
Change-Id: If3036921655abca967ed2793b03982dfb1b815b0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/97100
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-07-25 17:04:28 +00:00
Ben Clayton f122fd52a8 Roll third_party/webgpu-cts/ 72e3a2249..e88fcf99d (3 commits)
Update:
 - expectations.txt
 - ts_sources.txt
 - resource_files.txt
 - webtest .html files


72e3a22491..e88fcf99da
 - e88fcf Implement val:queue,writeTexture:sample_count (#1703)
 - 75268b Implement val:queue,writeTexture:texture_state (#1702)
 - c4eb1d Fix testing of the offset in image_copy,layout_related:required_bytes_in_copy (#1704)

Created with './tools/run cts roll'

Change-Id: Ic1986bfac317aabfb623213bbc84dc3c38cd9a2a
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/97001
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-07-23 00:21:26 +00:00
Yuly Novikov 9ec7893ad4 Follow up on Roll third_party/webgpu-cts/ a41bc407a..72e3a2249
1. Restore Optiplex 7080 Linux in the suppressions removed in
   https://dawn-review.googlesource.com/c/dawn/+/96880
2. Generalize depth_clip_clamp suppressions, since other combinations
   fail on Intel UHD 630 bot, see:
https://luci-milo.appspot.com/ui/p/chromium/builders/ci/Dawn%20Linux%20x64%20Release%20(Intel%20UHD%20630)/764/overview

Change-Id: Ia88d2c9903180db7c5ce7d6b366cfc6e6b2135d0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/97000
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-07-22 15:55:56 +00:00
Kai Ninomiya 5f5bd214f7 Roll third_party/webgpu-cts/ a41bc407a..72e3a2249 (15 commits)
Update:
 - expectations.txt
 - ts_sources.txt
 - resource_files.txt
 - webtest .html files


a41bc407a8..72e3a22491
 - 72e3a2 Expand map_detach test for buffer should detach on device.destroy (#1699)
 - d5e662 Enhance val:render_pass_descriptor:depth_stencil_attachment_depth_clear_value (#1674)
 - 12b775 Implement val:CopyExternalImageToTexture,destination_texture,dimension (#1695)
 - 2834ce Add an out-of-range check to the ranges test in writeBuffer.spec.ts (#1663)
 - bee493 Implement val:queue:writeTexture:usage (#1675)
 - ea0057 Add GPURenderPassDescriptor.maxDrawCount test plan (#1614)
 - d30940 Generate full range of `atan2` cases (#1679)
 - 5b9641 Correct the order of params in atan2 message (#1677)
 - 228c28 Implement f32 `degrees` tests (#1668)
 - 4786c2 Remove obsolete f32 testing infrastructure (#1665)
 - 8e1167 Add f32 tests for `pow` (#1658)
 - aa0719 Make `render_pass_descriptor:resolveTarget,usage` test a valid case together (#1660)
 - 6dfee4 Submit all shader batches before checking for results
 - bbd744 Convert `ldexp` tests to use interval framework (#1659)
 - 9d3043 Update f32 tests to handle returning undefined for infinity (#1655)

Created with './tools/run cts roll'

Change-Id: Ibdf6a28ea84e2115103c9c9637b3e648a62b8364
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/96880
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-07-22 01:13:15 +00:00
Austin Eng 8d73198aca Remove depth-clamping and add depth-clip-control feature
Fixed: dawn:1178
Change-Id: I251a7e05fec9ecef44300d4f948b2d0611888109
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/96320
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-07-18 20:38:05 +00:00
Yuly Novikov cd74244614 Follow up on Roll third_party/webgpu-cts/ 8cfc317e2..a41bc407a
Include Optiplex 7080 Linux in the suppressions added in
https://dawn-review.googlesource.com/c/dawn/+/96200

Change-Id: I8f99da7e6e42b675b40e200f0c668e638e2238f2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/96402
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-07-18 14:06:42 +00:00
Austin Eng 30d672963c Skip CTS tests crashing with SwiftShader
Some web_platform:* tests are crashing due to issues with SharedImage
and canvas formats.

Bug: chromium:1344876
Change-Id: I0a708bad15b3d19299ce614ad43ab58c888e5291
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/96300
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
2022-07-15 19:12:29 +00:00
Ben Clayton e21267fe94 Roll third_party/webgpu-cts/ 8cfc317e2..a41bc407a (23 commits)
Update:
 - expectations.txt
 - ts_sources.txt
 - resource_files.txt
 - webtest .html files


8cfc317e23..a41bc407a8
 - a41bc4 Implement val:render_pass_descriptor:timestampWrite,same_query_index (#1656)
 - 167076 Implement val:render_pass_descriptor:timestamp_writes_query_set_type (#1653)
 - 06954d Implement val:render_pass_descriptor:timestampWrite,query_index (#1654)
 - deec4f Implement val:render_pass_descriptor:occlusion_query_set_type (#1652)
 - 3bef26 Succinct the test names of render_pass_descriptor.spec.ts (3/3) (#1651)
 - 425fc8 Convert `clamp` f32 tests to use interval framework (#1645)
 - 46fce2 Add support for multiple intervals to FP testing framework (#1643)
 - 09c7fb Address feedback from Kai
 - f803ff Add context configuration tests
 - d620a1 Address feedback from Kai
 - 77633d Add tests for getCurrentTexture and getPreferredCanvasFormat
 - 781ad8 Succinct the test names of render_pass_descriptor.spec.ts (2/n) (#1639)
 - d7ca02 Implement val:render_pass_descriptor:timestamp_writes_location (#1630)
 - 09793f Test zero levels or layers is invalid in render_pass,resolve:resolve_attachment (#1600)
 - daf0da Split shader_stages_and_visibility and add control cases
 - 496182 Rewrite usage validation scope tests
 - f4e9a3 refactor: split out makeConflictingBindGroups from testValidationScope
 - bc278d nits: simplify a few things in this file
 - a65914 Implement val:render_pass_descriptor:depth_stencil_attachment_depth_clear_value (#1640)
 - a6bab7 Implement api,validation,capability_checks,features,texture_formats:canvas_configuration_view_formats (#1593)
 - e7f8fe Succinct the test names of render_pass_descriptor.spec.ts (1/n) (#1619)
 - 7f3683 Convert `fract` tests to use interval framework (#1612)
 - d8009f Correct logInterval & log2Interval handling of out of bounds inputs (#1629)

Created with './tools/run cts roll'

Change-Id: I10d895c4a11252317619f7ea480c97d821cbf81c
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/96200
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Auto-Submit: Ben Clayton <bclayton@google.com>
2022-07-15 16:25:39 +00:00
Ben Clayton e1bcb0b416 cts: Clean up expectations.txt
• Add `intel-hd-630-family` to the list of GPU tags (crbug.com/dawn/1444).
• `[ Skip ]` all the `inputSource="const"` expression tests for now (crbug.com/tint/1613).
• Reorder / normalize the rest of the expectations with `./tools/run cts update`.

Bug: dawn:1444
Bug: tint:1613
Change-Id: I39efc454ecff6e804417bcade744a4251acbda07
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95842
Reviewed-by: Austin Eng <enga@chromium.org>
Auto-Submit: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-07-14 09:54:11 +00:00
Yuly Novikov 9fecd7ef8a Suppress WebGPU CTS failures on Linux UHD630
webgpu:shader,execution,expression,call,builtin,abs:f32:inputSource="const";*
webgpu:shader,execution,expression,call,builtin,atan:f32:inputSource="const";*
webgpu:shader,execution,expression,call,builtin,clamp:f32:inputSource="const";*

Bug: tint:1612
Change-Id: I3151cb02142f4a7b38d1f419bd5c49e981dce3a3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/96103
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-07-13 18:49:10 +00:00