Commit Graph

11865 Commits

Author SHA1 Message Date
Ben Clayton e3f3de773a tint/resolver: Fix const-eval Equal()
It was not considering structures, and the default clause was happily assuming two std::monostates (no-value) were equal.
This lead to non-deterministic behaviour as the Hash() would sometimes match and sometimes not.

Change-Id: Idf01a9e0e4ac09d5eaf683b62fcadd1714dc5849
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113981
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-12-13 14:56:25 +00:00
Ben Clayton 61dbeb5b72 tools/cts: Handle CRLF in expectations.txt
Change-Id: Iccc9f0b4c488a93a3014bd1d2415b42b05c01553
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/114000
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
2022-12-13 14:55:50 +00:00
Ben Clayton f2b86aaffb tint: Add hash randomization
Enable this in Kororo builds to ensure that output isn't dependent on
hash values.

Change-Id: Ib538385b53bebf5260186b14cea396dac15caf6c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113980
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-12-13 14:46:02 +00:00
dan sinclair 10182c46d9 Move sem::Constant to constant::Constant
This CL splits the base constant code out of sem into their own folder.
This will allow re-using the constants in the IR. The concrete
implementations from the resolver will move in followup CLs.

Bug: tint:1718
Change-Id: Ic370db76dce34e3e6eca56a9c2a8df607492b4a6
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113802
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-12-13 14:17:50 +00:00
Dawn Autoroller 28483ef6dc Roll ANGLE from f3ebb2ca4123 to f8720bdb9e11 (5 revisions)
f3ebb2ca41..f8720bdb9e

2022-12-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 8b5ea902f8d4 to 66d1f426b724 (5 revisions)
2022-12-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 1c9a08119fdd to 438de6cec0a1 (605 revisions)
2022-12-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from d90c76e77622 to 9f4465eccb37 (6 revisions)
2022-12-13 cclao@google.com Vulkan: Clean up Resource class
2022-12-12 syoussefi@chromium.org Vulkan: Keep referenced pipeline libraries alive

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC bclayton@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: bclayton@google.com
Change-Id: Ibe7c9013393c3932e945c62c9c8d15db83be292c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113942
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-12-13 13:35:57 +00:00
Ben Clayton 60dc70df71 tools run-cts: Add --coverage flag
Displays a per-test coverage viewer in your browser

Change-Id: I0b808bfadf01dab0540143760580cd7ca680e93b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113644
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
2022-12-13 09:34:24 +00:00
dawn-autoroll 8ac417c39c Roll vulkan-deps from cab5276e492f to 66d1f426b724 (3 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/cab5276e492f..66d1f426b724

Changed dependencies:
* vulkan-loader: b43758588b..96488e2b2e
* vulkan-validation-layers: 46f343d060..e7a0c9bc0d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC bclayton@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: bclayton@google.com
Change-Id: I497620a4877de2ee2407fbd04f49d08ac5a07d0f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113941
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-12-13 09:17:55 +00:00
Dawn Autoroller 0cf2ef767b Roll SwiftShader from 9bfd96203d19 to 4a769cd69867 (5 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/9bfd96203d19..4a769cd69867

2022-12-13 swiftshader.regress@gmail.com Regres: Update test lists @ 29dc5eb3
2022-12-12 syoussefi@google.com Implement VK_KHR_surface/swapchain_maintenance1
2022-12-12 sugoi@google.com Float only writeColor
2022-12-12 syoussefi@google.com Update Vulkan headers to version 1.3.225
2022-12-12 sugoi@google.com Merge changes I6664b301,Iccccf7fd,I44bfc249,Ibd600b7e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC bclayton@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: bclayton@google.com
Change-Id: I19309df9d930d2ec611e2673dd00a3bf891f1732
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113920
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-12-13 05:31:10 +00:00
Dawn Autoroller c7039f1da8 Roll ANGLE from b1b4640104fc to f3ebb2ca4123 (8 revisions)
b1b4640104..f3ebb2ca41

2022-12-12 cclao@google.com Vulkan: Better mUse tracking for DynamicallyGrowingPool<Pool>
2022-12-12 abdolrashidi@google.com Fix the input arg after the trace_tests change
2022-12-12 abdolrashidi@google.com Vulkan: Add shared ring buffer cmd alloc feature
2022-12-12 romanl@google.com Re-enable dEQP-EGL.functional.resize.surface_size on Linux.
2022-12-12 ynovikov@chromium.org Skip DrawElementsIndexOutOfRangeWithDynamicDraw on Win Intel
2022-12-12 ynovikov@chromium.org More PixelLocalStorage skips on iOS
2022-12-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 89b9b4762b94 to 8b5ea902f8d4 (14 revisions)
2022-12-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 6ebc3347af9d to 36e043fa6d46 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC bclayton@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: bclayton@google.com
Change-Id: I0ef4e2d1d251909c184c8fddbfdca50be3a14c77
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113840
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-12-13 00:07:28 +00:00
Ben Clayton 61b5aaccf3 tools: Move idlgen and run-cts to from dawn/node to tools/
This is the standard place for tooling.

Update src/dawn/node/README.md with the new paths, and drop inferred
arguments from the examples.

Change-Id: Ib944ca045366b81b8897d9548112a8889e097769
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113643
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-12-12 23:06:43 +00:00
Ben Clayton f8e0aac2a6 tools: Port 'cov' package from SwiftShader
A library for dealing with coverage information, and compressing CTS test information down into something that can be easily downloaded and visualized in a web page

Change-Id: If025e1555665609f7c963bad14c9c91d8324a390
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113642
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
2022-12-12 21:49:02 +00:00
dan sinclair f6d95d3244 Rename TypeFlags and TypeFlag.
This CL updates TypeFlags and TypeFlag to drop the Type prefix.

Bug: tint:1718
Change-Id: Ia197c867e39102582ba3314b7b3f24d8bec89712
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113801
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
2022-12-12 21:26:23 +00:00
Ben Clayton f927bcb5a6 tools: Port turbo-cov from SwiftShader
A tiny utility that emits just the per segment coverage in a binary stream. This avoids the overhead of encoding to JSON, which provides substantial performance improvements.

Change-Id: I36a588069d69c5c800d31bca8dd5c542bcdbe313
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113641
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-12-12 21:21:54 +00:00
Loko Kung e70563ac03 Implements maxColorAttachmentBytesPerSample
- Adds the limit
- Adds relevant format-specific data into format table
- Adds deprecation validations regarding the limit
- Adds deprecation validation unit tests and helpful utils
- Moves deprecated api tests from end2end to unittests, allowing tests
  to be cross-files for ease after deprecation.
- Updates some validation messages to include helpful contexts.

Bug: dawn:1522
Change-Id: Ib05f9adb60808ff4d68061d9646e76c729a23643
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113543
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Loko Kung <lokokung@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2022-12-12 20:55:05 +00:00
dan sinclair 28a7827981 Rename type Base methods
This CL renames StructBase and StructMemberBase to drop the Base suffix
now that the move is complete.

Bug: tint:1718
Change-Id: If8126e4993c58bb2de475c2b18695705082a0a92
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113800
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
2022-12-12 20:51:44 +00:00
dawn-autoroll ac146b1a48 Roll vulkan-deps from 4513d3d91ac3 to cab5276e492f (4 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/4513d3d91ac3..cab5276e492f

Changed dependencies:
* glslang: 6d8b00b1c6..c6b3f279a7
* spirv-headers: 1d31a10040..70ff9d939c
* spirv-tools: 9c6a925c87..43c99b5ee0
* vulkan-validation-layers: 7140eba938..46f343d060

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC bclayton@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: bclayton@google.com
Change-Id: I5d61427f6779cbddb9e7e897816ffe0cb11157cc
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113780
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-12-12 20:20:01 +00:00
Jiawei Shao cc6a6faa98 Enable api,operation,buffers,map_oom:mapAsync:oom=true;* on 32-bit CPU
Bug: chromium:1377204, dawn:1586
Change-Id: Idc18d305767524ffbd45f748d6ea427f006b5dc9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113600
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-12-12 18:46:55 +00:00
Li, Hao ad57a58488 Add suppressed end2end tests back on Intel Windows Vulkan
Vulkan backend had been disabled on Intel Windows Vulkan driver <
30.0.101.2111, these suppressed end2end tests are fixed on that version
and later, we can remove the suppression.

Bug: dawn:1392, dawn:819, dawn:1172, dawn:1489
Change-Id: I91a8dfac833b068e8e3bb70d9f9af977f7b6026c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113610
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-12-12 17:10:40 +00:00
Yan,Shaobo 6bd13328fb Enable copyToTexture cases on linux
Disable GPU uploading path on linux ensure it hit on fallback CPU
uploading path. Test cases should work on that path.

Bug: chromium:1309194
Change-Id: Ic50314e780f287569cccfdbb3503c8c3df10f532
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112000
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-12-12 17:10:06 +00:00
Dawn Autoroller b6df89147a Roll SwiftShader from 36e043fa6d46 to 9bfd96203d19 (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/36e043fa6d46..9bfd96203d19

2022-12-12 sugoi@google.com Fix Kokoro presubmit checks

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC senorblanco@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: senorblanco@google.com
Change-Id: Iac8f0e793aeaa5a7ea1b6577c16bdd3b7bb6689b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113761
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-12-12 16:07:40 +00:00
Antonio Maiorano 7c9e639e35 tint: const eval of mix builtin
Bug: tint:1581
Change-Id: I3b9f0ff3a58956616daf17b3d4a922979fc30216
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113680
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-12-12 15:31:21 +00:00
Dawn Autoroller b5fedb7b5a Roll ANGLE from f8980c98b28d to b1b4640104fc (1 revision)
f8980c98b2..b1b4640104

2022-12-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 3b96c02c7465 to 1c9a08119fdd (378 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC senorblanco@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: senorblanco@google.com
Change-Id: I12d03b2a7e078ea32a6f1350eb6b35b8704b112d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113760
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-12-12 10:39:24 +00:00
dawn-autoroll 3f96cc8bb8 Roll vulkan-deps from a500751650f8 to 4513d3d91ac3 (2 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/a500751650f8..4513d3d91ac3

Changed dependencies:
* vulkan-validation-layers: 9487f4b06c..7140eba938

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC senorblanco@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: senorblanco@google.com
Change-Id: Iacaf36028c09e80f36539da73bddf85f363d2a96
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113609
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-12-12 06:26:41 +00:00
Dawn Autoroller 8b18988385 Roll ANGLE from fd75686e8380 to f8980c98b28d (6 revisions)
fd75686e83..f8980c98b2

2022-12-10 cclao@google.com Vulkan: Make ReadWriteResource subclass from Resource
2022-12-10 cclao@google.com Vulkan: Use finishQueueSerial for queueSubmitOneOff
2022-12-10 cclao@google.com Vulkan: Remove Resource::isCurrentlyInUse
2022-12-09 cclao@google.com Vulkan: mapRangeImpl should call flushImpl if unflushed write
2022-12-09 cclao@google.com Vulkan: Make PipelineHelper go through normal collectGarbage
2022-12-09 syoussefi@chromium.org Vulkan: Move desc set updates cache to share group

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC senorblanco@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: senorblanco@google.com
Change-Id: I59f0373f81b5e662b3593e4d8495ab8594f66a42
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113721
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-12-10 12:50:08 +00:00
Dawn Autoroller f87773947c Roll SwiftShader from 6ebc3347af9d to 36e043fa6d46 (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/6ebc3347af9d..36e043fa6d46

2022-12-10 capn@google.com Add a macro for indicating unoptimized code paths

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC senorblanco@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: senorblanco@google.com
Change-Id: I525c8c32677909e8a896eacfa7ff7f975f3beaae
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113720
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-12-10 04:53:47 +00:00
dawn-autoroll da9dcd34f8 Roll vulkan-deps from 89b9b4762b94 to a500751650f8 (10 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/89b9b4762b94..a500751650f8

Changed dependencies:
* glslang: ed257e2bdf..6d8b00b1c6
* vulkan-headers: bf3b3fb14e..9b48e83ef8
* vulkan-tools: f846ef57a0..ffa89a4447
* vulkan-validation-layers: 934d2bddab..9487f4b06c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC senorblanco@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: senorblanco@google.com
Change-Id: I7cb4682c653096e48fd7c6d2b2601a19e124c615
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113603
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-12-10 02:10:15 +00:00
Ben Clayton e38993feb1 CMake: Expand TINT_EMIT_COVERAGE to DAWN_EMIT_COVERAGE
Change-Id: I0caf174ecc68ffd3272e5ebfd6bf68f9bb4e53c1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113640
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-12-10 00:15:57 +00:00
Dawn Autoroller f681d00f39 Roll ANGLE from c9e7fd9c25c9 to fd75686e8380 (13 revisions)
c9e7fd9c25..fd75686e83

2022-12-09 syoussefi@chromium.org Vulkan: Fix EGL image queue change vs threads
2022-12-09 ynovikov@chromium.org Skip couple non-deterministic angle_restricted_trace_gold_tests
2022-12-09 lexa.knyazev@gmail.com GL: Support clip and cull distance redeclarations
2022-12-09 cclao@google.com Vulkan: Remove CommandQueue::mQueueSerialMutex
2022-12-09 syoussefi@chromium.org Vulkan: Remove the unused shadowBuffer feature
2022-12-09 cclao@google.com Vulkan: Remove ImageHelper::mImageAndViewGarbage
2022-12-09 ynovikov@chromium.org Enable angle_restricted_trace_gold_tests retries on Win Intel UHD630
2022-12-09 penghuang@chromium.org Workaround GetModulePath() returns incorrect path for exe in Chrome
2022-12-09 chris@rive.app Improve PLS load and store op tokens
2022-12-09 jmadill@chromium.org Better support for "vulkan-null" backend in trace tests.
2022-12-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4affe58949d3 to 89b9b4762b94 (5 revisions)
2022-12-09 gert.wollny@collabora.com Capture/Replay: Only create active secondary contexts in MEC
2022-12-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from eb46dc0d0fce to 3b96c02c7465 (547 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC senorblanco@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: senorblanco@google.com
Change-Id: I0de746baed051f90d89ec6c93d47a0db0b3b17a2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113700
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-12-09 23:26:06 +00:00
Antonio Maiorano 28779af91c tint: impement short-circuiting for const eval of logical and/or
Bug: tint:1581
Change-Id: I44852bfeb0e55771009a89ed199ea60ca51e8477
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113431
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-12-09 21:28:51 +00:00
David Neto 24c8440eb6 Update spirv-reader docs: supports texture and sampler func args
Change-Id: I893f050e3377c2aebe933a55d6e75c505c3e23d2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113560
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Auto-Submit: David Neto <dneto@google.com>
Reviewed-by: David Neto <dneto@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: David Neto <dneto@google.com>
2022-12-09 19:53:27 +00:00
dawn-autoroll ca01ec4689 Roll vulkan-deps from e6dba61053b8 to 89b9b4762b94 (1 revision)
https://chromium.googlesource.com/vulkan-deps.git/+log/e6dba61053b8..89b9b4762b94

Changed dependencies:
* vulkan-validation-layers: 2bbe7a9dfd..934d2bddab

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC senorblanco@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: senorblanco@google.com
Change-Id: I99b7b4f479fe36784810b29372b4e4c4fc77654f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113601
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-12-09 13:10:10 +00:00
Ben Clayton f528d33d52 tint/transform: fix PromoteInitializersToLet for constant expressions
Fix more edge cases uncovered with tint:1781

Fixed: tint:1781
Change-Id: I58d120185f47c10bc9fe55dd95a198d496c4ec94
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113024
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Auto-Submit: Ben Clayton <bclayton@google.com>
2022-12-09 12:34:36 +00:00
Dawn Autoroller dd0d45102a Roll ANGLE from 28290e34215a to c9e7fd9c25c9 (6 revisions)
28290e3421..c9e7fd9c25

2022-12-08 sugoi@chromium.org Revert "Skip AssignAssignmentToSwizzled on SwS Linux/Win"
2022-12-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 5e89361766f7 to 4affe58949d3 (3 revisions)
2022-12-08 syoussefi@chromium.org Vulkan: Use VK_EXT_pipeline_protected_access
2022-12-08 cclao@google.com Vulkan: Remove synchronous commands from CommandProcessor
2022-12-08 cclao@google.com Vulkan: Remove QueryVk::hasUnsubmittedUse()
2022-12-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 7935ee7ccbc0 to 5e89361766f7 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC senorblanco@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: senorblanco@google.com
Change-Id: I57a75a326f4cd483c6c86e4d7a0ee49a732848c4
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113580
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-12-09 08:51:33 +00:00
dan sinclair 837b8042d3 Rename TypeManager to Manager.
With the move to the type:: hierarchy rename type::TypeManager to
type::Manager.

Bug: tint:1718
Change-Id: I1c8e2c2e469e20b959676232e9f3d62c9b3a789e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113429
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
2022-12-09 05:00:07 +00:00
dawn-autoroll 0dc71406da Roll vulkan-deps from 7935ee7ccbc0 to e6dba61053b8 (8 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/7935ee7ccbc0..e6dba61053b8

Changed dependencies:
* vulkan-headers: b75e5a02b6..bf3b3fb14e
* vulkan-loader: 82d4232f0f..b43758588b
* vulkan-tools: ce45337c51..f846ef57a0
* vulkan-validation-layers: 1e422524e7..2bbe7a9dfd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC senorblanco@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: senorblanco@google.com
Change-Id: I3efe6a8e909f4a843ce444bfbb7e4b029f7ec628
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113542
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-12-09 00:04:44 +00:00
dan sinclair 98705d417e Remove type:: prefix in type/ folder.
Remove type:: namespaces added during the file moves.

Bug: tint:1718
Change-Id: I9862296cf93aad92e6c2b2e54d06d1c53d3a9b09
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113428
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-12-08 22:21:24 +00:00
dan sinclair 946858ad56 Move array to type/
This CL moves array to the type/ folder. Namespaces are updated as
needed. A FriendlyName method was added to ArrayCount so the sem::
ArrayCount entries do not need to be referenced inside type/.

Bug: tint:1718
Change-Id: I16a8f32b3fab1131b284a6981a5c386081138b08
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113427
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-12-08 22:21:24 +00:00
dan sinclair f53b2b5b2e Split sem/struct into sem and type.
This CL moves the Base entries from sem/struct into type. The class
names are maintained as Base over the move and will be renamed in a
followup.

Bug: tint:1718
Change-Id: I07bed013167c58fc83f0069c781404d8197966ee
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113425
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-12-08 22:21:24 +00:00
dan sinclair d8a084585f Move atomic to type/
This CL moves atomic to type/ and updates the namespaces.

Bug: tint:1718
Change-Id: I3331bc0dfae2ccede52b5589b7d3cc443366096a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113424
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-12-08 22:21:24 +00:00
dan sinclair 0e780da882 Move vector and matrix to type/.
This CL moves vector and matrix to type/ and updates the namespaces as
needed.

Bug: tint:1718
Change-Id: I48423b37f15cd69c03ab288143b2d36564789fbf
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113423
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-12-08 22:21:24 +00:00
Austin Eng 100d4bf339 Reland "Add expectations.txt validation to presubmit"
This is a reland of commit cde5589953

Original change's description:
> Add expectations.txt validation to presubmit
>
> Change-Id: Ibabdfbdf44b027a6e6441e140f23b2c2488f32dc
> Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112120
> Reviewed-by: Ben Clayton <bclayton@google.com>
> Commit-Queue: Austin Eng <enga@chromium.org>
> Kokoro: Kokoro <noreply+kokoro@google.com>

Change-Id: I013eeec03e27b3147023ea094f5bde011561edd1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113540
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Austin Eng <enga@chromium.org>
2022-12-08 21:57:55 +00:00
Ben Clayton 31090e3096 cts: Fix expectation collisions
Change-Id: I79ae5afa25dd2bd7ea0bb269212f5228a196319f
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Include-Ci-Only-Tests: true
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113480
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-12-08 21:53:33 +00:00
Austin Eng 68a74c82c3 Suppress tests failing with Metal backend validation layers
Bug: dawn:1430
Change-Id: Id8fad88bd5014a2a90e0d580d9df6831dd507b5d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113500
Reviewed-by: Gregg Tavares <gman@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Auto-Submit: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-12-08 21:23:56 +00:00
Ben Clayton 5f55990471 tools/cts: Fix expectations update failure
appendConsumedResultsForSkippedTests() adds fake results for expectations that are 'Skip'ed, so that these sub-trees aren't collapsed as all passing.

However, this code was not handling the fact that there might actually be results for the cases.
This happened because there was an expectation collision in the expectations.txt file, and tests were not being skipped even though there was an expectation with a Skip (a collision expectation was used instead).

Change-Id: I2a1543d231db44dc8aa6683d051f884f4cb96853
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113520
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Ben Clayton <bclayton@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-12-08 20:59:01 +00:00
Ben Clayton 06c1af47bd tint: Fix Renamer transform with type short-names
Fixed: tint:1783
Change-Id: I0ffd5860405651f15961dc8fe753eeac6edc8434
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113441
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-12-08 20:45:54 +00:00
Dawn Autoroller 384e2bee88 Roll SwiftShader from 6f73609d079a to 6ebc3347af9d (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/6f73609d079a..6ebc3347af9d

2022-12-08 swiftshader.regress@gmail.com Regres: Update test lists @ 6f73609d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC senorblanco@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: senorblanco@google.com
Change-Id: I8a8117a77b2bf04083b134c2c64f76822074193f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113461
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-12-08 20:05:49 +00:00
Dawn Autoroller 293bf3d50b Roll ANGLE from 15ae19c00c77 to 28290e34215a (5 revisions)
15ae19c00c..28290e3421

2022-12-08 ynovikov@chromium.org Skip Texture2DTestES3.NonZeroBaseEmulatedClear/ES3_Vulkan on Win Intel
2022-12-08 ynovikov@chromium.org Enable tests on Win Intel Optiplex 7080 experimental bot
2022-12-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 0c98167cb31e to 6ebc3347af9d (6 revisions)
2022-12-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from b1141d77c69a to eb46dc0d0fce (599 revisions)
2022-12-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 81e6bda0f261 to b1141d77c69a (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC senorblanco@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: senorblanco@google.com
Change-Id: I3b0ed43609498da28d734f034a99aa175f010305
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113460
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-12-08 19:14:22 +00:00
Ben Clayton d00663d882 tint: Move resolver/type_alias to type/short_name
'Short-name' is way less overloaded than 'alias' and 'builtin'.

The package move allows transforms to use these enums.

Change-Id: I61c6b3f7deee8e835990a948cd5427c07034fa5e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113440
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
2022-12-08 19:07:06 +00:00
James Price 04f792de9f tint/transform: Use InsertFront to add attribute
This is simpler than reconstructing the attribute list and manually
cloning the struct member.

Change-Id: I3d0bd4039030b47e53ce618d9de7ee572b9698f1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113422
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-12-08 19:01:17 +00:00
James Price 48802bb9ea tint/transform: Remove commented out code
Change-Id: Ie5fc57bdcc17e4b96173e43e0a230d4f00f58a93
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113421
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
2022-12-08 19:01:17 +00:00