a52be6c9ec
Add sem::Module
...
Holds `DependencyOrderedDeclarations()`, which will hold the
sorted dependency-graph ordered list of global declarations.
Bug: tint:1266
Change-Id: I9840fae8689abd214973ea4785f71c3ae2587bbc
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79766
Reviewed-by: James Price <jrprice@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-02-09 23:55:51 +00:00
311e20e5de
Roll Tint from 35cc663130 to 597fc4cdbe (4 revisions)
...
https://dawn.googlesource.com/tint.git/+log/35cc6631307c..597fc4cdbe07
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-dawn
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: amaiorano@google.com
Change-Id: Iab13a68106a7b2c60adee73689852903439b8007
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79923
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-09 23:54:01 +00:00
8d4fc76d17
Roll SwiftShader from 0915ab4bddf7 to cbd31d271e4c (3 revisions)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/0915ab4bddf7..cbd31d271e4c
2022-02-09 sugoi@google.com Dynamic state refactor
2022-02-09 sugoi@google.com VK_EXT_subgroup_size_control support
2022-02-09 capn@google.com Add compute benchmarks
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: amaiorano@google.com
Change-Id: I57bf38eaff7f0b8116cb988687bc3ee577f8c4de
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79922
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-09 22:42:51 +00:00
597fc4cdbe
resolver: Replace ICEs with proper errors
...
If you attempted to:
* Use a function as a type
* Use a variable as a type
* Use a variable as a call target
You would get an ICE. Replace these with proper error diagnostics.
Change-Id: Ibbe4cd1b59b1aadd451aa0445ad137859aa071eb
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79765
Reviewed-by: James Price <jrprice@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-02-09 22:23:17 +00:00
88d1a433aa
Castable: Have Switch() support nullptr objects.
...
Change-Id: I7635b01707e80c2d2e0b79148e07874f2fa2b5ff
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79764
Auto-Submit: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2022-02-09 21:37:57 +00:00
6839cba568
Add toggle to control if validity is expected in fuzzer
...
This toggle controls if the fuzzer will throw a fatal error in the
case that the shader becomes invalid.
Currently the fuzzers do no guarantee that the options that are
provided are correct/valid, so there are many uninteresting cases that
become invalid due to the limited nature of the fuzzers, not due to
bugs in the code. The default off state of this toggle will suppress
this noise.
Once https://bugs.chromium.org/p/tint/issues/detail?id=1356 is
implemented this toggle can be default on.
BUG=tint:1357,chromium:1294533
Change-Id: I7170e5a30691105c97e20d8337aadf81ac2bc3bc
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79840
Reviewed-by: Ben Clayton <bclayton@google.com>
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
2022-02-09 19:45:17 +00:00
71a363bcf9
Add error directives for api.h/api_cpp.h #ifdef __EMSCRIPTEN__
...
This could avoid including dawn's version of webgpu headers
and confusion at runtime when build with emscripten.
Emscripten's system/include/webgpu headers should be used.
Bug: None
Change-Id: Ie8c6ebc23f28a56b1cb887ae7f11d3f738151aec
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79740
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Shrek Shao <shrekshao@google.com>
2022-02-09 19:42:51 +00:00
b626409c4b
Roll Tint from d21ebe74bd to 35cc663130 (1 revision)
...
https://dawn.googlesource.com/tint.git/+log/d21ebe74bd9c..35cc6631307c
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-dawn
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: amaiorano@google.com
Change-Id: Id7d21f1b6c85927d35e3847ff42da3110181ddbe
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79921
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-09 18:46:11 +00:00
82ca6096ac
Mark 1D textures as safe.
...
Fixed: dawn:814
Change-Id: I216ebdb68cfb1634cfad8b44de998c2f1a87edaf
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79320
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2022-02-09 18:40:51 +00:00
dba215cd16
Add sem::Expression::HasSideEffects()
...
Will be used to implement order of execution.
Bug: tint:1300
Change-Id: I027295e482da7a3f9d7ca930b5303e8f89d7fe09
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79824
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2022-02-09 18:30:27 +00:00
19bb9563f8
Set vulkan_loader_shared to false on Mac.
...
This is the same configuation that ANGLE uses. Without this, Release
builds of Dawn on Mac can't find libvulkan.dylib.
Bug: angleproject:6981
Change-Id: Ib5eddd0f694d1b960e16341578427fa4f0a009c5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79560
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2022-02-09 17:45:51 +00:00
35cc663130
GLSL: implement desktop GLSL support.
...
Introduce a glsl::Version, to allow the client to specify ES or
Desktop, as well as the desired GLSL major and minor version.
Bug: tint:1422
Change-Id: I4116bc2da40ae6a553dc2522d042dda1464a0c05
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79700
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2022-02-09 17:44:17 +00:00
c6d343d18b
Roll ANGLE from 1b9774f57784 to 9cfd872447fd (4 revisions)
...
1b9774f577..9cfd872447sergeyu@google.com Allow surface creation in DisplayVkNull
2022-02-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from e576ca6011cd to 0915ab4bddf7 (6 revisions)
2022-02-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 817a527fde8c to 60719c9cd084 (571 revisions)
2022-02-09 syoussefi@chromium.org Vulkan: Fix vkCmdClearAttachments vs multiview
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: amaiorano@google.com
Change-Id: I03bf3136c6385bbbe2f15d3c12fa8ed71883750d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79920
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-09 16:09:01 +00:00
9fc28cf3b6
Metal: Fix leak of MTLVertexDescriptor when using vertex pulling
...
Bug: dawn:1175
Change-Id: I1fd833fef830de4165a397e07c3ddaae0d7bdca8
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79762
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-02-09 15:56:32 +00:00
189b0cec37
tint->dawn: Move src/dawn_tests -> src/dawn/tests
...
Bug: dawn:1275
Change-Id: I79f2aeb0c54a74dd5becd90c46792705a28e87da
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79100
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-02-09 14:54:31 +00:00
962c4ea5d5
Roll SwiftShader from 8ccc63f045d5 to 0915ab4bddf7 (2 revisions)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/8ccc63f045d5..0915ab4bddf7
2022-02-08 capn@google.com Fix validation layer error for ClearImage benchmarks
2022-02-08 capn@google.com Fix non-x86 build of LLVM Reactor
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: amaiorano@google.com
Change-Id: I25256077df04c9886794c9d90d67877d8b6e6cda
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79880
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-09 09:27:41 +00:00
73b577e9c6
Roll ANGLE from 8622810c4fae to 1b9774f57784 (8 revisions)
...
8622810c4f..1b9774f577m.maiya@samsung.com Vulkan: Force submit updates to immutable textures
2022-02-08 jmadill@chromium.org Vulkan: Bind aligned default uniform buffer size.
2022-02-08 jmadill@chromium.org Vulkan: Minor cleanup to DynamicDescriptorPool.
2022-02-08 syoussefi@chromium.org Overlay: Rearrange the font image
2022-02-08 jmadill@chromium.org Vulkan: Use common storage for descriptor set descs.
2022-02-08 jmadill@chromium.org Expand SwiftShader Win/ASAN suppression.
2022-02-08 cclao@google.com Vulkan: StreamVertexDataWithDivisor write beyond buffer boundary
2022-02-08 grt@chromium.org [fuchsia] Tests using additional_manifest_fragments are CFv1.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: amaiorano@google.com
Change-Id: Ie0323d20db89412f75d70154a1e1b1f7be18c7cd
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79860
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-09 03:06:40 +00:00
2a1f4dc5b1
Roll Tint from c6d8cadd33 to d21ebe74bd (1 revision)
...
https://dawn.googlesource.com/tint.git/+log/c6d8cadd3300..d21ebe74bd9c
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-dawn
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: amaiorano@google.com
Change-Id: I604503db4bdff31d8f49e09cf5a0334b5d7a799b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79823
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-08 22:39:20 +00:00
7fd6b996f4
tint->dawn: Add proxy groups and temp targets for Dawn tests
...
Needed so that Chromium can reference the temp groups and
targets while we move Dawn's test build targets.
Bug: dawn:1275
Change-Id: Ia26769adfb3714e78ebd058ffcec50f3ccfa1a05
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79821
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-02-08 22:15:50 +00:00
d21ebe74bd
Suppress "Wreserved-identifier" for the AST Fuzzer
...
This is a check that has been added to newer versions of clang and is
tripping for me locally. The actual issue is in code being generated
by protobuf.
Updating protobufs has cross-dependency issues with spriv-tools, so is
non-trivial. There is already a special case suppression for internal
protobuf issues, so I am just adding to the carve out.
BUG=tint:1419
Change-Id: I3ecd111a778fb4c65a113382ded8d6160deab462
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79841
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
2022-02-08 21:37:56 +00:00
ee50bc060a
dawn.json changes for the upstream webgpu.h
...
- Fix power preference undefined value
- Remove 'upstream' tagged content from emscripten-bits generation
explicitly tag 'emscripten' to things still needed
Bug: None
Change-Id: If575823ff1d99237d7c2cb0e784c24a7299b4a31
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79220
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Shrek Shao <shrekshao@google.com>
2022-02-08 20:21:40 +00:00
98d4a01bc1
Roll SwiftShader from e576ca6011cd to 8ccc63f045d5 (4 revisions)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/e576ca6011cd..8ccc63f045d5
2022-02-08 kramerb@google.com Avoid deprecated llvm::IRBuilder::CreateShuffleVector overload
2022-02-08 capn@google.com Unroll transcendentals benchmarks by 10x
2022-02-08 swiftshader.regress@gmail.com Regres: Update test lists @ e576ca60
2022-02-08 capn@google.com Remove Vulkan structure enum to integer casts
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: amaiorano@google.com
Change-Id: I2424df1eb78797f0e61beaf2277ea56140cf2a40
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79820
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-08 20:19:20 +00:00
25b3ed12e3
Enable the Tint/GLSL backend in the CMake build.
...
Don't build the Tint samples, because they require glslang.
Change-Id: I04ac6bb313fa8926bd161b91488d30c2c26ebb67
Bug: dawn:1217
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79660
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2022-02-08 15:32:00 +00:00
10e58e8a90
Roll ANGLE from 8b81742dd8d1 to 8622810c4fae (5 revisions)
...
8b81742dd8..8622810c4fangle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from ad6d7f84f2a1 to e576ca6011cd (19 revisions)
2022-02-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 26dacbf4b527 to 817a527fde8c (500 revisions)
2022-02-08 yuxinhu@google.com Add instructions to enable Debug Overlay On Android
2022-02-08 cnorthrop@google.com Tests: Add Dead Trigger 2 trace
2022-02-08 cnorthrop@google.com Test: Add Last Shelter: Survival trace
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: amaiorano@google.com
Change-Id: I449f267bf788c6c8980627b48532290a24b5475f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79780
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-08 14:11:41 +00:00
14c23850ac
Roll SwiftShader from c9e8f23b0fb8 to e576ca6011cd (17 revisions)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/c9e8f23b0fb8..e576ca6011cd
2022-02-08 natsu@google.com Fix `WARNING: UNSUPPORTED:` warnings related to Android swapchain
2022-02-08 natsu@google.com Fix `WARNING: UNSUPPORTED: ... EXTERNAL_FORMAT_ANDROID` warnings
2022-02-07 capn@google.com Benchmark optimized SPIR-V transcendental instructions
2022-02-07 capn@google.com Copy Reactor transcendentals benchmarks to new PipelineBenchmarks
2022-02-07 capn@google.com Test building benchmarks with Kokoro
2022-02-07 swiftshader.regress@gmail.com Regres: Update test lists @ 45f7fdc3
2022-02-07 capn@google.com Ignore VK_STRUCTURE_TYPE_IMAGE_VIEW_MIN_LOD_CREATE_INFO_EXT usage
2022-02-07 capn@google.com Eliminate EmulatedIntrinsics
2022-02-07 capn@google.com Remove OptimalIntrinsics source and header
2022-02-07 capn@google.com Eliminate rr::Precision
2022-02-07 capn@google.com Use full-precision transcendental function implementations in Reactor
2022-02-07 capn@google.com Update dEQP-VK and Cherry usage documentation
2022-02-07 capn@google.com Use ShaderCore functions to implement GLSL.std.450 transcendentals
2022-02-07 capn@google.com Copy optimized transcendental intrinsics to ShaderCore
2022-02-07 dvet@google.com Add an option to control where ASM listings are dumped.
2022-02-07 capn@google.com Make the Reactor build target an alias
2022-02-07 swiftshader.regress@gmail.com Regres: Update test lists @ ad6d7f84
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: amaiorano@google.com
Change-Id: I292eaed7ebbdf99e1ddc447ebce185339e3465c8
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79723
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-08 06:35:50 +00:00
f994c5637c
Roll Tint from bf0180bcee to c6d8cadd33 (2 revisions)
...
https://dawn.googlesource.com/tint.git/+log/bf0180bcee90..c6d8cadd3300
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-dawn
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: amaiorano@google.com
Change-Id: I82a9ae1b476ea06ea956042f7b5ff6eb51ba4ae9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79722
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-08 03:28:43 +00:00
1ba62221ca
Roll ANGLE from 06150ab2fb9f to 8b81742dd8d1 (8 revisions)
...
06150ab2fb..8b81742dd8jmadill@chromium.org Vulkan: Move shader resources descriptor set update.
2022-02-07 syoussefi@chromium.org Vulkan: Fix vkCmdResolveImage offsets
2022-02-07 syoussefi@chromium.org Vulkan: Make framebuffer fetch syncval errors more specific
2022-02-07 cnorthrop@google.com Tests: Add Magic Rush: Heroes trace
2022-02-07 ianelliott@google.com Revert "Vulkan: Enable framebuffer fetch on SwiftShader"
2022-02-07 cnorthrop@google.com Tests: Add Dragon Mania Legends trace
2022-02-07 jmadill@chromium.org Vulkan: Remove buffer get method from descriptors desc.
2022-02-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 2b76a13c38ae to ad6d7f84f2a1 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: amaiorano@google.com
Change-Id: Iaee0020a77d6fad3c75b7b88eb3c36fcb1c6bbae
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79721
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-08 00:35:40 +00:00
c6d8cadd33
main: Print the available transforms when mistyped
...
Declare the list of transforms once, and use this for the usage message and when a transform does not match.
Simplifies adding new transforms to the command line tool.
Change-Id: I57ec433d8a570dae465d1837f5a4c1d89b8cff05
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79280
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-02-08 00:09:26 +00:00
601feba10c
Roll Tint from 89c730dbf3 to bf0180bcee (1 revision)
...
https://dawn.googlesource.com/tint.git/+log/89c730dbf3da..bf0180bcee90
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-dawn
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: amaiorano@google.com
Change-Id: I1b9dc8cc7770a85e267236c457a52bdb8a796314
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79720
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-07 22:36:39 +00:00
85f7df55eb
CloneContext: fix InsertAfter and InsertBack not working if done while cloning a node in a vector
...
Also make tests more idiomatic by removing diamonds in the Node
hierarchy.
Bug: tint:1300
Change-Id: I681f4251bd8d9bdef169dcdf5de345792c927436
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79680
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2022-02-07 21:43:06 +00:00
0fee4c180a
Deprecate endPass(), replace with end()
...
Method was renamed in https://github.com/gpuweb/gpuweb/pull/2560
Bug: dawn:1286
Change-Id: I02a5da3f6ff56868c4d8f45a17433b6c5adf5c22
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79480
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
2022-02-07 19:48:39 +00:00
bf0180bcee
GLSL: only emit default precision qualifier for frag shader.
...
Other shader types don't need this.
Also fix code style of member var.
Bug: tint:1360
Change-Id: Ic3600ec7c6da9b85b57655fabbf1f2e44b0ea7d3
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79640
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2022-02-07 18:49:46 +00:00
a064f7c95c
Roll Tint from 2d87beb200 to 89c730dbf3 (1 revision)
...
https://dawn.googlesource.com/tint.git/+log/2d87beb20076..89c730dbf3da
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-dawn
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: amaiorano@google.com
Change-Id: Id40fa82e20341c0559f96148f495831a32898255
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79621
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
2022-02-07 17:05:49 +00:00
a9a80ef386
Guard for [MTLDevice counterSets] being null.
...
Bug: dawn:1102
Change-Id: I1c8fffba65cba0b04ef72018013f027f0a814f90
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79361
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2022-02-07 16:12:00 +00:00
89c730dbf3
GLSL: only build glslang if we're building samples.
...
We'll need this to build the GLSL backend in Dawn, since we don't want
glslang there.
Bug: tint:1217
Change-Id: Ied44ca89286c1d53a2e58a7083f0bfb859976770
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79500
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2022-02-07 16:05:36 +00:00
839d99cd9a
Roll SwiftShader from ad6d7f84f2a1 to c9e8f23b0fb8 (2 revisions)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/ad6d7f84f2a1..c9e8f23b0fb8
2022-02-07 capn@google.com Regres: Adjust mustpass folder for Vulkan 1.3
2022-02-07 nicolascapens@google.com Revert "Regres: Apply lazy initialization patch"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC shrekshao@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: shrekshao@google.com
Change-Id: I0a71bf5c95b972887a8600d55ac4eb023b94441f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79620
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-07 15:16:17 +00:00
31680a7ec0
Add validation of the max binding number.
...
Fixed: dawn:1283
Change-Id: I5efd0d5c92bd6c1a4cdfe91079a12a9f98ddfd61
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79260
Reviewed-by: Brandon Jones <bajones@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-02-07 12:02:57 +00:00
e71494b6dc
Roll Tint from 6d770093bd to 2d87beb200 (1 revision)
...
https://dawn.googlesource.com/tint.git/+log/6d770093bdf1..2d87beb20076
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-dawn
Please CC shrekshao@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: shrekshao@google.com
Change-Id: I20547dd8a2fd3e02630990c00ed364978a92b204
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79601
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-07 11:44:07 +00:00
1991ad6b2e
Roll ANGLE from f65e7c3ca739 to 06150ab2fb9f (1 revision)
...
f65e7c3ca7..06150ab2fbangle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 55ed02951fa2 to 26dacbf4b527 (583 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC shrekshao@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: shrekshao@google.com
Change-Id: Ic609b924b2ede435e45d7b1d6ef0aa757b28610e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79600
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-07 11:19:17 +00:00
2d87beb200
Add native visualizers for MSVC
...
Currently contains a subset of ast nodes to make it easier to debug.
Bug: tint:1331
Change-Id: I27afe3c57aa752bdf823120e31585100c8adbe36
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79460
Auto-Submit: Antonio Maiorano <amaiorano@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-02-07 10:07:25 +00:00
8e519d3bde
Roll SwiftShader from 2b76a13c38ae to ad6d7f84f2a1 (1 revision)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/2b76a13c38ae..ad6d7f84f2a1
2022-02-06 sugoi@google.com VK_KHR_synchronization2 support
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC shrekshao@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: shrekshao@google.com
Change-Id: Iaaa2e17fc9a440244bf04aebc61cb01257f65d28
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79580
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-06 18:58:18 +00:00
3b971ac7de
Roll ANGLE from 2ab8f48fead8 to f65e7c3ca739 (4 revisions)
...
2ab8f48fea..f65e7c3ca7m.maiya@samsung.com Vulkan: Take base level into account in image views
2022-02-05 lexa.knyazev@gmail.com Metal: Fix ANGLEUniformBlock alignment
2022-02-04 antonio.caggiano@collabora.com Vulkan: Fix present region rectangles
2022-02-04 syoussefi@chromium.org Vulkan: Enable framebuffer fetch on SwiftShader
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: Ia86a7baeb25f32e774571aef96f10a9cd22ab54f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79540
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-05 09:01:17 +00:00
608e4ea071
Roll Tint from 3d5b38447a to 6d770093bd (5 revisions)
...
https://dawn.googlesource.com/tint.git/+log/3d5b38447aec..6d770093bdf1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-dawn
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: Iff344676672795b10cad03ea3ddb87c371f08bc7
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79520
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-05 03:34:55 +00:00
377ead9d44
Fix version check for timestamp queries - Mac 11.0+ AMD
...
Bug: dawn:545
Change-Id: I7cb48813e0a582a6b7314c6fa726800b146ea6be
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79243
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-02-05 03:30:05 +00:00
6d770093bd
GLSL: fix arrayLength().
...
Bug: tint:1222
Change-Id: I6f9576908a41f3b37036ef7afe10cb74a99cd63f
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79440
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: David Neto <dneto@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2022-02-05 00:20:54 +00:00
deec53332f
GLSL: fix barriers.
...
Bug: tint:1416
Change-Id: I138932cc0d702289684c4db80b4640df43b41833
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79420
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: David Neto <dneto@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2022-02-05 00:15:34 +00:00
b79f51ece3
Fix clang-cl msvc build
...
Change-Id: I4834c03370db78ed1ba462eeb54a0dc91f481791
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79461
Auto-Submit: Antonio Maiorano <amaiorano@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-02-04 23:24:43 +00:00
46647f1c13
GLSL: put std430 packing on all buffer variables.
...
This is not 100% correct (the exceptions for mat2 and friends are not
implemented yet), but gets more tests passing in Dawn.
Bug: tint:1415
Change-Id: Ia11c63a5236f35e724431a65ddb6ef3c598775d0
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79380
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: David Neto <dneto@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2022-02-04 23:09:23 +00:00
c6d967b4dd
Add debugger::Break() to break into debugger if attached, and call when an ICE occurs
...
Helpful for debugging.
Bug: tint:1331
Change-Id: Ia2b58626ff7fb92194b419805eb4f48ad419092d
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79242
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2022-02-04 22:25:45 +00:00
aafb861973
Roll Tint from de857e1c58 to 3d5b38447a (5 revisions)
...
https://dawn.googlesource.com/tint.git/+log/de857e1c581c..3d5b38447aec
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-dawn
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: dawn:814
Tbr: cwallez@google.com
Change-Id: I4d0c51a8fb6eaf9cfc0ab28552ea12ca13a3668d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79401
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-04 22:13:55 +00:00
Ben Clayton
Dawn Autoroller
Ryan Harrison
Shrek Shao
Corentin Wallez
Antonio Maiorano
Stephen White
Austin Eng
Brandon Jones