Bug: chromium:1177288
Includes the following rolls:
Rolling 3 dependencies
Roll build/ 6fa63e6b1..ea192b29d (300 commits)
6fa63e6b15..ea192b29d2
$ git log 6fa63e6b1..ea192b29d --date=short --no-merges --format='%ad %ae %s'
2021-03-23 aeubanks Use --gcc-toolchain instead of -B to find libgcc
2021-03-23 chromium-autoroll Roll Fuchsia SDK from 3.20210322.3.1 to 3.20210323.0.1
2021-03-23 yhirano Revert "Reland "Add test directory -> monorail component metadata to test invocations.""
2021-03-23 dpranke Reland "Add test directory -> monorail component metadata to test invocations."
2021-03-22 chromium-autoroll Roll Fuchsia SDK from 3.20210322.1.1 to 3.20210322.3.1
2021-03-22 sdefresne [apple] Split the iOS and macOS toolchain definitions
2021-03-22 mthiesse Tighten Instrumentation timeouts to avoid shard timeouts.
2021-03-22 wnwen Android: Fix FragmentActivityReplacer stack frame
2021-03-22 chromium-autoroll Roll Fuchsia SDK from 3.20210322.0.1 to 3.20210322.1.1
2021-03-22 chromium-autoroll Roll Fuchsia SDK from 3.20210321.0.1 to 3.20210322.0.1
2021-03-22 msta Add the ability to enable pseudolocales to chromium
2021-03-21 chromium-autoroll Roll Fuchsia SDK from 3.20210320.3.1 to 3.20210321.0.1
2021-03-21 chromium-autoroll Roll Fuchsia SDK from 3.20210320.1.1 to 3.20210320.3.1
2021-03-21 pkotwicz [Build] Support public_deps in java_library()
2021-03-20 chromium-autoroll Roll Fuchsia SDK from 3.20210320.0.1 to 3.20210320.1.1
2021-03-20 chromium-autoroll Roll Fuchsia SDK from 3.20210319.2.1 to 3.20210320.0.1
2021-03-19 chromium-autoroll Roll Fuchsia SDK from 3.20210318.1.1 to 3.20210319.2.1
2021-03-19 sergeyu [Fuchsia] Fix build_system_archive.py for Python3
2021-03-19 omerlevran Revert "[fuchsia] migrate device discovery to ffx"
2021-03-19 pkotwicz Remove unused OnDeviceInstrumentationDriver
2021-03-19 dpranke Fix a couple of mac build issues for Python3.9 compat.
2021-03-19 omerlevran [fuchsia] migrate device discovery to ffx
2021-03-18 steveroe [fuchsia] Write binary size package blob data to json file.
2021-03-18 wnwen Android: Update r8 to 3.0.28-dev
2021-03-18 chromium-autoroll Roll Fuchsia SDK from 3.20210318.0.1 to 3.20210318.1.1
2021-03-18 chromium-autoroll Roll Fuchsia SDK from 3.20210317.3.1 to 3.20210318.0.1
2021-03-18 findit-for-me Revert "Enable pseudolocales on non-official builds"
2021-03-18 msta Enable pseudolocales on non-official builds
2021-03-18 steveroe [fuchsia] Remove binary_sizes.py recipe interface code.
2021-03-18 chromium-autoroll Roll Fuchsia SDK from 3.20210317.1.1 to 3.20210317.3.1
2021-03-18 ehmaldonado Add auto rollers as OWNERS of the files they touch
2021-03-18 kmarshall [fuchsia] Delegate target construction to class level methods.
2021-03-17 wnwen Android: Add --dump-inputs to dex.py
2021-03-17 bjoyce Upload results of all test runs to result_db.
2021-03-17 mheikal Ignore empty proguard config files when writing expectations.
2021-03-17 chromium-autoroll Roll Fuchsia SDK from 3.20210317.0.1 to 3.20210317.1.1
2021-03-17 hans [build] Pass --rtlib=libgcc in Android builds
2021-03-17 ortuno Revert "Roll clang llvmorg-13-init-3462-gfe5c2c3c-2 : llvmorg-13-init-4330-g08a5277a-1."
2021-03-17 chromium-autoroll Roll Fuchsia SDK from 3.20210316.2.1 to 3.20210317.0.1
2021-03-16 rubensf [reclient] Add use_rbe where we have use_goma.
2021-03-16 chromium-autoroll Roll Fuchsia SDK from 3.20210316.1.1 to 3.20210316.2.1
2021-03-16 sdefresne [ios] Fix compilation of cronet
2021-03-16 thakis mac: Make win/cross build work when use_system_xcode is not explicitly set
2021-03-16 chromium-autoroll Roll Fuchsia SDK from 3.20210315.1.1 to 3.20210316.1.1
2021-03-16 hans Roll clang llvmorg-13-init-3462-gfe5c2c3c-2 : llvmorg-13-init-4330-g08a5277a-1.
2021-03-16 sdefresne [apple] Split definitions of mac and ios toolchains
2021-03-16 chromium-autoroll Roll Fuchsia SDK from 3.20210315.0.1 to 3.20210315.1.1
2021-03-16 pkotwicz [Build] Introduce GN variable for whether Java asserts are enabled
2021-03-15 ukai disable goma for x86_64-nacl-{gcc|g++}
2021-03-15 aeubanks Use LLVM's new pass manager on Android
(...)
2021-02-13 pkotwicz [Build] Switch androidx dependencies to use //third_party/androidx
2021-02-12 chromium-autoroll Roll Fuchsia SDK from 0.20210212.1.1 to 0.20210212.2.1
2021-02-12 tikuta build: do not use fdebug-compiation-dir in coverage build
2021-02-12 chromium-autoroll Roll Fuchsia SDK from 0.20210210.2.1 to 0.20210212.1.1
2021-02-12 akhuang [clang build] Disable PCH on Windows builds temporarily to unbreak ToT windows buildbots
2021-02-11 bjoyce [code-coverage] Combine code coverage profraw files locally.
2021-02-11 bpastene Install cpython on CrOS DUTs/VMs when running net_unittests.
2021-02-11 agrieve Android: Remove ProductConfig.COMPRESSED_LOCALES
2021-02-11 mheikal Add the ability to output keep rules between subsets of inputs.
2021-02-11 hans [build] Disable ThinLTO in PGO-instrumented builds on Windows
2021-02-11 chromium-autoroll Roll Fuchsia SDK from 0.20210210.1.1 to 0.20210210.2.1
2021-02-11 ynovikov Partially enable logcats for Android isolated scripts
2021-02-10 chromium-autoroll Roll Fuchsia SDK from 0.20210210.0.1 to 0.20210210.1.1
2021-02-10 kimstephanie Pass bucket name to goldctl
2021-02-10 hans [build] Include libstdc++.so.6 with llvm-symbolizer also for chromeos and android
2021-02-10 agl Mention FragmentActivityReplacer if indicated.
2021-02-10 heiserya Update perf tester build targets to deploy Chrome and Lacros to DUTs.
2021-02-10 agrieve Android: Tweak target names FOO_process_device -> FOO__process_device
2021-02-10 yfriedman [Flaky Tests] Android: don't re-run Batched unit tests
2021-02-10 wbielawski Fix chrome_public_apk build that utilizes python 3.
2021-02-10 chromium-autoroll Roll Fuchsia SDK from 0.20210209.2.2 to 0.20210210.0.1
2021-02-10 hans Reland "[build] Enable ThinLTO in official Windows builds"
2021-02-10 thakis win toolchain: Remove win8 sdk support, move toolchain hash to top
2021-02-10 chromium-autoroll Roll Fuchsia SDK from 0.20210209.0.1 to 0.20210209.2.2
2021-02-09 bpastene chromeos: Support --gtest_filter arg when running Tast tests.
2021-02-09 jkop Revert "[build] Enable ThinLTO in official Windows builds"
2021-02-09 chromium-autoroll Roll Fuchsia SDK from 0.20210208.3.1 to 0.20210209.0.1
2021-02-09 wnwen Android: Improve fast local dev build server
2021-02-09 rnk Reland "Roll src/buildtools/third_party/libc++/trunk/ d9040c75c..69897abe2 (1149 commits)"
2021-02-09 chromium-autoroll Roll Fuchsia SDK from 0.20210208.2.1 to 0.20210208.3.1
2021-02-09 thakis win: Use /winsysroot when using clang and the hermetic win toolchain.
2021-02-09 yucliu Fix use_custom_libcxx_for_host when host and target CPU are identical
2021-02-09 chromium-autoroll Roll Fuchsia SDK from 0.20210205.1.1 to 0.20210208.2.1
2021-02-08 hans [build] Enable ThinLTO in official Windows builds
2021-02-08 hans [build] Hoist import_instr_limit variable (take 2)
2021-02-08 drott Revert "[build] Hoist import_instr_limit variable"
2021-02-08 hans [build] Hoist import_instr_limit variable
2021-02-08 sdefresne [ios] Mark variables as "used"
2021-02-05 hans [build] Unify ThinLTO -import-instr-limit= between Android and Linux+Win
2021-02-05 hans Increase the ThinLTO cache size.
2021-02-05 sdefresne [ios] Improve performance of `gn gen` by 80%
2021-02-05 ythjkt Reland "Lacros: Flip OS_LINUX and OS_CHROMEOS on lacros."
2021-02-05 chromium-autoroll Roll Fuchsia SDK from 0.20210204.3.1 to 0.20210205.1.1
2021-02-05 aeubanks Roll clang llvmorg-12-init-17251-g6de48655-1 : llvmorg-13-init-794-g83e2710e-1.
2021-02-05 brucedawson Repackaged toolchain with Windows Kits\10 paths
2021-02-05 chromium-autoroll Roll Fuchsia SDK from 0.20210204.1.1 to 0.20210204.3.1
2021-02-04 alemate Add GN build-time option to support apitrace on Chrome OS
2021-02-04 agrieve Android: Delete main_dex_list.py and negative_main_dex_globs
2021-02-04 chromium-autoroll Roll Fuchsia SDK from 0.20210204.0.1 to 0.20210204.1.1
2021-02-04 ychoi Move //chrome/browser/{chromeos => ash}/profiles
Roll buildtools/ fc5af1ac7..69cc9b8a3 (33 commits; 3 trivial rolls)
fc5af1ac75..69cc9b8a3a
$ git log fc5af1ac7..69cc9b8a3 --date=short --no-merges --format='%ad %ae %s'
2021-03-12 yahan [Build] Build libc++ with gcc need libs atomic
2021-03-12 ukai [reclient] add rewrapper_windows_nacl.cfg
2021-03-11 yahan Revert "[Build] Build libc++ with gcc need libs atomic"
2021-03-09 yahan [Build] Build libc++ with gcc need libs atomic
2021-03-09 thakis Remove buildtools/DEPS
2021-03-09 thakis Remove gn from buildtools/DEPS
2021-03-09 rubensf [reclient] Match windows server addr to linux server addr.
2021-03-06 thakis buildtools: remove clang_format from buildtools/DEPS
2021-03-04 thakis Update a comment after #859627
2021-03-04 thakis buildtools: remove libc++ from buildtools/DEPS
2021-03-03 rubensf [reclient] Add re client windows configs.
2021-03-03 thakis Temporarily move clang_format_revision back to clang_fmt_revision
2021-03-03 thakis Remove ensure_gn_version hook
2021-03-03 thakis Minor DEPS file gardening
2021-03-02 thakis buildtools: remove libc++abi from buildtools/DEPS
2021-02-26 thakis Roll src/buildtools/third_party/libc++abi/trunk/ 5fb4080bf..6918862bf (1 commit)
2021-02-26 thakis Remove reclient from buildtools/DEPS
2021-02-25 msavigny Update reclient version to 0.22.0
2021-02-24 jam Update documentation to allow owners of public APIs that are used throughout the codebase to Owners-Override changes across the source tree.
2021-02-24 thakis Reland "Roll src/buildtools/third_party/libc++abi/trunk/ 196ba1aaa..5fb4080bf (222 commits)"
2021-02-24 yekuang Upgrading to re-client version 0.21.0.04acc59
2021-02-23 thakis Make sure to build libc++abi without -fsanitize=vptr.
2021-02-22 thakis buildtools: Remove libunwind from buildtools/DEPS
2021-02-22 findit-for-me Revert "Roll src/buildtools/third_party/libc++abi/trunk/ 196ba1aaa..5fb4080bf (222 commits)"
2021-02-16 rubensf [reclient] Add nacl toolchain config to reclient
2021-02-12 sdefresne Reland "Roll GN from 55ad154c..dfcbc6fe"
2021-02-11 olaola Upgrading to re-client version 0.20.1.c4bbd2f
2021-02-09 rogerta Revert "Roll GN from 55ad154c..dfcbc6fe"
2021-02-09 sdefresne Roll GN from 55ad154c..dfcbc6fe
2021-02-09 rnk Reland "Roll src/buildtools/third_party/libc++/trunk/ d9040c75c..69897abe2 (1149 commits)"
Roll tools/clang/ aecd85e06..24cecabb8 (51 commits)
aecd85e062..24cecabb89
$ git log aecd85e06..24cecabb8 --date=short --no-merges --format='%ad %ae %s'
2021-03-20 chonggu [Fuchsia] Build Fuchsia runtime on Fuchsia ToT bots
2021-03-19 mmoss Revert "[Fuchsia] Build Fuchsia runtime on ToT bots"
2021-03-19 chonggu [Fuchsia] Add --with-fuchsia flag for clang
2021-03-18 chonggu [Fuchsia] Build Fuchsia runtime on ToT bots
2021-03-18 hans Roll clang llvmorg-13-init-3462-gfe5c2c3c-2 : llvmorg-13-init-4720-g7bafe336-1.
2021-03-18 keishi Fix rewrite-multiple-platforms.sh to avoid ~
2021-03-17 dpapad Remove NTP Kaleidoscope feature leftovers.
2021-03-17 ortuno Revert "Roll clang llvmorg-13-init-3462-gfe5c2c3c-2 : llvmorg-13-init-4330-g08a5277a-1."
2021-03-16 hans Roll clang llvmorg-13-init-3462-gfe5c2c3c-2 : llvmorg-13-init-4330-g08a5277a-1.
2021-03-16 keishi Add a rewrite_raw_ptr_fields rewrite script for multiple platforms
2021-03-14 aeubanks Revert "Build clang with stable clang"
2021-03-14 aeubanks Build clang with stable clang
2021-03-11 hans Pass --rtlib=libgcc to Clang when building Android sanitizer runtimes
2021-03-10 hans Build Clang with -DCLANG_DEFAULT_RTLIB=libgcc on Linux
2021-03-09 aeubanks Add llvm-nm and llvm-strip to Linux Clang package
2021-03-05 thakis [mac/lld] update things for new lld being the default lld now, and update docs
2021-03-05 thakis Roll clang llvmorg-13-init-1559-g01b87444-3 : llvmorg-13-init-3462-gfe5c2c3c-1.
2021-03-04 ynovikov Remove ANGLE "pinned Chromium" bots from WebGL and Clang rolls
2021-03-04 keishi Treat CheckedPtr specially in FindBadConstructsConsumer
2021-03-03 ynovikov Remove usages of obsolete Win ANGLE x64 bots
2021-02-25 aeubanks Build Clang on Windows with ThinLTO
2021-02-25 lukasza Replace machine-specific test expectations with machine-agnostic ones.
2021-02-24 thakis Revert "Treat CheckedPtr specially in FindBadConstructsConsumer"
2021-02-24 bartekn Add bartekn and his team to rewrite.sh OWNERS
2021-02-24 keishi Treat CheckedPtr specially in FindBadConstructsConsumer
2021-02-23 thakis Remove some references to the LLVM_FORCE_HEAD_REVISION env var
2021-02-22 aeubanks Add flag to specify build directory
2021-02-18 bartekn rewrite.sh should overwrite combined-fields-to-ignore.txt
2021-02-18 bartekn Remove CheckedPtr2/MTECheckedPtr related exclusions
2021-02-17 keishi Force rewrite base::FileDescriptorWatcher::Controller::watcher_ in rewrite_raw_ptr_fields
2021-02-17 keishi Exclude OutOfMemoryTest::value_ from rewrite_raw_ptr_fields
2021-02-17 chonggu Manually update clang.
2021-02-17 bartekn [BRP] Move the GigaCage DCHECKs into checked_ptr.cc
2021-02-17 chonggu [Fuchsia] Create/Reorganize documentation for Fuchsia
2021-02-17 keishi Exclude new checked_ptr.h dependencies from rewrite_raw_ptr_fields
2021-02-16 chonggu [Fuchsia] Build Fuchsia profile runtime
2021-02-14 thakis Roll clang llvmorg-13-init-794-g83e2710e-1 : llvmorg-13-init-1559-g01b87444-1.
2021-02-13 aeubanks Remove obsolete argument
2021-02-12 aeubanks Don't build instrumented build with ThinLTO
2021-02-12 thakis Revert "clang build script: omit libc++ tests on mac again after #852778"
2021-02-11 thakis clang build script: omit libc++ tests on mac again after #852778
2021-02-11 lukasza Avoid inserting new includes when the previous line is a doc comment.
2021-02-10 akhuang [build.py] Fix path for copying libstdc++ to test directories
2021-02-10 thakis clang build script: run check-all during bootstrap on mac
2021-02-10 bartekn Update CheckedPtr ignore lists (fields and paths)
2021-02-09 yutak rewrite_raw_ptr_fields: Follow upstream CommonOptionsParser change.
2021-02-09 akhuang [build.py] Add sanitizer_common tests to the list of places we copy libstdc++ because of a test that moves llvm-symbolizer around
2021-02-05 aeubanks Remove some remnants from the 12 -> 13 transition
2021-02-05 aeubanks Roll clang llvmorg-12-init-17251-g6de48655-1 : llvmorg-13-init-794-g83e2710e-1.
2021-02-04 bartekn [PA][BRP] Adjust pointer before checking belonging to GigaCage
2021-02-04 omerkatz heap: Roll clang for cppgc updates
Created with:
roll-dep build buildtools tools/clang
Change-Id: Ia1abedb6374eda26f6ccf84c4ddeff65d0da0c86
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/45606
Commit-Queue: Austin Eng <enga@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Stephen White <senorblanco@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
With all tests converted to WGSL we only use shaderc to assemble SPIRV
assembly to binary. shaderc requires glslang but we don't use it at all.
By using SPIRV-Tools directly to assemble SPIR-V, we can remove both the
shaderc and glslang dependencies.
Bug: dawn:572
Bug: chromium:1150045
Change-Id: I1588428dfb9478e7b724478bec662d002ee920e0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/45765
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
And rename CreateShaderModuleFromWGSL to CreateShaderModule.
Bug: dawn:572
Change-Id: I80dab401078b2001d738b87d6e24437f93b690d1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/45764
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
This was silently failing for me, resuling in a crash somewhere completely different.
Change-Id: Iba9dfba8bb4c9e51a947a1337fc9718437ad5254
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/45766
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Contains a few helper tasks that make developing with VSCode easier
Change-Id: I4bc8c86638804255e6a23f95f4bb6d02dfeef7cd
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/45601
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
Broke this in https://dawn-review.googlesource.com/c/tint/+/45621
We don't want /MP enabled for clang-cl builds as this results in an
unused parameter /MP warning.
Also opportunistically clean up CMake script a little.
Bug: tint:665
Change-Id: I4047b75332c1aa64b32b695dfe050c255009e922
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/45820
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Previously code generators would unconditionally write the generated
files even if they didn't change, causing all many more files to be
rebuilt than necessary.
Make extract_json.py check the file content to skip writing if it can to
fix this.
Bug: None
Change-Id: I22389444179c9b16a7ccc03ea133a973d419fad3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/45761
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Tint/WGSL don't support 16bit floats yet, so use SPIRV assembly to
remove the dependency on glslang, instead of WGSL.
Bug: dawn:572
Change-Id: I6dd209e62f0550e7aecd18626b8807f7f1414b19
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/45605
Commit-Queue: Ben Clayton <bclayton@google.com>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
This was updated/clarified by the SPIR WG.
Bug: tint:3
Change-Id: Ie4c503f0e5f80ffeabada9c526375588e81a5ceb
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/45740
Auto-Submit: David Neto <dneto@google.com>
Commit-Queue: Alan Baker <alanbaker@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Alan Baker <alanbaker@google.com>
Skia changed to only use -Weverything for Skia files so we no longer
need to suppress this warning.
Bug: dawn:706
Change-Id: Ifcb2421abd24ec514396b8033057a62abd312e16
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/45608
Commit-Queue: Austin Eng <enga@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
It required storageBarrier() to be implemented in Tint.
Bug: dawn:572
Change-Id: I62e8d89ef7a049044f3381dc66163466d62c839d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/45604
Commit-Queue: Ben Clayton <bclayton@google.com>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
This also removes the ability for the fuzzer to perform error
injection to generate testcases. The preferred method is to
use one of the Dawn test binaries to produce the trace directly.
Bug: dawn:629
Change-Id: If7295f9e6da5618be8f44e9301aa12dc56fcdfef
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/40301
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Skia changed to only add -Weverything for Skia files so this warning is
no longer needed.
Bug: dawn:706
Change-Id: I7ac111cfaf580ee0868fb318f953fe983ee17df2
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/45607
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Disable warning C4324: 'struct_name' : structure was padded due to
__declspec(align())
Multiprocessor builds are not enabled by default when using msbuild,
unlike for Ninja builds.
Bug: tint:665
Change-Id: I0e50c88ac91acd963c31c07cbbf2fae6b743e77d
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/45621
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
This is a reland of f84daa070f05eb80672a9a23e23aed205fe72a5e
Eliminate static initializer(disallowed in Chromium) by replacing
shader string living in anonymous namespace from type "std::string"
to char array.
Original change's description:
> CopyTextureForBrowser: Support color format conversion
>
> This CL enables blit from RGBA8Unorm soruce texture to dst texture that
> |CopyImageBitmapToTexture| supported dst format.
>
> BUG=dawn:465
>
> Change-Id: I99846cf8dc37bc89e0c168a3d86193bb3a0c0ebb
> Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/44020
> Commit-Queue: Shaobo Yan <shaobo.yan@intel.com>
> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
> Reviewed-by: Austin Eng <enga@chromium.org>
Bug: dawn:465
Change-Id: Ic3a156f5a20b217fd2aa5f86b01bad8ce77dc41c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/45443
Commit-Queue: Shaobo Yan <shaobo.yan@intel.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Improved error message to use friendly names. Fixed tests that broke as
a result of this change.
Bug: tint:642
Change-Id: I9a1e819e1a6110a89c826936b96ab84f7f79a084
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/45582
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
This enum isn't being used in Dawn yet, so it is safe to change without
deprecating it first.
BUG=dawn:700
Change-Id: I0f3cc788f26a8001f82aba4f9b3920e84204e4e4
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/45620
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: David Neto <dneto@google.com>
Still leave deprecated `depth` functional as there are some references in
other clients. Using `depth` and `depthOrArrayLayers` at the same time is
invalid. Add DeprecatedAPITests.
Bug: chromium:1176969
Change-Id: Ia06645e4f3c17588323dd36b11f9f3988b2e3aba
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/44640
Commit-Queue: Shrek Shao <shrekshao@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Destroying the adapter without the debug layer installed
would crash the process upon access of the debug filters.
Bug: dawn:460
Change-Id: I04819c5136af780fd3b981857bd87d69d4abc9c7
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/45560
Commit-Queue: Bryan Bernhart <bryan.bernhart@intel.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
This is in preparation of removing all the DAWN_ENABLE_WGSL logic: the
ShaderModuleBase will have either mSpirv or mTintProgram set based on
UseTintGenerator.
Also improves the constness of some functions.
Also simplifies a bit ShaderModuleBase::Initialize.
Bug: dawn:706
Change-Id: Ib879e2aec8a004aeb8ac5dc6e1176b1667fc227d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/45422
Commit-Queue: Austin Eng <enga@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Call validation was already implemented in Resolver. This change
completes it by deleting the relevant code in Validator, and moving and
updating the builtins validation test to use the Resolver.
Also added the "v-0004" error code for when detecting recursion, as was
done for the similar error in the Validator.
Bug: tint:642
Bug: tint:487
Change-Id: If7973bfd2d19681a0cbf48c6d427e17a3b927cde
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/45463
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
This was mostly already implemented in the Resolver, except for adding a
variable scope for blocks.
Moved tests and improved them to only add Source on the error node.
Bug: tint:642
Change-Id: I175dd22c873df5933133bc92276101aeab3021ed
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/45460
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
ast::IdentifierExpression nodes can appear outside of functions
(e.g. as initializers for module-scope variables), so we cannot assume
that current_block_ is not nullptr.
We already have several tests that do this, but for some reason the
nullptr dereference does not cause problems on our presubmits.
Change-Id: I612f3eb0d5711a0b1d0bb71663be7cca388b2b3c
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/45580
Auto-Submit: James Price <jrprice@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
This isn't in the WGSL spec, nor is it generated by readers.
This was only used inside the SPIR-V writer, but this remaining usage was removed in the parent change.
Change-Id: I1bbfde67dc760b761af010a7a144dccb52369148
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/45343
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: David Neto <dneto@google.com>
Downstream users have all caught up to the change.
Remove the "uniform_constant" token from the WGSL parser.
Fixed: tint:332
Change-Id: I046f93d5e6c26b89d419763e73b1ca583250570f
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/45462
Auto-Submit: James Price <jrprice@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Requiring a temporary stack-allocated ast::Literal is an unpleasant requirement to generate a SPIR-V constant value.
GenerateU32Literal() was also creating an invalid AST - the type was U32, yet an an ast::SintLiteral was used.
Instead add Constant for holding a constant value, and use this as the map key.
This also removes the last remaining use of ast::NullLiteral, which will be removed in the next change.
Change-Id: Ia85732784075f153503dbef101ba95018eaa4bf5
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/45342
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: David Neto <dneto@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Also test initializing a const from a function parameter.
Bug: tint:642
Change-Id: Ic10a4e8b5a2f67f56bc3720cb59f8d306e175d66
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/45520
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
This regression was accidentally introduced by my CL:
https://dawn-review.googlesource.com/c/tint/+/45382
I had removed too much of ValidatorImpl::ValidateFunction, including
its pushing of function parameters to the variable stack. As a result,,
any function parameters referenced by a function would fail the
Validator. This CL restores this bit, and adds a test for this case.
Bug: tint:642
Change-Id: I839057e73cabfb11631571ce806dec09f5d9f966
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/45500
Auto-Submit: Antonio Maiorano <amaiorano@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Since it isn't used by anyone yet we can make a breaking change to
CreateRenderPipelineAsync to immediately start using
RenderPipelineDescriptor2.
Bug: dawn:1177501
Change-Id: I9f88c6fc1b325b7a9356536e2a071d4f17abd6ea
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/45280
Commit-Queue: Brandon Jones <bajones@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
This has now been added.
Bug: tint:652
Change-Id: I5ed8a825dcca500748d5ced66f1ce41dd0c9d6b8
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/45344
Auto-Submit: Ben Clayton <bclayton@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
