Commit Graph

9380 Commits

Author SHA1 Message Date
Stephen Gutekanst 9514098b31 dawn/native/d3d12: improve constexpr compatability with clang
In Mach engine we compile Dawn's d3d12 backend using Zig as a C/C++
compiler, effectively clang with MinGW windows headers. Unfortunately,
this `static constexpr` fails to compile:

```
error: constexpr variable 'kD3D12PromotableReadOnlyStates' must be initialized by a constant expression
```

As kangz previously noted, the reason appears to be because `D3D12_RESOURCE_STATE_COPY_SOURCE`
is not `constexpr` [in MinGW headers](1de9cc347d/mingw-w64-headers/include/winnt.h (L682)).
The thought process is that making this just `const` is fine because
constant propagation would make it a constant anyway.

If we're comfortable merging this, it'd be one less change we have to
maintain on our side - and probably no impact otherwise. On the other
hand, I understand the most-correct fix would be in MinGW headers
themselves. I'd love to land this change, but it's no big deal if you
prefer not.

Signed-off-by: Stephen Gutekanst <stephen@hexops.com>
Change-Id: I772f1cb7e2b4f1b200820cd50f6b7df45850abbb
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/87381
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-07-11 20:12:48 +00:00
shrekshao a3f4a32022 Add clear alpha to one step to copy texture for browser
Bug: chromium:1331139
Change-Id: I69c31aea0320f302be686adf0167649a98db3414
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95682
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Shaobo Yan <shaobo.yan@intel.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2022-07-11 18:11:14 +00:00
shrekshao c6cbcdb05b Add internal usage for copyTextureForBrowser
Add an internal usage option for copyTextureForBrowserOption
allowing internal calls from call to use canvas context
texture as source/destination.

Bug: chromium:1331139
Change-Id: Ida8421b3962a6434e8ef57c581c7a2e1d607954c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/94985
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Shrek Shao <shrekshao@google.com>
Reviewed-by: Loko Kung <lokokung@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2022-07-11 18:11:14 +00:00
Corentin Wallez e629aee91a dawn::native: Check that ExternalTexture bindings are ExternalTextures
The code was checking the equivalence in one direction but not the
other, leading to a case where passing a TextureView instead of an
ExternalTexture passed validation and lead to crashes in the backends.

Bug: chromium:1343099
Change-Id: I428252796df375e7cf3a6df1a03192d65364e370
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95944
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Shrek Shao <shrekshao@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-07-11 17:21:17 +00:00
Ben Clayton 8ce7183e68 tint: Remove public include of ast include
ast::PipelineStage is private API. Duplicate the enum for the inspector.
Change-Id: Ib79600d2ef86cc13f409c7c800f98ea42bb3ace4
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95943
Commit-Queue: Ben Clayton <bclayton@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
2022-07-11 17:17:23 +00:00
Zhaoming Jiang a5988a3058 tint/writer/hlsl: Support for F16 type, constructor, and convertor
This patch make HLSL writer support emitting f16 types, f16 literals,
f16 constructor and convertor. Unittests are also implemented.

The HLSL writer will emit f16 literal as `float16_t(1.23h)`, making the
type explicit, and map f16 types as follow. The generated code require
DXC with SM6.0 or higher, and `-enable-16bit-types`.
WGSL type   -> HLSL type
f16         -> float16_t
vec2<f16>   -> vector<float16_t, 2>
vec3<f16>   -> vector<float16_t, 3>
vec4<f16>   -> vector<float16_t, 4>
mat2x2<f16> -> matrix<float16_t, 2, 2>
mat2x3<f16> -> matrix<float16_t, 2, 3>
mat2x4<f16> -> matrix<float16_t, 2, 4>
mat3x2<f16> -> matrix<float16_t, 3, 2>
mat3x3<f16> -> matrix<float16_t, 3, 3>
mat3x4<f16> -> matrix<float16_t, 3, 4>
mat4x2<f16> -> matrix<float16_t, 4, 2>
mat4x3<f16> -> matrix<float16_t, 4, 3>
mat4x4<f16> -> matrix<float16_t, 4, 4>

Bug: tint:1473, tint:1502
Change-Id: Iaf564f3ce29ace2984cef19d7df5a7dfb0fab2ef
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95685
Commit-Queue: Zhaoming Jiang <zhaoming.jiang@intel.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
2022-07-11 15:43:38 +00:00
Ben Clayton 94c6495ad2 dawn/node: Don't abort if the GPUDevice is not destroyed
Before being destructed.
If the Destroy() method is not called, then the lost_promise_ is not resolved or rejected, triggering an assertion.

Change-Id: I0a7c06674bc58d2e7c4df4229452bd2de27ca2b5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95941
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2022-07-11 13:33:48 +00:00
Ben Clayton 1604ae5b97 dawn/node: Work around NodeJS brokenness with printing long strings.
Attempting to print a long string can cause output to go missing.
Split long strings up into 4k chunks.

Change-Id: Ibcb07459bd8fb4a1a11b6f8db41c8378274a6d09
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95940
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-07-11 11:45:08 +00:00
Dawn Autoroller af13cc714b Roll ANGLE from adcc645392e2 to 659fb3c50e7c (1 revision)
adcc645392..659fb3c50e

2022-07-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 14abb4e33fdf to eb8af3adeed3 (542 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC dsinclair@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dsinclair@google.com
Change-Id: Iac5c5d8f72fe0aed829c000bc2470b5ef3246aac
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95900
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-07-11 09:33:58 +00:00
Zhaoming Jiang e9c5070348 tint/writer/msl: Support for F16 type, constructor, and convertor
This patch make MSL writer support emitting f16 types, f16 literals,
f16 constructor and convertor. Unittests are also implemented.

The MSL writer will emit f16 literal as `1.23h`, and map f16 types as
follow:
WGSL type   -> MSL type
f16         -> half
vec2<f16>   -> half2
vec3<f16>   -> half3
vec4<f16>   -> half4
mat2x2<f16> -> half2x2
mat2x3<f16> -> half2x3
mat2x4<f16> -> half2x4
mat3x2<f16> -> half3x2
mat3x3<f16> -> half3x3
mat3x4<f16> -> half3x4
mat4x2<f16> -> half4x2
mat4x3<f16> -> half4x3
mat4x4<f16> -> half4x4

Bug: tint:1473, tint:1502
Change-Id: Id91821e1a32d48c80bad9a0753faa5247835b0f7
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95686
Commit-Queue: Zhaoming Jiang <zhaoming.jiang@intel.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
2022-07-11 03:03:11 +00:00
Zhaoming Jiang 0d3d3210d4 tint/writer/glsl: Support for F16 type, constructor, and convertor
This patch make GLSL writer support emitting f16 types, f16 literals,
f16 constructor and convertor. Unittests are also implemented, and
end-to-end testcases are updated for GLSL extension requirement.

The GLSL writer will require `GL_AMD_gpu_shader_half_float` extension if
f16 WGSL extension is enabled, emit f16 literal as `1.23hf`, and map f16
types as follow:
WGSL type   -> GLSL type
f16         -> float16_t
vec2<f16>   -> f16vec2
vec3<f16>   -> f16vec3
vec4<f16>   -> f16vec4
mat2x2<f16> -> f16mat2
mat2x3<f16> -> f16mat2x3
mat2x4<f16> -> f16mat2x4
mat3x2<f16> -> f16mat3x2
mat3x3<f16> -> f16mat3
mat3x4<f16> -> f16mat3x4
mat4x2<f16> -> f16mat4x2
mat4x3<f16> -> f16mat4x3
mat4x4<f16> -> f16mat4

Bug: tint:1473, tint:1502
Change-Id: I7e788f82be2873911961c891a644200c1cbb74db
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95684
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Zhaoming Jiang <zhaoming.jiang@intel.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
2022-07-11 03:02:28 +00:00
Yunchao He f580be6960 Add a test to detect texture corruption on D3D12
Textures with particular dimensions may corrupt on some devices for
copy and rendering. This change add a test to detect it.

Bug: dawn:949
Change-Id: Idcb346191c1c7beac4c5ff91464bd14d8eeba6f3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95680
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Yunchao He <yunchao.he@intel.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-07-08 22:35:05 +00:00
Austin Eng 1b4da5d28f Vulkan: Implement WGSL->SPIRV caching
Bug: dawn:1480
Change-Id: I77facc854ce9d5fe41c2332236113f266178470a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/94660
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-07-08 21:30:25 +00:00
Dawn Autoroller 6d41e60a77 Roll ANGLE from 94bbb40a42cd to adcc645392e2 (3 revisions)
94bbb40a42..adcc645392

2022-07-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 867b77cee987 to ef9a6635208b (14 revisions)
2022-07-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 1d6a1036bdb3 to 16e026a959f1 (1 revision)
2022-07-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 84d7af71045d to 14abb4e33fdf (505 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC dsinclair@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dsinclair@google.com
Change-Id: If2f9f0bc1f93deb557794efcdf90fbbeca8f2ad5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95880
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-07-08 21:22:55 +00:00
Zhaoming Jiang 9c71174f38 tint/resolver: Temporally ban f16 in buffer, pipeline IO and override
This patch make resolver reject using f16 types in uniform or storage
buffer, pipeline IO or overridable variable, since these are not
implemented yet. This can help prevent hitting invalid path in writers.

Bug: tint:1473, tint:1502
Change-Id: I5ea753e4254276a6d141d7012a6d0987423a61cf
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95827
Reviewed-by: Ben Clayton <bclayton@google.com>
Auto-Submit: Zhaoming Jiang <zhaoming.jiang@intel.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Zhaoming Jiang <zhaoming.jiang@intel.com>
2022-07-08 19:35:05 +00:00
Corentin Wallez 03d9835d14 Roll third_party/abseil-cpp/ 789af048b..e44b3e77a (88 commits; 1 trivial rolls)
789af048b3..e44b3e77a9

$ git log 789af048b..e44b3e77a --date=short --no-merges --format='%ad %ae %s'
2022-07-06 danilchap Roll abseil_revision 736458b555..4bbdb02689
2022-06-29 mbonadei Roll abseil_revision d2c5297a3c..736458b555
2022-06-23 ynovikov Update absl DEF files
2022-06-20 danilchap Roll abseil_revision 2e36d96669..d2c5297a3c
2022-06-16 wutao Revert "Reland "Roll src/buildtools/third_party/libc++/trunk/ b1269813e..1a637088a (287 commits)""
2022-06-16 zafzal Reland "Roll src/buildtools/third_party/libc++/trunk/ b1269813e..1a637088a (287 commits)"
2022-06-16 ayzhao Revert "Roll src/buildtools/third_party/libc++/trunk/ b1269813e..1a637088a (287 commits)"
2022-06-15 mbonadei Roll abseil_revision 2617970857..2e36d96669
2022-06-10 mbonadei Roll abseil_revision 1963f10ae5..2617970857
2022-05-26 ayzhao Reland "Roll src/buildtools/third_party/libc++/trunk/ 79a2e924d..b1269813e (1399 commits)"
2022-05-25 danilchap Roll abseil_revision 9df63a8bea..1963f10ae5
2022-05-18 mbonadei Roll abseil_revision 5073947530..9df63a8bea
2022-05-16 ayzhao Update gRPC version to 2022-05-12
2022-05-16 aeubanks Re-add "-Xclang -no-opaque-pointers"
2022-05-16 ynovikov Fix abseil .def files after turning on opaque pointers in clang
2022-05-11 danilchap Roll abseil_revision 8d9cef25c7..5073947530
2022-05-05 danilchap Rerun .def generation for abseil roll
2022-05-04 mbonadei Roll abseil_revision 731689ffc2..8d9cef25c7
2022-05-03 avi Remove base::in_place and base::in_place_type_t
2022-04-26 danilchap Roll abseil_revision 6f43f5bb39..731689ffc2
2022-04-22 aeubanks Reland Roll clang llvmorg-15-init-7570-gba4537b2-1 : llvmorg-15-init-7980-g4ffd0b6f-2
2022-04-14 thakis Reland "Roll clang llvmorg-15-init-7040-g50de659a-3 : llvmorg-15-init-7570-gba4537b2-1"
2022-04-14 ortuno Revert "Roll clang llvmorg-15-init-7040-g50de659a-3 : llvmorg-15-init-7570-gba4537b2-1"
2022-04-14 findit-for-me Revert "Roll abseil_revision 6f43f5bb39..ac1398a629"
2022-04-14 thakis Roll clang llvmorg-15-init-7040-g50de659a-3 : llvmorg-15-init-7570-gba4537b2-1
2022-04-13 danilchap Roll abseil_revision 6f43f5bb39..ac1398a629
2022-04-06 mbonadei Roll abseil_revision 3204cc0625..6f43f5bb39
2022-03-30 danilchap Roll abseil_revision f3489c9ca6..3204cc0625
2022-03-23 mbonadei Roll abseil_revision 231c393a17..f3489c9ca6
2022-03-16 danilchap Roll abseil_revision c5a424a2a2..231c393a17
2022-03-09 mbonadei Roll abseil_revision 5e4ea1ce09..c5a424a2a2
2022-03-07 hans Roll clang llvmorg-15-init-1995-g5bec1ea7-4 : llvmorg-15-init-3540-g85c53c70-1
2022-03-02 danilchap Roll abseil_revision 7f850b3167..5e4ea1ce09
2022-02-23 mbonadei Roll abseil_revision c2ef703338..7f850b3167
2022-02-21 mbonadei Re-enable hash_test.
2022-02-16 danilchap Roll abseil_revision 73316fc3c5..c2ef703338
2022-02-16 danilchap Add absl::Cleanup to absl component
2022-02-09 mbonadei Roll abseil_revision 5202173ca7..73316fc3c5
2022-02-02 danilchap Roll abseil_revision e3fdd9b16a..5202173ca7
2022-01-31 sdefresne Convert use of deprecated macro
2022-01-27 mbonadei Reland "Roll abseil_revision c59e7e59f5..e3fdd9b16a"
2022-01-26 findit-for-me Revert "Roll abseil_revision c59e7e59f5..e3fdd9b16a"
2022-01-26 hans Roll clang llvmorg-14-init-12719-gc4b45eeb-5 : llvmorg-14-init-17086-g38e16e1c-2
2022-01-26 mbonadei Roll abseil_revision c59e7e59f5..e3fdd9b16a
2022-01-19 danilchap Roll abseil_revision 2a042b082c..c59e7e59f5
2022-01-18 avi Rename c++11.md
2022-01-17 leszeks Revert "Roll clang llvmorg-14-init-12719-gc4b45eeb-3 : llvmorg-14-init-14241-ged3a4a49-1"
2022-01-12 mbonadei Roll abseil_revision c498947f8c..2a042b082c
2022-01-11 thakis Roll clang llvmorg-14-init-12719-gc4b45eeb-3 : llvmorg-14-init-14241-ged3a4a49-1
2022-01-05 danilchap Roll abseil_revision 04610889a9..c498947f8c
2022-01-04 mbonadei Roll abseil_revision f523d0dd69..04610889a9
2021-12-21 danilchap Roll abseil_revision 1065514ef3..f523d0dd69
2021-12-21 mingcl Update gRPC, its gn template, plugin registry and absl_component_deps
2021-12-18 thakis Roll clang llvmorg-14-init-12246-g7787a8f1-2 : llvmorg-14-init-12719-gc4b45eeb-1
2021-12-15 mbonadei Roll abseil_revision 9336be04a2..1065514ef3
2021-12-11 mbonadei Add missing dependency
2021-12-08 danilchap Roll abseil_revision 3e1983c5c0..9336be04a2
2021-12-02 ynovikov Update abseil-cpp DEF files after clang roll
2021-12-01 mbonadei Roll abseil_revision ec0d76f1d0..3e1983c5c0
2021-11-26 thakis Build with -std=c++17 on Windows.
2021-11-25 johannkoenig Revert "Build with -std=c++17 on some platforms"
2021-11-25 thakis Build with -std=c++17 on some platforms
2021-11-24 danilchap Roll abseil_revision 9b924cedb6..ec0d76f1d0
2021-11-17 mbonadei Roll abseil_revision 39f46faa69..9b924cedb6
2021-11-13 pbos Rename "base/macros.h" => "base/ignore_result.h"
2021-11-10 danilchap Roll abseil_revision 3b22e57740..39f46faa69
2021-11-09 sdefresne [ios] Remove support for building with Xcode clang
2021-11-04 mbonadei Reland "Roll abseil_revision f70eadadd7..3b22e57740"
2021-11-03 avi Revert "Roll abseil_revision f70eadadd7..3b22e57740"
2021-11-03 mbonadei Roll abseil_revision f70eadadd7..3b22e57740
2021-11-03 thakis win: Remove a few /wd flags
2021-11-03 mingcl Add absl/strings:cord to absl_component_deps
2021-10-27 danilchap Roll abseil_revision a2f52e1177..f70eadadd7
2021-10-20 mbonadei Roll abseil_revision d6f40f4e1f..a2f52e1177
2021-10-14 danilchap Remove Karl from abseil-in-chromium owners
2021-10-13 danilchap Roll abseil_revision b9b925341f..d6f40f4e1f
2021-10-08 dcheng [absl] Explicitly use hardened versions of various absl classes.
2021-10-06 mbonadei Roll abseil_revision 7143e49e74..b9b925341f
2021-09-29 danilchap Roll abseil_revision 1ce4ceca2b..7143e49e74
2021-09-27 mbonadei Revert "absl: Suppress -Wunused-value for files including internal/flag.h"
2021-09-24 mbonadei Roll abseil_revision de71511109..1ce4ceca2b
2021-09-23 thakis absl: Suppress -Wunused-value for files including internal/flag.h
2021-09-22 mbonadei Roll abseil_revision b2dc72c17a..de71511109
2021-09-20 danilchap Patch BUILD.bazel file to exclude legacy annotations headers
2021-09-15 joenotcharles Replace c++11.html with c++11.md.
2021-09-15 danilchap Roll abseil_revision 8c800bb08d..b2dc72c17a
2021-09-08 mbonadei Roll abseil_revision 637722af3a..8c800bb08d

Created with:
  roll-dep third_party/abseil-cpp

Bug: dawn:1484

Change-Id: I35253ac55d0dd6a3d87406a92637f7feb7dd1e6b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95843
Kokoro: Kokoro <noreply+kokoro@google.com>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-07-08 17:04:15 +00:00
Shrek Shao e1d0aa9f92 Inline memory transfer service offset bound update
Offset > 0 is already implicitly included in this if statement
(when `offset == 0` then `size > mDataLength` could safely assert it's invalid).
So we could remove it and use `offset > mDataLength` instead of `>=`.

Bug: chromium:1340654
Change-Id: Ieafe1ea6bef5aae29bc6ef2bd9702d6f7a92d8b5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95820
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Loko Kung <lokokung@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Shrek Shao <shrekshao@google.com>
2022-07-08 14:42:24 +00:00
Ben Clayton 2777cbc441 tools/cts: Fix go unit tests
Got broken with https://dawn-review.googlesource.com/c/dawn/+/95841.

Change-Id: I75e0996dfb453ffa66dd580252a7f6fbcf8e46a7
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95845
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Ben Clayton <bclayton@google.com>
2022-07-08 14:23:15 +00:00
Ben Clayton be88e62c0f tools/cts: Treat 'Skip' results as 'Pass'
Change-Id: I2548c2449e535cff1f6907a9f2e892037038aa02
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95841
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Ben Clayton <bclayton@chromium.org>
2022-07-08 12:33:46 +00:00
Ben Clayton d31838aff1 tint: Fix x86 build
Change-Id: Idb2002dd59cf12e49f75af6174e08258b4331137
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95840
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-07-08 12:17:34 +00:00
Dawn Autoroller 2468978f0b Roll ANGLE from 929a3752077e to 94bbb40a42cd (5 revisions)
929a375207..94bbb40a42

2022-07-08 lexa.knyazev@gmail.com GL: Enable pack skip emulation on all Apple drivers
2022-07-07 cclao@google.com Vulkan: Remove VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT
2022-07-07 lexa.knyazev@gmail.com D3D9: Implement float sources for Image9::copyFromRTInternal
2022-07-07 lexa.knyazev@gmail.com Clamp viewport dimensions on store
2022-07-07 mark@lunarg.com Extend labelObject functionality

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC dsinclair@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dsinclair@google.com
Change-Id: Ifeef973ad4684cacab02dd747d7414d49c4ec73e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95801
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-07-08 08:26:34 +00:00
Dawn Autoroller 342931ae08 Roll ANGLE from afcca86c6da3 to 929a3752077e (4 revisions)
afcca86c6d..929a375207

2022-07-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 7987bda077c8 to 1d6a1036bdb3 (2 revisions)
2022-07-07 lexa.knyazev@gmail.com Expose EXT_compressed_ETC1_RGB8_sub_texture on Metal and GL
2022-07-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 34e0281e9664 to c119749eff1f (5 revisions)
2022-07-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 0820cef93768 to 84d7af71045d (436 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC dsinclair@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dsinclair@google.com
Change-Id: If1ffff157e37e7775e5dbda017240292017e0d3c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95800
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-07-07 18:53:21 +00:00
Ben Clayton 63e6f820d8 tint/resolver: Evaluate const-expr swizzles
Bug: chromium:1341475
Change-Id: I2ac44824b08c460df759a96d0ba96f6045b60f74
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95765
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-07-07 17:49:02 +00:00
Ben Clayton d5f53ab580 tint/resolver: Optimize constant evaluation methods
Materialize() was re-evaluating the constant values for the incoming
semantic expression, despite this already being evaluated. Just use the
sem::Expression::ConstantValue().

resolver.cc already has all the semantic pointers, so pass them in
instead of pointlessly hitting the ast -> sem map.

Change-Id: If2bc7cd10f79079fb811e9d83c5150dd3c0c244c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95764
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
2022-07-07 17:30:11 +00:00
Ben Clayton 51265542e9 tint/sem: Remove TypeMappings for derived expressions
Any AST expression may map to a sem::Materialize, so the inferred
mapping is bug-prone (the implicit sem type may mismatch and Get() may
return nullptr).

Change-Id: I34485a4a067635df930a407316fae8b2e9628c3d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95763
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-07-07 17:15:01 +00:00
Ben Clayton b6c8ea9624 tint/resolver: Fix calling of builtins at module-scope
No builtins are implemented as `@const` yet, but validation handles this already.

Bug: chromium:1341472
Change-Id: Id85893345299ba3414e2d15b85dd071c326f481d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95762
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-07-07 17:04:21 +00:00
Ben Clayton 89bdea0f77 tint/resolver: Fix null-deref
Materialize() can return nullptr, if there's an error.
Check the returned pointer for nullptr, before continuing on to using the pointer.

Bug: chromium:1341313
Change-Id: Ib7c9e593fbf2bb4374305c341c2b04e34e7487e9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95761
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
2022-07-07 16:56:21 +00:00
Ben Clayton 808f616762 gn: Add empty ubsan ignore list
Required to build Dawn with GN flag `is_ubsan = true`

Change-Id: I80b49b81377f0a9c8bd2c1310e12786427947c38
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95760
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
2022-07-07 16:34:01 +00:00
Dawn Autoroller e427a9ba5e Roll SwiftShader from 1d6a1036bdb3 to 16e026a959f1 (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/1d6a1036bdb3..16e026a959f1

2022-07-07 swiftshader.regress@gmail.com Regres: Update test lists @ 1d6a1036

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC dsinclair@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dsinclair@google.com
Change-Id: I3d7d7682edc5dc9dff2e3077301e57e57dce5376
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95780
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-07-07 14:17:01 +00:00
dawn-autoroll fcceb0ee80 Roll vulkan-deps from 6745d5386850 to c119749eff1f (4 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/6745d5386850..c119749eff1f

Changed dependencies:
* spirv-tools: dcee3a5de0..05de650371
* vulkan-validation-layers: a83fbb9594..c9ceaf94e8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC dsinclair@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dsinclair@google.com
Change-Id: I870e21dc2c1c4f89fdfd7435b9620255ecf5478b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95683
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-07-07 10:22:51 +00:00
Alexis Hetu 09a98b64be Remove Dawn Depth16Unorm test suppressions for SwiftShader Vulkan
The Depth16Unorm specific issue should now be fixed:
https://swiftshader-review.googlesource.com/c/SwiftShader/+/66888
so the test suppressions can be removed.

Bug: b/204919030
Change-Id: Ib221d2e11712995237da506ecc6de1f292bfa0bb
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95700
Auto-Submit: Alexis Hétu <sugoi@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-07-07 09:38:31 +00:00
Dawn Autoroller 17eb23d198 Roll ANGLE from 3e5de4acc1fa to afcca86c6da3 (8 revisions)
3e5de4acc1..afcca86c6d

2022-07-07 b.schade@samsung.com Fix ValidateCompressedTexSubImage3D compressed format check
2022-07-07 lehoangquyen@google.com Metal: Allow Surfaces to be created without depth & stencil
2022-07-07 syoussefi@chromium.org Vulkan: Resolve GoogleX MSRTSS conflict with EXT
2022-07-06 m.maiya@samsung.com Vulkan: min/mag filters follow chroma filter value
2022-07-06 eddiehatfield@google.com Merge getTempPath and CreateTemporaryFile
2022-07-06 rafael.cintron@microsoft.com Handle OOM in SwapChain11::getRenderTargetShaderResource
2022-07-06 syoussefi@chromium.org Fix samples' arguments to SampleApplication
2022-07-06 antonio.caggiano@collabora.com Vulkan: Wayland resize callback

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC dsinclair@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dsinclair@google.com
Change-Id: I389fe4422ef2d27f9883811b5ab6077b0572ede9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95721
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-07-07 05:48:01 +00:00
Zhaoming Jiang 2c7440a13f tint: Implement f16 value binary representation
This CL add methods that return the binary16 bit pattern for a
constructed Number<detail::NumberKindF16>. This is required for
generating SIPR-V oprand.

Bug: tint:1473, tint:1502
Change-Id: Ia3680cdb5a0e64d31bfe2f48432cda3850c1f5a7
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95240
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Zhaoming Jiang <zhaoming.jiang@intel.com>
2022-07-07 03:29:11 +00:00
Dawn Autoroller 590040cfb4 Roll SwiftShader from 488cb63b5b4d to 1d6a1036bdb3 (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/488cb63b5b4d..1d6a1036bdb3

2022-07-06 sugoi@google.com Always perform depth test using floating point values

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC dsinclair@google.com,sugoi@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dsinclair@google.com,sugoi@google.com
Change-Id: Ib44d2d63bad17a9cf0138635f38b2bf3a568d577
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95720
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-07-06 23:34:30 +00:00
dawn-autoroll 8cc040fb31 Roll vulkan-deps from 34e0281e9664 to 6745d5386850 (1 revision)
https://chromium.googlesource.com/vulkan-deps.git/+log/34e0281e9664..6745d5386850

Changed dependencies:
* spirv-tools: 5f4284aa78..dcee3a5de0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC dsinclair@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dsinclair@google.com
Change-Id: Ic537629daccc1bf5c1a7352c2508f5e9e7d0d1c3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95681
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-07-06 20:51:13 +00:00
David Neto 3f56970c2a Fix relative reference to docs/building.md
Change-Id: Id8d448d86f06f1fa69ead54c875e947690e49eaf
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95380
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: David Neto <dneto@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-07-06 19:23:51 +00:00
Dan Sinclair caead5d3a5 Roll third_party/webgpu-cts/ 5de908c54..8cfc317e2 (1 commit)
Update:
 - expectations.txt
 - ts_sources.txt
 - resource_files.txt
 - webtest .html files


5de908c54a..8cfc317e23
 - 8cfc31 Seperate out interval operation definitions from builder functions (#1628)

Created with './tools/run cts roll'

Change-Id: Iddda2eebb44375a83f697b22f4969911f0944fcc
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95661
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
2022-07-06 18:01:40 +00:00
Dawn Autoroller b0a35cde3d Roll ANGLE from 9070e279a887 to 3e5de4acc1fa (4 revisions)
9070e279a8..3e5de4acc1

2022-07-06 chris@rive.app Add a test that passes image2D handles as function args
2022-07-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from d1116fa9e9dc to 7987bda077c8 (1 revision)
2022-07-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 24ed8b7a6bd7 to 34e0281e9664 (9 revisions)
2022-07-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 532c25a8e2ac to 0820cef93768 (270 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC dsinclair@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dsinclair@google.com
Change-Id: I1b1be937e95f1dc569fc575da7e6d140830123a6
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95662
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-07-06 16:38:40 +00:00
Dawn Autoroller 9b4b5591bf Roll SwiftShader from 7987bda077c8 to 488cb63b5b4d (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/7987bda077c8..488cb63b5b4d

2022-07-06 swiftshader.regress@gmail.com Regres: Update test lists @ 7987bda0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC dsinclair@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dsinclair@google.com
Change-Id: Iafb6ac07dd8f96b624704f4ebe625f47acf45085
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95660
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-07-06 14:44:30 +00:00
dawn-autoroll 561e57fcbe Roll vulkan-deps from 5d976018641e to 34e0281e9664 (8 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/5d976018641e..34e0281e9664

Changed dependencies:
* spirv-tools: 8ec4a0772b..5f4284aa78
* vulkan-loader: 0ad591fa3c..26921924d6
* vulkan-validation-layers: 46f5d6ba1d..a83fbb9594

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC dsinclair@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dsinclair@google.com
Change-Id: I864f804fb208d3e55677df938d2e0a9ce082e439
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95640
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-07-06 04:39:40 +00:00
Dawn Autoroller 871c213d1b Roll ANGLE from 1154cc46d44d to 9070e279a887 (2 revisions)
1154cc46d4..9070e279a8

2022-07-05 m.maiya@samsung.com Vulkan: Handle platforms that have imprecise float division issues
2022-07-05 ynovikov@chromium.org Roll chromium_revision b1ab0fbd60..532c25a8e2 (1020158:1020841)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC dsinclair@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dsinclair@google.com
Change-Id: I3c91a33bb343b18bd544689498a8fc63eac267bf
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95620
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-07-06 03:31:40 +00:00
David Neto 760c399cfb Delete tests with invalid SPIR-V inputs
The structured CFG rule was revised/clarified in SPIR-V 1.6 Rev2
Validation now rejects a few cases.

SpvParserTest, ValueFromBlockNotInBlockOrder
SpvParserFunctionVarTest, EmitStatement_Phi_ValueFromBlockNotInBlockOrderIgnored
SpvParserFunctionVarTest_EmitStatement_Phi_ValueFromBlockNotInBlockOrderIgnored
  - Originally from crbug.com/tint/804
    Invalid by SPIR-V 1.6 Rev2 update to validation rules:
     - Block 80 is a structurally reachable continue target
     - Block 25 is not structually reachable, and not part of the loop,
       but branches to 80.

vk-gl-cts/graphicsfuzz/cov-dead-branch-func-return-arg/0-opt.*
  -  The continue construct with the continue target 37[%37]
     is not structurally post dominated by the back-edge block 64[%64]
  - The SPIRV-Tools inliner no longer creates such cases.  It splits the
    single-block loop and pushes the continue target down.

vk-gl-cts/graphicsfuzz/nested-for-loops-with-return/0-opt.spvasm
  - The loop headed at block 46 does not structurally dominate its merge
    block 44.  There is a continue-target edge from 41 to 44.

SpvParserCFGTest_ClassifyCFGEdges_BackEdge_MultiBlockLoop_MultiBlockContinueConstruct_ContinueIsHeader.spvasm
SpvParserCFGTest_EmitBody_Loop_MultiBlockContinueIsEntireLoop.spvasm
SpvParserCFGTest_LabelControlFlowConstructs_MultiBlockLoop_HeaderIsContinue.spvasm
SpvParserCFGTest_SiblingLoopConstruct_ContinueIsWholeMultiBlockLoop.spvasm
SpvParserCFGTest, ClassifyCFGEdges_BackEdge_MultiBlockLoop_MultiBlockContinueConstruct_ContinueIsHeader
SpvParserCFGTest, EmitBody_Loop_MultiBlockContinueIsEntireLoop
SpvParserCFGTest, LabelControlFlowConstructs_MultiBlockLoop_HeaderIsContinue
SpvParserCFGTest, SiblingLoopConstruct_ContinueIsWholeMultiBlockLoop
 - Continue target 20 also its own loop header, but is not structurally
   post-dominated by the backedge block.
 - Delete the end-to-end test.
 - Keep the unit test because it's about classifying edges, but disable dumping
   into the end2end suites.

Change-Id: I9ec2504aadd2fec9ea463901af7dc1b5f47481b5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95580
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: David Neto <dneto@google.com>
2022-07-06 01:45:30 +00:00
Dan Sinclair c1f9e47a9b Roll third_party/webgpu-cts/ 7334f06d2..6c0f3bab4 (11 commits)
Update:
 - expectations.txt
 - ts_sources.txt
 - resource_files.txt
 - webtest .html files


7334f06d2b..6c0f3bab40
 - 6c0f3b Update the descriptions of the tests of in_pass_encoder.spec.ts (#1598)
 - 7c96bd Fix an arithmitic error in memcpy
 - 6121d9 Address feedback from Austin
 - 145914 Optimized several expensive methods texture tests
 - dd6ecd Adjust skip criteria based on suggestion from Austin
 - a5c733 Guard against writeTimestamp() calls without the proper feature
 - 85f975 Describe each test of the validation tests in render|compute pass encoder (#1573)
 - 0bf125 Convert `min` tests to use interval framework (#1596)
 - 88a46e Convert multiplication tests to use interval framework (#1591)
 - 2379b9 Convert division tests to use interval framework (#1590)
 - 7cdef8 Convert `max` tests to use interval framework (#1595)

Created with './tools/run cts roll'

Change-Id: Ife3d6b89275ad66887d037aa4c66b385b2e1acbc
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95480
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
2022-07-05 21:20:42 +00:00
Dawn Autoroller 8d10b865d9 Roll SwiftShader from d1116fa9e9dc to 7987bda077c8 (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/d1116fa9e9dc..7987bda077c8

2022-07-05 nicolas.capens@gmail.com Compute vertex clip flags using scalable SIMD

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC dsinclair@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dsinclair@google.com
Change-Id: Icd9c71b513aec7916cd94330abcbacf960f39e88
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95600
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-07-05 19:54:52 +00:00
dawn-autoroll 5c561198ec Roll vulkan-deps from 24ed8b7a6bd7 to 5d976018641e (1 revision)
https://chromium.googlesource.com/vulkan-deps.git/+log/24ed8b7a6bd7..5d976018641e

Changed dependencies:
* spirv-headers: 36c0c15962..0bcc624926

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC dsinclair@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dsinclair@google.com
Change-Id: Id9a24dc7ce72f217d18c5b158434baa2ff486de8
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95560
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-07-05 15:29:09 +00:00
Dawn Autoroller a1d3003e16 Roll ANGLE from 44d8bf7602e2 to 1154cc46d44d (4 revisions)
44d8bf7602..1154cc46d4

2022-07-05 syoussefi@chromium.org Vulkan: Fix round-after-dither logic
2022-07-05 ukai@google.com angle: set $build/goma["use_luci_auth"] = True
2022-07-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 8e3184380881 to 24ed8b7a6bd7 (2 revisions)
2022-07-05 chris@rive.app pls: Rename GL_DISABLED_ANGLE -> GL_DISABLE_ANGLE

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC dsinclair@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dsinclair@google.com
Change-Id: I9e786712c946d7808588e0a18ae2498319ebd1c4
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95540
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-07-05 14:40:19 +00:00
dawn-autoroll b9ab024003 Roll vulkan-deps from 2117cffa2620 to 24ed8b7a6bd7 (1 revision)
https://chromium.googlesource.com/vulkan-deps.git/+log/2117cffa2620..24ed8b7a6bd7

Changed dependencies:
* spirv-cross: f46745095d..d8d051381f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC dsinclair@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dsinclair@google.com
Change-Id: I326a1510f89ffa687ddeabb7971baf3079de93b0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95520
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-07-05 01:55:00 +00:00
Dawn Autoroller bd512acad8 Roll ANGLE from 2a941833c838 to 44d8bf7602e2 (2 revisions)
2a941833c8..44d8bf7602

2022-07-04 antonio.caggiano@collabora.com Vulkan: Support EGL_EXT_platform_wayland
2022-07-04 antonio.caggiano@collabora.com Vulkan: Support DRM_FORMAT_MOD_LINEAR

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC dsinclair@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: dsinclair@google.com
Change-Id: I912cd5439a0772e2addb119da9665a9bc88b56e3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/95500
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-07-05 01:37:39 +00:00
dan sinclair cfa951a662 tint: Remove semicolon as struct member delimeter
Fixup a couple of internal Dawn shaders that used this syntax.

Fixed: tint:1475
Change-Id: Ibd6b3309944bfd955e724fef5d71d1297a84ef5f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/93361
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
2022-07-04 16:58:00 +00:00
dan sinclair 5286ea9d16 tint: Disallow write-only storage buffers
These have not been in the spec for a long time. The read_write access
mode can be used instead.

Fixed: tint:1342
Change-Id: I01ffc343d2d2f9df9d7028bba4548c749616c65c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/93500
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
2022-07-04 15:17:00 +00:00