Corentin Wallez
a569015325
Fix gn check for dawn_unittests.
...
Fixed: dawn:1404
Change-Id: I203762d4f090554a87b3422023f54627fcc6b4b8
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89404
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2022-05-11 00:22:55 +00:00
Corentin Wallez
ed4e5ee093
Fix warning in dawn.node for the newly added shader-f16 extension.
...
Bug: None
Change-Id: I0729dc75ad393d9f8c8b4409da4f3cc0f3acce74
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89660
Commit-Queue: Ben Clayton <bclayton@google.com>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-05-11 00:14:44 +00:00
dawn-autoroll
e6ca60d749
Roll vulkan-deps from 27ef4a0d9701 to b17c2c5b5b53 (6 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/27ef4a0d9701..b17c2c5b5b53
Changed dependencies:
* spirv-cross: 0c8a79b0b5..940efca099
* spirv-tools: ad3514b732..f74b85853c
* vulkan-headers: 8ba8294c86..33d4dd987f
* vulkan-validation-layers: 40437fb6ed..ce37b9affe
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: kainino@google.com
Change-Id: I7c866674ed68c018b6737149a740226cc03de8b1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89701
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-11 00:09:55 +00:00
Kai Ninomiya
63cea3f8c0
Revert "[chromium-style] Adding constructors and destructors."
...
This reverts commit efab8c894e
.
Reason for revert: breaks check_static_initializers check in Chromium
https://chromium-review.googlesource.com/c/chromium/src/+/3636809/
due to the line `static Format kUnusedFormat;` in Texture.cpp.
Error: file "Texture.cpp" is not expected to have static initializers in binary "chrome"
# Static initializers in chrome:
# 000101 _Unwind_Resume@plt
# 000101 guard variable for std::__1::ios_base::Init::Init()::init_the_streams
# 000101 std::__1::DoIOSInit::DoIOSInit()
# 000101 std::__1::DoIOSInit::~DoIOSInit()
# 000101 std::__1::ios_base::Init::Init()::init_the_streams
# 000101 __cxa_atexit@plt [registers a dtor to run at exit]
# 000101 __cxa_guard_abort
# 000101 __cxa_guard_acquire
# 000101 __cxa_guard_release
# 000101 __dso_handle
# InstrProfilingRuntime.cpp __llvm_profile_initialize
# Texture.cpp dawn::native::Format::Format()
# Texture.cpp dawn::native::kUnusedFormat
# Texture.cpp __dtor__ZN4dawn6nativeL13kUnusedFormatE
# Texture.cpp atexit
# iostream.cpp: (empty initializer list)
# Found 15 static initializers in 4 files.
Original change's description:
> [chromium-style] Adding constructors and destructors.
>
> This CL adds missing constructors and destructors.
>
> Bug: dawn:1405
> Change-Id: I0a0ea7ca50643d48cfc4a4dcf4ce46ff37ed10ad
> Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89200
> Reviewed-by: Austin Eng <enga@chromium.org>
> Kokoro: Kokoro <noreply+kokoro@google.com>
> Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
TBR=enga@chromium.org ,dsinclair@chromium.org,bclayton@google.com,noreply+kokoro@google.com,dawn-scoped@luci-project-accounts.iam.gserviceaccount.com
Change-Id: I86daffc227c2411e8c2c69cc4683224320f4480c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: dawn:1405
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89702
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
2022-05-10 23:32:44 +00:00
Ben Clayton
824e824709
tint: Rename float / int literal tokens
...
Rename:
• kFloatFLiteral -> kFloatLiteral_F
• kIntILiteral -> kIntLiteral_I
• kIntULiteral -> kIntLiteral_U
As suggested in review:
https://dawn-review.googlesource.com/c/dawn/+/89031/comments/b37253a3_e830b482
Bug: tint:1504
Change-Id: I4120f2904d8614152d4c804c226c9710f2ef8653
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89661
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-05-10 22:26:04 +00:00
Ben Clayton
508e4a5a82
tint: Add abstract AInt and AFloat typedefs
...
Add ProgramBuilder expression helpers for these.
Bug: tint:1504
Change-Id: I921dc4ebe0b97a5e451d98a19ad97df7f60384b3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89032
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-05-10 22:08:04 +00:00
Dawn Autoroller
b7bbe7cbbb
Roll SwiftShader from e4a6f2d74d3c to e0a1188d7652 (1 revision)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/e4a6f2d74d3c..e0a1188d7652
2022-05-10 syoussefi@google.com Fix dynamic state for line width
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: kainino@google.com
Change-Id: Ic5b6af9fc1e2d9fff7b5052a79a3f81ae16868d4
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89680
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-10 22:00:24 +00:00
dan sinclair
a5ff0e9dc3
[warnings] Add Wsuggest-override and Wsuggest-destructor-override.
...
This CL adds the `-Wsuggest-override` and
`-Wsuggest-destructor-override` warnings and fixes up the identified
issues.
Change-Id: I0ec1303a822abc258ce34d3bf1900e37ade6a8dc
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89561
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-05-10 18:44:34 +00:00
Austin Eng
552045a559
Don't use incremental build in webgpu-cts/scripts/list.py
...
The incremental build can become stale for unknown reasons,
breaking presubmits. Disable it for now.
Bug: dawn:1395
Change-Id: I83a71da0006ee3184b8df2996d8e53b6efbcc20a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89640
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-05-10 18:17:54 +00:00
Ben Clayton
0a3cda9911
tint: Replace all ProgramBuilder float literals with '_f' suffix
...
Unsuffixed float literals are currently treated as f32,
but will shortly become AbstractFloat. To keep tests behaving
identically to how they are currently, change all float literals
to explicitly use the f32 '_f' suffix.
Bug: tint:1504
Change-Id: I2a00725ee1b34a6efbe15ac4ba438c00c4416dd8
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89402
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-05-10 17:30:15 +00:00
Corentin Wallez
a439e7b89c
DawnTest: Make error/device loss mocks StrictMocks
...
Any unhandled error or device loss in the tests that are not expected
should cause a test failure. Mocks other than StrictMock will not cause
a failure and instead just write to stdout (or not write at all).
Fixed: dawn:1412
Change-Id: I2dd108da8fa6ba2cd7967790de4d7fa4b9f821ae
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89600
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Loko Kung <lokokung@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-05-10 17:06:34 +00:00
Ben Clayton
636e3d0111
tint: Add a negation operator to Number
...
Use this for expressing negative i32s.
Replacing `i32(-123)` with `-123_i` is more readable as the former looks
like it should be generating a WGSL cast, which it does not.
Bug: tint:1504
Change-Id: Iead3885b903e1f707b8a7e6b9090d65930df118e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89401
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-05-10 16:02:06 +00:00
Ben Clayton
17fa42d527
tint: Prevent Expr() implicit conversion to bool
...
Enfore that the Expr(bool) overloads are only used if the argument type
is explicitly a bool.
Fix a test bug where this was happening.
Change-Id: I5d7520be4859a700265d62b322416a90f278b2d3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89400
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-05-10 15:29:14 +00:00
Ben Clayton
41285aa578
tint: Lex different tokens for float suffixes
...
Generate different tokens for:
• 'f' suffixed float literals
• unsuffixed integer literals
'f' and unsuffixed are currently both treated as f32 by the resolver,
but this is the first step to supporting abstract floats.
Bug: tint:1504
Change-Id: Id3b1fe420b6eb8901f88d6a5de06ef4f54aa3edf
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89031
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
2022-05-10 14:55:34 +00:00
Corentin Wallez
dd5947ff76
Triage WebGPU CTS expectations
...
Bug: chromium:1234041, chromium:1309194
Bug: dawn:1319, dawn:1357, dawn:1398
Change-Id: Id7ad9350b6294d986f4ac6235d47bf36378344c6
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/88307
Commit-Queue: Ben Clayton <bclayton@google.com>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
2022-05-10 13:57:24 +00:00
Dawn Autoroller
33bd1bf069
Roll ANGLE from 2b8172b9b21e to 9872c1d63f38 (4 revisions)
...
2b8172b9b2..9872c1d63f
2022-05-10 romanl@google.com Switch deqp merge to python3
2022-05-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 626b2fd72bde to 27ef4a0d9701 (2 revisions)
2022-05-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 1dd93361b1d9 to e4a6f2d74d3c (2 revisions)
2022-05-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 7f78f00fdc5c to 46c13be19f0f (273 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: kainino@google.com
Change-Id: I38c430e4855d6411e43abdc627ba1c04eccebdc3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89620
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-10 13:49:19 +00:00
dan sinclair
010f32bca0
[warnings] Add -Wunused-macros
...
This CL adds the `-Wunused-macros` warning and removes the unused macro
found.
Change-Id: I1b2aa925f89e19ff6184e34b59d5ee076cb3807c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89560
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2022-05-10 13:31:16 +00:00
dawn-autoroll
2985c867e2
Roll vulkan-deps from 7de4282f2446 to 27ef4a0d9701 (1 revision)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/7de4282f2446..27ef4a0d9701
Changed dependencies:
* vulkan-validation-layers: 14155d96ed..40437fb6ed
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: kainino@google.com
Change-Id: I0e22fed55b987af998febefa6041d19a44d924b5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89580
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-05-10 09:48:22 +00:00
Jiawei Shao
6c9e475211
tint: Support dot4I8Packed and dot4U8Packed in sem
...
This patch adds the support of dot4I8Packed and dot4U8Packed in
semantics under the extension "chromium_experimental_dp4a".
Bug: tint:1497
Test: tint_unittests
Change-Id: I659172fcb8953ba13b49664c6c9ad75724ff5957
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/88962
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-05-10 09:05:54 +00:00
Corentin Wallez
4b6d3f4346
ShaderModule: Don't create an inspector just to reflect exts
...
Bug: tint:1472
Change-Id: Ifc170c3da531dd17015f0f36dfccfaa8e250b50c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89403
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-05-10 06:41:24 +00:00
Dawn Autoroller
c167ae12aa
Roll SwiftShader from f5cda7835ab7 to e4a6f2d74d3c (1 revision)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/f5cda7835ab7..e4a6f2d74d3c
2022-05-09 swiftshader.regress@gmail.com Regres: Update test lists @ f5cda783
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: kainino@google.com
Change-Id: I5a8ddeb7f11baf419ece7340f8ada7342e1496b3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89541
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-05-10 03:43:15 +00:00
Corentin Wallez
65271f6645
Vk: Run SingleEntryPoint before BindingRemapper.
...
This avoids Tint validation errors between transforms caused by unused
entry-points having conflict with the remapped bindings.
Fixed: dawn:1363
Change-Id: If7d22d09905816bfe777ab22211af21513f98698
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89441
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Loko Kung <lokokung@google.com>
2022-05-10 03:33:34 +00:00
Dawn Autoroller
7c2680badd
Roll ANGLE from 78d88796b44b to 2b8172b9b21e (12 revisions)
...
78d88796b4..2b8172b9b2
2022-05-09 cclao@google.com Vulkan: Add missing initialization for mTotalMemorySize
2022-05-09 syoussefi@chromium.org Vulkan: Remove suppressions and workarounds for old AMD/Windows
2022-05-09 ynovikov@chromium.org Revert "Vulkan: GBM platform"
2022-05-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from bc117969dbb5 to 7f78f00fdc5c (162 revisions)
2022-05-09 geofflang@chromium.org Reset the program executable if async linking fails.
2022-05-09 antonio.caggiano@collabora.com Vulkan: GBM platform
2022-05-09 cclao@google.com Vulkan: Fix VVL error for black desert mobile
2022-05-09 lexa.knyazev@gmail.com Add CopyTextureTest.ClearAfterCopySubTexture
2022-05-09 jmadill@chromium.org Vulkan: Use ImageView layer count functions in TextureVk.
2022-05-09 geofflang@chromium.org HLSL: Disambiguate functions that have int/uint parameters.
2022-05-09 jmadill@chromium.org Vulkan: Always init image views using image format.
2022-05-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 74e34ab97aeb to 1dd93361b1d9 (3 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: kainino@google.com
Change-Id: I72e6442157d95911d35e9f0b4857c0e6826162c5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89540
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-10 00:52:25 +00:00
dan sinclair
efab8c894e
[chromium-style] Adding constructors and destructors.
...
This CL adds missing constructors and destructors.
Bug: dawn:1405
Change-Id: I0a0ea7ca50643d48cfc4a4dcf4ce46ff37ed10ad
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89200
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
2022-05-10 00:14:04 +00:00
Loko Kung
bfe9f91975
Remove NiceMock on device lost callback.
...
- Unexpected device lost should result in an error.
Fixes: dawn:1412
Change-Id: I6fe0b1ccc3e4b51cc85b9a058f8eac65c7622d89
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89500
Auto-Submit: Loko Kung <lokokung@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-05-09 23:10:54 +00:00
dan sinclair
61f30bad1e
[chromium-style] Adding/moving constructors and destructors.
...
This CL adds missing constructors and destructors. Others are moved
from the header file to implementation files.
Bug: dawn:1405
Change-Id: I06657d4a4faa437ca5a95a0067a8f9f9bbc89d12
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89181
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-05-09 22:22:18 +00:00
Ben Clayton
b61e0452f8
tint: Add unary-ops to the intrinsic table
...
• Declare all the unary ops in the intrinsics.def file.
• Reimplement the bulk of Resolver::UnaryOp() with the IntrinsicTable.
This will simplify maintenance of the operators, and will greatly
simplify the [AbstractInt -> i32|u32] [AbstractFloat -> f32|f16] logic.
Bug: tint:1504
Change-Id: Ifc646d086fc93cfbe3f3f861b8c447178664c1f7
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89028
Reviewed-by: James Price <jrprice@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@chromium.org>
2022-05-09 21:22:24 +00:00
Brandon Jones
7378612ca5
Remove Unsafe API Toggle Check For Multiplane External Textures
...
Removes check for Unsafe API toggle for multiplane external textures.
This is no longer needed now that the the implementation is functional.
Bug: dawn:1409
Bug: chromium:1323647
Change-Id: Iaf1c1b6bd053b68e306df61759ee9d81777f9b87
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89460
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Brandon1 Jones <brandon1.jones@intel.com>
2022-05-09 20:35:43 +00:00
dan sinclair
357bfa89d8
[chromium-style] Adding/moving constructors and destructors.
...
This CL adds some missing constructors and destructors. Others are moved
from the header file to implementation files.
Bug: dawn:1405
Change-Id: I17e98f6da48518112bafb0876679cc3989ba2548
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89160
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-05-09 20:28:54 +00:00
dawn-autoroll
c5931800f2
Roll vulkan-deps from 626b2fd72bde to 7de4282f2446 (1 revision)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/626b2fd72bde..7de4282f2446
Changed dependencies:
* spirv-tools: ffc8f2d455..ad3514b732
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: kainino@google.com
Change-Id: I6b7055e94a761c0e50e8a4e9bc687fcd1a57aa11
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89461
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-05-09 20:12:15 +00:00
Ben Clayton
9fb29a364e
tint: Add binary-ops to the intrinsic table
...
• Declare all the binary ops in the intrinsics.def file.
• Reimplement Resolver::BinaryOpType() with the IntrinsicTable.
This will simplify maintenance of the operators, and will greatly
simplify the [AbstractInt -> i32|u32] [AbstractFloat -> f32|f16] logic.
Bug: tint:1504
Change-Id: Ie028602e05b59916c3f2168c92f200f10e402b96
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89027
Reviewed-by: James Price <jrprice@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-05-09 20:00:13 +00:00
dan sinclair
bcdb6e9da8
[chromium-style] Split mock constructors/destructors to cpp files.
...
This CL moves the constructors and desctructors for the native
unittest mocks into separate cpp files.
Bug: dawn:1405
Change-Id: I20dccaa8114f3d7f8b61da1c1495648cb7328148
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89121
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
2022-05-09 18:24:53 +00:00
Ben Clayton
e6e96def66
tint: Add operator support to intrinsic-gen
...
Adapt the builtin parsing and resolving to also support operators.
Will be used to generate intrinsic table entries for operators.
This will simplify maintenance of the operators, and will greatly
simplify the [AbstractInt -> i32|u32] [AbstractFloat -> f32|f16] logic.
Bug: tint:1504
Change-Id: Id75735ea24e501877418812185796f3fba88a521
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89026
Commit-Queue: Ben Clayton <bclayton@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
2022-05-09 18:08:23 +00:00
dan sinclair
d84daed72c
[chromium-style] Fixup a few chromium-style issues.
...
This CL fixes a few missing overrides and updates some `auto`'s to
have a `*` on them.
Bug: dawn:1405
Change-Id: I621cd35fb10d8308a5831db11c22a3595e52e295
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89120
Reviewed-by: Ben Clayton <bclayton@google.com>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-05-09 16:26:44 +00:00
Dawn Autoroller
abd1840550
Roll SwiftShader from 1dd93361b1d9 to f5cda7835ab7 (1 revision)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/1dd93361b1d9..f5cda7835ab7
2022-05-09 swiftshader.regress@gmail.com Regres: Update test lists @ 1dd93361
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: amaiorano@google.com
Change-Id: If30396118d110b52f5395bb6101efc7ff2fe7dcd
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89420
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-05-09 14:27:23 +00:00
Dawn Autoroller
be0abb611a
Roll ANGLE from e316203a6a2f to 78d88796b44b (1 revision)
...
e316203a6a..78d88796b4
2022-05-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 333c8248b125 to bc117969dbb5 (506 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: amaiorano@google.com
Change-Id: If1a3fce9c6a99e7d19d573e304497bfde0e05b83
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89380
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-09 11:49:53 +00:00
Dawn Autoroller
680f513bda
Roll ANGLE from 225d8f83af71 to e316203a6a2f (1 revision)
...
225d8f83af..e316203a6a
2022-05-08 zzyiwei@chromium.org Vulkan: add forceContinuousRefreshOnSharedPresent feature
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: amaiorano@google.com
Change-Id: I1c018959f6c8193277c83447e9b35d5f30486a68
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89321
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-08 02:11:42 +00:00
Dawn Autoroller
1bc2601884
Roll SwiftShader from 00efa1913863 to 1dd93361b1d9 (1 revision)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/00efa1913863..1dd93361b1d9
2022-05-07 capn@google.com Always enable MemorySanitizer instrumentation for vertex routines
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: amaiorano@google.com
Change-Id: I4e425007d61c9094b2de908cc252f534c65564a7
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89360
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-07 19:35:32 +00:00
Dawn Autoroller
b284205aad
Roll ANGLE from cadb933fdb12 to 225d8f83af71 (2 revisions)
...
cadb933fdb..225d8f83af
2022-05-07 yuxinhu@google.com Tests: Add Mortal Kombat App Trace
2022-05-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 4ca7acf89869 to 626b2fd72bde (22 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: amaiorano@google.com
Change-Id: I1b8bd6a9c08ee264187eb9909a448e42276187f5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89301
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-05-07 09:53:42 +00:00
dawn-autoroll
7f36c0e711
Roll vulkan-deps from e13072c54977 to 626b2fd72bde (2 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/e13072c54977..626b2fd72bde
Changed dependencies:
* glslang: e3bca2add6..14f6e27304
* spirv-tools: c11ea09652..ffc8f2d455
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: amaiorano@google.com
Change-Id: Ib50ee5883cea1f4db68e615917c3fcf30658867d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89320
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-05-07 06:49:52 +00:00
Dawn Autoroller
b79438ea6f
Roll SwiftShader from 74e34ab97aeb to 00efa1913863 (2 revisions)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/74e34ab97aeb..00efa1913863
2022-05-07 capn@google.com Don't make use of roundps in MSan builds
2022-05-07 capn@google.com Don't make use of cvtps2dq in MSan builds
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: amaiorano@google.com
Change-Id: Ib6f4f85ca609e40133615557f7eefe1faa312d57
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89300
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-05-07 05:42:12 +00:00
Dawn Autoroller
d2129ebeaa
Roll ANGLE from 1d5d09e4191a to cadb933fdb12 (14 revisions)
...
1d5d09e419..cadb933fdb
2022-05-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 3bc34dd4d819 to 333c8248b125 (124 revisions)
2022-05-06 cnorthrop@google.com Tests: Add Basemark GPU trace
2022-05-06 abdolrashidi@google.com Revert "Remove limit_max_texture_size_to_4096 workaround"
2022-05-06 ynovikov@chromium.org [Fuchsia] Download the gn sdk instead of core
2022-05-06 cnorthrop@google.com Tests: Add Puzzles and Survival trace
2022-05-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 106df4122297 to acf70aaf3fdb (12 revisions)
2022-05-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 643179694ec7 to 74e34ab97aeb (7 revisions)
2022-05-06 cnorthrop@google.com Tests: Add Monument Valley trace
2022-05-06 cnorthrop@google.com Tests: Add Dead Cells trace
2022-05-06 chonggu@google.com Migrate Fuchsia sdk checkout from using script to CIPD
2022-05-06 jmadill@chromium.org Vulkan: Simplify external format Chroma code.
2022-05-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 617cd3226543 to 3bc34dd4d819 (40 revisions)
2022-05-06 lubosz.sarnecki@collabora.com util/X11Window: Set PMinSize and PMaxSize hints.
2022-05-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 7a60295b6324 to 617cd3226543 (278 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: amaiorano@google.com
Change-Id: I5c3b9d025646950987b8f8800190a1a79ad7ca36
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89263
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-06 21:05:41 +00:00
dawn-autoroll
d66f973460
Roll vulkan-deps from 4957ae734445 to e13072c54977 (21 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/4957ae734445..e13072c54977
Changed dependencies:
* spirv-cross: a9d23d7652..0c8a79b0b5
* spirv-headers: 46b7918218..b765c355f4
* spirv-tools: 46492aa45a..c11ea09652
* vulkan-loader: 191e261495..08cad0c015
* vulkan-validation-layers: 75a5d5459f..14155d96ed
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: amaiorano@google.com
Change-Id: Ib4322b2ddcd488ae005d5f6a73e63e8eecca8111
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89244
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-06 17:27:17 +00:00
Dawn Autoroller
118aabf4f5
Roll SwiftShader from 62c1af08ea4d to 74e34ab97aeb (5 revisions)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/62c1af08ea4d..74e34ab97aeb
2022-05-06 capn@google.com Override the SPIRV-Headers path to use local copy
2022-05-06 capn@google.com Fix SPIRV-Tools Android.bp build
2022-05-05 amaiorano@google.com Update SPIR-V Headers to b765c355f
2022-05-05 amaiorano@google.com Update SPIR-V Tools to 7014be600
2022-05-05 amaiorano@google.com update-spirvheaders: run Gerrit hook on generated CLs
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: amaiorano@google.com
Change-Id: If2de42810c88713fa166b7965c075a77f823feb7
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89262
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-06 16:39:42 +00:00
Ben Clayton
e132516e6f
tint: Rename and move builtin_table and builtin-gen
...
• Rename 'builtin-gen' back to 'intrinsic-gen', as 'intrinsics' now
include both builtins and operators.
• Move the intrinsic definitions, and IntrinsicTable to the resolver
package, where it belongs.
Bug: tint:1504
Change-Id: I5ad5c285c1e360a224ee1235c293ccd55eb2693d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89025
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-05-06 15:13:01 +00:00
Ben Clayton
7f7234afad
dawn: Fix clang warning treated as error
...
Fixes Kokoro builds
Change-Id: I9261da8988091ddc0ae9ab0edd1ccbae64f39417
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89030
Commit-Queue: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@chromium.org>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
2022-05-06 13:42:43 +00:00
Zhaoming Jiang
d6b2501be2
dawn: Add shader module validation for WGSL extension
...
Tint has already implemented the enable directive for using WGSL
extension in the future, and using a WGSL extension that is not allowed
for the device should result in a shader creation error.
In this patch a WGSL extension allow list is added in DeviceBase, and
a validation is added in shader module base initialization to make sure
all extensions used in the WGSL program are in the allow list. This
patch also rename the `ValidateShaderModuleDescriptor` to
`ValidateAndParseShaderModule`, which is more descriptive for what it
actually does.
Bug: tint:1472
Change-Id: I4b039a3e37c25159b4fc6cfa37488aa817004ab2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/88241
Commit-Queue: Zhaoming Jiang <zhaoming.jiang@intel.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2022-05-06 08:51:12 +00:00
Dawn Autoroller
4cb75245e3
Roll ANGLE from 2ce60b52a239 to 1d5d09e4191a (10 revisions)
...
2ce60b52a2..1d5d09e419
2022-05-06 syoussefi@chromium.org Vulkan: Prefer MAILBOX over IMMEDIATE present mode
2022-05-05 cclao@google.com Vulkan: Reduce kMaxBufferToImageCopySize to 64M
2022-05-05 cclao@google.com Vulkan: Limit the total bytes of suballocation garbages in flight
2022-05-05 lubosz.sarnecki@collabora.com FramebufferTest: Add FramebufferChangeTest test.
2022-05-05 cnorthrop@google.com Scripts: Strip prebuilt debug APK from AOSP roll
2022-05-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 1c301e690de1 to 7a60295b6324 (184 revisions)
2022-05-05 cclao@google.com Vulkan: Force prune when there are lots of suballocations destroyed
2022-05-05 boliu@google.com Remove limit_max_texture_size_to_4096 workaround
2022-05-05 cclao@google.com Vulkan: Use heuristic to decide how many empty buffers to keep
2022-05-05 lubosz.sarnecki@collabora.com Tests: Add Alto's Odyssey trace.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: amaiorano@google.com
Change-Id: Ic50c7d2aa03bb0f580bbb14893083d58fb65a361
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89221
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-05-06 08:11:02 +00:00
James Price
8dbe22c65a
Surface Vulkan validation messages in errors
...
This change ensures that when errors are raised from WebGPU, including
lost context errors, they can include any associated Vulkan validation
layer messages in the message text if backend validation is enabled.
This will allow these messages to be surfaced in places like when
running CTS tests on browser build infrastructure.
Because of how Vulkan messages are raised at the instance level, some
routing of the messages to the appropriate device needed to be added.
This is based on appending message IDs to object labels and then parsing
them out of the message when it comes in.
This change also makes Vulkan validation messages cause a device loss,
which is inline with the behavior of the D3D12 backend.
Bug: dawn:1396
Change-Id: I2b309ba5475a338e7e99d4b4daaa7c3d5de61011
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/88460
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
2022-05-05 22:14:20 +00:00
Ben Clayton
0ce9ab042e
tint: Change all ProgramBuilder literals to 'i' or 'u' suffix
...
Unsuffixed integer literals are currently treated as i32,
but will shortly become AbstractInteger. To keep tests behaving
identically to how they are currently, change all test literals
to using either 'i' or 'u' suffixes.
Bug: tint:1504
Change-Id: Ic373d18ce1c718a16b6905568aec89da3641d36b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/88845
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-05-05 20:23:40 +00:00