Ben Clayton
657e61d43d
tint: Add and use new Std140 transform
...
This transform breaks up matNx2<f32> matrices used in uniform buffers
into column vectors, which fixes std140 layout rules.
Used by the SPIR-V and GLSL backends.
Re-enable tests that were disabled for these cases.
Bug: tint:1632
Change-Id: I596d016582b4189a0b413d762b3e7eabd3504b22
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100907
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@chromium.org>
2022-09-01 22:12:19 +00:00
dan sinclair
644d23b3f8
Update sample code WGSL.
...
This CL fixes up the sample code to use ',' instead of ';' for
struct members. This allows the Animometer and ComputeBoids samples
to execute again after the Tint change.
Change-Id: I96fae4fe3b96b0a6cc596edfd73013f2aa6ef0da
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101060
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-09-01 18:19:19 +00:00
Dawn Autoroller
efa5d3e3d3
Roll SwiftShader from f0db6df92f88 to 78cfdcddd8c7 (2 revisions)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/f0db6df92f88..78cfdcddd8c7
2022-09-01 sugoi@google.com Remove the "--cached" flag from clang formatting
2022-09-01 sugoi@google.com Allow ExecutionModeStencilRefReplacingEXT execution mode
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC bajones@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: bajones@google.com
Change-Id: Ibde5b0e07d1347938278179e24baaf85e98f2f38
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101020
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-01 17:59:09 +00:00
Ben Clayton
655db07022
tint/sem: Rename sem::Manager to TypeManager
...
This used to live in a `type` namespace, and wasn't prefixed when types were moved to sem.
Change-Id: Ic7a08c2fb40aff034247524c755d9f66157e4da2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101000
Commit-Queue: Ben Clayton <bclayton@chromium.org>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-01 17:35:39 +00:00
Ben Clayton
ad22c3e7ab
Update doxygen to 1.9.5
...
The older 1.8.14 has package dependencies on things that are no longer
provided by major linux package distributions.
Change-Id: Ifd3e1911faf6635db3ea7fc346302ea19401cecb
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100900
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@chromium.org>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
2022-09-01 16:47:59 +00:00
Antonio Maiorano
c20c5dfb4a
tint: Implement const eval of binary multiply
...
Bug: tint:1581
Change-Id: I70ff40ed4d8faf0a665824fef936ffbafb3f0948
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/99362
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
2022-09-01 14:57:39 +00:00
Dawn Autoroller
ae6f76fe3a
Roll ANGLE from 2f9d0810ecb7 to cec499f28957 (3 revisions)
...
2f9d0810ec..cec499f289
2022-09-01 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from da42de1e5ad7 to 40446ec62941 (12 revisions)
2022-09-01 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 6511404d8c85 to c709ec453fcb (552 revisions)
2022-08-31 cclao@google.com Vulkan: No depth load/store if depthFunc==ALWAYS/NEVER && mask==FALSE
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC bajones@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: bajones@google.com
Change-Id: I59dcf79684ed90c4531cba9e5be09a1eedb8d5d8
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100980
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-01 13:00:49 +00:00
Ben Clayton
2b47c21640
tint/sem: Add Find() to the type manager
...
Lets you lookup a type without modifying anything.
Change-Id: I7a37d37f1c49c7f37f96c35b8e73a66743d9000a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100906
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-09-01 09:15:20 +00:00
dawn-autoroll
6903fc0c46
Roll vulkan-deps from 3747e941a171 to 1d36249fb716 (10 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/3747e941a171..1d36249fb716
Changed dependencies:
* glslang: 9e78bc8108..69ae9e7460
* spirv-tools: d51dc53d2c..b5d1040b94
* vulkan-loader: 40faec799c..095a7bf60b
* vulkan-tools: 439026106a..77cf67df07
* vulkan-validation-layers: bd411a0ce4..d8c7808f87
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC bajones@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: bajones@google.com
Change-Id: I8ac3b8e088288caa91a3cf3803075c68d564d70f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100801
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-09-01 05:10:19 +00:00
Zhaoming Jiang
426b47e481
tint: add missing F16 conversion expression support
...
This CL add missing type conversions for f16, especially for SPIRV
backend which require special handling. A transform,
VectorizeMatrixConversions, are also added for SPIRV to replace a matrix
conversion to a matrix construction with converted column vectors.
Unittests for the transform and SPIRV writer, and end-to-end tests for
all conversion rules are added.
Bug: tint:1473, tint:1502, chromium:1356215
Change-Id: Iaff125e5dd295d35c4ab74757eb56b642802a51a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100483
Reviewed-by: David Neto <dneto@google.com>
Commit-Queue: Zhaoming Jiang <zhaoming.jiang@intel.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-01 03:08:20 +00:00
Brandon Jones
0df4e4aea3
Disabled Swiftshader for Android Builds.
...
Currently fails to build with the following error:
../../third_party/swiftshader/src/Vulkan/VkImage.hpp:24:11:
fatal error: 'vulkan/vk_android_native_buffer.h' file not found
Bug: dawn:286
Change-Id: I7daa992ba775621524ae936e9fa6ed4ee8a5727a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100940
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2022-09-01 00:04:39 +00:00
Ben Clayton
0c7c23b9c4
tint: Misc hash / container contract improvements
...
Add a hash implementation to tint::Number.
Add a utils::Hasher specialization for std::variant.
Add an operator!= for Vector. Needed for std::variants.
Drop the need for explicit on Vector constructors from refs.
These all help general usage with STL and util containers.
Change-Id: I1e594edf532e78f531062c534dacaee7616cded5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100905
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-08-31 23:51:48 +00:00
Ben Clayton
6a17e33f3d
tint/writer: Remove spirv::Operand hasher
...
It's not used any more. utils::Hasher is specialized for vectors.
Change-Id: Ic7c6978ae1f54b608b4dba98abeac077c1be9567
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100904
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-31 23:51:18 +00:00
Ben Clayton
b04d992f83
tint/utils: Fix Hashmap::GetOrCreate() for map mutation in create
...
Its not unreasonable for the create callback to mutate the map. If this
happened, the map would be corrupted.
This change fixes this.
Change-Id: I2bb3820061c741c6da36ebe3667cb6b878515a27
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100903
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-08-31 23:15:38 +00:00
Dawn Autoroller
bd1e38aa3d
Roll ANGLE from 080b67ed0ec0 to 2f9d0810ecb7 (5 revisions)
...
080b67ed0e..2f9d0810ec
2022-08-31 romanl@google.com Revert "Sort items to avoid python2/3 diffs."
2022-08-31 romanl@google.com Sort items to avoid python2/3 diffs.
2022-08-31 geofflang@google.com Vulkan: Parse human readable ARM driver versions.
2022-08-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from db1584efaa9b to da42de1e5ad7 (1 revision)
2022-08-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 476165cc7c0c to ecba967ea71f (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC bajones@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: bajones@google.com
Change-Id: I25aec8db865c724a407caccbd55bfc745aae1851
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100921
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-31 23:04:48 +00:00
Antonio Maiorano
b6d524380e
tint: Improve resolver test helper to specify more than one expression arg
...
Bug: tint:1581
Change-Id: Ie77c56c15a5965b20008036cd99a81cbabd86988
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100340
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2022-08-31 22:59:08 +00:00
Dawn Autoroller
329ddd813d
Roll SwiftShader from ecba967ea71f to f0db6df92f88 (5 revisions)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/ecba967ea71f..f0db6df92f88
2022-08-31 capn@google.com Eliminate incorrect Exponent() function
2022-08-31 capn@google.com Optimize Frexp() zero handling
2022-08-31 capn@google.com Fix Frexp() for subnormal arguments under DAZ
2022-08-31 capn@google.com Move Frexp and Ldexp to ShaderCore
2022-08-31 sugoi@google.com OpCopy* fixes
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC bajones@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: bajones@google.com
Change-Id: I55331b046ad75d46b2e5263c5a2155786be4ac14
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100920
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-31 21:35:39 +00:00
Ben Clayton
cd716e6f01
tint::CloneContext: Use Hashmap::Generation()
...
Instead of tracking its own generation.
Change-Id: Iea9710fd6665cfc13fb72741b8a80c6dde4f64e9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100902
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-31 19:43:48 +00:00
Ben Clayton
4e0335c5af
tint/utils: Add Generation() to Hashmap and Hashset.
...
Useful for knowing if you have to look up an entry again since the last
lookup.
Change-Id: Ib0374627ef5cd7fcff7fa2d9e72b4214260b2df3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100901
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@chromium.org>
2022-08-31 19:04:28 +00:00
Brandon Jones
4d67a883b6
Implement maxBindingsPerBindGroup limit
...
Bug: dawn:1523
Change-Id: Ifcf83f6836a5d7ed447080ccb033e4163970432e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100706
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Brandon Jones <bajones@chromium.org>
2022-08-31 17:01:58 +00:00
dawn-autoroll
1862e83510
Roll vulkan-deps from da42de1e5ad7 to 3747e941a171 (1 revision)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/da42de1e5ad7..3747e941a171
Changed dependencies:
* spirv-tools: fca39d5cb4..d51dc53d2c
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC bajones@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: bajones@google.com
Change-Id: I73f39ab1239d3cfa4078ad6367b28a793cafc28c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100880
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-31 16:06:28 +00:00
Antonio Maiorano
ff0295ebd8
tint: Fix AInt -> AFloat implicit conversion from construction
...
Bug: tint:1581
Change-Id: I8c6a1e375130ab38ef52cb0d8dddaca03cc098da
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100800
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-31 13:48:41 +00:00
dan sinclair
5361d9e778
Convert @id to an expression.
...
This CL updates the @id AST nodes to store an expression instead
of a literal value. This is in anticipation of the parser updates
for ID expressions.
Bug: tint:1633
Change-Id: I4dd626007dd1f9093999a0236e220ffdbc9e62db
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100760
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-31 13:39:48 +00:00
Dawn Autoroller
969692ccf8
Roll ANGLE from 7428369ada4a to 080b67ed0ec0 (2 revisions)
...
7428369ada..080b67ed0e
2022-08-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 25d1a1a7a886 to 6511404d8c85 (577 revisions)
2022-08-30 zzyiwei@chromium.org Vulkan: disable EGL_EXT_image_gl_colorspace
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC bajones@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: bajones@google.com
Change-Id: I8038a128704ebc039e0a08f206f19d3cfe9fc582
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100841
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-31 09:24:28 +00:00
Dawn Autoroller
ef751b76ee
Roll SwiftShader from f1b1938f48c3 to ecba967ea71f (3 revisions)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/f1b1938f48c3..ecba967ea71f
2022-08-31 nicolascapens@google.com Revert "Workaround vkGetPhysicalDeviceProperties2() issue"
2022-08-31 nicolascapens@google.com Revert "Temporarily allow unsupported structures in PhysicalDevice::getFeatures2()"
2022-08-31 nicolascapens@google.com Revert "Workaround for dEQP-VK.info.device_mandatory_features failure"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC bajones@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: bajones@google.com
Change-Id: Ie12f62b31adbde016cd7ff5cfbe9e0c1a530f051
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100840
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-31 08:21:58 +00:00
Austin Eng
183c87e4f6
Mark error scope stackDepth=100000 tests as slow
...
These tests regularly take 7+ seconds to complete due to their size
Change-Id: I5ee554610275ed68f4eab7a821c4278a2c478595
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100820
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-08-31 03:25:18 +00:00
jchen10
fb2c8fb6a1
Enable gbm VideoViewsTests
...
When writting texels into the mapped texture, we need to take
'stride' into consideration.
chromium:1258986
Change-Id: Icc892d4ce324539e6280307d1699599d59204a9d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100480
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jie A Chen <jie.a.chen@intel.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-31 01:16:47 +00:00
Ben Clayton
54bcbdbbf3
tint/resolver: Fix intrinsic table matching of AInt as AFloat
...
An AInt argument can be passed to a parameter of type AFloat.
Fix the matcher for AFloat so that it includes AInts.
Change-Id: I6aeebb567b6176b146920a2035f09cd07c11c014
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100780
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-31 01:06:28 +00:00
Corentin Wallez
ef8b50f9d2
Suppress an additional OOM allocation test on M1.
...
Bug: dawn:1506
Change-Id: I0ebd89c17284ff724a5cf8b875fbb01d2366f3e5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100703
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-08-31 00:49:18 +00:00
dawn-autoroll
b4697b713c
Roll vulkan-deps from db1584efaa9b to da42de1e5ad7 (1 revision)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/db1584efaa9b..da42de1e5ad7
Changed dependencies:
* vulkan-validation-layers: 67b79bcb00..bd411a0ce4
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC bajones@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: bajones@google.com
Change-Id: I2c95e0e4f652a6f4ffe966ed064674ffa0487217
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100705
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-30 21:15:07 +00:00
dan sinclair
7b332abc82
Remove cmake visibility flags.
...
This Cl removes the visiblity flags from the CMake file. In both
Debug and Release mode on OSX setting these flags caused piles
of warnings about mis-matched visibility settings throughout the
third_party libraries.
This CL fixes that by removing the flags. This maynot be the right
way to fix this, but it does fix the warnings. We need to decide
if we want to hide symbols by default and, if so, figure out how
to fix the downstream projects.
Change-Id: I8ee7422cfa2aec3715dba226da58e974f39e0d18
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100420
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
2022-08-30 20:42:48 +00:00
Dawn Autoroller
ae9cc2f759
Roll ANGLE from 64f41972a9a3 to 7428369ada4a (9 revisions)
...
64f41972a9..7428369ada
2022-08-30 cclao@google.com Vulkan: Use macros for load/store Op check
2022-08-30 lfy@google.com Vulkan: Don't try to guess format mapping
2022-08-30 lexa.knyazev@gmail.com Support provoking vertex state query
2022-08-30 kkinnunen@apple.com Make shader dump code compile after ShCompileOptions API change
2022-08-30 romanl@google.com Add include atomic, missing in Skia builds.
2022-08-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 7d94bcff7a00 to db1584efaa9b (3 revisions)
2022-08-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 75cc1cb02dd7 to 25d1a1a7a886 (533 revisions)
2022-08-30 yuxinhu@google.com Check max shader storage blocks support in test
2022-08-30 syoussefi@chromium.org Vulkan: Handle suboptimal like out-of-date
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC bajones@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: bajones@google.com
Change-Id: I28343178f2573fe4d9c0383cd30b6148b08da143
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100741
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-30 20:28:12 +00:00
Dawn Autoroller
df90cda634
Roll SwiftShader from 476165cc7c0c to f1b1938f48c3 (1 revision)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/476165cc7c0c..f1b1938f48c3
2022-08-30 swiftshader.regress@gmail.com Regres: Update test lists @ 476165cc
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC bajones@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: bajones@google.com
Change-Id: I04fdcf39351386f160c2d1bc6023263b832021ad
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100740
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-30 19:27:18 +00:00
Corentin Wallez
1105ec78fe
Merge DAWN_FORMAT_VALIDATION_ERROR in DAWN_VALIDATION_ERROR.
...
Done with changes to Error.h and the following command:
git grep -l DAWN_FORMAT_VALIDATION_ERROR | xargs sed -i "" "s/DAWN_FORMAT_VALIDATION_ERROR/DAWN_VALIDATION_ERROR/"
then fixing compilation errors in ErrorTests.cpp, Pipeline.cpp and
CommandEncoder.cpp.
Bug: dawn:563
Change-Id: I081a514d662e81f4842b6d7fadfcea67c12720d6
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100468
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-08-30 13:39:47 +00:00
Corentin Wallez
1eb6d2dd02
Convert a few remaining DAWN_VALIDATION_ERROR.
...
There are still DAWN_VALIDATION_ERROR occurences left but they don't use
any format string so it is fine to merge DAWN_FORMAT_VALIDATION_ERROR
into DAWN_VALIDATION_ERROR in follow-up CLs.
Bug: dawn:563
Change-Id: Ic1ba1de44216b36ef6a972712b957685e0ee193e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100467
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-08-30 13:33:37 +00:00
Dawn Autoroller
c68683c306
Roll ANGLE from 5ef3960bc1f1 to 64f41972a9a3 (9 revisions)
...
5ef3960bc1..64f41972a9
2022-08-29 jmadill@chromium.org Use canonical gl.xml and update enum to string function.
2022-08-29 sunnyps@chromium.org d3d11: Support rendering to GL_TEXTURE_2D target for YUV images
2022-08-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 435ebaff9214 to f08773d25d83 (15 revisions)
2022-08-29 romanl@google.com Replace std::this_thread::get_id() use with a unique thread id.
2022-08-29 syoussefi@chromium.org Vulkan: SPIR-V Gen: Remove suppression of passing tests
2022-08-29 solti@google.com update CopyTextureCHROMIUM to match Chromium
2022-08-29 romanl@google.com Capture/Replay: Delete binary data in FinishReplay via callback
2022-08-29 ynovikov@chromium.org Fix loading end2end test expectations on iOS
2022-08-29 eddiehatfield@google.com Fix data race in BlobCache
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC bajones@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: bajones@google.com
Change-Id: Icc3c6a8940fc93a78cff49bb9195324cd96c38d3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100720
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-30 06:34:47 +00:00
dawn-autoroll
445ef17ba0
Roll vulkan-deps from c5f01bfc31ec to db1584efaa9b (2 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/c5f01bfc31ec..db1584efaa9b
Changed dependencies:
* spirv-tools: 66bdbacc9c..fca39d5cb4
* vulkan-validation-layers: 1396d7b36a..67b79bcb00
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC bajones@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: bajones@google.com
Change-Id: I72295d49a023b7682f2bd63c7f120681eed6a7dc
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100700
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-08-30 05:34:07 +00:00
Corentin Wallez
7143450998
Remove support for snake_case wgpu::Features.
...
Chromium has been updated so the fallback is no longer needed.
Bug: dawn:550
Change-Id: I25b054617fc054926e0eb850229f244ddc51bb61
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100470
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-08-30 01:00:50 +00:00
Corentin Wallez
5fee3f93aa
Remove ToSampleTypeBit as it is unused.
...
Bug: dawn:527
Change-Id: I09ce1e7e30b7d1329e3e42db9308f7220199cdd8
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100469
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-30 00:57:33 +00:00
Corentin Wallez
59b2ccc09a
Remove TODO that's already done.
...
Bug: None
Change-Id: Iee58a385868e46879bb003b7e1fa8b39e9812fc3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100471
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-30 00:51:30 +00:00
Loko Kung
3a53edcf18
Promote LoseForTesting to ForceLoss device so that user agents can use.
...
Bug: chromium:1356738
Change-Id: I348837ad4224124d9adba1ecf69a05b2060760c9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100566
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Loko Kung <lokokung@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-08-29 22:33:50 +00:00
dan sinclair
be4c9f48aa
Convert @group to an expression
...
This CL updates the group attribute to store an expression
instead of a single value. The parser always produces an
IntLiteralExpression at the moment.
Bug: tint:1633
Change-Id: Ice05c26d652c7f5c21825f745f270e96e3d88e08
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100441
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-29 21:22:31 +00:00
dan sinclair
f9b831c39a
Convert @binding to an expression
...
This CL updates the binding attribute to store an expression
instead of a single value. The parser always produces an
IntLiteralExpression at the moment.
Bug: tint:1633
Change-Id: I14b2a61b5bcdea66e9e24df7afbb55fb60be785e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100440
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-29 21:13:00 +00:00
Antonio Maiorano
cbe8b36256
tint: spir-v reader: add support for GLSLstd450Determinant
...
Bug: tint:1061
Change-Id: I18f6d0726c2fac192b8893f35dcbf45bf4a3d752
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100466
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2022-08-29 20:52:00 +00:00
Austin Eng
c165937955
Return false from IsDeviceIdle if there are pending callback tasks
...
Fixes a race where async pipeline compilations could never see their
callbacks called because Chromium stopped calling device.Tick().
Fixed: dawn:1527
Change-Id: I273409d427ef02a7a6817647eb38564adfdf0da8
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100565
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Loko Kung <lokokung@google.com>
2022-08-29 18:46:10 +00:00
Dawn Autoroller
fe6d72dc4f
Roll ANGLE from bec40d768468 to 5ef3960bc1f1 (4 revisions)
...
bec40d7684..5ef3960bc1
2022-08-29 kkinnunen@apple.com Use correct seed type for XXH32 fuzzer
2022-08-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from eb46f95f20dc to 7d94bcff7a00 (8 revisions)
2022-08-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 6517262b2386 to 476165cc7c0c (6 revisions)
2022-08-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 21906127bee6 to 75cc1cb02dd7 (625 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC bajones@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: bajones@google.com
Change-Id: I2e0a99d2891f62b721a0333b6573a079e37bc4a0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100660
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-29 17:12:49 +00:00
Corentin Wallez
bc93cbc2a2
Correctly print backend type in DiscoverAdapters logs.
...
Bug: chromium:1348664
Change-Id: Id2eaf25a9f46b1f6614d80642dc7f8e8aef09b9e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100520
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-08-29 16:38:39 +00:00
dawn-autoroll
29d0a523f2
Roll vulkan-deps from 7d94bcff7a00 to c5f01bfc31ec (1 revision)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/7d94bcff7a00..c5f01bfc31ec
Changed dependencies:
* spirv-tools: a98f05d02f..66bdbacc9c
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC bajones@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: bajones@google.com
Change-Id: I6ce1a71f9a0e83791a0ac1913293d2c97e52af22
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100465
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-29 16:11:50 +00:00
Dawn Autoroller
6c55c128ec
Roll ANGLE from ac2aeccde28d to bec40d768468 (1 revision)
...
ac2aeccde2..bec40d7684
2022-08-29 syoussefi@chromium.org Vulkan: Set SPIR-V Generator version to 1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC rharrison@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: rharrison@google.com
Change-Id: I71f18b3828002143690771ccf3aa848beddf0885
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100463
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-29 04:13:49 +00:00
Dawn Autoroller
009404164d
Roll SwiftShader from 6c0f2889c2d9 to 476165cc7c0c (1 revision)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/6c0f2889c2d9..476165cc7c0c
2022-08-27 swiftshader.regress@gmail.com Regres: Update test lists @ 6517262b
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC rharrison@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: rharrison@google.com
Change-Id: Ie6d702d384ca76e847d653f09230ce17aa8339b5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100621
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-08-28 00:57:48 +00:00