49334b05cf
tint/utils: Remove non-const accessors on VectorRef
...
Nothing uses these, and the mutability of these breaks
const-correctness.
Switch functions that used to return `const utils::Vector<T, N>&`
to returning `utils::VectorRef<T>`. Removes the templated size from the
public interface.
Replace all `const utils::VectorRef<T>&` with `utils::Vector<T>`,
there's no point in using yet another level of pointer indirection.
Change-Id: Ib96e3171500606d9afffbb13f40023552a74fffc
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113021
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
2022-12-06 19:39:02 +00:00
6016d1e5cd
tint: Fix unused-but-set-parameter warning
...
Bug: dawn:1608
Change-Id: I49575fc34f162be4b046ac479459c554a563bcca
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113080
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-12-06 19:37:38 +00:00
8753796aac
tint: Add PreservePadding transform
...
This is used to ensure that assignments to host-visible memory do not
modify padding bytes in structures and arrays. We decompose
assignments of whole structure and array types into member-wise or
element-wise copies, using helper functions.
This is used in all backends except HLSL, which already decomposes
memory accesses.
Bug: tint:1571
Change-Id: Id6de2f917fb80151cc654a7e1c8413ae956f0d61
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112720
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: James Price <jrprice@google.com>
2022-12-06 18:32:19 +00:00
f2b8d2b1ab
tools: Parallelize ./tools/format
...
10x speed improvement on my 3990x machine
Change-Id: Ie4b2377719e9a25860ec05bb7649aa652d26ccf0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113022
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Ben Clayton <bclayton@google.com>
2022-12-06 18:29:08 +00:00
d933470b20
Roll SwiftShader from 95d0c32f427b to 0c98167cb31e (2 revisions)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/95d0c32f427b..0c98167cb31e
2022-12-06 sugoi@google.com Merge changes I1950088a,Iecb2d8a2,I250a1541,I4dc2e503
2022-12-06 sugoi@google.com Change Chromium's SwiftShader owners
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC senorblanco@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: senorblanco@google.com
Change-Id: I72af4daaaaa918f84740cd3eec1e0d67ac3fb002
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113040
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-12-06 17:26:19 +00:00
a31d89d6a3
tint/utils: Add support for unsafe pointer downcasts
...
Bug: tint:1779
Change-Id: Icfd27680edf7dfaedbfb70f25641dc762d23f42a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113020
Auto-Submit: Ben Clayton <bclayton@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-12-06 15:43:40 +00:00
4c5a9c1ef7
node: Throw a TypeError when writeTimestamp is not supported
...
Bug: None
Change-Id: I7e02883c53371c40a9e1766d50550ffc43165c2e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112425
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
2022-12-06 13:37:21 +00:00
9f7c06ce14
Roll ANGLE from 87815de2b5bb to 701ef3f2286e (9 revisions)
...
87815de2b5..701ef3f228angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from e6a3153888f0 to 2783f6bf0a03 (2 revisions)
2022-12-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from ca8ca2aba961 to a497ee9d6755 (62 revisions)
2022-12-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 6a259c87ef52 to e6a3153888f0 (24 revisions)
2022-12-06 abdolrashidi@google.com Suppress VUID-vkCmdDraw-None-06887
2022-12-06 abdolrashidi@google.com Skip AssignAssignmentToSwizzled on SwS Linux/Win
2022-12-06 abdolrashidi@google.com Add cmnt for VUID-vkDestroySemaphore suppression
2022-12-05 cclao@google.com Vulkan: Make mLargestAllocatedIndex atomic
2022-12-05 syoussefi@chromium.org Vulkan: Make sure program's pipeline cache is created
2022-12-05 cclao@google.com Vulkan: Remove RenderPassSerial
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC senorblanco@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: senorblanco@google.com
Change-Id: Ib9107880f9a841010b1f1b29c3d253c0939fa27f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112980
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-12-06 12:46:43 +00:00
0faef02f33
Roll vulkan-deps from ef116f5551fb to 80770ea57aff (7 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/ef116f5551fb..80770ea57aff
Changed dependencies:
* spirv-tools: d9446130d5..40f5bf59c62826791bed..891c40de1ab17374498f..ce45337c515c3f60e51d..d5b7d98cf8https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC senorblanco@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: senorblanco@google.com
Change-Id: I20d61090eb1ede2b1a08d5480a432823a8caf287
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112960
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-12-06 06:22:01 +00:00
b5d25b5bcc
Roll SwiftShader from e6a3153888f0 to 95d0c32f427b (1 revision)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/e6a3153888f0..95d0c32f427b
2022-12-06 swiftshader.regress@gmail.com Regres: Update test lists @ e6a31538
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC senorblanco@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: senorblanco@google.com
Change-Id: I97f61842f0500006fe76117a072e2b07840abdc0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112940
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-12-06 04:20:24 +00:00
3c4fddf3e3
Fix leak of Metal counter sample buffers
...
The blit descriptor allocation was leaking, which references the
counter sample buffer. Fix it by storing the descriptor in a
scoped NSRef
Fixed: dawn:1603
Change-Id: If40e8608db167717a4e07f3cb64a5e98402e3f1a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112861
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Loko Kung <lokokung@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-12-06 02:25:23 +00:00
99cdc539df
Reduce kMaxQueryCount to 4096
...
Bug: gpuweb#3648
Change-Id: Ic0dc211a4338f42de1a533c0f18f8852d8af4d36
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112445
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2022-12-06 02:24:49 +00:00
0249ef5b58
Roll ANGLE from 3269998c712e to 87815de2b5bb (3 revisions)
...
3269998c71..87815de2b5lexa.knyazev@gmail.com Adjust GetFramebufferAttachmentParameterivBase validation
2022-12-05 syoussefi@chromium.org Overlay: Switch font to RobotoMono
2022-12-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 9d22258ed442 to d90c76e77622 (14 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC senorblanco@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: senorblanco@google.com
Change-Id: Ifd9973677436e9fa2cd64fb84fd5982e5b866f82
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112900
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-12-05 23:20:21 +00:00
875d116a87
tint: fix signed overflow in const eval modulo
...
Bug: chromium:1395241
Bug: tint:1581
Change-Id: I6f6084749d9bc5c0d493476b251eeec5543d8621
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112701
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Auto-Submit: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-12-05 17:16:15 +00:00
af7b4d0d9e
Roll vulkan-deps from 63dc6101459e to ef116f5551fb (1 revision)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/63dc6101459e..ef116f5551fb
Changed dependencies:
* vulkan-validation-layers: d5824670d4..5c3f60e51dhttps://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC senorblanco@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: senorblanco@google.com
Change-Id: If9371c6e0e67ebcb061af94ee5e66efe49df9fb2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112800
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-12-05 17:10:11 +00:00
c17b4f9b69
node: Throw a TypeError for unsupported GPUQueryTypes
...
The WebGPU spec requires this so that an extension not being enabled or
not implemented by the browser both behave the same.
Bug: None
Change-Id: I52d991ba63438068d4adaf1391771336186a402a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112422
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-12-05 13:54:44 +00:00
0d6b1fc45f
node: Implement support for depth-clip-control
...
Bug: None
Change-Id: If62e2963917b1f2a94e415ce2c4c22b14317779a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112601
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-12-05 12:04:16 +00:00
e2cdafbf8a
node: Throw a TypeError for unsupported GPUTextureFormats
...
The WebGPU spec requires this so that an extension not being enabled or
not implemented by the browser both behave the same.
Bug: None
Change-Id: Iba449c1f67d266aa53b924501577d646cd944f55
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112421
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-12-05 11:50:49 +00:00
027bf02278
Roll ANGLE from b36e337e8d94 to 3269998c712e (1 revision)
...
b36e337e8d..3269998c71angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 5d807d6fc7dd to bdfdd7d2b008 (315 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC dsinclair@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: dsinclair@google.com
Change-Id: Ida2d4a1b10d5ecc5655028fe12db4c8a7ad059ad
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112780
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-12-05 09:48:27 +00:00
1e1834a4ce
Roll SwiftShader from 33b63f98a30d to e6a3153888f0 (1 revision)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/33b63f98a30d..e6a3153888f0
2022-12-02 capn@google.com Use helper function for SPIR-V explicit layout storage classes
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC dsinclair@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: dsinclair@google.com
Change-Id: I301f90c198a578a74ebad38d46555fa1d4ce6981
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112761
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-12-03 12:17:33 +00:00
d26656292b
Roll ANGLE from b432c84c2b8c to b36e337e8d94 (12 revisions)
...
b432c84c2b..b36e337e8dangle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 366b354bb4e3 to 5d807d6fc7dd (318 revisions)
2022-12-02 jmadill@chromium.org Fixes for Vulkan secondaries build.
2022-12-02 syoussefi@chromium.org Vulkan: Remove fixed VVL errors
2022-12-02 cnorthrop@google.com Capture/Replay: Add ResourcesToDelete
2022-12-02 cclao@google.com Vulkan: Add two tests for per context queue serial work
2022-12-02 abdolrashidi@google.com Vulkan: Add memory allocation log support in debug
2022-12-02 syoussefi@chromium.org GLES1: Use less precision for color and tex coords
2022-12-02 cclao@google.com Vulkan: Let each current context has its own QueueSerial.
2022-12-02 syoussefi@chromium.org Vulkan: Fix -Wbitfield-enum-conversion
2022-12-02 cnorthrop@google.com Android: Remove smhasher license
2022-12-02 ianelliott@google.com Android: set android:allowBackup="false" in manifset
2022-12-02 jmadill@chromium.org Build and test ANGLE with Vulkan secondary CBs.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC dsinclair@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: dsinclair@google.com
Change-Id: I7bc60700362ac46329c7deca2c7794856fea5fbe
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112740
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-12-03 05:17:49 +00:00
6f70e3f096
Roll vulkan-deps from d800a9330101 to 63dc6101459e (5 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/d800a9330101..63dc6101459e
Changed dependencies:
* vulkan-loader: 5035e37bf6..82d4232f0fd50f0ee365..d5824670d4https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC dsinclair@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: dsinclair@google.com
Change-Id: I31e04ef908d216f852becfed9c6b3a01c9047f30
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112702
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-12-03 04:50:53 +00:00
bf80d24eb9
Roll SwiftShader from 72c25a855bb3 to 33b63f98a30d (1 revision)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/72c25a855bb3..33b63f98a30d
2022-12-02 sugoi@google.com Add memory allocation checks
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC dsinclair@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: dsinclair@google.com
Change-Id: Ie4bf88c7e032fbe6e06dd498f0feb2e397f49f51
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112681
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-12-02 23:10:24 +00:00
f42d92a1d5
Tint: Refactor transform VertexPulling and its unit tests
...
This CL prepare transform VertexPulling and its unit tests for
implementing f16 pipeline io. This CL distinguishes vertex format type
and WGSL variable type of a vertex shader attribute (location input) in
VertexPuilling transform as both `f32` and `f16` WGSL types would be
mapepd to float vertex format. This CL splits VertexPulling unit tests
by base veretx format (SInt, UInt and Float), make it easier to add
`f16` tests.
Bugs: tint:1473, tint:1502
Change-Id: I649deb61e8eb8dac6ebd653bf77ef96475334a56
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112520
Commit-Queue: Zhaoming Jiang <zhaoming.jiang@intel.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-12-02 18:11:57 +00:00
3c33cf15e3
Roll ANGLE from 4eed6b9b7827 to b432c84c2b8c (5 revisions)
...
4eed6b9b78..b432c84c2bgert.wollny@collabora.com Capture/Replay: Fix collecting the initialized contexts
2022-12-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 076a539c2991 to 366b354bb4e3 (53 revisions)
2022-12-02 solti@google.com Revert "Vulkan: Enable async pipeline cache sync by default"
2022-12-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 42032d061a0a to 076a539c2991 (1718 revisions)
2022-12-02 m.maiya@samsung.com Reset thread context during threadCleanup
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC dsinclair@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: dsinclair@google.com
Change-Id: I28aa5be0b25487d12b02350b7057e2876fc22b32
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112680
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-12-02 16:18:47 +00:00
da3f1e395c
Roll vulkan-deps from e05101aa3095 to d800a9330101 (1 revision)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/e05101aa3095..d800a9330101
Changed dependencies:
* vulkan-validation-layers: 0855e59b13..d50f0ee365https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC dsinclair@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: dsinclair@google.com
Change-Id: Iabd075964c7aa2aaf0e31dd2c09c93e38b468398
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112700
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-12-02 15:44:56 +00:00
06749f92b2
node: add support for GPUErrorFilter.Internal
...
Bug: None
Change-Id: Icb36b8a3d207d068185494580358f438f8332c65
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112420
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-12-02 15:36:17 +00:00
63a67a7218
node: Support sparse vertex buffer layouts
...
Bug: dawn:1000
Change-Id: I616369acdf5c9d883da8d0da292aa1b3f4a77250
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112021
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
2022-12-02 15:35:14 +00:00
89b2e10eac
node: Implement Compute/RenderPassTimestampWrites
...
Bug: dawn:1250
Change-Id: Iccd9123b3af7347d7586b998df5b11ab15608bb1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112424
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-12-02 15:33:51 +00:00
42ada5f248
tint: const eval of binary right shift
...
Bug: tint:1581
Change-Id: I3f40454559c4fc36565de1a11a6e6c8c394fd0cc
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112620
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2022-12-02 15:25:20 +00:00
7423496da6
tint/transform: Fix NPE in ZeroInitWorkgroupMemory.
...
If an array uses an override expression, then we'd raise an error, but then attempt to dereference a nullptr.
Bug: chromium:1392853
Change-Id: Ib1d538bc491923b628b32f2398f8b2ace24c3bc3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112561
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-12-02 13:49:57 +00:00
25c0bdf2a9
node: Add support for GPURenderPassDescriptor.maxDrawCount
...
Bug: None
Change-Id: I5e2ff510ceaa09becf0f5f760d0d0f7bc1d0cb49
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112423
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-12-02 12:06:35 +00:00
15e7f94b76
Remove ArrayCount helpers.
...
This CL removes the helpers in sem::Array to determine the type of
ArrayCount. Instead the `Is` and `As` functions from Castable are used
at the call sites.
Bug: tint:1718
Change-Id: Ie666bfbfca6bb1be8ead613266a7221d88f7a76d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112442
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
2022-12-02 02:59:44 +00:00
a5d3d16b1d
Roll vulkan-deps from 3d89f6ee5534 to e05101aa3095 (8 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/3d89f6ee5534..e05101aa3095
Changed dependencies:
* spirv-headers: 1ebdaf0858..1d31a10040b092b2fccc..2826791bed3c25bbc5fa..5035e37bf66361ae332c..b17374498fe6dd47ed9e..0855e59b13https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC dsinclair@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: dsinclair@google.com
Change-Id: I7a475c46bc5e2fb3b8324ee18048e31597172b86
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112621
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-12-02 02:40:51 +00:00
f5e7df5b63
Roll ANGLE from 8ee1b89fc5c5 to 4eed6b9b7827 (11 revisions)
...
8ee1b89fc5..4eed6b9b78cnorthrop@google.com ubsan: Ignore errors from SwiftShader
2022-12-01 chris@rive.app Workaround for AMD [[raster_order_group()]] bug
2022-12-01 pasko@chromium.org android: Remove uncompress_shared_libraries
2022-12-01 capn@google.com Include volk.h from a relative location
2022-12-01 capn@google.com Move trace_event into anglebase
2022-12-01 capn@google.com Move the anglebase folder up a level
2022-12-01 ynovikov@chromium.org Add ANGLE experimental bots for Win Intel
2022-12-01 cnorthrop@google.com ubsan: Ignore alignment errors
2022-12-01 capn@google.com Use string_view to compute custom string hash
2022-12-01 capn@google.com Include xxhash.h from a relative location
2022-12-01 jmadill@chromium.org Remove trace tests from win-intel.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC dsinclair@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: dsinclair@google.com
Change-Id: I4c9cb96bcb93c3082430427a1af2c7c75526a1ec
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112660
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-12-02 02:28:52 +00:00
4b1d79e292
Moved sem::ArrayCount to an inherited structure
...
This CL moves the ArrayCount from a variant to use inheritance. This
will allow the sem to have different array count classes from the IR.
The ArrayCounts, similar to types, are unique across the code base and
are provided by the TypeManager.
Bug: tint:1718
Change-Id: Ib9c7c9df881e7a34cc3def2ff29571f536d66244
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112441
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-12-01 23:45:18 +00:00
71e6bcf1af
Update validation for pass encoding beginRenderPass/beginComputePass
...
Make validation for pass encoding aligned to spec, where
descriptor validation failure will make pass invalid and stop
immediately instead of defer to CommandEncoder::Finish()
Bug: dawn:1602
Change-Id: I7892009e31f7565e4da43c38d365b056c9ecc22f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112448
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Shrek Shao <shrekshao@google.com>
2022-12-01 22:23:47 +00:00
847cfa07c5
Move allocator into TypeManager
...
Currently the TypeManger is a UniqueAllocator. This works as long as the
TypeManager only manages one specific thing. In order to support
ArrayCount, which is type related, but not a type, the TypeManager will
need to be able to store two types of things.
This CL changes the TypeManager to contain a UniqueAllocator and proxies
the needed Get, Find and iteration methods to that allocator. This will
allow another allocator to be added for ArrayCount later.
Bug: tint:1718
Change-Id: I0f952eb5c3ef90a7c85dead14d11b657dceba951
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112640
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-12-01 21:42:47 +00:00
2939c4531e
Fix stack-overflow in `lhs_expression`.
...
Currently when parsing `*` and `&` we recursively call into ourselves to
process the tokens. This can cause stack issues if there are an
excessive number of `*`s and `&`s.
This Cl changes `lhs_expression` to generate a list of UnaryOps to be
applied and does not recursively call `lhs_expression`.
Bug: chromium:1394972
Change-Id: I40caee05c9b7f71abb776d375cbf995c6a1fd36f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112580
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-12-01 20:39:33 +00:00
6992f51ebd
tint: Add DirectVariableAccess transform
...
Enables the 'chromium_experimental_full_ptr_parameters' extension to
allow passing of uniform, storage and workgroup address-spaced
pointers as parameters, as well as pointers into sub-objects.
Bug: tint:1758
Change-Id: I8c85e6104ef4f2b9a177dec2857b1bf7f5148212
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/103860
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Ben Clayton <bclayton@google.com>
Reviewed-by: James Price <jrprice@google.com>
2022-12-01 18:49:09 +00:00
d257e28792
tint: Don't override alignment with @offset
...
Overriding the alignment to 1 would cause nested structures to be
incorrectly laid out. The fix: Don't override the alignment.
All struct layout validation works on the sem offsets, so none of this
has to change.
Bug: tint:1776
Change-Id: Ic01d45fb2790cd823ed9a55e336860ebdc351aea
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112603
Kokoro: Ben Clayton <bclayton@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-12-01 18:41:57 +00:00
efb17b0254
tint/writer/wgsl: Print @offset attributes as comment
...
We use WGSL to visualize the AST. Make sure we don't hide anything.
Bug: tint:1776
Change-Id: Iedd7ca797fb745d9db7d0aba8a5718039241afbb
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112602
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Ben Clayton <bclayton@google.com>
Auto-Submit: Ben Clayton <bclayton@google.com>
2022-12-01 17:37:56 +00:00
f745e4e2bf
Add Source to sem::Struct
...
This CL adds a Source to the sem::Struct. The uses of
struct->Declaration()->source now use the source stored directly on the
struct.
Bug: tint:1718
Change-Id: I860c67764f85d98b3f655247e18f93fa0fef9436
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112447
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
2022-12-01 16:25:25 +00:00
8954189545
tint_common_fuzzer: Don't attempt to use an invalid program
...
validate_program was not returning 0 for invalid programs that did not contain diagnostics with a severity greater than error.
This lead to broken behavior in logic that used the program.
Bug: chromium:1392853
Change-Id: Id860e266cfe24ade955edf4f2f2a9c26c2e117fa
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112560
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@chromium.org>
2022-12-01 15:34:55 +00:00
527e38b68b
[sem] Move TransitivelyReferencedOverrides to sem::Info.
...
This CL pulls the TransitivelyReferencedOverrides from sem::Array and
sem::GlobalVariable up to the sem::Info.
Moving this data outside of sem::Array removes one of the references to
non-Type sem content.
Bug: tint:1718
Change-Id: I40c1c8b2d5ec60dc2723b56cc30cd436e9b7e997
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112324
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
2022-12-01 15:33:43 +00:00
331a3b7980
Add Source to sem::StructMember
...
This CL adds a Source to the sem::StructMember. The uses of
member->Declaration()->source now use the source stored directly on the
struct member.
Bug: tint:1718
Change-Id: Ic97053dd3e0080f128ee411857512920d3940858
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112446
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-12-01 15:08:21 +00:00
c5b1b5c77a
Access struct member name through sem.
...
This CL changes the uses of Declaration()->symbol for struct members in
the sem to access the `Name` directly.
Bug: tint:1718
Change-Id: I3050147b97bea66d6c283e176a7152f36eb2b25f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112444
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-12-01 14:52:33 +00:00
d5d207ba9f
tint: Add builtin type aliases (vec3f, etc)
...
Fixed: tint:1772
Change-Id: I4bed36ded91ca5288875ed6ea819ff4bbb432186
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112340
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: James Price <jrprice@google.com>
2022-12-01 13:41:56 +00:00
5798f2d021
Roll vulkan-deps from af77d06fcb68 to 3d89f6ee5534 (2 revisions)
...
https://chromium.googlesource.com/vulkan-deps.git/+log/af77d06fcb68..3d89f6ee5534
Changed dependencies:
* vulkan-tools: 0a122e62b8..6361ae332c73c5cbe4d2..e6dd47ed9ehttps://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC dsinclair@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: dsinclair@google.com
Change-Id: I0dc4ac85e298d10b17a384263666548d556e3534
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112522
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-12-01 13:41:50 +00:00
54860f4432
Roll ANGLE from db67df60f8c8 to 8ee1b89fc5c5 (3 revisions)
...
db67df60f8..8ee1b89fc5chris@rive.app Refactor pixel local storage options
2022-12-01 chris@rive.app Implement pixel local storage with metal::read_write textures
2022-12-01 syoussefi@chromium.org Translator: Support SSO's built-in redeclaration
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC dsinclair@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: dsinclair@google.com
Change-Id: I34d4c60425fe51c6df4979f50bed25e36902acdd
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112521
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-12-01 13:26:19 +00:00
Ben Clayton
Jason Erb
James Price
Dawn Autoroller
Corentin Wallez
Austin Eng
Antonio Maiorano
Zhaoming Jiang
dan sinclair
shrekshao