mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-07-24 14:05:53 +00:00
7a4685f448
This CL adds a TypedInteger helper which provides additional type
safety in Dawn. It is a compile-time restriction that prevents integers
of different types from being used interchangably in Debug builds.
It also adds ityp::{array,bitset,span} as helper classes to wrap std::
versions (not span). These accept a template paramter as the Index type
so that typed integers, or enum classes, may be used as a type-safe
index.
For now, bind group layout binding indices use TypedInteger. Future
CLs will convert other indices to be type-safe as well.
Bug: dawn:442
Change-Id: I5b63b1e4f6154322db0227a7788a4e9b8303410e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19902
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
131 lines
5.0 KiB
C++
131 lines
5.0 KiB
C++
// Copyright 2017 The Dawn Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#ifndef DAWNNATIVE_BINDGROUPLAYOUT_H_
|
|
#define DAWNNATIVE_BINDGROUPLAYOUT_H_
|
|
|
|
#include "common/Constants.h"
|
|
#include "common/Math.h"
|
|
#include "common/SlabAllocator.h"
|
|
#include "common/ityp_array.h"
|
|
#include "common/ityp_span.h"
|
|
#include "dawn_native/BindingInfo.h"
|
|
#include "dawn_native/CachedObject.h"
|
|
#include "dawn_native/Error.h"
|
|
#include "dawn_native/Forward.h"
|
|
|
|
#include "dawn_native/dawn_platform.h"
|
|
|
|
#include <bitset>
|
|
#include <map>
|
|
|
|
namespace dawn_native {
|
|
|
|
MaybeError ValidateBindGroupLayoutDescriptor(DeviceBase*,
|
|
const BindGroupLayoutDescriptor* descriptor);
|
|
|
|
MaybeError ValidateBindingTypeWithShaderStageVisibility(
|
|
wgpu::BindingType bindingType,
|
|
wgpu::ShaderStage shaderStageVisibility);
|
|
|
|
MaybeError ValidateStorageTextureFormat(DeviceBase* device,
|
|
wgpu::BindingType bindingType,
|
|
wgpu::TextureFormat storageTextureFormat);
|
|
|
|
MaybeError ValidateStorageTextureViewDimension(wgpu::BindingType bindingType,
|
|
wgpu::TextureViewDimension dimension);
|
|
|
|
// Bindings are specified as a |BindingNumber| in the BindGroupLayoutDescriptor.
|
|
// These numbers may be arbitrary and sparse. Internally, Dawn packs these numbers
|
|
// into a packed range of |BindingIndex| integers.
|
|
class BindGroupLayoutBase : public CachedObject {
|
|
public:
|
|
BindGroupLayoutBase(DeviceBase* device, const BindGroupLayoutDescriptor* descriptor);
|
|
~BindGroupLayoutBase() override;
|
|
|
|
static BindGroupLayoutBase* MakeError(DeviceBase* device);
|
|
|
|
// A map from the BindingNumber to its packed BindingIndex.
|
|
using BindingMap = std::map<BindingNumber, BindingIndex>;
|
|
|
|
const BindingInfo& GetBindingInfo(BindingIndex bindingIndex) const {
|
|
ASSERT(!IsError());
|
|
ASSERT(bindingIndex < BindingIndex(kMaxBindingsPerGroup));
|
|
return mBindingInfo[bindingIndex];
|
|
}
|
|
const BindingMap& GetBindingMap() const;
|
|
BindingIndex GetBindingIndex(BindingNumber bindingNumber) const;
|
|
|
|
// Functors necessary for the unordered_set<BGLBase*>-based cache.
|
|
struct HashFunc {
|
|
size_t operator()(const BindGroupLayoutBase* bgl) const;
|
|
};
|
|
struct EqualityFunc {
|
|
bool operator()(const BindGroupLayoutBase* a, const BindGroupLayoutBase* b) const;
|
|
};
|
|
|
|
BindingIndex GetBindingCount() const;
|
|
// Returns |BindingIndex| because dynamic buffers are packed at the front.
|
|
BindingIndex GetDynamicBufferCount() const;
|
|
uint32_t GetDynamicUniformBufferCount() const;
|
|
uint32_t GetDynamicStorageBufferCount() const;
|
|
|
|
struct BufferBindingData {
|
|
uint64_t offset;
|
|
uint64_t size;
|
|
};
|
|
|
|
struct BindingDataPointers {
|
|
ityp::span<BindingIndex, BufferBindingData> const bufferData = {};
|
|
ityp::span<BindingIndex, Ref<ObjectBase>> const bindings = {};
|
|
};
|
|
|
|
// Compute the amount of space / alignment required to store bindings for a bind group of
|
|
// this layout.
|
|
size_t GetBindingDataSize() const;
|
|
static constexpr size_t GetBindingDataAlignment() {
|
|
static_assert(alignof(Ref<ObjectBase>) <= alignof(BufferBindingData), "");
|
|
return alignof(BufferBindingData);
|
|
}
|
|
|
|
BindingDataPointers ComputeBindingDataPointers(void* dataStart) const;
|
|
|
|
protected:
|
|
template <typename BindGroup>
|
|
SlabAllocator<BindGroup> MakeFrontendBindGroupAllocator(size_t size) {
|
|
return SlabAllocator<BindGroup>(
|
|
size, // bytes
|
|
Align(sizeof(BindGroup), GetBindingDataAlignment()) + GetBindingDataSize(), // size
|
|
std::max(alignof(BindGroup), GetBindingDataAlignment()) // alignment
|
|
);
|
|
}
|
|
|
|
private:
|
|
BindGroupLayoutBase(DeviceBase* device, ObjectBase::ErrorTag tag);
|
|
|
|
BindingIndex mBindingCount;
|
|
BindingIndex mBufferCount{0}; // |BindingIndex| because buffers are packed at the front.
|
|
uint32_t mDynamicUniformBufferCount = 0;
|
|
uint32_t mDynamicStorageBufferCount = 0;
|
|
|
|
ityp::array<BindingIndex, BindingInfo, kMaxBindingsPerGroup> mBindingInfo;
|
|
|
|
// Map from BindGroupLayoutEntry.binding to packed indices.
|
|
BindingMap mBindingMap;
|
|
};
|
|
|
|
} // namespace dawn_native
|
|
|
|
#endif // DAWNNATIVE_BINDGROUPLAYOUT_H_
|