CMake-only fork of https://dawn.googlesource.com/dawn with cleaned, vendored dependencies
c5c2fce3ed
Normal behavior of ApiObjectBase's APIRelease() which only locks the
device when last ref dropped is not thread safe if the object is cached
as raw pointers by the device. Example of cached objects: bind group
layout, pipeline, sampler, shader module.
The following scenario could happen:
- thread A:
- shaderModuleA.APIRealease()
- shaderModuleA.refCount.Decrement() == true (ref count has reached zero)
- going to call shaderModuleA.LockAndDeleteThis().
- thread B:
- device.CreateShaderModule().
- lock()
- device.GetOrCreateShaderModule()
- shaderModuleA is in the cache, so return it.
- unlock()
- thread A:
- starting to call shaderModuleA.LockAndDeleteThis()
- lock()
- erase shaderModuleA from the cache.
- delete shaderModuleA.
- unlock()
This CL fixes this bug by locking the entire APIRelease() method until
we find a better solution.
Bug: dawn:1769
Change-Id: I1161af66fc24f3a7bafee22b9614b783e0dc4503
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/128441
Commit-Queue: Quyen Le <lehoangquyen@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
|
||
|---|---|---|
| .vscode | ||
| build_overrides | ||
| docs | ||
| generator | ||
| include | ||
| infra | ||
| scripts | ||
| src | ||
| test | ||
| third_party | ||
| tools | ||
| webgpu-cts | ||
| .clang-format | ||
| .clang-tidy | ||
| .gitattributes | ||
| .gitignore | ||
| .gn | ||
| AUTHORS | ||
| BUILD.gn | ||
| CMakeLists.txt | ||
| CMakeSettings.json | ||
| CODE_OF_CONDUCT.md | ||
| CONTRIBUTING.md | ||
| CPPLINT.cfg | ||
| DEPS | ||
| DIR_METADATA | ||
| Doxyfile | ||
| LICENSE | ||
| OWNERS | ||
| PRESUBMIT.py | ||
| README.chromium | ||
| README.md | ||
| codereview.settings | ||
| dawn.json | ||
| dawn_wire.json | ||
| go.mod | ||
| go.sum | ||
| go_presubmit_support.py | ||
| tint_overrides_with_defaults.gni | ||
README.md
Dawn, a WebGPU implementation
Dawn is an open-source and cross-platform implementation of the work-in-progress WebGPU standard.
More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL.
Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.
Dawn provides several WebGPU building blocks:
- WebGPU C/C++ headers that applications and other building blocks use.
- The
webgpu.hversion that Dawn implements. - A C++ wrapper for the
webgpu.h.
- The
- A "native" implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
- A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
- Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.
Helpful links:
- Dawn bug tracker if you find issues with Dawn.
- Tint bug tracker if you find issues with Tint.
- Dawn's mailing list for other discussions related to Dawn.
- Dawn's source code
- Dawn's Matrix chatroom for live discussion around contributing or using Dawn.
- WebGPU's Matrix chatroom
- Tint mirror for standalone usage.
Documentation table of content
Developer documentation:
- Dawn overview
- Building
- Contributing
- Code of Conduct
- Testing Dawn
- Debugging Dawn
- Dawn's infrastructure
- Dawn errors
- Tint experimental extensions
User documentation: (TODO, figure out what overlaps with the webgpu.h docs)
Status
(TODO)
License
Apache 2.0 Public License, please see LICENSE.
Disclaimer
This is not an officially supported Google product.