mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-05-16 04:11:25 +00:00
7c24b6b2ff
This reverts commit 63f2666ee77c987a56c6be5bfc6bbb10d12a9f63. Reason for revert: causes failures in dawn_unittests after Dawn uses SPVC by default. We need a fix in both SPVC and this CL before re-landing. Original change's description: > Check bind group layout with storage texture in pipeline descriptors > > This patch adds all the validations on the use of bind group layout with > read-only storage texture and write-only storage texture in the creation > of pipeline objects. > > 1. GPUBindGroupLayout.bindingType must match the type of the storage > texture variable (read-only or write-only) in shader. > 2. GPUBindGroupLayout.storageTextureFormat must be a valid texture > format that supports STORAGE usage. > 3. GPUBindGroupLayout.storageTextureFormat must match the storage > texture format declaration in shader. > 4. GPUBindGroupLayout.textureDimension must match the storage texture > dimension declared in shader. > > BUG=dawn:267 > TEST=dawn_unittests > > Change-Id: Ifa3c2194dc76de14f790a0a73868e69bbb31c814 > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/17167 > Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> > Reviewed-by: Kai Ninomiya <kainino@chromium.org> TBR=cwallez@chromium.org,kainino@chromium.org,yunchao.he@intel.com,jiawei.shao@intel.com,shaobo.yan@intel.com,hao.x.li@intel.com,enga@chromium.org,jiajie.hu@intel.com Change-Id: Idb4083b11f22fa7e4c5c8477bc4b65b58900746e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:267 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/17380 Reviewed-by: Jiawei Shao <jiawei.shao@intel.com> Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>