AxioDL/PrimeWorldEditor
2
0
Fork 0
mirror of https://github.com/AxioDL/PrimeWorldEditor.git synced 2025-12-10 14:07:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

CSelectInstanceDialog: Pass QModelIndex by const reference

Browse Source 
Gets rid of a few trivial 24 byte copies.
This commit is contained in:
Lioncache
2025-12-07 08:08:04 -05:00
parent 6428864373
commit e7a2a10d64
2 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/Editor/WorldEditor/CSelectInstanceDialog.cpp
View File

@@ -60,20 +60,19 @@ void CSelectInstanceDialog::OnTabChanged(int NewTabIndex)
ui->ButtonBox->button(QDialogButtonBox::Ok)->setEnabled(mValidSelection); ui->ButtonBox->button(QDialogButtonBox::Ok)->setEnabled(mValidSelection);
} }
void CSelectInstanceDialog::OnTreeClicked(QModelIndex Index) void CSelectInstanceDialog::OnTreeClicked(const QModelIndex& Index)
{ {
int TabIndex = ui->TabWidget->currentIndex(); const int TabIndex = ui->TabWidget->currentIndex();
if (TabIndex == 0) if (TabIndex == 0)
{ {
QModelIndex SourceIndex = mLayersProxyModel.mapToSource(Index); const QModelIndex SourceIndex = mLayersProxyModel.mapToSource(Index);
mpLayersInst = mLayersModel.IndexObject(SourceIndex); mpLayersInst = mLayersModel.IndexObject(SourceIndex);
mValidSelection = (mpLayersInst != nullptr); mValidSelection = (mpLayersInst != nullptr);
} }
else else
{ {
QModelIndex SourceIndex = mTypesProxyModel.mapToSource(Index); const QModelIndex SourceIndex = mTypesProxyModel.mapToSource(Index);
mpTypesInst = mTypesModel.IndexObject(SourceIndex); mpTypesInst = mTypesModel.IndexObject(SourceIndex);
mValidSelection = (mpTypesInst != nullptr); mValidSelection = (mpTypesInst != nullptr);
} }
@@ -81,7 +80,7 @@ void CSelectInstanceDialog::OnTreeClicked(QModelIndex Index)
ui->ButtonBox->button(QDialogButtonBox::Ok)->setEnabled(mValidSelection); ui->ButtonBox->button(QDialogButtonBox::Ok)->setEnabled(mValidSelection);
} }
void CSelectInstanceDialog::OnTreeDoubleClicked(QModelIndex /*Index*/) void CSelectInstanceDialog::OnTreeDoubleClicked(const QModelIndex& /*Index*/)
{ {
// Instance selection was handled in OnTreeClicked on the first click. // Instance selection was handled in OnTreeClicked on the first click.
if (mValidSelection) if (mValidSelection)

4
src/Editor/WorldEditor/CSelectInstanceDialog.h
View File

@@ -36,8 +36,8 @@ public:
public slots: public slots:
void OnTabChanged(int NewTabIndex); void OnTabChanged(int NewTabIndex);
void OnTreeClicked(QModelIndex Index); void OnTreeClicked(const QModelIndex& Index);
void OnTreeDoubleClicked(QModelIndex Index); void OnTreeDoubleClicked(const QModelIndex& Index);
}; };
#endif // CSELECTINSTANCEDIALOG_H #endif // CSELECTINSTANCEDIALOG_H