Commit Graph

1255 Commits

Author SHA1 Message Date
Lioncash e962d9ba96 CLight: Correct lack of assignment in SetSpotCutoff()
Brought this up with Antidote and was told that this is likely what was
intended to be done.
2020-06-14 20:16:54 -04:00
Lioncash 9e3018809f CWorld: Eliminate sign conversion warnings 2020-06-14 19:48:23 -04:00
Lioncash 35ea47e473 CWorld: Make use of in-class initializers
Same behavior, less code.
2020-06-14 19:47:05 -04:00
Lioncash 128ee0d01c CMaterialLoader: Make use of static
This function doesn't touch instance state at all
2020-06-14 19:43:43 -04:00
Lioncash cc376d3e21 CMaterialLoader: Make use of std::array 2020-06-14 19:41:42 -04:00
Lioncash 903f6dfe7e CGameArea: Make use of in-class initializers where applicable
Same behavior, less code.
2020-06-14 19:27:54 -04:00
Lioncash 2c274897c9 CLightParameters: Make EWorldLightingOptions an enum class
Avoids polluting the global namespace.
2020-06-14 19:21:30 -04:00
Lioncash cec88d182b CLightNode: Mark member functions as const where applicable
Several functions don't modify internal member state.
2020-06-14 19:13:35 -04:00
Lioncash f2201ca03c CLight: Make CalculateSpotAngleAtten() const
This member function doesn't modify internal member state.
2020-06-14 19:05:29 -04:00
Lioncash b439e4bba1 CLight: Make use of in-class initializers where applicable
Same behavior, less code.
2020-06-14 19:03:32 -04:00
Lioncash f942ad6551 CGameTemplate: Mark getter functions as const
These don't modify internal class state, so we can mark them as const.
2020-06-14 18:58:05 -04:00
Lioncash 15708b8624 CGameTemplate: Collapse loops into ranged for where applicable 2020-06-14 18:49:37 -04:00
Lioncash d9bb255518 CGameTemplate: Use in-class initializers where applicable
Same behavior, less code.
2020-06-14 18:35:10 -04:00
Lioncash 332be356de CIndexBuffer: Make use of size_t where applicable
Provides a nicer interface for operating with standard types, etc.
2020-06-14 18:29:39 -04:00
Lioncash d4564434c3 FShowFlags: Remove use of cpp file
Now that these constructs are constexpr capable, we can make use of
constexpr here to contain it fully within the header.
2020-06-14 17:12:37 -04:00
Lioncash b2db6a21fa CFlagsProperty: Mark HasValidValue() as const
This doesn't modify internal state.
2020-06-14 17:07:47 -04:00
Lioncash d5a33b631a CFlagsProperty: Make use of a ranged for loop 2020-06-14 17:06:46 -04:00
Lioncash 84184da66d CFont: Prevent Wmaybe-uninitialized warning 2020-06-14 17:04:35 -04:00
Lioncash 4861f118fb CFont: Make PtsToFloat() internally linked
This is only ever used within the cpp file
2020-06-14 17:04:35 -04:00
Lioncash 1c292f5e2d CFont: Make use of std::array
Same behavior, stronger typing.
2020-06-14 17:04:32 -04:00
Lioncash b6b7bcace1 CFont: In-class initialize members where applicable
Provides a consistent initial state.
2020-06-14 16:54:16 -04:00
Lioncash 01e68ec5d8 CFontLoader: Default constructor 2020-06-14 16:51:13 -04:00
Lioncash e49315a645 CSkeleton: Make use of unique_ptr where applicable
Makes ownership semantics explicit.
2020-06-14 16:49:51 -04:00
Lioncash 4dcb539763 CSkeletonLoader: Make use of ranged for where applicable
Same behavior, less code.
2020-06-14 16:13:28 -04:00
Lioncash 6909c75d64 CTextureDecoder: Misc cleanup
Const correctness, unimplemented prototypes, reducing copies, etc.
2020-06-14 16:07:43 -04:00
Lioncash 68455c54e8 CTextureDecoder: Make utility functions internally linked
Same behavior, but keeps implementation details internal.
2020-06-14 15:41:32 -04:00
Lioncash 849906c8c4 externals: Update LibCommon 2020-06-12 17:27:09 -04:00
Lioncash f0cd6ee99b CStructProperty: Make use of ranged for 2020-06-12 17:25:06 -04:00
Lioncash 7b40eec19c CScriptObject: Collapse for loops into ranged for loops
While we're at it, eliminate sign conversion warnings.
2020-06-12 17:12:37 -04:00
Lioncash 5c42bcc580 CLink: Resolve sign conversion warnings 2020-06-12 16:46:49 -04:00
Lioncash 38d245b460 CLink: Make constructor explicit 2020-06-12 16:45:33 -04:00
Lioncash f5e9254c9a CIndexBuffer: Make use of in-class initializers where applicable 2020-06-12 16:43:54 -04:00
Lioncash 721c4d8121 CIndexBuffer: Make constructor explicit
Prevents implicit constructions.
2020-06-12 16:41:47 -04:00
Lioncash ece0aec27a CGraphics: Make use of std::array 2020-06-12 16:36:34 -04:00
Lioncash bf9233779a CGraphics: Make skDefaultAmbientColor constexpr
Same behavior, no runtime initializer.
2020-06-12 16:19:59 -04:00
Lioncash e8a20933de CVirtualDirectory: Resolve -Wreorder warnings 2020-06-12 16:09:20 -04:00
Lioncash 1ae5462cd7 CGameProject: Make use of unique_ptr where applicable
Makes the ownership semantics explicit.
2020-06-12 16:07:04 -04:00
Lioncash 1bdcdb85de CResourceStore: Use unique_ptr where applicable
Makes the ownership semantics explicit and prevents leaks from occurring
a little better.
2020-06-12 14:43:39 -04:00
Lioncash 137b2395c9 CResourceStore: Use in-class initializers where applicable 2020-06-12 14:11:57 -04:00
Lioncash 7da16efe9d CDependencyTree: Make use of unique_ptr
Makes the ownership semantics explicit in the interface.
2020-06-12 14:09:08 -04:00
Lioncash e2190793fd CDependencyTree: Tidying up
- Convert for loops to ranged for loops.
- Collapse loop into an any_of.
2020-06-12 13:37:54 -04:00
Lioncash 7d4ce7e909 CDependencyGroupLoader: Default constructor 2020-06-12 13:26:39 -04:00
LC 10cbcd4024
Merge pull request #31 from lioncash/properties
Property: Make use of override where applicable
2020-06-12 13:17:05 -04:00
Lioncash c020084587 CCollisionMaterial: Make use of std::array
Allows simplifying some size calculations.
2020-06-12 13:14:39 -04:00
Lioncash a51604ca91 CCollisionMeshGroup: Make use of unique_ptr 2020-06-12 13:08:48 -04:00
Lioncash 48d8d361b6 CCollisionLoader: Collapse for loop into ranged for pt. 2 2020-06-12 12:57:18 -04:00
Lioncash 3b3b2cc80f CCollisionLoader: Collapse for loop into ranged for
Also removes a delete left behind in an error case.
2020-06-12 12:52:28 -04:00
Lioncash 3449f60317 CCollisionLoader: Make use of unique_ptr more
Same behavior, but makes the allocation ownership explicit
2020-06-12 12:50:19 -04:00
Lioncash d43f2dab31 CAudioGroupLoader: Default constructor 2020-06-12 12:44:27 -04:00
Lioncash 9e2a8bd693 CAnimationLoader: Make use of std::array
Prevents implicit array to pointer decay.
2020-06-12 12:43:09 -04:00