Commit Graph

1255 Commits

Author SHA1 Message Date
Lioncash 12ccb2fbd4 CGameArea: Simplify allocation handling
Eliminates manual new/delete and also makes the lifecycle of allocations
enforced within the interface.
2020-06-12 12:38:54 -04:00
Lioncash 674ae65e56 CAnimSetLoader: Collapse for loops into ranged for loops 2020-06-12 11:28:05 -04:00
Lioncash 9921ccfe25 IMetaTransition: Always initialize CMetaTransTrans members
Always provides a deterministic initial state.
2020-06-12 10:47:22 -04:00
Lioncash eabc789910 CAnimSet: Simplify allocation code
We can make use of std::unique_ptr to prevent any potential memory leaks
from occurring and simplifying the destruction code.
2020-06-12 10:43:29 -04:00
Lioncash 4eb1027362 CAnimSet: Collapse loops into ranged for where applicable 2020-06-12 10:03:02 -04:00
Lioncash 2a5ab1ed32 CAnimEventLoader: Use unique_ptr more
Makes memory handling a little more robust.
2020-06-11 21:10:02 -04:00
Lioncash ecbd3eb83d CAnimEventLoader: Default destructor
Allows the constructor to be considered trivial.
2020-06-11 21:00:08 -04:00
Lioncash 114742fc37 CCamera: Resolve -Wreorder warnings 2020-06-11 20:58:59 -04:00
Lioncash 6f0c8669de CCollisionLoader: Formatting 2020-06-11 20:53:11 -04:00
Lioncash d0bd7eb292 CCollisionLoader: Make LoadAreaCollision() return a unique_ptr
Same behavior, less boilerplate
2020-06-11 20:46:39 -04:00
Lioncash 55eee5da65 externals: Update LibCommon 2020-06-11 20:26:26 -04:00
Lioncash 907f1270bd CResourceFactory: Make use of unique_ptr
Makes the API more memory safe
2020-06-11 20:22:21 -04:00
Lioncash ce315280c3 CResource: Make BuildDependencyTree() return a unique_ptr
Makes the functions more memory safe in terms of freeing memory in
exceptional paths .
2020-06-11 18:39:07 -04:00
Lioncash eb8ca98a8a CAnimEventData: Collapse for loop into a ranged for loop 2020-06-11 18:02:52 -04:00
Lioncash 044efcf59d CAnimEventData: Remove unnecessary inline specifiers 2020-06-11 18:01:18 -04:00
Lioncash aeea0f8052 CMaterialPass: Make use of std::array 2020-06-11 17:50:40 -04:00
Lioncash 7b81aa5268 CMaterialPass: Simplify initialization code 2020-06-11 17:41:54 -04:00
Lioncash 92811a9309 CShader: Simplify initialization 2020-06-11 17:34:52 -04:00
Lioncash b8078e7419 CShaderGenerator: Fix compiler warning
MSVC desires the namespace version
2020-06-11 15:55:06 -04:00
Lioncash 012da6fb6d General: Remove unnecessary inline specifiers and add overrides 2020-06-11 15:49:42 -04:00
Lioncash 2d76c5865a CCharacterNode: Add missing override specifiers 2020-06-11 13:44:20 -04:00
Lioncash 060101c718 CCharacterNode: Remove unnecessary inline specifiers
Functions defined in class declarations are implicitly inline
2020-06-11 13:43:19 -04:00
Lioncash 100453b356 CCamera: Remove unnecessary inline specifiers
Functions defined within a class declaration are inline by default.
2020-06-11 13:41:33 -04:00
Lioncash 53b257fb8a CBoneTransformData: Remove unnecessary inline keywords
Functions defined within the class declaration are inline by default.
2020-06-11 13:40:00 -04:00
Lioncash 9ec61de2ca CAudioManager: Make LogSoundInfo() a const member function
This function doesn't modify internal state.
2020-06-11 13:38:00 -04:00
Lioncash 872c38b384 CAudioManager: Make GetSoundInfo() a const member function
This doesn't modify internal member state.
2020-06-11 13:35:38 -04:00
Lioncash 9692a064cd CAudioManager: Make constructor explicit
Prevents potentially error-prone constructions from occurring
2020-06-11 13:34:17 -04:00
Lioncash 7f881b1b10 CAudioMacro: Make use of ranged for where applicable
Same behavior, less moving parts.
2020-06-11 13:32:29 -04:00
Lioncash f9031283d0 CAudioMacro: Add missing override specifier 2020-06-11 13:31:40 -04:00
Lioncash 416608a76a CAudioMacro: Remove unnecessary inline specifiers
Functions defined within a class declaration are already inline by
default.
2020-06-11 13:31:00 -04:00
Lioncash edaafd4bcf CAudioMacro: Make constructor explicit
Prevents implicit error-prone constructions from occurring.
2020-06-11 13:30:07 -04:00
Lioncash e95cb1117a CAudioLookupTable: Include used headers 2020-06-11 13:28:11 -04:00
Lioncash 1b4ebd5f7b CAudioLookupTable: Make FindSoundDefineID() const
This doesn't mutate any contained state, so it can be const.
2020-06-11 13:26:32 -04:00
Lioncash a82f9c197b CAudioLookupTable: Make use of explicit constructors
Prevents implicit constructions
2020-06-11 13:25:19 -04:00
Lioncash d223bac56a CAudioGroup: Make use of in-class initializers 2020-06-11 13:23:50 -04:00
Lioncash 7ce0e14e29 CAssetNameMap: Eliminate file-scope string allocations 2020-06-11 13:21:33 -04:00
Lioncash 9925925b6f TResPtr: Use in-class initializers where applicable 2020-06-11 13:14:33 -04:00
Lioncash 11f156352a CAnimSetLoader: Default constructor 2020-06-11 13:11:38 -04:00
Lioncash 6a97a13e1e externals: Update LibCommon 2020-06-11 13:08:16 -04:00
Lioncash 77000ca6fd externals: Update LibCommon 2020-06-11 12:40:59 -04:00
Lioncash 094d3afc77 externals: Update LibCommon 2020-06-11 11:27:28 -04:00
Lioncash 61a6151afe externals: Update LibCommon 2020-06-11 11:10:04 -04:00
LC b5ddc20771
Merge pull request #26 from lioncash/scene
CSceneNode: Minor cleanup
2020-06-11 10:53:51 -04:00
LC 1fb554fa4c
Merge pull request #24 from lioncash/cook
CAreaCooker: Minor cleanup
2020-06-11 10:53:17 -04:00
LC 8babcc13bb
Merge pull request #22 from lioncash/anim2
CAnimation: Minor clean up
2020-06-11 10:52:59 -04:00
LC 9c2b7e4c95
Merge pull request #23 from lioncash/iter
CResourceIterator: Cleanup and undefined behavior prevention
2020-06-11 10:52:41 -04:00
LC d7b6ab81ea
Merge pull request #27 from lioncash/gen
CShaderGenerator: Make file-scope arrays non-allocating
2020-06-11 10:52:19 -04:00
LC 80ccc32e68
Merge pull request #29 from lioncash/viewport
CBasicViewport: Make member functions const where applicable
2020-06-11 10:51:53 -04:00
LC 919dcfd8d9
Merge pull request #28 from lioncash/table
CStringTable: Eliminate file-scope allocations
2020-06-11 10:51:34 -04:00
LC 4f289193bb
Merge pull request #32 from lioncash/str
CGameInfo: Make file-scope strings non-allocating
2020-06-11 10:51:20 -04:00