AxioDL/PrimeWorldEditor
2
0
Fork 0
mirror of https://github.com/AxioDL/PrimeWorldEditor.git synced 2025-12-17 17:05:37 +00:00
Code Issues Packages Projects Releases Wiki Activity
1,398 Commits 4 Branches 6 Tags
c662ef6266b0108f94d56cbfc77afbbbd800709c
Commit Graph

1398 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Lioncache
c662ef6266 CScene: Pass by const in getters 
These are overly restrictive, since the parameters are only ever
queried.
 2025-12-09 15:10:23 -05:00
Lioncache
cddb342632 CPoiListDialog: Tidy up list management 2025-12-09 14:46:55 -05:00
Lioncache
98d9f9b962 CPoiMapSidebar: Tidy up formatting 2025-12-09 14:34:37 -05:00
Lioncache
3c2bd55df6 CPoiMapSidebar: Pass QModelIndex by const reference 2025-12-09 14:28:18 -05:00
Lioncache
b5615b4a02 CCamera: Fix wonky bracing 2025-12-08 19:56:00 -05:00
Lioncache
edbbe9f097 CCamera: Simplify ValidatePitch() 
We can just use std::clamp here.
 2025-12-08 19:48:24 -05:00
Lioncache
f6a64565cd CCamera: Simplify CastRay() 
We can just make use of CRay's constructor to simplify the
initialization
 2025-12-08 19:45:07 -05:00
Lioncache
561b0e08f6 CCamera: Allow toggleable camera movement speed 
In a lot of 3D scene editors, it's quite common to have a default speed
that the camera can move at, plus a quicker one when shift (or some
other kind of keybind is held. We can replicate this here as a fixed
increment, but in the future this could also potentially be a
configurable UI setting.

Just makes the viewport expectations a little more natural like Blender
or 3DS Max.
 2025-12-08 19:30:08 -05:00
Lioncache
04f73a9687 Externals: Update LibCommon 
Fixes a bug in string splitting that broke the texture selection dialogs
in the model editor. They should now populate properly and let you
change textures if you want to do a little modding or something of the
sort.

It also exposed a bug where we had a stack overflow case
that was never hit until now. IsValidDirectoryPath() was intended to be
calling IsValidDirectoryName() on the consitituent parts of the path,
but was calling into itself. The only reason this was never hit in
practice is because the bugged Split() function would keep discarding
the end character in the strings recursively over the course of
execution until the strings were completely empty (oof!).

It also turns out that the handler for the indirect texture handling was
never hooked up to a slot in the model window. So, not only could the
model never have it's indirect texture changed, but would never render
it either, since the respective material would never be set.

We essentially smoked 3 bugs with a one-liner at the same time.
 2025-12-08 18:46:24 -05:00
Lioncache
69290914b8 CResourceProxyModel: Simplify exit cases in filterAcceptsRow() 2025-12-08 15:46:01 -05:00
Lioncache
e231158b1d CResourceProxyModel: Use forward declarations 
Reduce the amount of rebuilding necessary.
 2025-12-08 15:38:02 -05:00
Lioncache
e33088f8a3 CResourceProxyModel: Move implementation to cpp file 
Allows modifying how the resource model works without rebuilding
half of the codebase.
 2025-12-08 15:18:23 -05:00
Lioncache
e8af8cc4b1 CWorldTreeModel: Use built-in filtering facilities 
The ability to filter via a string is already built into the proxy
model. This also extends the search bar to allow general regular
expressions as well out of the box without any additional work.
 2025-12-08 15:00:50 -05:00
Lioncache
21d482f35e CWorldInforSidebar: Pass QModelIndex by const reference 
Avoids some trivial copies.
 2025-12-08 14:27:10 -05:00
Lioncache
3f8271004f CWorldInfoSidebar: Add missing UICommon include 
Gets rid of an indirect include.
Also adds a forward declaration to prevent build failures in the future.
 2025-12-08 14:11:26 -05:00
Lioncache
e6bf47112a CVirtualDirectory: Pass by const in IsDescendantOf 
This isn't modified.
 2025-12-08 04:13:56 -05:00
Lioncache
d335465141 CMaterialLoader: Formatting shenanigans 2025-12-08 03:26:45 -05:00
Lioncache
934bdaf889 CModel: Mark query functions as const 2025-12-08 03:04:33 -05:00
Lioncache
f3fd7f8268 CGameInfo: Reduce string copies in formatting 2025-12-07 12:20:09 -05:00
Lioncache
5f7e0e1e7f CGameExporter: Pass CAssetID by reference in MakeWorldName() 
Just prevents a copy where one isn't necessary
 2025-12-07 12:19:44 -05:00
Lioncache
53e52d3587 CGameExporter: Brace logical AND between ORs 
Silences potential warnings.
 2025-12-07 12:09:14 -05:00
Lioncache
5d3086ec31 CModelEditorWindow: Convert old signal/slot to modern style 
Turns out this was attached incorrectly.
 2025-12-07 09:47:45 -05:00
Lioncache
2d0d3d03c6 Editor: Remove now unnecessary qOverload instances 
These used to be necessary on older versions of Qt
 2025-12-07 09:21:08 -05:00
Lioncache
6fac2d126f CExportGameDialog: Remove redundant QString conversion 
We can just use QFileInfo here.
 2025-12-07 08:58:53 -05:00
Lioncache
5e1db1f0bc CCharacterEditor: Invert if in UpdateCameraOrbit() 
Allows simplifying some behavior.
 2025-12-07 08:58:22 -05:00
Lioncache
23ba1c19f7 CQuickplayPropertyEditor: Add missing <QPushButton> include 
Gets rid of an indirect include.
 2025-12-07 08:35:07 -05:00
Lioncache
15f100e325 CResourceTableView: std::move in DeleteSelected() 
Avoids churning list copies.
 2025-12-07 08:31:15 -05:00
Lioncache
37907c7837 CResourceTableModel: std::move parameters in DisplayEntryList() 
We can allow for moving into this to avoid allocation churning.
 2025-12-07 08:29:14 -05:00
Lioncache
e7a2a10d64 CSelectInstanceDialog: Pass QModelIndex by const reference 
Gets rid of a few trivial 24 byte copies.
 2025-12-07 08:08:07 -05:00
Lioncache
6428864373 CModelEditorViewport: Pass color by reference 
Avoids an unnecessary 16-byte float copy
 2025-12-07 03:22:47 -05:00
Lioncache
5d61bbc85c CSkeletonHierarchyModel: Pass skeleton by const to SetSkeleton() 2025-12-07 03:10:31 -05:00
Lioncache
6620980add CSkeletonHierarchyModel: Pass bones by const to IndexForBone() 
Given these aren't modified, we can make this obvious.
 2025-12-07 03:09:21 -05:00
Lioncache
03ae5b54df INodeEditor: Pass cursor by reference 2025-12-07 03:00:02 -05:00
Lioncache
2f39217583 IEditPropertyCommand: Mark IsNewDataDifferent() as const 
This doesn't modify class state.
 2025-12-07 02:55:09 -05:00
Lioncache
8f8e6aa8f4 WModifyTab: Pass QModelIndex by const reference 
Just a trivial way to eliminate a 24 byte copy.
 2025-12-07 02:51:18 -05:00
Lioncache
511c86785b WDraggableSpinBox: Make use of qsizetype 
Avoids implicit truncations.
 2025-12-07 02:46:33 -05:00
Lioncache
a85bbd3e49 CResourceBrowser: Pass strings by const reference in signals 
Allows slots to avoid copies where applicable.
 2025-12-07 02:37:54 -05:00
Lioncache
919820bdf7 ICreateDeleteDirectoryCommand: std::move strings where applicable 
Same behavior without churning allocations.
 2025-12-07 02:32:51 -05:00
Lioncache
f577335087 Editor/Undo: Mark relevant variables as maybe unused 
Prevents potential warnings on release mode.
 2025-12-07 02:30:04 -05:00
Lioncache
deb1aaae01 CVirtualDirectoryModel: Mark Found variable as [[maybe_unused]] 
This can technically be unused on release builds.
 2025-12-07 02:26:08 -05:00
Lioncache
5ff96c750b Editor/CWorldEditor: Eliminate redundant copies 2025-12-07 02:25:24 -05:00
Lioncache
051d0ec50b Editor/CPropertyModel: std::move font instance 
Avoids making a full copy of the font.
 2025-12-07 02:08:54 -05:00
Lioncache
25c45b2b28 CSceneNode: Make use of structured bindings in RayAABoxIntersectTest() 
Same thing, but lets the returned values have more self-explanatory
names.
 2025-12-06 18:31:34 -05:00
Lioncache
4914ccdc22 CAnimSetLoader: Make use of designated initializes + reserve where applicable 
Simplifies some declarations, and overall reduces allocation churning.
 2025-12-06 18:07:39 -05:00
Lioncache
04f31acc71 CAudioGroupLoader: Reserve audio lookup table elements beforehand 
Potentially reduces repeated reallocations.
 2025-12-06 17:50:24 -05:00
Lioncache
335816af03 CFlagsProperty: Default comparison operators 
Same behavior, less code.
 2025-12-06 17:36:05 -05:00
Lioncache
5d35a14538 CEnumProperty: Default comparison operators 
Same behavior, less code.
 2025-12-06 17:35:39 -05:00
Lioncache
55ed25023b CResourceEntry: Mark bool as maybe unused 
This can be considered unused in release builds
 2025-12-06 17:22:36 -05:00
Lioncache
172f450b84 CArrayProperty: Make Use of defaulted comparisons 
Same behavior, less code.
 2025-12-06 17:22:02 -05:00
Lioncache
f093c3d552 Core/AssetNameGeneration: Mark assert variables as maybe unused 
These may be considered unused in release builds.
 2025-12-06 17:12:57 -05:00