Lioncash
58040eb53d
CKnockBackController: Make CalculateExtraHurlVelocity() a const member function
...
This doesn't modify internal member state, so it can be marked const
While we're at it we can also invert the conditional to unindent the
main calculation.
2020-04-17 01:07:41 -04:00
Lioncash
b55d1e4c77
CKnockBackController: Make use of const references where applicable
...
In many cases the CPatterned& parameter is only used for read-only
querying. We can make this explicit in the interface.
2020-04-17 01:03:12 -04:00
Lioncash
49cc019699
CKnockBackController: Make GetKnockBackCharacterState() a const member function
...
This doesn't modify internal instance state, so this can be made const.
2020-04-17 00:58:29 -04:00
Lioncash
529d7e58bd
CFishCloud: Initialize x230_whichModel on construction
...
Provides a deterministic initial state.
2020-04-17 00:49:06 -04:00
Lioncash
fa9f0fdc61
CFishCloud: Brace statements where applicable
...
Makes the code more uniform and consistent.
While we're in the same area, we can make use of const where applicable.
2020-04-17 00:47:25 -04:00
Lioncash
3715e6dcbb
CFlameWarp: Make use of const where applicable
...
Makes algorithms easier to follow by explicitly marking immutable
state.
2020-04-17 00:27:22 -04:00
Lioncash
ed125031f3
CFluidUVMotion: Collapse separate resize and assignment into a constructor call
...
We can pre-size and insert the elements all at the same time.
2020-04-16 21:11:31 -04:00
Phillip Stephens
c85f1a64dd
Merge branch 'master' of ssh+git://git.axiodl.com:6431/AxioDL/urde
2020-04-16 17:20:25 -07:00
Phillip Stephens
ba3b23edaa
Disable saving on non-NTSC-U versions
2020-04-16 17:19:55 -07:00
Lioncash
20e5595042
CGameState: Always initialize x80_
...
Provides a deterministic initial state.
2020-04-16 20:00:26 -04:00
Lioncash
a551dbc21d
CGameState: Silence implicit truncation warnings
...
Ensures boolean conditions are used where applicable.
2020-04-16 20:00:20 -04:00
Lioncash
f844f2028b
CGameOptions: Give all function prototype parameters a name
...
Makes the interface more self-documenting and also allows better IDE
introspection.
2020-04-16 19:49:35 -04:00
Lioncash
e7ef1e0b5e
CGameOptions: Make TuneScreenBrightness() a const member function
...
This member function doesn't modify internal class state.
2020-04-16 19:42:22 -04:00
Phillip Stephens
d16e758f07
Include stdbool because AppleClang is weird
2020-04-16 13:43:23 -07:00
Phillip Stephens
dea8438f19
Minor fix for macOS
2020-04-16 13:18:44 -07:00
Lioncash
c32c42e12b
CGameOptions: Amend wonky formatting of VisorOptsNew
2020-04-16 13:00:08 -04:00
Phillip Stephens
be45be9d67
Fix FrontEnd options screen
2020-04-16 03:35:51 -07:00
Phillip Stephens
9365c35000
Finish fixing STRG indices
2020-04-16 03:25:59 -07:00
Phillip Stephens
8e2636c14c
Undo debug code
2020-04-15 23:58:00 -07:00
Phillip Stephens
c64e3d2ba7
Initial string fixes
2020-04-15 23:57:04 -07:00
Phillip Stephens
582d8a6999
Initial PAL/JP/Trilogy imps, various cleanup
2020-04-15 22:26:14 -07:00
Phillip Stephens
3487ea92c7
Merge branch 'master' of ssh+git://git.axiodl.com:6431/AxioDL/urde
2020-04-15 11:56:57 -07:00
Phillip Stephens
191d0f079d
Add real URDEVersionInfo.hpp
2020-04-15 11:54:17 -07:00
Luke Street
6d4ad6d956
Add URDEVersionInfo.hpp
2020-04-15 13:43:49 -04:00
Phillip Stephens
52b4db2f00
Integrate URDEVersionInfo
2020-04-15 06:42:44 -07:00
Phillip Stephens
e553a9022f
Fix CMemoryCardSys
2020-04-15 04:27:06 -07:00
Phillip Stephens
8a974d6e5e
Merge branch 'master' of ssh+git://git.axiodl.com:6431/AxioDL/urde
2020-04-15 00:57:37 -07:00
Phillip Stephens
1eade15395
Add version info to extracted data, clean up MP1.*
2020-04-15 00:56:59 -07:00
Luke Street
790b155b7f
Update hecl
2020-04-14 22:14:27 -04:00
Luke Street
b020904e84
Comment out printfs entirely
2020-04-14 22:14:27 -04:00
Luke Street
eb89a17817
CDummyWorld: Fix IGetAreaId
2020-04-14 21:15:38 -04:00
Luke Street
f4ab5e45a1
Update hecl/extern/athena
2020-04-14 21:00:11 -04:00
Lioncash
6436184a3f
CWorld: Make use of find_if in GetAreaIdForSaveId()
...
Same behavior minus any explicit mutable state.
2020-04-14 16:40:13 -04:00
Lioncash
86b94ad915
CWorld: Make use of std::find_if in IGetAreaId
...
Removes explicit mutable state. This can be further simplified in the
future with ranges.
2020-04-14 16:31:17 -04:00
Lioncash
655805ffcb
CWorld: Add missing override specifier
2020-04-14 16:17:26 -04:00
Luke Street
c7771be751
Add screenshot to README.md
2020-04-14 16:14:09 -04:00
Lioncash
8e89ac234f
CElementGen: Initialize x80_timeDeltaScale on construction
...
Provides deterministic state upon construction, which is nicer for
debugging.
2020-04-14 16:11:38 -04:00
Lioncash
384efebf55
CElementGen: Collapse loop into a ranged-for loop
...
Same behavior, nicer syntax.
2020-04-14 16:08:21 -04:00
Lioncash
c14721611b
CEnergyProjectile: Make use of const where applicable
...
While we're at it, make use of consistent bracing, given some
conditionals traveled over one line.
2020-04-14 15:47:45 -04:00
Luke Street
9cf95b5c10
Editor: Move cvars to CVarCommons
2020-04-14 15:20:51 -04:00
Luke Street
94be460a1b
MP1: Convert MP1_VARIABLE_DELTA_TIME to cvar
2020-04-14 14:41:02 -04:00
Lioncash
3c8ce3dc99
CGuiTextSupport: Amend typo in debug group label
...
This is within the Render() function, so we can rename the group name.
2020-04-14 13:34:50 -04:00
Lioncash
5381c011a0
CParticleElectric: Eliminate several sign conversion instances
...
Makes sign conversion cases explicit and eliminates them entirely in
other cases.
2020-04-14 12:30:38 -04:00
Lioncash
4cbf8ef513
CParticleElectric: Mark CGlobalRandom instance as maybe unused
...
This has a stateful destructor, so we mark it as unused to silence
unused variable warnings.
2020-04-14 12:16:25 -04:00
Lioncash
8aef2cf95d
CParticleElectric: Make use of const where applicable
...
Makes it easier to read long functions by knowing which variables are
mutable.
2020-04-14 04:20:03 -04:00
Lioncash
fed72614ef
CParticleSwoosh: Use const where applicable
...
Given the length of some functions, this makes following flow nicer,
since it's easier to visually see which variables get modified.
2020-04-14 03:56:27 -04:00
Lioncash
6fbf6734c2
CParticleSwoosh: Eliminate variable shadowing
2020-04-14 03:31:31 -04:00
Lioncash
480d27e68c
CParticleSwoosh: Initialize class data members
...
Makes for deterministic initial state.
2020-04-14 03:27:15 -04:00
Luke Street
112322be5a
Merge pull request #311 from lioncash/sign
...
CScanDisplay: Eliminate implicit sign conversions
2020-04-14 02:10:13 -04:00
Luke Street
594fe2fcbd
Merge pull request #310 from lioncash/table
...
CFluidPlane: Make use of std::array where applicable
2020-04-14 02:09:19 -04:00