Commit Graph

2655 Commits

Author SHA1 Message Date
Phillip Stephens 1b1cc42139
Update submodules 2019-09-10 04:08:22 -07:00
Phillip Stephens 60409d2f6a
Merge pull request #63 from lioncash/char
CActorModelParticles: Make DGRP array constexpr
2019-09-10 04:03:06 -07:00
Lioncash 5baf3206f4 CActorModelParticles: Make DGRP array constexpr
Technically this array wasn't readonly and contained a sequence of
modifiable elements. We can make this constexpr so that the compiler can
definitively place it into the read-only segment.
2019-09-09 20:44:23 -04:00
Phillip Stephens e2ab93dfac
Update submodules 2019-09-09 04:21:01 -07:00
Phillip Stephens f07fc458d2
Merge pull request #62 from lioncash/crc
CCRC32: Move table declaration into the cpp file
2019-09-08 17:49:44 -07:00
Phillip Stephens fae4fe9bf1
Merge pull request #61 from lioncash/ai
CAiFuncMap: Minor cleanup
2019-09-08 17:49:34 -07:00
Phillip Stephens fa1b3a5a12
Merge pull request #60 from lioncash/athena
DataSpec: Be explicit about athena's SeekOrigin type
2019-09-08 17:49:25 -07:00
Lioncash f430a00314 CCRC32: Move table declaration into the cpp file
This can be moved entirely into the cpp file, making it an
implementation detail.
2019-09-08 18:18:29 -04:00
Lioncash c9271809a7 CAiFuncMap: Remove unused static std::vector
This isn't used, so we can remove it and get rid of a static
constructor.
2019-09-08 18:08:10 -04:00
Lioncash 20a0585cc5 CAiFuncMap: Convert typedefs into type aliases
Same thing, but reads a little nicer.
2019-09-08 18:08:10 -04:00
Lioncash 2f06fcba0a CAiFuncMap: Avoid redundant map lookups in getters
We can just use the result of the find operation instead of rehashing
into the map to retrieve the entry.

This also allows us to make the getter const qualified.
2019-09-08 18:08:10 -04:00
Lioncash 1cfe83d8d1 CAiFuncMap: Replace map indexing with emplace in the constructor
Provides the same behavior, but without default initializing a map entry
that immediately gets overridden in the assignment.
2019-09-08 18:08:10 -04:00
Lioncash bf818a883e DataSpec: Be explicit about athena's SeekOrigin type
This was missed in 9c0d13f001
2019-09-08 16:44:02 -04:00
Phillip Stephens 4a4781de76
Update submodules 2019-09-08 00:16:42 -07:00
Phillip Stephens 1992060927
Merge pull request #59 from lioncash/enum
General: Be explicit about athena's SeekOrigin type
2019-09-08 00:13:44 -07:00
Lioncash c0c6d02c27 Editor/ProjectManager: Be explicit about athena's SeekOrigin type
Allows this code to work if it's ever changed into an enum class.
2019-09-07 21:22:41 -04:00
Lioncash 9c0d13f001 DataSpec: Be explicit about athena's SeekOrigin type
Allows code to still function properly if the enum is changed into an
enum class.
2019-09-07 21:20:01 -04:00
Phillip Stephens 92eb6bc6f0
Update submodules 2019-09-07 07:08:33 -07:00
Phillip Stephens c6664d65ab
Update submodules 2019-09-06 23:32:43 -07:00
Phillip Stephens 12c3942e65
Merge pull request #57 from lioncash/ref
World/CScript*: Pass by reference over by value
2019-09-06 23:21:23 -07:00
Phillip Stephens eae1f1ab82
Merge pull request #56 from lioncash/tentacle
MP1/CFlaahgraTentacle: Amend sphere collision list appending
2019-09-06 23:21:01 -07:00
Phillip Stephens c2777b42f8
Merge pull request #55 from lioncash/typo
WPSC: Correct typo within WPSM's _read() function
2019-09-06 23:20:29 -07:00
Phillip Stephens 3a5cb71c74
Merge pull request #54 from lioncash/overrun
DNAMP1/CTweakPlayerGun: Prevent array overrun cases
2019-09-06 23:20:02 -07:00
Phillip Stephens e783850cc7
Merge pull request #53 from lioncash/cmake
visigen/CMakeLists: Modify target directly
2019-09-06 23:18:48 -07:00
Phillip Stephens 58fa527aeb
Merge pull request #58 from lioncash/overrun2
ControlMapper: Prevent array overrun cases
2019-09-06 23:18:32 -07:00
Lioncash 5b1e783a90 ControlMapper: Prevent array overrun cases
These should be comparing with >=, not >.

The command table descriptions also weren't kept in sync with the
enumeration.
2019-09-06 11:18:13 -04:00
Lioncash 2c6aed7033 World/CScript*: Pass by reference over by value
Based off the use of the const, it's likely that these were intended to
be references, rather than be copied by value
2019-09-06 10:49:54 -04:00
Lioncash d25f4fa9a3 MP1/CFlaahgraTentacle: Amend sphere collision list appending
This was always using the first element in the array to append t the
output joint list, resulting in incorrect names and radius values.
2019-09-06 09:43:32 -04:00
Lioncash 8556a74196 WPSC: Correct typo within WPSM's _read() function
This should be calling read() on xunk_SPS1, not xunk_SPS2
2019-09-06 08:42:35 -04:00
Lioncash 66ce2774d5 DNAMP1/CTweakPlayerGun: Prevent array overrun cases
These arrays are both 5 elements in size. Accessing them at index 5
would be out of bounds.
2019-09-06 08:13:10 -04:00
Lioncash d5d176d1a5 visigen/CMakeLists: Modify target directly
Instead of using variables, we can directly specify our requirements on
the target instance directly. This also avoids modifying
CMAKE_CXX_FLAGS.
2019-09-06 07:50:17 -04:00
Phillip Stephens fea7984f71
Update submodules 2019-09-05 01:11:11 -07:00
Phillip Stephens d075ae209b
Merge pull request #52 from lioncash/init
PAK: Zero initialize m_sz and m_pos of PAKEntryReadStream
2019-09-05 01:08:59 -07:00
Lioncash 7a0e7f449e PAK: Make operator bool() explicit for PAKEntryReadStream
Prevents potential error-prone conversions to bool.
2019-09-05 00:59:32 -04:00
Lioncash 107dfc4203 PAK: Zero initialize m_sz and m_pos of PAKEntryReadStream
Provides a deterministic initial state for the members in the case of
the default constructor.
2019-09-05 00:57:57 -04:00
Phillip Stephens cc52f0b855
Update submodules 2019-09-04 19:38:13 -07:00
Phillip Stephens 96e482567c
Merge pull request #51 from lioncash/inc
SpecBase: Add missing includes
2019-09-04 19:28:17 -07:00
Lioncash da89e7cf45 SpecBase: Add missing includes 2019-09-04 19:30:04 -04:00
Phillip Stephens 549cae79a8
Update specter 2019-09-03 23:26:11 -07:00
Phillip Stephens a1819ca079
Merge pull request #50 from lioncash/jbus
General: Amend relevant code to compile with jbus changes
2019-09-03 23:12:06 -07:00
Phillip Stephens 2d1d11fb56
Update submodules, fix compiling against kabufuda 2019-09-03 23:11:04 -07:00
Lioncash 5aafd3935b CGBASupport: Amend code to compile with jbus changes 2019-09-04 01:56:08 -04:00
Lioncash fac7c7b1fc gbalink: Amend code to compile with jbus changes 2019-09-04 01:56:04 -04:00
Phillip Stephens 74572e5be2
Update kabufuda 2019-09-02 01:03:45 -07:00
Phillip Stephens a456b904f1
Update kabufuda 2019-09-01 11:34:19 -07:00
Phillip Stephens 4dc6241f20
Update submodules 2019-09-01 11:09:11 -07:00
Phillip Stephens 12238e5c30
Merge pull request #49 from lioncash/resource
CStringTable: Use std::array instead of std::vector
2019-09-01 11:06:15 -07:00
Lioncash d5fa8b72b0 CStringTable: Remove unnecessary initializer
std::unique_ptr always initializes to nullptr. We can remove this
implicit convertion from 0 to nullptr.
2019-09-01 03:16:54 -04:00
Lioncash e23dfbd8db CStringTable: Use std::array instead of std::vector
Gets rid of a static constructor, as well as a few heap allocations
2019-09-01 03:13:45 -04:00
Phillip Stephens 484a6b0cdf
Update hecl-gui 2019-08-31 16:29:21 -07:00