Lioncash
1d0151ccbc
General: Make use of lock deduction guides
2020-04-20 00:38:10 -04:00
Lioncash
dca87e7dce
CPlayerGun: Convert missed literal to a boolean literal
...
whoops.
2020-04-19 23:39:04 -04:00
Lioncash
1f8f3726e6
CPlayerGun: Make use of bool literal where appropriate
...
Avoids a conversion to bool from int.
2020-04-19 23:35:07 -04:00
Luke Street
1fd28d3fc3
CStateMachine: Use logvisor report for state logging
2020-04-19 22:11:09 -04:00
Lioncash
f0133c9eef
CAuiImagePane: Eliminate implicit conversions
...
We can make them explicit instead.
2020-04-19 22:06:30 -04:00
Lioncash
ecdedb5d8f
CActorModelParticles: Make IsMediumOrLarge() parameter a const reference
...
Nothing about the parameter is modified.
2020-04-19 21:44:31 -04:00
Luke Street
2185dc30f1
CStateManager: Fix seek again (I tested it this time)
2020-04-19 21:40:08 -04:00
Luke Street
764432882c
CStateManager: Fix wrong stream position on error
2020-04-19 21:27:08 -04:00
Luke Street
d5fcb4a917
CStateManager: Revert debug commit
2020-04-19 21:20:25 -04:00
Luke Street
24acb585f8
MSVC & zeus fixes; update hecl-gui
2020-04-19 21:09:30 -04:00
Lioncash
ec5d680be0
CBurstFire: Unindent conditionals where applicable
...
Makes it nicer to read early-exit conditions.
2020-04-19 00:40:46 -04:00
Luke Street
e50d363e88
CPlayerGun: Rename EMissileState; minor CMotionState::Update fix
2020-04-19 00:26:53 -04:00
Luke Street
a3e0c42794
Merge pull request #312 from lioncash/explicit
...
MkCastTo: Make operator bool instances explicit
2020-04-19 00:24:15 -04:00
Lioncash
2c3e5e205f
MkCastTo: Make operator bool instances explicit
...
Prevents error prone implicit conversions.
2020-04-18 23:02:11 -04:00
Luke Street
0a2d0bcfe9
Merge pull request #313 from lioncash/bug
...
CToken: Amend incorrect return value of TToken's operator=
2020-04-18 18:16:42 -04:00
Luke Street
7f15390d4f
Editor: Only create Win32 console & redirect logging if not attached
2020-04-18 03:02:44 -04:00
Phillip Stephens
df75c00203
Fix WideScreenFilter crash
2020-04-17 15:32:26 -07:00
Lioncash
76f0b57340
General: Use bool literals where applicable
...
More indicative of the passed in type compared to raw values.
2020-04-17 17:43:56 -04:00
Lioncash
8e5fc3668c
CToken: Amend incorrect return value of TToken's operator=
...
This should be returning by reference, not the pointer of this.
2020-04-17 17:16:33 -04:00
Lioncash
0b05c906df
CScriptEffect: Eliminate variable shadowing
...
Avoids clashing names.
2020-04-17 16:31:02 -04:00
Luke Street
8f5caca1e5
CMemoryCardSysWin: Add includes
2020-04-17 15:10:52 -04:00
Luke Street
61e656e732
CDvdFile: Remove const from auto type for MSVC
2020-04-17 15:01:31 -04:00
Luke Street
36bbc5004f
CDvdFile: Use auto for string_view::begin
2020-04-17 14:52:25 -04:00
Luke Street
4a8f077d92
MP1: Use _SYS_STR where needed
2020-04-17 14:39:40 -04:00
Luke Street
248e7654fa
MP1: char -> boo::SystemChar
2020-04-17 14:31:29 -04:00
Luke Street
73b9d2024b
MP1: Use SystemStringConv for printing version string
2020-04-17 14:24:06 -04:00
Lioncash
5491f3ff23
CKnockBackController: Simplify initialization of x24_ in constructor
...
Same behavior, less code.
2020-04-17 13:17:27 -04:00
Lioncash
26ac3b166d
CKnockBackController: Make use of braces where applicable
...
Makes code more consistent.
Where applicable we can also unindent code.
2020-04-17 13:17:27 -04:00
Phillip Stephens
acf513c6bf
Merge branch 'master' of ssh+git://git.axiodl.com:6431/AxioDL/urde
2020-04-17 05:54:17 -07:00
Phillip Stephens
a06594f404
Fix CAutoMapper strings, disable saving on non-USA/GC versions
2020-04-17 05:53:22 -07:00
Lioncash
58040eb53d
CKnockBackController: Make CalculateExtraHurlVelocity() a const member function
...
This doesn't modify internal member state, so it can be marked const
While we're at it we can also invert the conditional to unindent the
main calculation.
2020-04-17 01:07:41 -04:00
Lioncash
b55d1e4c77
CKnockBackController: Make use of const references where applicable
...
In many cases the CPatterned& parameter is only used for read-only
querying. We can make this explicit in the interface.
2020-04-17 01:03:12 -04:00
Lioncash
49cc019699
CKnockBackController: Make GetKnockBackCharacterState() a const member function
...
This doesn't modify internal instance state, so this can be made const.
2020-04-17 00:58:29 -04:00
Lioncash
529d7e58bd
CFishCloud: Initialize x230_whichModel on construction
...
Provides a deterministic initial state.
2020-04-17 00:49:06 -04:00
Lioncash
fa9f0fdc61
CFishCloud: Brace statements where applicable
...
Makes the code more uniform and consistent.
While we're in the same area, we can make use of const where applicable.
2020-04-17 00:47:25 -04:00
Lioncash
3715e6dcbb
CFlameWarp: Make use of const where applicable
...
Makes algorithms easier to follow by explicitly marking immutable
state.
2020-04-17 00:27:22 -04:00
Lioncash
ed125031f3
CFluidUVMotion: Collapse separate resize and assignment into a constructor call
...
We can pre-size and insert the elements all at the same time.
2020-04-16 21:11:31 -04:00
Phillip Stephens
c85f1a64dd
Merge branch 'master' of ssh+git://git.axiodl.com:6431/AxioDL/urde
2020-04-16 17:20:25 -07:00
Phillip Stephens
ba3b23edaa
Disable saving on non-NTSC-U versions
2020-04-16 17:19:55 -07:00
Lioncash
20e5595042
CGameState: Always initialize x80_
...
Provides a deterministic initial state.
2020-04-16 20:00:26 -04:00
Lioncash
a551dbc21d
CGameState: Silence implicit truncation warnings
...
Ensures boolean conditions are used where applicable.
2020-04-16 20:00:20 -04:00
Lioncash
f844f2028b
CGameOptions: Give all function prototype parameters a name
...
Makes the interface more self-documenting and also allows better IDE
introspection.
2020-04-16 19:49:35 -04:00
Lioncash
e7ef1e0b5e
CGameOptions: Make TuneScreenBrightness() a const member function
...
This member function doesn't modify internal class state.
2020-04-16 19:42:22 -04:00
Lioncash
c32c42e12b
CGameOptions: Amend wonky formatting of VisorOptsNew
2020-04-16 13:00:08 -04:00
Phillip Stephens
be45be9d67
Fix FrontEnd options screen
2020-04-16 03:35:51 -07:00
Phillip Stephens
9365c35000
Finish fixing STRG indices
2020-04-16 03:25:59 -07:00
Phillip Stephens
8e2636c14c
Undo debug code
2020-04-15 23:58:00 -07:00
Phillip Stephens
c64e3d2ba7
Initial string fixes
2020-04-15 23:57:04 -07:00
Phillip Stephens
582d8a6999
Initial PAL/JP/Trilogy imps, various cleanup
2020-04-15 22:26:14 -07:00
Phillip Stephens
52b4db2f00
Integrate URDEVersionInfo
2020-04-15 06:42:44 -07:00