Commit Graph

10378 Commits

Author SHA1 Message Date
Austin Eng e2bdb5edd7 Update CTS docs
Update with additional argument docs, and docs on uploading builds
to Swarming. I've found this particularly useful lately.

Bug: none
Change-Id: Iee04043b7260c505d4d63025c4038e3eb50db338
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102106
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2022-09-14 17:13:17 +00:00
Seto c6927203d5 Fix the Chinese windows system encoding problem.
Bug: dawn:1532

Change-Id: I01d72f07c304c1ac058f58cfc004d5e8595dc7e4
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102220
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-09-14 16:41:07 +00:00
Austin Eng a659937918 Roll third_party/webgpu-cts/ a6451cc67..5e70787c4 (7 commits)
Update:
 - expectations.txt
 - ts_sources.txt
 - resource_files.txt
 - webtest .html files

a6451cc673..5e70787c4d
 - 5e7078 Add global option noRaceWithRejectOnTimeout (#1836)
 - cf51bc Add a 'storage_texture,format' test to createBindGroup.spec.ts (#1829)
 - 446c22 Fix type error when trying to .writeBuffer a Float16Array (#1833)
 - a0408e shader/execution: Add heartbeats to expression tests
 - 3c579b Add `length` F32 tests (#1815)
 - fee036 Make `make*ToF32IntervalCase`s more idiomatic (#1816)
 - a20c0a Implement `quantizeToF16` f32 tests (#1828)

Created with './tools/run cts roll'

Change-Id: I98bb79ac57585a5b57d3e4303bd7a2c4ca576598
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102150
Auto-Submit: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-09-14 16:01:37 +00:00
Jiawei Shao 060137a712 Replace NULL with nullptr
This patch replaces NULL with nullptr as nullptr is preferred as null
pointers in Chromium coding style.

Bug: None
Change-Id: Ie6ab9d606d791bad2c50001815062c22e9ec0d25
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102102
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-09-14 14:39:37 +00:00
Austin Eng a48e46f3a4 CTS: Handle may_exonerate tag
may_exonerate indicates that a test failed for a known issue that
we could exonerate. Merging of test results now removes results
with may_exonerate unless all of them were tagged as such. So, if
for example, a test fails for a known timeout issue, but has a
subsequent pass, the timeout will be ignored.

This serves to reduce the impact of known, hard-to-fix issues and
allow the CTS roller to make progress with less noise.

Change-Id: I5103a666496398a17b3aa6ccf3f267421e40ba97
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101804
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-09-14 14:29:07 +00:00
Wang Qing cd86adaf41 loongarch: Add ASSERT() breakpoint support on loongarch architecture.
Bug: dawn:1506
Change-Id: Icff59529676c1f2ad3b9e1779577cad467866797
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102146
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Loko Kung <lokokung@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-09-14 13:31:37 +00:00
Shrek Shao b74ca3f8e0 Block NaN and Inf constants value as invalid
Bug: chromium:1362412
Change-Id: Ie3b8c447677ebb4bc12177a5dc4fd92d9033a359
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102280
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Auto-Submit: Shrek Shao <shrekshao@google.com>
2022-09-14 13:13:07 +00:00
Dawn Autoroller a0b64c7e64 Roll ANGLE from f39a9659c91a to a902eea901d0 (6 revisions)
f39a9659c9..a902eea901

2022-09-13 ynovikov@chromium.org Qualify Mac 12.5.1 on Intel
2022-09-13 m.maiya@samsung.com Do not link program pipeline in glUseProgramStages
2022-09-13 m.maiya@samsung.com Vulkan: Extend bounding box when pruning updates
2022-09-13 ynovikov@chromium.org Skip end2end tests failing on iOS
2022-09-13 solti@google.com use proper TPrecision when creating TType
2022-09-13 ynovikov@chromium.org Fix UninstantiatedParameterizedTestSuite errors on iOS.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC enga@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: enga@google.com
Change-Id: I06959add2a71da2f6aa5f53906e4493a073ab365
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102300
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-09-14 03:50:27 +00:00
Yan,Shaobo 876bd3bf87 Enable external_texture/* cts
Change-Id: Ieb153292c78ea8197b4309d796d352ce820646d1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/99241
Commit-Queue: Shaobo Yan <shaobo.yan@intel.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-09-14 01:09:42 +00:00
Ben Clayton 751e6686aa tint/intrinsics.def: Implement saturate()
Fixed: tint:1591
Change-Id: I0b1397d74abd49cd44caf326a2063e50c5cf07de
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101480
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Auto-Submit: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-13 22:57:52 +00:00
Ben Clayton f3d9ea4bea tint: Error if statically indexing out of bounds.
Fixed: tint:1665
Change-Id: Icd5f24f3b4d6ebbdc18b536dc426da92558a3a4b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101183
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: David Neto <dneto@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-13 22:47:12 +00:00
Austin Eng 75943c234f Remove .d.ts files from CTS js output list
Change-Id: I3ea78cd4008772d3d60c67e1f665fe987d4cd92f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102260
Commit-Queue: Shrek Shao <shrekshao@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Shrek Shao <shrekshao@google.com>
Auto-Submit: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-13 22:22:02 +00:00
Austin Eng e0cbb0cfe9 CTS: set noRaceWithRejectOnTimeout
Following https://github.com/gpuweb/cts/pull/1836, this will let Chrome's
CTS runner bypass the builtin CTS timeouts in favor of our own harness
timeouts.

Bug: chromium:1340602
Change-Id: I09f25de26f28f4595c6d277050f2a71969566fdb
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102200
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-09-13 22:16:42 +00:00
Antonio Maiorano 8a440ee3b4 tint: delete and regen SKIP e2e tests that were missing FXC error message
Change-Id: Id63cd40445bb9dab09ebcc67c5fef45ee29529e7
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102149
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2022-09-13 22:04:22 +00:00
Stephen White 05d8b02b0f GLSL: implement host-visible memory padding.
Since GLSL ES does not support the offset= attribute, struct members
with explicit @align or @size attributes require adding explicit
padding members.  This in turn requires rewriting any constructor
calls to initialize the new padding to zero, handled in the same
transform.

Note that this is currently overly-verbose, and will add padding where
GLSL doesn't technically need it (e.g., padding a vec3 out to 16 bytes).

Bug: tint:1415
Change-Id: Ia9ba513066a0e84f4c43247fcbbe02f5fadd6630
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101720
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-13 19:48:51 +00:00
Austin Eng 26ffcd1768 CTS: Allow sync code to interrupt and cancel a scheduled heartbeat
Bug: chromium:1340602
Change-Id: Id6f8d58bd283c8232af533cf2a0fe74adb704336
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102180
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-13 18:28:31 +00:00
Ben Clayton e667d777ac tint/fuzzers/tint_concurrency_fuzzer: Reduce number of threads
Should reduce memory and improve performance.

Bug: chromium:1360731
Bug: chromium:1357188
Change-Id: I94c3653f6d61db9d949ad27d8b666688ccad86dd
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102182
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Auto-Submit: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-09-13 18:24:02 +00:00
Antonio Maiorano 0dfbaa9ef9 tint: Make ForEachElemPair return value an enum instead of a bool
Bug: tint:1581
Change-Id: Ia16a548c03f7dff4ebc45599e20c0004834da6ae
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102121
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
2022-09-13 18:16:11 +00:00
Antonio Maiorano e53b6f9502 tint: const eval of binary bitwise AND and OR
Bug: tint:1581
Change-Id: Id6a7a1c8e45ee91bede8014dca03a59035b29678
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102060
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2022-09-13 18:13:01 +00:00
Antonio Maiorano 5b3707a2d7 tint: Implement const eval of unary not
Bug: tint:1581
Change-Id: If0a74b1f6739725a2284678aab97baf737d96937
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101761
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2022-09-13 17:32:17 +00:00
Antonio Maiorano 8175cff07b tint/const_eval_test: factor out testing framework from binary tests to use with unary tests
Bug: tint:1581
Change-Id: I55c46123f5adfcd9b48ef03f62ceb68a1d7aca58
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101760
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2022-09-13 17:18:02 +00:00
dawn-autoroll 3a3ff04c98 Roll vulkan-deps from 326dc2045cba to fb10489972ad (1 revision)
https://chromium.googlesource.com/vulkan-deps.git/+log/326dc2045cba..fb10489972ad

Changed dependencies:
* spirv-tools: 49deada730..272e4b3d07

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC enga@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: enga@google.com
Change-Id: I27fe734b22fc38a9fa303d1c5416dbb7eefed2b2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102148
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-13 16:06:41 +00:00
Dawn Autoroller c4945f49d9 Roll ANGLE from ae971cfe57bd to f39a9659c91a (4 revisions)
ae971cfe57..f39a9659c9

2022-09-13 jmadill@chromium.org Update flex/bison binaries.
2022-09-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 4258f175b8d9 to 8195c076a9c9 (5 revisions)
2022-09-13 lubosz.sarnecki@collabora.com gles1/FogTest: Add test that combines blending and fog.
2022-09-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 3c60121d064a to 4f2938b7d694 (507 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC enga@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: enga@google.com
Change-Id: If08d872efc9f5fe38e124c4ef49c70656fa2f500
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102147
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-09-13 14:45:23 +00:00
Dawn Autoroller a1f245cc0e Roll ANGLE from a25f92882e6d to ae971cfe57bd (9 revisions)
a25f92882e..ae971cfe57

2022-09-12 m.maiya@samsung.com Vulkan: Expose wide gamut and HDR EGL colorspace extensions
2022-09-12 patrto@microsoft.com Add Direct Composition offset to gl_FragCoord
2022-09-12 yuxinhu@google.com Add instructions to configure RenderDoc ShaderView
2022-09-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from e7211d52993a to 3c60121d064a (1898 revisions)
2022-09-12 cnorthrop@google.com Tests: Add Botworld Adventure trace
2022-09-12 kkinnunen@apple.com Rename include guards for angle_version_info.h, angle_version.h
2022-09-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 2d84fcfd2251 to 6dee9965e173 (8 revisions)
2022-09-12 cnorthrop@google.com Tests: Add Zombie Smasher trace
2022-09-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from b772fe545415 to 3811e73c4b6f (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC enga@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: enga@google.com
Change-Id: I8f6fddbdf72a954f72990bea8617c7b395a08dfb
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102141
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-09-13 01:25:01 +00:00
dawn-autoroll 4e5bb20e62 Roll vulkan-deps from 3811e73c4b6f to 326dc2045cba (6 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/3811e73c4b6f..326dc2045cba

Changed dependencies:
* glslang: df7fec2cfa..c0cf8ad876
* spirv-cross: 1e7e9fc32b..f6ca617825
* spirv-tools: fb27bbf307..49deada730
* vulkan-validation-layers: 825dd8a890..c53a4cb4e0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC enga@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: enga@google.com
Change-Id: I9b8013ebde6695863d6fa3f78dc75da83bed1e5c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102140
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-13 01:11:41 +00:00
Austin Eng c1f5112462 Remove code to set Vulkan backend debug labels
This is hitting a memory corruption issue inside the NVIDIA driver.
Speculatively delete the code in the Vulkan backend until further
analysis finds the root cause.

Bug: dawn:1539
Change-Id: Ie7bf5bed31976da5f13325c81033e787c4d376b9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102100
Reviewed-by: Loko Kung <lokokung@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-09-12 21:43:21 +00:00
Dawn Autoroller 54bee2372f Roll ANGLE from 09446a6bfdb8 to a25f92882e6d (1 revision)
09446a6bfd..a25f92882e

2022-09-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 27383fa99bbd to 4258f175b8d9 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC enga@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: enga@google.com
Change-Id: Ie696c10d3e05197e0bc6b97fb83fb03d4fca3f3c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102020
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-12 12:32:20 +00:00
dawn-autoroll 0d2010cce2 Roll vulkan-deps from 07d4d5d2e105 to 3811e73c4b6f (1 revision)
https://chromium.googlesource.com/vulkan-deps.git/+log/07d4d5d2e105..3811e73c4b6f

Changed dependencies:
* spirv-cross: 210a800130..1e7e9fc32b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC enga@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: enga@google.com
Change-Id: I717ee9eb64fd5894d0b8ad2237134300855b30c8
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102001
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-09-12 11:33:30 +00:00
Dawn Autoroller 0ea001703d Roll ANGLE from 6c469cdfb3d5 to 09446a6bfdb8 (1 revision)
6c469cdfb3..09446a6bfd

2022-09-09 geofflang@google.com Metal: Upload the last texture row separately on AMD.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC shrekshao@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: shrekshao@google.com
Change-Id: Ic98599bc64d5eb513f2eaddac645d0d67d4331a2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101921
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-10 11:21:19 +00:00
Jiawei Shao 1b02102e2b Declare nextInChain as ChainedStructOut when extensible is out
This patch changes the type of the structure member nextInChain in
AdapterProperties and SupportedLimits as "ChainedStructOut *" instead
of "ChainedStruct * const" as all members of these structures should
be writable when they are used as the outputs of Dawn APIs.

Bug: dawn:1516
Change-Id: I185a0b5846ac6009717ac722df67bf7170354947
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101802
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2022-09-10 01:38:59 +00:00
dawn-autoroll 278f071c68 Roll vulkan-deps from b772fe545415 to 07d4d5d2e105 (3 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/b772fe545415..07d4d5d2e105

Changed dependencies:
* glslang: 7757cbebe4..df7fec2cfa
* spirv-tools: f5b27b6513..fb27bbf307

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC shrekshao@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: shrekshao@google.com
Change-Id: Iaa7341bdb2b2db28cc39ab3831bc80691975b3fe
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101902
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-09 22:43:39 +00:00
Austin Eng ddc53ea856 Update expectations in preparation for removing --retry-limit=3
Ensure that all actually known flaky tests are marked RetryOnFailure.
Generated with some manual changes, then `./tools/run cts update`
pointing at the Chromium CL to disable retries.

Bug: chromium:1343969, chromium:1344876, chromium:1359106, dawn:1500
Change-Id: Ia92a83e55bd64f39ecd8ff1be194dca95febd9bb
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101801
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-09-09 22:37:19 +00:00
Dawn Autoroller 6a243de204 Roll ANGLE from 8fdfd8be4e54 to 6c469cdfb3d5 (4 revisions)
8fdfd8be4e..6c469cdfb3

2022-09-09 doremylover123@gmail.com Properly Create C++ string objects
2022-09-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 4e4d2b45391f to 27383fa99bbd (1 revision)
2022-09-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 6feded35cfee to b772fe545415 (6 revisions)
2022-09-09 gert.wollny@collabora.com Capture/Replay: Capture the attr locations as set by the program

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC shrekshao@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: shrekshao@google.com
Change-Id: If9d3bd05e350c2d36e281453f7e029acfa46787f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101881
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-09-09 22:22:59 +00:00
Brian Sheedy 3ada731606 Expand Mac Metal Intel suppression
Expands a couple of existing suppressions to also apply to Mac 12.5, as
the issue still occurs after the upgrade from Mac 12.4 to 12.5.

Bug: dawn:1462
Change-Id: Iba0041fd0f9deafeb3fb770867ffa2e2e4d12553
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101901
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@google.com>
Auto-Submit: Brian Sheedy <bsheedy@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-09-09 21:26:19 +00:00
Ben Clayton 4b70776aed tint: Fix transform errors when calling arrayLength() as a statement
Bug: chromium:1360925
Change-Id: If60fa4bb1cf4981c10dd15f8814c0aed70c0066e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101780
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-09 20:42:29 +00:00
Dawn Autoroller f313c48030 Roll SwiftShader from 27383fa99bbd to 6de56bda0d49 (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/27383fa99bbd..6de56bda0d49

2022-09-09 syoussefi@google.com Add helper to find an extended struct in pNext chain

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC shrekshao@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: shrekshao@google.com
Change-Id: I3292a9468f2094c066033431246f34a0377ef447
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101880
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-09-09 18:48:21 +00:00
dan sinclair 3526bc4f42 Remove GLSL override generation
This CL removes the override emission from the GLSL backend. The
override should be removed by the substitute_override transform
before making it to the backend.

Bug: tint:1155
Change-Id: Ic95413cfedaf417f54cab80aef413f745ccf3bfa
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101664
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
2022-09-09 16:55:58 +00:00
dan sinclair e1854b2d72 Remove SPIR-V override generation
This CL removes the override emission from the SPIR-V backend. The
override should be removed by the substitute_override transform
before making it to the backend.

Bug: tint:1155
Change-Id: Id00a58d497988908e15e3746ea05b57838acc8ba
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101740
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-09 16:18:48 +00:00
dan sinclair f6a9404978 Remove HLSL override generation
This CL removes the override emission from the HLSL backend. The
override should be removed by the substitute_override transform
before making it to the backend.

Bug: tint:1155
Change-Id: I6fecf47a5f5616a81281b179853e0f00ba31011f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101663
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-09 16:16:19 +00:00
Ben Clayton 1524d9e1bf Roll third_party/webgpu-cts/ 27dc745ca..a6451cc67 (19 commits)
Update:
 - expectations.txt
 - ts_sources.txt
 - resource_files.txt
 - webtest .html files


27dc745ca1..a6451cc673
 - a6451c Update 'buffer,usage' test in createBindGroup.spec.ts (#1824)
 - 0007e6 Add 'buffer,resource_offset' to createBindGroup.spec.ts (#1825)
 - a40f43 shader/execution: Fix shader creation errors (#1827)
 - 25c9f4 Add 'buffer,usage' test to createBindGroup.spec.ts (#1820)
 - 888ada slightly broaden/simplify pipeline_output_targets (#1823)
 - 708441 test ~all cases of pipeline_output_targets,blend (#1822)
 - 399cd2 Fix a wrong bit operation to decide the validation in indirect_dispatch_buffer,usage (#1819)
 - 73c9e8 Add storage_texture,mip_level_count test to createBindGroup.spec.ts (#1818)
 - 65fdb8 Minor clean up in life_of.md (#1608)
 - e53aff Add storage_texture,usage test to createVindGroup.spec.ts (#1813)
 - 39f597 Add `smoothstep` F32 Tests (#1811)
 - e97d14 Add tests to fullI32Range (#1792)
 - 7c4e02 Remove old implementation of correctlyRounded (#1796)
 - e93c41 Add 'multisampled_validation' test to createBindGroup.spec.ts (#1810)
 - cc7a40 Use trackForCleanup() for dst texture in copyToTexture cases (#1809)
 - 3c353f Adds remaining adapter.requestDevice tests. (#1798)
 - fd9cf4 Implement 'texture_buffer_usage' test to buffer_texture_copies.spec.ts (#1807)
 - f7f601 Add RENDER_ATTACHMENT usage when creating multisampled textures (#1806)
 - 63c716 Add 'texture_buffer_usage' test to buffer_texture_copies.spec.ts (#1803)

Created with './tools/run cts roll'

Change-Id: I608a519f30d75d18efd9edb6b1ece61e856ac2f5
Cq-Include-Trybots: luci.chromium.try:dawn-try-win10-x86-rel,linux-dawn-rel,mac-dawn-rel,win-dawn-rel
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101681
Auto-Submit: Ben Clayton <bclayton@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-09-09 16:14:19 +00:00
dan sinclair 5432767a04 Remove MSL override generation
This CL removes the override emission from the MSL backend. The
override should be removed by the substitute_override transform
before making it to the backend.

Bug: tint:1155
Change-Id: I9d3852a7e20b258a2f0af200bff6268037eaa0b5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101662
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
2022-09-09 16:14:10 +00:00
dan sinclair e214a130dd Run substitute_overrides for all tests.
This CL updates all of the integration tests to run the substitute_override
transform where needed. The test runner is updated to match comments in
the spvasm files as well as the wgsl files.

Bug: tint:1155
Change-Id: I8187d426970d056d744e530ed6447e4ec69db5f4
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101661
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-09 16:04:39 +00:00
dan sinclair 93df967003 Update StructMember{Offset,Size}Attribute to expressions.
This CL updates the StructMember Offset and Size attributes to
store expressions instead of uint32_t values.

Bug: tint:1633
Change-Id: I771b64fbd27a398ffbcb3f8cc2cbb7fa2606983e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101640
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-09 14:49:09 +00:00
dawn-autoroll f0209f58ea Roll vulkan-deps from c5b26b6fb63c to b772fe545415 (4 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/c5b26b6fb63c..b772fe545415

Changed dependencies:
* vulkan-loader: 23043a5c87..2f87e2b3a5
* vulkan-tools: d9f4641f90..f7dff1f7dd
* vulkan-validation-layers: 8982285117..825dd8a890

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC shrekshao@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: shrekshao@google.com
Change-Id: Iadf1bd9a47ff420e01c28792cbce14ad7f673fe6
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101803
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-09-09 09:21:27 +00:00
Dawn Autoroller 33bb4e4b26 Roll ANGLE from 6387f4118331 to 8fdfd8be4e54 (6 revisions)
6387f41183..8fdfd8be4e

2022-09-09 gman@chromium.org Update Dev docs to mention Chromium
2022-09-08 kkinnunen@apple.com Use base name of the generator script in various generated files
2022-09-08 srisser@google.com Avoid general python exceptions in retrace script
2022-09-08 geofflang@google.com GL: Ignore qualcomm errors about timestamps
2022-09-08 gman@chromium.org Move out of bounds buffer access tests under correct extension
2022-09-08 gman@chromium.org Fix UNSYNCHRONIZED glMapBufferRange test

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC shrekshao@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: shrekshao@google.com
Change-Id: I750ff800e0ea21f3dcee4ac2b2f0c5ea26a28fd0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101840
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-09-09 09:13:19 +00:00
shrekshao 14579b9da3 Add Overrides implementation for OpenGL/OpenGLES backend
As we are using SubstituteOverride, it is easy to add
overridable constants support for OpenGL/OpenGLES.

Also add validate workgroup size for null backend.

Bug: dawn:1537, dawn:1504
Change-Id: I293f10b9a6c606aee6c0ed25b1d966bc56a0b88d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101800
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Shrek Shao <shrekshao@google.com>
2022-09-09 00:49:08 +00:00
Brandon Jones 7edef20bdd Add AHardwareBuffer support
Initial pass at adding AHardwareBufferSupport so that Dawn can display
content on Android. Confirmed that this will allow many WebGPU pages to
render when paired with
https://chromium-review.googlesource.com/c/chromium/src/+/3877262

Bug: dawn:286
Change-Id: I627fa2ab71f85bd3cb7ea21b0588dbd2089cdf5f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101460
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-09-08 23:03:28 +00:00
Dawn Autoroller 0d7cd27fd3 Roll ANGLE from 11fd8346d6c2 to 6387f4118331 (5 revisions)
11fd8346d6..6387f41183

2022-09-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from f08773d25d83 to 2d84fcfd2251 (4 revisions)
2022-09-08 geofflang@google.com Vulkan: Don't store EGLSyncVk::mAttribs as a const ref.
2022-09-08 m.maiya@samsung.com Vulkan: Enable VK_EXT_swapchain_colorspace when supported
2022-09-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 7c6c7b79af8c to 4e4d2b45391f (6 revisions)
2022-09-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from c8b855ee4e1d to 6feded35cfee (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC shrekshao@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: shrekshao@google.com
Change-Id: I687fef644c00df6692762279f33b3cb668558fff
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101701
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-09-08 20:12:28 +00:00
dawn-autoroll 37718ecd2f Roll vulkan-deps from 66ed613293a9 to c5b26b6fb63c (3 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/66ed613293a9..c5b26b6fb63c

Changed dependencies:
* vulkan-headers: 9f4c61a314..88ebcb08cb
* vulkan-loader: 0a783b5d3e..23043a5c87
* vulkan-validation-layers: dd32ac341e..8982285117

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC shrekshao@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: shrekshao@google.com
Change-Id: I97601c9e5ad2152184c39ad038a5c37cad73ee3c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101665
Kokoro: Kokoro <noreply+kokoro@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-09-08 20:08:48 +00:00
Corentin Wallez aa93cb8d5a Suppress tests failing to due VVL error on depthStencilReadOnly
Bug: dawn:1512
Change-Id: Id0b281735604dbb226893d05879af5417e15a672
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/101120
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-09-08 17:23:46 +00:00