Instead use ast::TypeName.
Also improve the validation and diagnostics around providing template
arguments to types that do not accept them.
Bug: tint:1810
Change-Id: I4241d50ce0425ab721157686889e918993482876
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119284
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: James Price <jrprice@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@chromium.org>
This CL refactor the logic adapter creating device toggles set when
creating device and the way device holding its toggles. This CL also
introduce the concept "toggle stage", currently "device stage" only but
in future will add "instance stage" and "adapter stage" for instance and
adapter toggles. No changes on Dawn API.
More details:
1. Introduce `TogglesState` objects that represent the complete toggles
state of a device (and will used for instance and adapter in future).
2. When creating a device, adapter set up a TogglesState object for it
in `AdapterBase::CreateDeviceInternal` and
`Adapter::SetupBackendDeviceToggles`, no other place would change
the device's toggles state. This change simplify the logic.
3. Introduce the `ToggleStage` enum for every toggle and `TogglesState`
object. Currently we only have `Device` toggle stage, but in future
will have `Instance` and `Adapter` for instance and adapter toggles.
Bug: dawn:1495
Change-Id: Ifafac6a6a075b5b9a733159574ae5b6d4f3ebde9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/118030
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Zhaoming Jiang <zhaoming.jiang@intel.com>
Instead use ast::TypeName for all of these.
Bug: tint:1810
Change-Id: Ie51a69bf40648a9da73c0a1de2cd96a93d4eac76
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/117892
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@chromium.org>
Tint used to validate that type initializers and conversions were not
used as statements. The WGSL specification has been recently updated to
allow this, but Tint requires more work to correctly handle these as
statements.
For now, restore the validation.
Bug: tint:1836
Bug: chromium:1414489
Change-Id: I9f6aabece26c30b0a0d789ae0dfa10d6f43ee4dc
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119360
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@chromium.org>
Dawn was using a hard-coded constant for the Windows SDK version number
but that makes upgrading the Windows SDK to build Chromium impossible.
This change uses the newly created $windows_sdk_version to solve this
problem.
This new variable was added in crrev.com/c/4234366
Bug: tint:1719
Change-Id: I6a9f74f542d3517c046d74178a41e1e4d5887e7f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119340
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Roll build/ 6dc6eb47f..8cbb95464 (92 commits)
6dc6eb47fb..8cbb95464b
$ git log 6dc6eb47f..8cbb95464 --date=short --no-merges --format='%ad %ae %s'
2023-02-09 brucedawson Remove UCRT references
2023-02-09 brucedawson Remove old large_pdb code
2023-02-09 twellington Revert "Android: Update play core library"
2023-02-09 brucedawson Expose the current Windows SDK value
2023-02-09 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230209.1.1 to 11.20230209.2.1
2023-02-09 wnwen Android: Update play core library
2023-02-09 adetaylor [rust] Windows build fixes
2023-02-09 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230208.3.1 to 11.20230209.1.1
2023-02-09 sushraja Fix build/vs_toolchain.py when using SDK installed through VS2022
2023-02-09 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230208.2.1 to 11.20230208.3.1
2023-02-08 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230208.1.1 to 11.20230208.2.1
2023-02-08 chonggu [Fuchsia] Reenable circuit-switched overnet for ffx
2023-02-08 chonggu [Fuchsia] Remove unnecessaary code-coverage flag
2023-02-08 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230207.2.1 to 11.20230208.1.1
2023-02-08 adetaylor [rust] Re-enable custom toolchains
2023-02-08 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230207.1.1 to 11.20230207.2.1
2023-02-07 miguelfrde [fuchsia] Update ffx log --no-symbols to use --raw
2023-02-07 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230207.0.1 to 11.20230207.1.1
2023-02-07 danakj Pass ldflags to the Rust linker on Windows
2023-02-07 wnwen Android: Use //third_party/kotlin_stdlib
2023-02-07 sokcevic [codesearch] Fix java xref extraction
2023-02-07 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230202.3.1 to 11.20230207.0.1
2023-02-07 brucedawson Enable large pdbs by default
2023-02-06 zijiehe [Fuchsia] Include both arm64 and x64 toolchains in fuchsia_sizes
2023-02-06 hypan Remove emma_coverage_stats.py and emma_coverage_stats_tests.py
2023-02-06 agrieve Android: Do not enforce that all merged manifests have unique packages
2023-02-06 hypan Archive the logcat log for apk installation on android.
2023-02-06 hypan Add option "--emulator-debug-tags" to android test runners.
2023-02-06 huangs [Build] Update version.txt gen for high-end 64/32 ARM builds.
2023-02-06 danakj Support `gn analyze` in Rust crates which only specify the crate_root
2023-02-04 hypan Make sure system user is used for android gtest & instrumentation tests.
2023-02-04 brucedawson Update parse_and_expand_globlist for Windows
2023-02-03 grt [fuchsia] Remove context_provider.cmx
2023-02-03 hans Revert "Generate rudimentary Rust mojom bindings"
2023-02-03 hans [build] Suppress -Wdeprecated-this-capture warnings
2023-02-03 agrieve Android: Add versionCode to manifest expectation files
2023-02-03 collinbaker Generate rudimentary Rust mojom bindings
2023-02-03 vollick [ios] Generalize update_ios_bundle_data.py and add PRESUBMIT checks
2023-02-02 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230202.2.1 to 11.20230202.3.1
2023-02-02 agrieve Android: Fix androidx autoroller by adding requires_android=true
2023-02-02 agrieve Android: Rename lib.java intermediates for prebuilts
2023-02-02 benmason Add automotive version code
2023-02-02 sergeyu [Fuchsia] Implement FlatlandSurfaceCanvas
2023-02-02 agrieve Reland "Android: Set use appropriate android.jar for androidx_privacysandbox_ads_ads_adservices_java"
2023-02-02 jruthe [c++][fuchsia] Enable -gsimple-template-names for Fuchsia debug builds
2023-02-02 hypan Support logging emulator logs with pylib.base.output_manager.
2023-02-02 gbeaty Revert "Android: Set use appropriate android.jar for androidx_privacysandbox_ads_ads_adservices_java"
2023-02-02 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230202.0.1 to 11.20230202.2.1
2023-02-02 titouan Revert "Use PGO instead of AFDO for Lacros."
2023-02-02 agrieve Android: Stop merging chrome and base modules in expectation files
2023-02-02 agrieve Android: Set use appropriate android.jar for androidx_privacysandbox_ads_ads_adservices_java
2023-02-02 hidehiko Use PGO instead of AFDO for Lacros.
2023-02-02 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230201.2.1 to 11.20230202.0.1
2023-02-01 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230201.0.1 to 11.20230201.2.1
2023-02-01 smaier JNI: make JNI Multiplexing work (behind flag)
2023-02-01 dtapuska Add support for use_blink gn variable to conditionally compile blink.
2023-02-01 wnwen Android: Add kotlinc args
2023-02-01 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230131.2.1 to 11.20230201.0.1
2023-02-01 agrieve Android: Allow mergeable_android_manifests on apk and module targets
2023-02-01 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230131.1.1 to 11.20230131.2.1
2023-02-01 collinbaker Add Rust libstd GN bindings generated by gnrt
2023-01-31 wnwen Android: Support Kotlin files in size info files
2023-01-31 danakj Tie the rustc binary version into all rustc invocations
2023-01-31 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230131.0.1 to 11.20230131.1.1
2023-01-31 zhaoyangli Enable sending variant to result sink from test runners
2023-01-31 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230130.3.1 to 11.20230131.0.1
2023-01-31 justincohen Reland "Disable outlining with no-outline."
2023-01-31 richardwa Remote action wrapper should only import mojom code when necessary
2023-01-31 linxinan Initialize "configs" if use_large_pdb arg is true
2023-01-31 linxinan Enable large pdb for chrome_dll on arm64
2023-01-30 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230129.3.1 to 11.20230130.3.1
2023-01-30 adetaylor [rust] Add chrome://crash/rust
2023-01-30 danakj Remove rustc_can_link
2023-01-30 ddorwin [fuchsia] Remove unused TEST_REALM_NAME from test_runner
2023-01-30 ayzhao Do not define _LIBCPP_AVAILABILITY_CUSTOM_VERBOSE_ABORT_PROVIDED
2023-01-30 wnwen Android: Auto detect version in generate_gradle.py
2023-01-30 pkasting Switch Fuchsia to C++20 by default.
2023-01-30 johnidel Allow building against Tiramisu Preview SDK
2023-01-30 pkasting Switch CrOS device builds to C++20.
2023-01-30 luci-bisection Revert "Disable outlining with no-outline."
2023-01-30 justincohen Disable outlining with no-outline.
2023-01-30 haoyu.zhang [CrOS] Enable profile inference (Profi) for ChromeOS
2023-01-30 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230129.2.1 to 11.20230129.3.1
2023-01-29 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230129.1.1 to 11.20230129.2.1
2023-01-29 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230128.2.1 to 11.20230129.1.1
2023-01-29 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230128.1.1 to 11.20230128.2.1
2023-01-28 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230128.0.1 to 11.20230128.1.1
2023-01-28 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230127.3.1 to 11.20230128.0.1
2023-01-28 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230127.2.1 to 11.20230127.3.1
2023-01-27 chromium-internal-autoroll Roll Fuchsia Internal Images from 11.20230127.1.1 to 11.20230127.2.1
2023-01-27 wnwen Android: Explicitly set JAVA_HOME for kotlinc
2023-01-27 smaier Reland "JNI: Give each DFM its own registration file"
Roll buildtools/ 3c7e3f1b8..70e9f44cb (11 commits)
3c7e3f1b8b..70e9f44cbc
$ git log 3c7e3f1b8..70e9f44cb --date=short --no-merges --format='%ad %ae %s'
2023-02-09 chromium-autoroll Roll libc++ from 6569774a3313 to 035440c70772 (1 revision)
2023-02-08 chromium-autoroll Roll libc++ from 31cf778cc264 to 6569774a3313 (11 revisions)
2023-02-07 chromium-autoroll Roll libc++ from 549781a48cef to 31cf778cc264 (2 revisions)
2023-02-06 chromium-autoroll Roll libc++ from c8da880757e3 to 549781a48cef (2 revisions)
2023-02-04 chromium-autoroll Roll libc++ from 7a7a3a7a4cea to c8da880757e3 (4 revisions)
2023-02-03 chromium-autoroll Roll libc++ from bd44075f8521 to 7a7a3a7a4cea (2 revisions)
2023-02-02 chromium-autoroll Roll libc++ from 59bae40d835a to bd44075f8521 (9 revisions)
2023-01-31 chromium-autoroll Roll libc++ from b93c72898263 to 59bae40d835a (9 revisions)
2023-01-30 chromium-autoroll Roll libc++ from 1bdd3e2d8088 to b93c72898263 (2 revisions)
2023-01-30 ayzhao Do not define _LIBCPP_AVAILABILITY_CUSTOM_VERBOSE_ABORT_PROVIDED
2023-01-30 hans Roll libc++ 1127c78cf..1bdd3e2d8 and libcxxabi d520d582aa71..b74d7716111d
Roll buildtools/third_party/libc++/trunk/ bfaf65c48..035440c70 (47 commits)
bfaf65c48f..035440c707
$ git log bfaf65c48..035440c70 --date=short --no-merges --format='%ad %ae %s'
2023-02-06 ldionne.2 [libc++] Implement LWG3657 std::hash<filesystem::path>
2023-02-06 ldionne.2 [libc++] Implement P1328R1 constexpr std::type_info::operator==
2023-02-07 ldionne.2 [libc++][NFC] Use _LIBCPP_HIDE_FROM_ABI everywhere in pair
2023-02-07 ldionne.2 [libc++] Remove #error about _LIBCPP_DEBUG
2023-02-06 ldionne.2 [libc++] Use __builtin_FILE and __builtin_LINE in _LIBCPP_ASSERT
2023-02-07 ldionne.2 [libc++][NFC] Reformat __assert with clang-format
2023-02-06 koraq [libc++][format] Fixes constexpr validation.
2023-02-06 ldionne.2 [libc++][NFC] _VSTD -> std in ryu
2023-02-06 ldionne.2 [libc++] Add missing _LIBCPP_HIDE_FROM_ABI
2023-02-06 ldionne.2 [libc++] Fix path to versioned clang-format in the CI job
2023-02-06 ldionne.2 [libc++] Export CXX and CC env vars in format and documentation CI jobs
2023-02-06 ldionne.2 [libc++][NFC] Remove FP from_chars from the <charconv> synopsis since we don't implement it yet
2023-02-06 v.g.vassilev Don't re-export top-level modules
2023-01-31 koraq [libc++][CI] Uses LLVM 17 in Docker.
2023-02-02 nikolasklauser [libc++][NFC] Rename _LIBCPP_EXPLICIT_AFTER_CXX11 to _LIBCPP_EXPLICIT_SINCE_CXX14
2023-02-02 nikolasklauser [libc++][NFC] Rename _LIBCPP_NO_RTTI to _LIBCPP_HAS_NO_RTTI
2023-02-03 ldionne.2 [libc++] Remove leftover LIBCXX_ENABLE_CLANG_TIDY in run-buildbot
2023-02-02 ldionne.2 [libc++] Add a CI configuration to test Modules with LSV enabled
2023-02-02 varconst [libc++][format] Fix a missing include in tests.
2023-02-02 varconsteq [libc++] Make some tests in `math_nodiscard_extensions` Clang-only.
2023-01-25 tom [libc++] Remove use of internal glibc macros to determine if c8rtomb() and mbrtoc8() are present.
2023-02-01 nikolasklauser [libc++] Avoid ODR violations in __exception_guard
2023-01-31 nikolasklauser [libc++] Look for Clang 17 when compiling clang-tidy checks
2023-01-20 nikolasklauser [libc++] Forward ranges::sort to instantiations in the dylib
2023-01-20 nikolasklauser [libc++] Split ranges.transform.binary.pass.cpp up
2023-01-20 nikolasklauser [libc++] Remove explicit instantiations of __insertion_sort_incomplete and __sort5 from the dylib
2023-01-10 nikolasklauser [libc++] Add a clang-tidy check to make sure we use _Uglyfied attribute names
2023-02-01 nikolasklauser Revert "[libc++] Fix ODR violation with __exception_guard in mixed exceptions builds"
2023-02-01 alexfh [libc++] Fix ODR violation with __exception_guard in mixed exceptions builds
2023-01-31 varconst [libc++][ranges] Fix incorrect integer typedef in `elements_view` test.
2023-01-30 ldionne.2 [libc++] Use bounded iterators in std::string_view when the debug mode is enabled
2023-01-30 koraq [NFC][libc++] Addresses LWG3781.
2023-01-30 koraq [libc++] Addresses LWG3755.
2023-01-29 koraq [libc++] Marks LWG2970 as complete.
2023-01-21 koraq [libc++] Partly addresses LWG3798.
2023-01-21 koraq [libc++] Addresses LWG3764.
2023-01-29 koraq [NFC][libc++][format] Uses retarget buffer.
2023-01-27 koraq [libc++] Fixes the Clang modular build.
2021-09-23 yedeng.yd [libc++] Remove <experimental/coroutine>
2023-01-26 ldionne.2 [libc++] Add missing include promote.h in <cmath>
2023-01-11 nikolasklauser [libc++] Add [[clang::lifetimebound]] to min/max algorithms
2022-11-28 ldionne.2 [libc++] Don't assume that string_view::const_iterator is a raw pointer
2023-01-30 hans Revert "[ASan][libcxx] Annotating std::vector with all allocators"
2023-01-30 varconsteq [libc++][ranges] Temporarily mark `ranges::join_view` as experimental.
2023-01-30 varconst [libc++] Fix some missed `return 0` statements in test `main` functions.
2023-01-21 koraq [libc++] Addresses LWG3754
2023-01-27 koraq [libc++] Disables a test in clang-17.
Roll testing/ a9787cefa..d5ea1bf4b (155 commits)
a9787cefae..d5ea1bf4b6
$ git log a9787cefa..d5ea1bf4b --date=short --no-merges --format='%ad %ae %s'
2023-02-09 jonross Remove PercentDroppedFrames v1
2023-02-09 hypan Green device_unittests, gl_tests_validating on android 12l, 13
2023-02-09 kylechar Filter RGBA_F16 test in pie emulator
2023-02-09 kainino Revert "Enable WebGPU CTS on mac-code-coverage"
2023-02-09 gujen [LR] More Lightweight Reactions cleanup
2023-02-09 noahrose Add updater bots for Linux
2023-02-09 mastiz Add fieldtrial testing config for ScopedCriticalActionReuseEnabled
2023-02-09 wfh Extend timeout for zlib_unittests to 400s
2023-02-09 hypan Fix the trichrome tests on x64 without skip_secondary_abi_for_cq
2023-02-09 shuyng [RDSG] Update fieldtrial_testing_config
2023-02-08 hypan Green perfetto_unittests, crashpad_tests, base_unittests on android 12l,13
2023-02-08 koulvipul Code cleanup for the Save Card UI experiment.
2023-02-08 hypan Add filter for media_unittests on android 12l and 13 builders.
2023-02-08 ckitagawa [TabSelectionEditorV2] Enable bookmarks in fieldtrial config
2023-02-08 ftirelo [Managed prefs] Add highlight disclaimer expt to test config
2023-02-08 skylab-test-cros-roller [skylab_tests] Update skylab tests cros img version
2023-02-08 katie Disable more Select to Speak tests flaking in Lacros browsertests
2023-02-08 chonggu [Fuchsia] Remove unnecessaary code-coverage flag
2023-02-08 bpastene Move most/all fuchsia arm64 tests to the temporary LIFO swarming pool
2023-02-08 agrieve Delete chrome_modern_public_bundle target
2023-02-08 alessiob Fieldtrial testing config for `WebRTC-Audio-GainController2`
2023-02-08 eladalon Launch NewGetDisplayMediaPickerOrder
2023-02-08 zalmashni AboutThisSite: Add field trial for ImprovedBottomSheet experiment
2023-02-08 bozydar [reclient] Remove Linux CFI (reclient shadow)
2023-02-08 mlbipin Add school account to chromium field trial testing config
2023-02-08 kainino Enable WebGPU CTS on win10-code-coverage
2023-02-08 kainino Enable WebGPU CTS on mac-code-coverage
2023-02-08 agrieve Remove references to now removed internal target "chrome_modern_bundle"
2023-02-08 brucedawson Fix \ != / presubmit failures on Windows
2023-02-08 jeffyoon Remove iOS tests from skipped GN targets in manage.py
2023-02-08 jiesheng Fix mac wpt runner result json
2023-02-08 jakubm hiberman: Add CrOSLateBootSuspendToHibernate
2023-02-08 nickdiego ozone: return null in CreateKeyboardHook default impl
2023-02-08 tinazwang [P13n] Add field trial to IOSFeedBottomSyncPromo exp
2023-02-08 jiesheng Add ios build dependency to WPT ios bot.
2023-02-07 shuyng [RDSD] Launch subdomain settings on ToT
2023-02-07 yueshe target T2 machines for tests running on SIM_IPAD_PRO_3RD_GEN_16_2 on ios-simulator-noncq
2023-02-07 kuanhuang Move win-asan to use default win10 mixin and add more shards.
2023-02-07 mfoltz [Media Router] Fix target for end-to-end tests.
2023-02-07 wangxianzhu Add ScrollOverlapOptimization flag to WebView
2023-02-07 chonggu [Fuchsia] Remove cfv2 fyi builders
2023-02-07 andysjlim Create fieldtrial for client side phishing desktop model 30.0
2023-02-07 wenyufu [EngagementSignals][CCTBrand] Enable features by default
2023-02-07 edchin [ios] Add fieldtrial config for Feed Image Caching
2023-02-07 djmitche Remove support for triple-keyed NAKs.
2023-02-07 victorvianna Add fieldtrial testing config for IOSShowPasswordStorageInSaveInfobar
2023-02-07 tsergeant Link Capturing: Remove field trial config
2023-02-07 skylab-test-cros-roller [skylab_tests] Update skylab tests cros img version
2023-02-07 chonggu [Fuchsia] Migrate coverage bot to v2 scripts
2023-02-07 alvinjia increase timeout for chromeos-eve-chrome
(...)
2023-02-01 ckitagawa Delete DiscardOccludedBitmaps Flag
2023-02-01 fleimgruber Enable AutofillComplementCountryEarly by default.
2023-02-01 vasilii Change std::size_t to size_t in fuzzer_support.mm.
2023-02-01 skylab-test-cros-roller [skylab_tests] Update skylab tests cros img version
2023-02-01 eduardoyap Increase shards of lacros-x86-perf from 6 to 10.
2023-01-31 sky field-trial: updates params for ProcessHtmlDataImmediately
2023-01-31 travislane Add DriveFsChromeNetworking to fieldtrial config
2023-01-31 danakj Exclude gn analyze when rolling the Rust toolchain
2023-01-31 svenzheng Disable some browser tests on lacros asan
2023-01-31 srinivashegde Check if sourcemaps are valid
2023-01-31 rkgibson Fix fieldtrial entry for IOSNewOverflowMenuIPH study
2023-01-31 joemerramos [iOS] Changing fieldtrial study name
2023-01-31 benreich [js-code-coverage] Remove unnecessary steps and use correct lcov command
2023-01-31 josiahk language_packs: Add fieldtrial testing config for LanguagePacksTts
2023-01-31 thegreenfrog [ios] Remove ContentSuggestionsUIModuleRefresh enabled from tests
2023-01-31 ynovikov Enable Metal debug layers on ANGLE bots
2023-01-31 jam Update name of preconnect experiment in field trial testing config.
2023-01-31 curranmax Add fieldtrial_testing_config entry for DesktopPrefetchUseContentRefactor.
2023-01-31 sunxiaodi Create high end Android builder config and map shards for Pixel6
2023-01-31 skylab-test-cros-roller [skylab_tests] Update skylab tests cros img version
2023-01-31 jyammine [fyfre]Add pixel tests to profile picker main view
2023-01-31 robertlin Prerender: Update field trial config for OmniboxPrerender
2023-01-31 yawano Update config of GalleryAppPdfEditNotification
2023-01-30 manukh [omnibox][doc] Add fieldtrial_testing_config entry for MaxLowQuality.
2023-01-30 freedjm Add fieldtrial_testing_config entry for DiscoFeedEndpoint.
2023-01-30 danakj Remove rustc_can_link
2023-01-30 jam Fix slowdown in simple-url.html and url-parser.html perf tests.
2023-01-30 dgn [fyfre] Clean up synthetic study setup in welcome code
2023-01-30 yaoxia [Topics] Enable BrowsingTopicsXHR in fieldtrial_testing_config.json
2023-01-30 mmenke Migrate all Value::Append() calls in /testing/perf
2023-01-30 dizhangg Add UMA experiment config for feature KeyboardFocusableScrollers
2023-01-30 elkurin TooltipLacros: Remove tooltip tests from exceptions for Lacros
2023-01-30 thomasanderson Reland "Reland "Upgrade WebKit Linux MSAN to Focal""
2023-01-30 rmhasan Finch: Run commands for disabling or enabling airplane mode on devices in the Android test suite
2023-01-30 skylab-test-cros-roller [skylab_tests] Update skylab tests cros img version
2023-01-30 hiroh fieldtrial_testing_config.json: Add WebRtcEncoderAsyncEncode
2023-01-30 arabm Enable Incognito Download Warning in TOT
2023-01-29 skylab-test-cros-roller [skylab_tests] Update skylab tests cros img version
2023-01-28 rockot cc: Experimental age-based decode cache limits
2023-01-28 skylab-test-cros-roller [skylab_tests] Update skylab tests cros img version
2023-01-28 avi Remove base::Value::Type::DICTIONARY
2023-01-28 rockot cc: Experimental size cap for image decode cache
2023-01-27 peilinwang [Cleaup] Remove IsVoiceSearchEnabledCache experiment code
2023-01-27 bryantchandler Reland "[fuchsia] Cut out runtime data bloat from Chrome tests."
2023-01-27 nihardamar add mac13 x86 + arm bot
2023-01-27 kyleshima Add ChromeOS Finch smoke test builder configs
2023-01-27 olivierli Add ios to fieldtrial config for UseSimplifiedMessagePumpKqueueLoop
2023-01-27 stkhapugin Add Omnibox Most Visited Tiles On Srp flag on iOS
2023-01-27 rostedt Field trial testing config for SchedUtilHints
2023-01-27 sprang Add testing config for WebRTC-SendBufferSizeBytes
Roll third_party/catapult/ 35952dc54..37e879a7d (52 commits)
https://chromium.googlesource.com/catapult.git/+log/35952dc547f2..37e879a7d13c
$ git log 35952dc54..37e879a7d --date=short --no-merges --format='%ad %ae %s'
2023-02-08 paulirish Traceviewer: keep process header sticky-visible
2023-01-31 renewitt Fixing filename for Oboe license file in README.chromium.
2023-02-07 agrieve Make "android-chromium-bundle" point to monochrome rather than chrome_modern
2023-02-06 hypan Fix the unhashable error in provision_devices
2023-02-07 bsheedy Add stack summaries
2023-02-07 sunxiaodi [chromeperf] Move Pinpoint version forward
2023-02-01 cbruni [chrome_inspector] Increase CollectChromeTracingData timeout
2023-02-06 nikolaos [chromeperf] Replace lorempixel with loremflickr
2023-02-06 hypan Add the arg emulator_debug_tags to browser_options
2023-02-06 hypan Implement GetCurrentUser for Android versions < Nougat.
2023-02-03 sunxiaodi [Chrome Health] average Speedometer2 metrics with multiple values
2023-02-04 funing [Pinpoint UI] Allow user to use chromium commit position to choose base/exp build
2023-02-03 bsheedy Revert "Change non-root profile dir"
2023-02-02 hypan Devil: Add two user-related methods to device_utils.
2023-02-03 hypan Support the Issuetracker bug format "b:NNNN" in the commit message.
2023-02-03 rmhasan Devil: Refactor the GetApplicationVersion method
2023-02-03 sunxiaodi [chromeperf] Move versions forward
2023-02-03 cbruni [chrome_inspetor] Add more details to TracingTimeoutException
2023-02-03 sunxiaodi [Pinpoint] Ensure batch ID is always empty when restarting job
2023-02-02 sunxiaodi Mapping Pixel 6 isolates to Pinpoint UI
2023-02-02 johnchen Add expectations tags for Pixel 6 and 6 Pro
2023-02-02 wenbinzhang [chromeperf] misc clean up
2023-02-01 bsheedy Change non-root profile dir
2023-02-01 cbruni [chrome-inspector] Add more details TracingTimeoutException
2023-02-02 funing Update TokenRequiredFlask
2023-02-01 funing Replace six.assertCountEqual with self.assertCountEqual
2023-02-02 funing Update some of the flask suffixed functions
2023-02-01 sunxiaodi Add Android high end builder to pinpoint isolate map for Pixel6
2023-02-01 funing Removing isRunningFlask
2023-02-01 rmhasan Devil: Add method to get the webview provider to DeviceUtils
2023-02-01 funing More removal of six.py
2023-02-01 eduardoyap Add unit tests for email_template.
2023-01-31 wenbinzhang [chromeperf] fix cloud build failure
2023-01-31 funing Remove sys.version_info related py2 code
2023-02-01 ashwinpv Fix UT that's failing in cloud build
2023-01-31 rohpavone Revert "[remote-linux] changes"
2023-01-31 ashwinpv [chromeperf]: Post ADC service account migration cleanup
2023-01-31 eduardoyap Ensure group report link is a properly formatted string.
2023-01-31 ashwinpv Update prod versions for default,pinpoint and api services
2023-01-31 ashwinpv Revert "Set adc=False for issue_tracker clients"
2023-01-31 funing Remove deploy(py2) and rename deploy-py3
2023-01-30 wenbinzhang [chromeperf] fix job tests under pinpoint
2023-01-30 funing Remove some skipped tests, also mark crbug for some to be updated
2023-01-30 ashwinpv Set adc=False for issue_tracker clients
2023-01-30 funing Remove py2 build conf
2023-01-27 pasko flag_changer: Fix documentation to mention existing method
2023-01-28 funing Remove six.py2 in dashboard
2023-01-26 funing [Pinpoint UI] More instructions on extra args, especially for --enalbe-features
2023-01-27 bpastene devil: Drop presubmit coverage of py2 unittests
2023-01-27 wenbinzhang [chromeperf] More pylint cleanup under catapult
2023-01-27 sunxiaodi fix testPost_LongSupplementalAnnotation
2023-01-26 wenbinzhang [chromeperf] remove usages of flask_flag
Roll third_party/googletest/ b72202078..b73f27fd1 (16 commits)
b72202078d..b73f27fd16
$ git log b72202078..b73f27fd1 --date=short --no-merges --format='%ad %ae %s'
2023-02-08 tomhughes Fix _MSC_VER check
2023-02-07 tomhughes Remove GTEST_USES_PCRE references
2023-02-07 mvels Fix GTEST_HAS_ABSL define check for [-Werror=undef] compilations
2023-02-06 absl-team Add support for the alternative base64 encoding in RFC 4648 section 5 to `WhenBase64Unescaped`.
2023-02-02 tomhughes Fix compiler flags in Linux presubmit
2023-02-02 tomhughes Fix -Wsign-conversion warnings
2023-02-02 tomhughes Remove unneccessary "#if _MSC_VER"
2023-02-02 absl-team Add a trailing decimal point to FormatTimeInMillisAsSeconds() output when input is an exact N seconds.
2023-02-01 tomhughes Fix include order
2023-02-01 tomhughes Remove GMOCK_RENAME_MAIN
2023-02-01 tomhughes Build gmock Python tests when building with cmake
2023-02-01 tomhughes Fix gmock_output_test when using MSVC
2023-01-31 tomhughes Fix sign conversion warning from clang:
2023-01-30 tomhughes Use GTEST_DISABLE_MSC_WARNINGS macros to disable warnings
2023-01-30 tomhughes Use explicit short to fix MSVC compiler warning
2023-01-04 SunBlack Fix typos found by codespell
Roll tools/clang/ c272f2cdc..fff7f04d3 (7 commits)
c272f2cdc1..fff7f04d30
$ git log c272f2cdc..fff7f04d3 --date=short --no-merges --format='%ad %ae %s'
2023-02-09 danakj Pull OpenSSL pre-built libraries from 3pp for the Rust toolchain
2023-02-09 bartekn Use vpython3 in extract_edits.py
2023-02-08 vollick Use vpython3 in run_tool.py and apply_edits.py
2023-02-07 paulsemel devtools: lookup for record definitions to avoid handling declaration
2023-02-06 danakj Find the stage0 hash from build_rust.py
2023-01-31 hans Clang build.py: Add third_party/ninja/ to PATH on Windows
2023-01-30 hans [Clang] Switch from llvm::Optional to std::optional
Created with:
roll-dep build buildtools buildtools/third_party/libc++/trunk buildtools/third_party/libc++abi/trunk testing third_party/catapult third_party/googletest tools/clang
Change-Id: Iedcb7e81fc3f370f1aa5593a0deb9a20c5130c40
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119341
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
The default behaviour is a 1 minute timeout, which depending on
network load and other factors, may not be enough time to clone the
CTS repo when running the tool.
Increasing the timeout for this step to 10 minutes, since the tool is
expected to take a significant amount of time to run, so a bit of
extra time on setup isn't noticable.
Change-Id: If51ed154a8b2373bb9b246f29467fb17c7d7e345
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119300
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Change Resolver::Expression() and Resolver::Identifier() to return a
sem::Expression instead of a sem::ValueExpression.
This is required as IdentifierExpressions may resolve to non-values.
Handle expressions that resolve to types, when they are expected to
resolve to a value.
Bug: tint:1810
Change-Id: I1cb069e3e736fc85af7bc395b388abe153b1f65a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/118500
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Take advantage of the fact that all AST nodes now use an
`ast::Identifier` instead of directly using Symbols.
This will be important for ensuring that un-keyworded identifiers will
be preserved.
Bug: tint:1810
Change-Id: If5c3e9f00b4c1c14a6f11bd617bd8b895250fb7e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119285
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@chromium.org>
A bunch of template magic to recursively test that an identifier (and
template arguments) matches the given values. Will be heavily used for
AST and parser tests.
Bug: tint:1810
Change-Id: I8d83090352c345f0ce1ac7840e163eea96eac8a2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119124
Commit-Queue: Ben Clayton <bclayton@chromium.org>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
The goal here is to have all AST nodes use an identifier instead of
symbols directly. This will greatly simplify the renamer transform,
and gives the symbol a Source location, which is helpful for
diagnostics and tooling.
Change-Id: I8b3e05d05886c6caa16513a5cfb45d30f7a8d720
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119283
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Ben Clayton <bclayton@google.com>
Variable::name is an ast::Identifier.
The goal here is to have all AST nodes use an identifier instead of
symbols directly. This will greatly simplify the renamer transform,
and gives the symbol a Source location, which is helpful for
diagnostics and tooling.
Change-Id: I71fe3e8df3d22b12d4a3430c41f236ddf5bc0b9e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119282
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
StructMember::name is an ast::Identifier.
The goal here is to have all AST nodes use an identifier instead of
symbols directly. This will greatly simplify the renamer transform,
and gives the symbol a Source location, which is helpful for
diagnostics and tooling.
Change-Id: I1156653a48b02997ec0a9077b174401f65a13457
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119281
Kokoro: Ben Clayton <bclayton@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Function::name is an ast::Identifier.
The goal here is to have all AST nodes use an identifier instead of
symbols directly. This will greatly simplify the renamer transform,
and gives the symbol a Source location, which is helpful for
diagnostics and tooling.
Change-Id: I723a9a104668758db2cb32051efa1f6d3c105913
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119280
Reviewed-by: James Price <jrprice@google.com>
Kokoro: Ben Clayton <bclayton@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Add scaffolding for structured Dawn wire fuzzer.
This CL contains a basic fuzzer for Dawn wire server
that shows some simple design ideas:
1) A basic protobuf spec that is generated using dawn.json
2) conversion from protobuf message to a dawn wire server
command.
This is not the complete implementation and serves as a
foundation for the fuzzer so that subsequent CLs will be
easier to review.
Bug: chromium:1374747
Change-Id: Ife1642dda13d01d3308bdd5fe56cf85978399fd3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/109406
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Brendon Tiszka <tiszka@chromium.org>
GPUPipelineError differentiates between validation and internal errors,
so update the async pipeline creation status accordingly. The "error"
enum value is kept temporarily while Chromium is updated.
Bug: chromium:1404422
Change-Id: Iac8174a9a3d15068caa5dcf815123c5b2b99fe5f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119240
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Add ResolvedIdentifier to hold the resolved AST node, sem::BuiltinType
or type::Builtin.
Reduces duplicate builtin symbol lookups in Resolver.
Bug: tint:1810
Change-Id: Idde2b5f6fa22804b5019adc14c717bebd8342475
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119041
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Instead of having the stride be yet another integer argument, make the
stride explicit by adding an attribute list parameter. This is more
consistent with other nodes.
Bug: tint:1810
Change-Id: I916d810f29afd172b878ded48b6701e8b299b13f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119040
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@chromium.org>
perf_test_runner.py doesn't run properly after recent python migration.
Fix by decoding output (bytes) to string using utf-8 and then re.serach
the string.
Bug: None
Change-Id: Id988d0f5161d0c9edc827a48a3a30f8e60f8f814
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/119080
Reviewed-by: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Shrek Shao <shrekshao@google.com>
- Removes remaining usages of the values in Dawn and removes tests.
- Note that the values will be removed from the JSON entirely in
follow up CL after Chromium side changes.
Change-Id: I30ccb3c412cd97047065ad515f6a5ff4de642420
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/117593
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Loko Kung <lokokung@google.com>
This belongs on Block(), not Func().
Also make Func() smarter about the `body` argument, allowing the caller
to pass an ast::BlockStatement*, ast::Statement* or nullptr.
Change-Id: I8ac6c1598b37f2a94615b452c5eb37671b4305fa
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/118982
Reviewed-by: James Price <jrprice@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
WGSL does not have a void type. Functions that do not return a value
simply omit the return type from the function signature.
Change-Id: Id45adc008dce46115552e7dc401a2e27ae10eeb4
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/118981
Reviewed-by: James Price <jrprice@google.com>
Kokoro: Ben Clayton <bclayton@google.com>
Once all ast::Type derived classes are removed, there will be no
distinction between a type initializer / conversion and a function call.
Bug: tint:1810
Change-Id: Ic10fd1a0364a564d24dbe2499af0f1424641596c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/118980
Auto-Submit: Ben Clayton <bclayton@google.com>
Reviewed-by: James Price <jrprice@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@chromium.org>
This patch adds a workaround on Intel Gen9.5 and Gen11 GPUs to always
allocate renderable 2D textures as committed resources instead of
placed resources to mitigate a driver bug about CreatePlacedResource().
Bug: dawn:1628
Change-Id: I38062115d94933bd58e571c812ff6888e9781df6
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/100640
Commit-Queue: Austin Eng <enga@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
These will include the builtin language types.
Bug: tint:1810
Change-Id: I695a9ee833e1035eb1d17913d709038ae4c561d8
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/118502
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
Ben Clayton
Corentin Wallez
Antonio Maiorano
Peng Huang
dawn-autoroll
Zhaoming Jiang
Bruce Dawson
Kai Ninomiya
Ryan Harrison
Yunchao He
Brendon Tiszka
shrekshao
Loko Kung
James Price
Jiawei Shao