Commit Graph

8566 Commits

Author SHA1 Message Date
Austin Eng 7a8006033a Add additional guards in counter set feature checks
- Don't use for..in since some crashes show that NSFastEnumeration
   in those loops is doing something wrong.
 - Check that the receiver actually supports the selector before
   calling it. Crashes indicate an unrecognized selector is being
   used.
 - Add a ref to MTLCounterSet to be sure it is not somehow freed
   between when it is stored, and when we use it as the receiver for
   [MTLCounterSet counters].

Bug: dawn:1102
Change-Id: I882045ba09547df62a98a862e6e64c5a7d656e80
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/80461
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
2022-02-15 18:18:26 +00:00
Stephen White 5f6a185d02 GLSL: implement textureNumLayers(), and update expectations.
Bug: tint:1426
Change-Id: I609a34be458c14deef866ab66d7b57b8ee6316f2
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/80580
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2022-02-15 17:58:07 +00:00
Stephen White ee38740991 GLSL: implement bitwise & and | on boolean types.
Bug: tint:1427
Change-Id: Ide2b89ac5f61237d0d39c1210dadaf9587c5db97
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/80360
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Stephen White <senorblanco@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2022-02-15 17:52:37 +00:00
Antonio Maiorano ce982d8a06 HoistToDeclBefore: hoist to reference if expression is a reference type
Don't lose reference-ness of expression. This is necessary for
assignments via the hoisted variable, for example.

Bug: tint:1300
Change-Id: I8e633f20e50541bb70becc5069019f795ec11e01
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/80540
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2022-02-15 17:04:47 +00:00
James Price d0ec88ce61 Add support for override keyword and @id attribute
This replaces the @override keyword that was previously used for
pipeline-overridable constants.

Support for pipeline-overridable constants in Dawn is hidden behind
the "disallow-unsafe-APIs" toggle, so we can make this change directly
instead of deprecating and continuing to support the old syntax.

Fixed: tint:1403
Change-Id: I9b2957a1e33b12772bfe449c0f3a31d929f8aa8b
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/80480
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: James Price <jrprice@google.com>
2022-02-15 16:36:57 +00:00
Dawn Autoroller cfbd1baf2e Roll SwiftShader from a7f412ebb116 to 0863290dc7f6 (6 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/a7f412ebb116..0863290dc7f6

2022-02-10 sugoi@google.com Add partial support of VK_EXT_extended_dynamic_state2
2022-02-10 sugoi@google.com Support VK_EXT_texel_buffer_alignment promoted features
2022-02-10 capn@google.com Fix shuffling of vectors with a different size mask
2022-02-10 sugoi@google.com VK_EXT_extended_dynamic_state support
2022-02-10 capn@google.com Remove unused sin/cos approximations
2022-02-10 capn@google.com Optimize SPIR-V sin and cos operations

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: amaiorano@google.com
Change-Id: I308c7a33be1869ad4550d1c3bb22458304bf413b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/80180
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
2022-02-15 16:23:56 +00:00
Ben Clayton 5f60eb72c0 docs: Add GLSL backend to arch.md
Change-Id: Ifef0b3bb449de2bffc5bc3b84886d4f678971620
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/80521
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Stephen White <senorblanco@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-02-15 14:02:47 +00:00
Dawn Autoroller b10100696e Roll ANGLE from a0bc9dab4eef to ad4fae642fe8 (3 revisions)
a0bc9dab4e..ad4fae642f

2022-02-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from c9825531290b to d984ec3b132a (580 revisions)
2022-02-15 yuxinhu@google.com Debug Overlay Demo
2022-02-14 cclao@google.com Vulkan: Switch XFB counter buffer to suballocation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: kainino@google.com
Change-Id: I4641642fab7464c3995ccbbc05d3bf0ce7e4a14b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/80542
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-15 12:56:08 +00:00
Li Hao 3a60f96079 Reset root descriptor table for samplers when descriptor heaps are changed
When shader-visible heap switch happens, we re-populate all bindgroups
and change the descriptor heaps, which need to reset root descriptor
tables, but for the samplers which are cached in
mBoundRootSamplerTables and not changed, they won't be reset, which make
shaders cannot access the sampler heaps.

Bug: dawn:1255

Change-Id: Icc142206121af9daf8b9352b4c639f7d7ef8f1d3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/76780
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Hao Li <hao.x.li@intel.com>
2022-02-15 02:05:06 +00:00
Dawn Autoroller 058334829b Roll ANGLE from c6f5a5bbe6cf to a0bc9dab4eef (6 revisions)
c6f5a5bbe6..a0bc9dab4e

2022-02-14 cclao@google.com Vulkan: Switch stencilBlitResolveNoShaderExport to suballocation
2022-02-14 andrew-naumov@yandex-team.ru Unicode support for system_utils on Windows
2022-02-14 cnorthrop@google.com Tests: Add MARVEL Strike Force trace
2022-02-14 syoussefi@chromium.org Vulkan: Enable overlay by default with debug layers
2022-02-14 m.maiya@samsung.com Vulkan: Enable subgroup feature in GenerateMipmap.comp
2022-02-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 071bfca11aa9 to 2d1377ec02b5 (11 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: kainino@google.com
Change-Id: I9c8a19275598d789f0582a21f7a798d558c1255d
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/80561
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-14 23:42:06 +00:00
Dawn Autoroller d726fa4cfa Roll Tint from f95f11417e to f1d570a11e (1 revision)
https://dawn.googlesource.com/tint.git/+log/f95f11417eb2..f1d570a11eba

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-dawn
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: kainino@google.com
Change-Id: Id9545099921368ee0bb564e12067f9053fccf78e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/80560
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-14 23:12:35 +00:00
Ben Clayton f1d570a11e docs: document that OOO-decls is now supported
Fixed: tint:1266
Change-Id: Ib78038bdf63dfeae6c2e328213560c37df41eb81
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/80520
Auto-Submit: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: James Price <jrprice@google.com>
Commit-Queue: James Price <jrprice@google.com>
2022-02-14 21:56:06 +00:00
Brandon Jones fe994f74ff More verbose BindGroupLayout error messages
Begins including the expected BindGroupLayout in validation messages
where a BindGroup descriptor does not match the BindGroupLayout. This
is especially helpful in cases where the BindGroupLayout was implicitly
created by the pipeline.

Bug: dawn:1258
Change-Id: Icbf27b4a2ac9b4dc1716feed47e3e63cf99929a7
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/80380
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
2022-02-14 19:06:55 +00:00
dawn-autoroll 958d82d015 Roll vulkan-deps from f868b4437065 to 6b02308bdccf (77 revisions)
https://chromium.googlesource.com/vulkan-deps.git/+log/f868b4437065..6b02308bdccf

Changed dependencies:
* glslang: c34bb3b6c5..90d4bd05cd
* spirv-cross: 53d94a982e..131278458e
* spirv-headers: b42ba6d92f..6a55fade62
* spirv-tools: a73e724359..471428a04f
* vulkan-headers: 1dace16d80..b32da5329b
* vulkan-loader: 8aad559a09..0a7407b151
* vulkan-tools: b69bea3446..5f9e5f14e5
* vulkan-validation-layers: ed00aa4b67..9a307c998f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC kainino@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: kainino@google.com
Change-Id: I4a8672d1547cbbe1231070bb5cef1f64c74bb4a8
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/80440
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-14 17:55:15 +00:00
Dawn Autoroller b78f21f098 Roll Tint from 6f9ac3524a to f95f11417e (1 revision)
https://dawn.googlesource.com/tint.git/+log/6f9ac3524a0f..f95f11417eb2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-dawn
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: amaiorano@google.com
Change-Id: Ia43ad696fc276f2b46965448526b7661c94b98ae
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/80420
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-14 11:29:05 +00:00
Dawn Autoroller b65d7b8c84 Roll ANGLE from 06edae72ba69 to c6f5a5bbe6cf (1 revision)
06edae72ba..c6f5a5bbe6

2022-02-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from c0b2804cbd93 to c9825531290b (658 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: amaiorano@google.com
Change-Id: Ic2bc8ee62f3c8bc7d7d1cfcd1ef230c9a99387f1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/80400
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-14 10:18:30 +00:00
Ben Clayton f95f11417e resolver: Use Switch() for type-dispatch
Bug: tint:1383
Change-Id: I9efbe6b3e7c0314a76f65b5e8969f1f20bcecf93
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79771
Reviewed-by: David Neto <dneto@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: Ben Clayton <bclayton@chromium.org>
2022-02-14 10:05:16 +00:00
Dawn Autoroller 3b88de5201 Roll ANGLE from 9b7a77b08d8a to 06edae72ba69 (3 revisions)
9b7a77b08d..06edae72ba

2022-02-12 b.schade@samsung.com Vulkan: Allow duplicated block name in different shader interface
2022-02-11 cnorthrop@google.com FrameCapture: Remove destroyed contexts from share group
2022-02-11 cclao@google.com Vulkan: Fix two bugs exposed by moving mEmptyBuffer to suballocation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: amaiorano@google.com
Change-Id: I3327f654bb01f39f1f189eaf2f9d8936725aa88a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/80342
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-12 11:00:42 +00:00
Dawn Autoroller e83267c11e Roll ANGLE from d5df233189ca to 9b7a77b08d8a (10 revisions)
d5df233189..9b7a77b08d

2022-02-11 jmadill@chromium.org Double batch timeout for sanitizer tests.
2022-02-11 lexa.knyazev@gmail.com Keep ANGLE_base_vertex_base_instance available for ES 2.0
2022-02-11 syoussefi@chromium.org Vulkan: Use VK_EXT_depth_clip_control
2022-02-11 constantine.shablya@collabora.com Add entry points for EGL_KHR_partial_update
2022-02-11 cnorthrop@google.com Traces: Add restricted_trace_perf.py script for Android
2022-02-11 lexa.knyazev@gmail.com GL: Remove avoid_dxt1_srgb_texture_format feature
2022-02-11 hckim.kim@samsung.com Rebind program on glUseProgramStages
2022-02-11 cheryl.wei@arm.com Vulkan: Add an end2end test
2022-02-11 lubosz.sarnecki@collabora.com GetImageTest: Enable on Vulkan SwiftShader.
2022-02-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from bf99b2cc0f6b to c0b2804cbd93 (526 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: amaiorano@google.com
Change-Id: Icde557d99ef1cea5a0a1a2008647368be60c294f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/80341
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-11 21:47:30 +00:00
Dawn Autoroller fe8682c919 Roll Tint from 73e7988694 to 6f9ac3524a (2 revisions)
https://dawn.googlesource.com/tint.git/+log/73e79886943c..6f9ac3524a0f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-dawn
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: amaiorano@google.com
Change-Id: Id2ece902458b2ba9ce9c20843233b69db3734c00
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/80340
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-11 19:46:22 +00:00
Stephen White 6f9ac3524a GLSL: fix isNormal.
(I know it's deprecated, I'm just being a completist.)

Bug: tint:1222
Change-Id: Ie7716d2f5dd2d2bd2245ba2b0fe7ed8705574de0
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/80141
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2022-02-11 14:35:14 +00:00
Dawn Autoroller ea5ad06289 Roll Tint from 98facb28ab to 73e7988694 (2 revisions)
https://dawn.googlesource.com/tint.git/+log/98facb28abc8..73e79886943c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-dawn
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: amaiorano@google.com
Change-Id: I778fab44614b4cbee0580023e600f0df6cd2211c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/80280
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-11 14:23:01 +00:00
Stephen White 723f999ac2 GLSL: fix frexp and modf builtins.
These still had vestiges of HLSL.

Bug: tint:1222
Change-Id: I5f93f75e7384db641f0c5421dca24a3e8f2b716e
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/80140
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2022-02-11 13:41:23 +00:00
Ben Clayton 73e7988694 fuzzers: Shuffle module scope declarations
For the tint_all_transforms_fuzzer. Exercises the fact we now allow
declarations in any order.

Bug: tint:1266
Change-Id: I9ddfac90aaafe213cd860944f210718216cb3d13
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79770
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-02-11 12:59:08 +00:00
Ben Clayton 6688b0a3c7 resolver: Enable support of out of order declarations
Allow module-scope declarations to be made in any order.

Bug: tint:1266
Change-Id: Ib2607b6c33fad7c83e2c36f85b0a965eac922ec5
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79769
Reviewed-by: David Neto <dneto@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-02-11 12:59:08 +00:00
Dawn Autoroller daff392705 Roll ANGLE from 118ce6aae027 to d5df233189ca (6 revisions)
118ce6aae0..d5df233189

2022-02-11 cclao@google.com Vulkan: Disable EGLContextSharingTestNoSyncTextureUploads on Pixel6
2022-02-10 syoussefi@chromium.org Vulkan: Render the overlay in the graphics pipeline
2022-02-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from b594e2aabae9 to 071bfca11aa9 (1 revision)
2022-02-10 cclao@google.com Vulkan: Use Vulkan API directly for BufferPool's buffer allocation
2022-02-10 m.maiya@samsung.com Update GL_MAX_CLIP_DISTANCES_EXT validation
2022-02-10 steven@valvesoftware.com Vulkan: improve command buffer reset performance

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: amaiorano@google.com
Change-Id: I4ea55973653adb90587bb2b11b2e86706bc3a14e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/80220
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-11 08:26:01 +00:00
Stephen White a52abab38c Nuke SPIRV-Cross.
Change-Id: I1fc58d50ba3999e3a9b6f4e30a0799be301893de
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79481
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2022-02-11 00:45:51 +00:00
Dawn Autoroller 0778a4285a Roll Tint from 0b3dfef469 to 98facb28ab (3 revisions)
https://dawn.googlesource.com/tint.git/+log/0b3dfef4698f..98facb28abc8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-dawn
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: amaiorano@google.com
Change-Id: I942fb1d5a72697fd0c19d649b3d796e64080d933
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/80160
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-10 23:49:11 +00:00
Stephen White 96b72c262c OpenGL: use Tint for GLSL generation.
Change-Id: Ibced679fa6568f1eb33707f0157d03505e6f8a1c
Bug: dawn:1263
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/67540
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2022-02-10 22:17:41 +00:00
Brandon Jones 31f60e3a40 Remove accidental unused Transform Manager
Removes an unused tint::Transform::Manager that was accidentally merged
as part of commit "Integrate Multiplanar External Texture Transform".

Bug: dawn:1082
Change-Id: I55b5eec8b17f27df22658a90912dec4d6d583cbb
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/80100
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Brandon1 Jones <brandon1.jones@intel.com>
2022-02-10 21:56:51 +00:00
Ryan Harrison 98facb28ab Add my @chromium.org account to OWNERS
Change-Id: Ib61ff92d373b63c39bbf664a2c67d5f0b8e9bd2e
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/80080
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: David Neto <dneto@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
2022-02-10 19:57:53 +00:00
Austin Eng e710706858 Remove old src/tests/BUILD.gn
Bug: dawn:1275
Change-Id: I1da086fb291551b0a437411b13285a097557e7de
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/80060
Auto-Submit: Austin Eng <enga@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-02-10 19:41:24 +00:00
Brandon Jones cff04b4d3f Integrate Multiplanar External Texture Transform
Introduces the majority of the logic associated with enabling
multiplanar external textures. Removes most backend logic associated
with external textures in favor of expanding them into their components
in the frontend. Includes a basic e2e test demonstrating multiplanar
YUV-to-RGB conversion.

Bug: dawn:1082
Change-Id: Ib5c042e5639b1a8efe2954680abc346c8c6c76d7
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/78248
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Brandon1 Jones <brandon1.jones@intel.com>
2022-02-10 19:31:13 +00:00
Dawn Autoroller e6e2bcf436 Roll ANGLE from 670a6e476ea4 to 118ce6aae027 (4 revisions)
670a6e476e..118ce6aae0

2022-02-10 sweeper1203@gmail.com Support to open d3d12 shared handles
2022-02-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 0915ab4bddf7 to cbd31d271e4c (3 revisions)
2022-02-10 ynovikov@chromium.org Revert "Don't build dEQP tests on MSVC temporarily"
2022-02-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 60719c9cd084 to bf99b2cc0f6b (543 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: amaiorano@google.com
Change-Id: Ida55abe25676edfaabf038f66d91ad504f413318
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/80041
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-10 18:59:21 +00:00
Antonio Maiorano 0bb04c2057 Split back out two transforms previously combined into PromoteSideEffectsToDeclTest
That is, bring back both VarForDynamicIndex and
PromoteInitializersToConstVar. This is not a complete revert, though:
*  VarForDynamicIndex no longer depends on ForLoopToLoop
* Both can cope with hoisting from "else if"
* More unit tests were added in the interim

Delete PromoteSideEffectsToDecl for now. This may be brought back to
handle ensuring order of evaluation.

Bug: tint:1300
Change-Id: I8bbae46377ec4603cc02c1eb3f0661a8461a19fa
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79940
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2022-02-10 18:50:38 +00:00
Vadim Shtayura 3ce05348e7 Generate shorter bucket names in luci-scheduler.cfg.
This is an ongoing LUCI config format migration.

R=jrprice@google.com

Change-Id: I12c2913b61f97ea1a4108ac9e5cc0b46f0be3765
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79960
Auto-Submit: Vadim Shtayura <vadimsh@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Ryan Harrison (use @chromium.org) <rharrison@google.com>
Commit-Queue: Ryan Harrison (use @chromium.org) <rharrison@google.com>
2022-02-10 18:42:18 +00:00
Dawn Autoroller d513b69680 Roll Tint from 8bbdda7e89 to 0b3dfef469 (1 revision)
https://dawn.googlesource.com/tint.git/+log/8bbdda7e89dd..0b3dfef4698f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-dawn
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: amaiorano@google.com
Change-Id: I57298f05c18ffdb7254a789fed5eff2a392bd464
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/80040
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-10 18:34:41 +00:00
Dawn Autoroller 13152e7dbb Roll SwiftShader from cbd31d271e4c to a7f412ebb116 (1 revision)
https://swiftshader.googlesource.com/SwiftShader.git/+log/cbd31d271e4c..a7f412ebb116

2022-02-10 swiftshader.regress@gmail.com Regres: Update test lists @ cbd31d27

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: amaiorano@google.com
Change-Id: I2f6dcf15360f4d9f1cf4c30170af1926c85cee82
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/80000
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-10 16:56:21 +00:00
Stephen White 0b3dfef469 GLSL: call renamer transform from GLSL transform.
This significantly simplifies the calling code from Dawn.
It does require moving the SingleEntryPoint transform above the
renamer, since we need to call SEP with the original name. That is
probably also an optimization, since we do the subsequent transforms
with a culled AST.

Bug: tint:1268
Change-Id: I1f48ec0238ea76310742c60b119311747dd3dbac
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/80020
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2022-02-10 16:22:28 +00:00
Vadim Shtayura 040bfe2518 Generate shorter bucket names in luci-scheduler.cfg.
This is an ongoing LUCI config format migration.

Change-Id: Id01a7a1461c78f8e7147fb314e0379ab9835e528
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79981
Auto-Submit: Vadim Shtayura <vadimsh@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2022-02-10 09:02:02 +00:00
Dawn Autoroller 1d39cb13cc Roll Tint from 597fc4cdbe to 8bbdda7e89 (3 revisions)
https://dawn.googlesource.com/tint.git/+log/597fc4cdbe07..8bbdda7e89dd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-dawn
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: amaiorano@google.com
Change-Id: Ic0b83beaec1a3f596646b3a204afd04cac482652
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79924
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-10 05:16:22 +00:00
Dawn Autoroller 74d9fe10ac Roll ANGLE from 9cfd872447fd to 670a6e476ea4 (7 revisions)
9cfd872447..670a6e476e

2022-02-10 m.maiya@samsung.com Ignore invalid texture type error
2022-02-10 kpiddington@apple.com Metal: Fix multisample resolves.
2022-02-09 cclao@google.com Vulkan: Fix incorrect DescriptorSet's bufferInfo in XFB emulation path
2022-02-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 97ceb2222747 to b594e2aabae9 (64 revisions)
2022-02-09 cnorthrop@google.com Test: Add Lords Mobile trace
2022-02-09 jmadill@chromium.org Fix perf test runner script.
2022-02-09 jonahr@google.com Add keying on backend to ANGLE Display caching.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: amaiorano@google.com
Change-Id: I9b613edb64b3625ec19dd326b8d96637dcf49e28
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79925
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-10 05:09:42 +00:00
Jiawei Shao 47f051984b D3D12: Only set root parameters for dynamic storage buffers when needed
This patch skips setting the items for dynamic storage buffer lengths
in root signatures when there is no dynamic storage buffer in the
pipeline layout so that we can avoid adding a root constant with
Num32BitValues == 0 in the root signature.

BUG=dawn:1262

Change-Id: I7d698425c94092299aefaf8cb6ef465745c8d194
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79742
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
2022-02-10 00:05:01 +00:00
Ben Clayton 8bbdda7e89 transform: Update MultiplanarExternalTexture to support OOO-decls
MultiplanarExternalTexture cannot deal with out-of-order declarations.
Re-work things so that it can.

Bug: tint:1266
Change-Id: Ie2c8237be4f6ddb91120cbeb25f3c186b572ba59
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79768
Reviewed-by: David Neto <dneto@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-02-09 23:55:51 +00:00
Ben Clayton 8ec32a6ec9 writers: Use the new sem::Module::DependencyOrderedDeclarations
As the resolver currently enforces in-order declarations, this does not
change the declaration order from iterating over the
ast::Module::GlobalDeclarations.

The MSL backend has been changed to use the
sem::Module::DependencyOrderedDeclarations list instead of looping over
different declaration types separately.

Bug: tint:1266
Change-Id: I698d612032285311017bfceab3c42adae1928a0e
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79767
Reviewed-by: James Price <jrprice@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-02-09 23:55:51 +00:00
Ben Clayton a52be6c9ec Add sem::Module
Holds `DependencyOrderedDeclarations()`, which will hold the
sorted dependency-graph ordered list of global declarations.

Bug: tint:1266
Change-Id: I9840fae8689abd214973ea4785f71c3ae2587bbc
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79766
Reviewed-by: James Price <jrprice@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-02-09 23:55:51 +00:00
Dawn Autoroller 311e20e5de Roll Tint from 35cc663130 to 597fc4cdbe (4 revisions)
https://dawn.googlesource.com/tint.git/+log/35cc6631307c..597fc4cdbe07

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-dawn
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: amaiorano@google.com
Change-Id: Iab13a68106a7b2c60adee73689852903439b8007
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79923
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-09 23:54:01 +00:00
Dawn Autoroller 8d4fc76d17 Roll SwiftShader from 0915ab4bddf7 to cbd31d271e4c (3 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/0915ab4bddf7..cbd31d271e4c

2022-02-09 sugoi@google.com Dynamic state refactor
2022-02-09 sugoi@google.com VK_EXT_subgroup_size_control support
2022-02-09 capn@google.com Add compute benchmarks

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC amaiorano@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: amaiorano@google.com
Change-Id: I57bf38eaff7f0b8116cb988687bc3ee577f8c4de
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79922
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
2022-02-09 22:42:51 +00:00
Ben Clayton 597fc4cdbe resolver: Replace ICEs with proper errors
If you attempted to:
 * Use a function as a type
 * Use a variable as a type
 * Use a variable as a call target

You would get an ICE. Replace these with proper error diagnostics.

Change-Id: Ibbe4cd1b59b1aadd451aa0445ad137859aa071eb
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79765
Reviewed-by: James Price <jrprice@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
2022-02-09 22:23:17 +00:00
Ben Clayton 88d1a433aa Castable: Have Switch() support nullptr objects.
Change-Id: I7635b01707e80c2d2e0b79148e07874f2fa2b5ff
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/79764
Auto-Submit: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2022-02-09 21:37:57 +00:00