Commit Graph

51 Commits

Author SHA1 Message Date
Austin Eng 43655314ee Roll vulkan-deps from fb10489972ad to fc12bd106db5 (12 revisions)
Also, set vvl_spirv_headers_dir build override to fix the build.

https://chromium.googlesource.com/vulkan-deps.git/+log/fb10489972ad..fc12bd106db5

Changed dependencies:
* spirv-cross: f6ca617825..6d3518e238
* vulkan-headers: 88ebcb08cb..5177b119bb
* vulkan-loader: 2f87e2b3a5..3090fc12bd
* vulkan-tools: f7dff1f7dd..5b4f221819
* vulkan-validation-layers: c53a4cb4e0..7bc6e19210

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-dawn-autoroll
Please CC enga@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Change-Id: Ie23bc22b4981e7b48082c0b43975e8805bfd2ff9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/102463
Auto-Submit: Austin Eng <enga@chromium.org>
Reviewed-by: Loko Kung <lokokung@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Commit-Queue: Loko Kung <lokokung@google.com>
2022-09-15 23:04:18 +00:00
Antonio Caggiano 8a29038826 GN: Wayland build overrides
Introduce //build_overrides/wayland.gni to simplify the management of
the wayland dependencies.

Bug: chromium:1327041
Bug: angleproject:7409
Change-Id: Ib1e120c722aec6ff3cb171f39a8e794b93799129
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/93788
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: dan sinclair <dsinclair@google.com>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
2022-06-27 15:17:34 +00:00
dan sinclair 77bf233cef Move tint unittest behind a build flag.
This CL moves the Tint unittest code behind a build flag in order
to hide the //testing/test.gni dependency from downstream consumers.

The unittests are enabled by default and can be disabled by setting
`tint_build_unittests` to false.

Bug: dawn:1517
Change-Id: Id560ed98416ba0725b62a93ddd27caf341699e75
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/94481
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2022-06-22 12:40:43 +00:00
Loko Kung 7d2b9d9e83 Add alternative method to use a version/git hash from a file.
- This is necessary for Chromium builds from tarballs where git is no longer available. This gives Chromium another option to create the version file when creating the tarball to accomplish the same thing.

Bug: dawn:549
Change-Id: Iffb4bf694b0df1306dd92939353422e5115346a7
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/94043
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Loko Kung <lokokung@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2022-06-22 04:19:43 +00:00
Ryan Harrison e87ac76f7d Merge remote-tracking branch 'tint/main' into HEAD
Integrates Tint repo into Dawn

KIs:
- Building docs for Tint is turned off, because it fails due to lack
  of annotations in Dawn source files.
- Dawn CQ needs to be updated to run Tint specific tests
- Significant post-merge cleanup needed

R=bclayton,cwallez
BUG=dawn:1339

Change-Id: I6c9714a0030934edd6c51f3cac4684dcd59d1ea3
2022-04-06 15:37:27 -04:00
Nicolas Capens 8191f846cc Remove swiftshader_spirv_tools_dir
SwiftShader now uses an independent build of SPIRV-Tools dependencies,
like in other environments.

Bug: b/158002593
Change-Id: I2149b99fc4b4f615c77c589ae9e5eb880f37feb6
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/85660
Auto-Submit: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
2022-04-04 21:00:52 +00:00
Ryan Harrison 3374f43c31 Normalize DEPS to ease merging with Dawn
- Format specific targets to have the hash in the target rule instead
  of a variable.
- Only have the base part of the URL in a variable
- Use vulkan-deps instead of individual DEPS (spirv-tools,
  spirv-headers & glslang)

BUG=tint:1481

Change-Id: I871a656e26050698da2c77f4f39fec94a9c4f8a4
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/84723
Reviewed-by: David Neto <dneto@google.com>
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
2022-03-28 18:01:02 +00:00
Stephen White a52abab38c Nuke SPIRV-Cross.
Change-Id: I1fc58d50ba3999e3a9b6f4e30a0799be301893de
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79481
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2022-02-11 00:45:51 +00:00
Stephen White 19bb9563f8 Set vulkan_loader_shared to false on Mac.
This is the same configuation that ANGLE uses. Without this, Release
builds of Dawn on Mac can't find libvulkan.dylib.

Bug: angleproject:6981

Change-Id: Ib5eddd0f694d1b960e16341578427fa4f0a009c5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/79560
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>
2022-02-09 17:45:51 +00:00
Dawn Autoroller 2ed5c1c0d2 Roll SwiftShader from 562df4889b81 to f354daff5a2b (164 revisions)
https://swiftshader.googlesource.com/SwiftShader.git/+log/562df4889b81..f354daff5a2b

2021-12-14 swiftshader.regress@gmail.com Regres: Update test lists @ 1eee6cbc
2021-12-13 srisser@google.com Regres updates deqp.json before updating testlists
2021-12-13 swiftshader.regress@gmail.com Regres: Update test lists @ 592d413e
2021-12-13 swiftshader.regress@gmail.com Regres: Update test lists @ 592d413e
2021-12-10 capn@google.com Refactor image sample normalization
2021-12-10 capn@google.com Report depth and multi-plane UNORM formats as unsigned normalized
2021-12-10 swiftshader.regress@gmail.com Regres: Update test lists @ 4c62980d
2021-12-10 cwallez@chromium.org Suppress -Wdeprecated-declarations in Subzero's LLVM
2021-12-10 capn@google.com Implement VK_KHR_vulkan_memory_model
2021-12-09 capn@google.com Update vk::Stringify() structure handling
2021-12-09 sugoi@google.com Fix using XCB with odd width
2021-12-09 capn@google.com Implement VK_EXT_format_feature_flags2
2021-12-09 andre.kempe@arm.com [pac] Add a specific flag for enabling PAC only
2021-12-09 capn@google.com Simplify scaling of 16-bit sampled texel components
2021-12-09 capn@google.com Remove OpenGL ES targets from the CMake build
2021-12-09 capn@google.com Remove the ANGLE submodule
2021-12-08 capn@google.com Refactor active blend factor determination
2021-12-08 capn@google.com Refactor active blend operation determination
2021-12-08 capn@google.com Fix passthrough blend operations
2021-12-08 capn@google.com Report input attachment usage capability for surface images
2021-12-08 capn@google.com Report storage usage capability for surface images
2021-12-07 cwallez@google.com Bump maxUniformBufferRange 2^14 to 2^16
2021-12-03 capn@google.com Skip building SPIRV-Tools executables
2021-12-03 kramerb@google.com Move swiftshader off deprecated llvm::IRBuilder APIs
2021-12-03 swiftshader.regress@gmail.com Regres: Update test lists @ a465cca8
2021-12-03 capn@google.com Unpack 1010102 formats into upper 16-bit components
2021-12-02 nicolascapens@google.com Add bclayton to OWNERS
2021-12-02 swiftshader.regress@gmail.com Regres: Update test lists @ f9c39655
2021-12-02 capn@google.com Update SPIR-V Tools to c75a1a46f
2021-12-02 srisser@google.com Expose support for VK_KHR_swapchain_mutable_format
2021-11-30 capn@google.com Prevent exit-time destructors in src/WSI, Pipeline, and System
2021-11-30 capn@google.com Update SPIR-V Tools to d0a827a9f
2021-11-30 capn@google.com Update SPIR-V Headers to 20b02de99
2021-11-30 capn@google.com Don't handle vendor-specific SPIR-V instructions
2021-11-30 capn@google.com Don't consider OpType* instructions to be statements
2021-11-30 capn@google.com Eliminate SpirvShaderInstructions.inl
2021-11-26 capn@google.com Statically allocate function pointer tables for libXCB
2021-11-26 capn@google.com Statically allocate function pointer tables for libX11
2021-11-26 capn@google.com Refactor libXCB and libX11 wrappers
2021-11-26 ari.suonpaa@siru.fi Fix component normalization for texture gather
2021-11-25 sugoi@google.com Make Win32SurfaceKHR::present() more robust
2021-11-24 capn@google.com Assert that casting memory sizes to 32-bit doesn't overflow
2021-11-24 capn@google.com Use size_t for methods returning memory sizes
2021-11-24 capn@google.com Add a GN build option for the startup dialog
2021-11-23 capn@google.com Regres: Update test lists @ 9e727fad
2021-11-22 capn@google.com Assert that the descriptor set is not null
2021-11-22 capn@google.com Implement Assert() for Reactor
2021-11-22 ari.suonpaa@siru.fi Fix green bits for R5G6B5_UNORM_PACK16
2021-11-19 sugoi@google.com Make line stipple related tests pass
2021-11-19 capn@google.com Run clang-format-all.sh as a Bash script
2021-11-19 swiftshader.regress@gmail.com Regres: Update test lists @ 210fe010
2021-11-19 capn@google.com Update testslists to match the dEQP revision
2021-11-18 swiftshader.regress@gmail.com Regres: Update test lists @ 4c687cc2
2021-11-18 ari.suonpaa@siru.fi Fix border color when sampling normalized texture formats
2021-11-18 srisser@google.com Regres fetches HEAD and truncates deqp.json
2021-11-17 swiftshader.regress@gmail.com Regres: Update test lists @ e068963d
2021-11-17 capn@google.com Add support for VK_FORMAT_B8G8R8A8_UNORM|SRGB as storage image formats
2021-11-16 swiftshader.regress@gmail.com Regres: Update test lists @ f0e8ec2d
2021-11-15 capn@google.com Implement shaderStorageImageWriteWithoutFormat support
2021-11-15 capn@google.com Perform image write from a static function
2021-11-15 capn@google.com Support writing to storage images with packed formats
2021-11-15 capn@google.com Provide StorageImageDescriptor with an image view identifier
2021-11-15 capn@google.com Make GetTexelAddress() independent from SPIR-V parsing
2021-11-15 srisser@google.com Detemplatize hasExtendedFeatures
2021-11-15 msisov@igalia.com Rename use_x11 to ozone_platform_x11
2021-11-15 capn@google.com Allow dereferencing of constant Reactor pointers
2021-11-15 capn@google.com Parse the OpTypeImage information into ImageInstructionSignature
2021-11-15 capn@google.com Parse OpImageTexelPointer into an ImageInstruction
2021-11-13 liyl@google.com cmake: Add VK_USE_PLATFORM_METAL_EXT for macOS builds
2021-11-13 sugoi@google.com Structure conversion cleanup
2021-11-12 sugoi@google.com Fix Xcb depth
2021-11-12 capn@google.com Produce a Visual Studio error for unreferenced local variables
2021-11-12 capn@google.com Rename ImageInstructionState to ImageInstructionSignature
2021-11-12 capn@google.com Separate the SPIR-V image and sampler as part of ImageInstruction
2021-11-12 capn@google.com Determine SPIR-V zero constants from SPIR-V binary only
2021-11-12 capn@google.com Parse OpImageRead and OpImageWrite into an ImageInstruction
2021-11-12 swiftshader.regress@gmail.com Regres: Update test lists @ 678d3931
2021-11-12 capn@google.com Make sw::Constants a member of vk::Device
2021-11-12 capn@google.com Pass the vk::Device to every routine as an extra parameter
2021-11-12 capn@google.com Split image sampling into routine lookup and function call
2021-11-11 sugoi@google.com VK_KHR_copy_commands2 support
2021-11-10 sugoi@google.com Tightly pack PlaneEquations array
2021-11-10 sugoi@google.com Fix Android.bp build after SPIRV-Headers update
2021-11-09 sugoi@google.com Follow-up 2: Fix Android.bp build after SPIRV-Tools update
2021-11-09 sugoi@google.com Follow-up: Fix Android.bp build after SPIRV-Tools update
2021-11-09 capn@google.com Associate inline sampler caches with instruction position
2021-11-09 capn@google.com Use the Vulkan format for OpImageWrite
2021-11-09 capn@google.com Simplify obtaining the type from a SPIR-V object <id>
2021-11-09 capn@google.com Treat sRGB formats as unsigned normalized
2021-11-09 capn@google.com Improve inverse blendConstant() readability
2021-11-09 capn@google.com Optimize clamping of constant blend factors
2021-11-09 capn@google.com Parse SPIR-V image instructions before code generation
2021-11-09 capn@google.com Check for valid SPIR-V <id>s by comparing against 0
2021-11-09 sugoi@google.com Fix Android.bp build after SPIRV-Tools update
2021-11-09 sugoi@google.com Add warning treated as error for missing case statement
2021-11-08 srisser@google.com Regres updates SHA and testlists after daily run
2021-11-08 sugoi@google.com Update SPIR-V shader instructions after SPIRV-Tools update
2021-11-08 swiftshader.regress@gmail.com Regres: Update test lists @ 4c6da56d
2021-11-08 sugoi@google.com Update SPIR-V Tools to 339d4475c
2021-11-08 sugoi@google.com Update SPIR-V Headers to 29817199b
2021-11-08 sugoi@google.com No format verification in SPIR-V headers and tools update scripts
2021-11-07 sugoi@google.com VK_EXT_pipeline_creation_feedback support
2021-11-07 swiftshader.regress@gmail.com Regres: Update test lists @ 70f3a0ff
2021-11-06 capn@google.com Fix min/max blend operations
2021-11-05 sugoi@google.com VK_EXT_blend_operation_advanced minimal implementation
2021-11-05 sugoi@google.com Support VK_EXT_pipeline_creation_cache_control
2021-11-05 capn@google.com Poison device memory allocations for GN MSan builds
2021-11-03 sugoi@google.com Add assert on illegal signed/unsigned blit
2021-11-02 sugoi@google.com Perform all blend operations in floating-point
2021-11-02 swiftshader.regress@gmail.com Regres: Update test lists @ 542593f0
2021-11-01 capn@google.com Implement support for VK_FORMAT_R16*_UNORM attachment formats
2021-11-01 capn@google.com Clamp blend factors and color output
2021-11-01 capn@google.com Refactor blending
2021-10-27 srisser@google.com Update git-hooks to HEAD revision
2021-10-27 srisser@google.com Revert "Make git-hooks track with origin/main"
2021-10-27 sugoi@google.com Refactor Queue::Submit to use internal structure
2021-10-26 srisser@google.com Make git-hooks track with origin/main
2021-10-25 capn@google.com Delay extension support check until instance/device creation
2021-10-21 srisser@google.com Update git-hooks to latest version
2021-10-21 sergeyu@google.com [Fuchsia] Fix Vulkan compilation
2021-10-20 swiftshader.regress@gmail.com Regres: Update test lists @ 6b700ffc
2021-10-19 srisser@google.com Add VK_KHR_shader_integer_dot_product structs
2021-10-19 swiftshader.regress@gmail.com Regres: Update test lists @ 85101b9e
2021-10-19 capn@google.com Avoid SPIR-V binary identifier clashes
2021-10-19 capn@google.com Avoid recompiling identical SPIR-V binaries
2021-10-19 capn@google.com Store the SPIR-V binary of a vk::ShaderModule in an sw::SpirvBinary
2021-10-18 sugoi@google.com Fix uninitialized memoryOwner on unused DescriptorSet
2021-10-18 sugoi@google.com Fix BC6h decoder
2021-10-18 sugoi@google.com Fix blitting of various packed formats
2021-10-18 srisser@google.com Update Vulkan headers to version 1.2.196
2021-10-15 liyl@google.com Use smart pointer for the LibX11Exports singleton
2021-10-15 swiftshader.regress@gmail.com Regres: Update test lists @ ce1449fd
2021-10-14 sugoi@google.com Fix Depth+Stencil image copy
2021-10-14 sugoi@google.com Fix blitting of compressed images
2021-10-14 sugoi@google.com Make decompression functions const
2021-10-14 srisser@google.com Remove LOG_TRAP
2021-10-13 thakis@chromium.org Disable -Wbitwise-instead-of-logical for llvm-10.0 in swiftshader
2021-10-13 swiftshader.regress@gmail.com Regres: Update test lists @ ca2ada82
2021-10-13 sugoi@google.com Fix border update when rendering to cube face
2021-10-12 capn@google.com Revert "Kokoro: Disable gcp_ubuntu builds failing to update CMake"
2021-10-12 sugoi@google.com Regres: Roll dEQP to master revision e2aeccd
2021-10-12 capn@google.com Restore zero-initialization of device memory allocations for GN builds
2021-10-09 capn@google.com Don't initialize device memory allocations in MSan builds
2021-10-08 capn@google.com Don't initialize host memory allocations in MSan builds
2021-10-08 thakis@chromium.org Disable C4244 when building LLVM for swiftshader
2021-10-07 sugoi@google.com Move ExternalMemoryHost to its own file
2021-10-07 capn@google.com Refactor DeviceMemory buffer allocation/freeing
2021-10-07 capn@google.com Rename allocation functions
2021-10-06 capn@google.com Separate device memory allocations from host allocations
2021-10-05 capn@google.com Deep copy specialization info
2021-10-05 swiftshader.regress@gmail.com Regres: Update test lists @ 70178a76
2021-10-04 capn@google.com Refactor swapchain image creation
2021-10-04 capn@google.com Increase the maximum 1D, 2D, and Cube image dimension to 16384
2021-10-04 nicolascapens@google.com Kokoro: Disable gcp_ubuntu builds failing to update CMake
2021-10-02 vadimsh@chromium.org Add realms.cfg to LUCI configs.
2021-10-01 capn@google.com Add padding to VkBuffer size to avoid access violation
2021-10-01 capn@google.com Remove the legacy GLSL ES vertex shader fuzzer
2021-10-01 capn@google.com Fix macOS build requiring Objective-C++17 compilation
2021-10-01 capn@google.com Restore zero-initialization of memory allocations
2021-09-30 capn@google.com Refactor config constants
2021-09-29 capn@google.com Don't initialize memory allocations in MSan builds
2021-09-29 yikong@google.com Fix unused-command-line-argument warning
2021-09-28 capn@google.com Regres: Skip the Vulkan Loader
2021-09-28 swiftshader.regress@gmail.com Regres: Update test lists @ 562df488

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-dawn-autoroll
Please CC enga@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in SwiftShader: https://bugs.chromium.org/p/swiftshader/issues/entry
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: dawn:1173,dawn:1233
Tbr: enga@google.com
Change-Id: I1e09cd20b010bcef8d1222ff1b1371e60ca5dc65
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/74100
Reviewed-by: Shrek Shao <shrekshao@google.com>
Bot-Commit: Dawn Autoroller <dawn-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
2021-12-21 19:14:52 +00:00
Austin Eng f30f3a912d Roll third_party/vulkan-deps/ d74e02442..39f3a18bd (591 commits)
https://chromium.googlesource.com/vulkan-deps/+log/d74e02442e56..39f3a18bdfbe

Changed dependencies:
  * glslang: 7ca4dfa061..ca13951205
  * spirv-cross: bab4e5911b..e9cc640334
  * spirv-headers: 449bc986ba..eddd4dfc93
  * spirv-tools: 926ff6d1ba..7d768812e2
  * vulkan-headers: c5b7a2fa18..e005e1f817
  * vulkan-loader: 90fd66f60f..a11162fcac
  * vulkan-tools: 5805106266..05c6171c04
  * vulkan-validation-layers: cefa7fd82e..f8f8e2fe64

$ git log d74e02442..39f3a18bd --date=short --no-merges --format='%ad %ae %s'
2021-12-15 chromium-autoroll Roll SPIRV-Tools from b7251d4fb756 to 7d768812e202 (1 revision)
2021-12-15 chromium-autoroll Roll SPIRV-Headers from d53b49635b74 to eddd4dfc930f (1 revision)
2021-12-15 chromium-autoroll Roll Vulkan-ValidationLayers from 9f537109da6d to f8f8e2fe648a (2 revisions)
2021-12-15 chromium-autoroll Roll SPIRV-Tools from 354a46a2a22e to b7251d4fb756 (1 revision)
2021-12-15 chromium-autoroll Roll SPIRV-Tools from 4322c4b5a7db to 354a46a2a22e (1 revision)
2021-12-15 chromium-autoroll Roll Vulkan-Loader from 24373f2d987b to a11162fcaca8 (1 revision)
2021-12-14 chromium-autoroll Roll SPIRV-Tools from f0351b7bc60b to 4322c4b5a7db (1 revision)
2021-12-13 chromium-autoroll Roll Vulkan-Loader from ca9efe3f1ccd to 24373f2d987b (1 revision)
2021-12-13 chromium-autoroll Roll SPIRV-Tools from ff07cfd86fa2 to f0351b7bc60b (1 revision)
2021-12-13 chromium-autoroll Roll Vulkan-Tools from d3cdb64f2ef5 to 05c6171c04df (1 revision)
2021-12-12 chromium-autoroll Roll Vulkan-Tools from 08f87babadc4 to d3cdb64f2ef5 (1 revision)
2021-12-11 chromium-autoroll Roll Vulkan-Loader from 2bbfe2ef640c to ca9efe3f1ccd (9 revisions)
2021-12-10 chromium-autoroll Roll Vulkan-ValidationLayers from 3dfeacfe0ad0 to 9f537109da6d (1 revision)
2021-12-10 chromium-autoroll Roll SPIRV-Tools from e4527925944c to ff07cfd86fa2 (1 revision)
2021-12-10 chromium-autoroll Roll SPIRV-Tools from 315615887836 to e4527925944c (1 revision)
2021-12-09 chromium-autoroll Roll SPIRV-Tools from a2260d3b1fd2 to 315615887836 (1 revision)
2021-12-09 chromium-autoroll Roll Vulkan-ValidationLayers from f16f14915b7d to 3dfeacfe0ad0 (3 revisions)
2021-12-09 chromium-autoroll Roll glslang from 542ee69d8309 to ca1395120555 (1 revision)
2021-12-09 chromium-autoroll Roll SPIRV-Tools from d240d0db92d5 to a2260d3b1fd2 (1 revision)
2021-12-09 chromium-autoroll Roll Vulkan-ValidationLayers from 965e5f89e257 to f16f14915b7d (1 revision)
2021-12-09 chromium-autoroll Roll Vulkan-ValidationLayers from ee8a454f88a8 to 965e5f89e257 (1 revision)
2021-12-09 chromium-autoroll Roll SPIRV-Tools from f37551d2b617 to d240d0db92d5 (3 revisions)
2021-12-09 chromium-autoroll Roll SPIRV-Tools from 438096e0c252 to f37551d2b617 (1 revision)
2021-12-08 chromium-autoroll Roll SPIRV-Tools from 64328e94dbd1 to 438096e0c252 (1 revision)
2021-12-08 chromium-autoroll Roll SPIRV-Tools from 1ed847f43804 to 64328e94dbd1 (1 revision)
2021-12-08 chromium-autoroll Roll SPIRV-Tools from b162ede0dea5 to 1ed847f43804 (1 revision)
2021-12-08 chromium-autoroll Roll SPIRV-Tools from 1f3f0f185b62 to b162ede0dea5 (1 revision)
2021-12-08 chromium-autoroll Roll SPIRV-Tools from f9bcc82ec730 to 1f3f0f185b62 (1 revision)
2021-12-08 chromium-autoroll Roll SPIRV-Headers from 29414ae1fd07 to d53b49635b74 (1 revision)
2021-12-07 chromium-autoroll Roll glslang from ec5ea2d6cbad to 542ee69d8309 (2 revisions)
2021-12-07 chromium-autoroll Roll Vulkan-Loader from 3d3aae8fab85 to 2bbfe2ef640c (1 revision)
2021-12-07 chromium-autoroll Roll Vulkan-ValidationLayers from 2c2b81c05189 to ee8a454f88a8 (2 revisions)
2021-12-07 chromium-autoroll Roll Vulkan-Headers from ea61f32f24d2 to e005e1f8175d (1 revision)
2021-12-06 chromium-autoroll Roll Vulkan-ValidationLayers from 81195dfecbd0 to 2c2b81c05189 (1 revision)
2021-12-06 chromium-autoroll Roll Vulkan-Loader from 876a1b9c3427 to 3d3aae8fab85 (1 revision)
2021-12-04 chromium-autoroll Roll SPIRV-Tools from c75a1a46f39f to f9bcc82ec730 (1 revision)
2021-12-03 chromium-autoroll Roll Vulkan-Loader from 143eb773e4e8 to 876a1b9c3427 (1 revision)
2021-12-03 chromium-autoroll Roll Vulkan-Loader from 737b390a4c53 to 143eb773e4e8 (1 revision)
2021-12-02 chromium-autoroll Roll Vulkan-ValidationLayers from 8c4aad9df626 to 81195dfecbd0 (1 revision)
2021-12-02 chromium-autoroll Roll Vulkan-ValidationLayers from 1858ae9e00a4 to 8c4aad9df626 (2 revisions)
2021-12-02 chromium-autoroll Roll Vulkan-Headers from a15237165443 to ea61f32f24d2 (1 revision)
2021-12-02 chromium-autoroll Roll Vulkan-ValidationLayers from 2a7d7a3c3b1f to 1858ae9e00a4 (1 revision)
2021-12-02 chromium-autoroll Roll Vulkan-ValidationLayers from ae1ef56fc99b to 2a7d7a3c3b1f (2 revisions)
2021-12-02 ynovikov Revert "Roll Vulkan-Headers from a15237165443 to ea61f32f24d2 (1 revision)"
2021-12-02 chromium-autoroll Roll glslang from 0e1396862cc8 to ec5ea2d6cbad (1 revision)
2021-12-02 chromium-autoroll Roll Vulkan-Loader from f8c72d8fe402 to 737b390a4c53 (1 revision)
2021-12-02 chromium-autoroll Roll SPIRV-Tools from d0a827a9f313 to c75a1a46f39f (1 revision)
2021-12-01 chromium-autoroll Roll Vulkan-Loader from 6df9f13c7b68 to f8c72d8fe402 (1 revision)
2021-12-01 chromium-autoroll Roll Vulkan-Tools from 68b0ab756634 to 08f87babadc4 (1 revision)
2021-12-01 chromium-autoroll Roll Vulkan-ValidationLayers from c6bafff88f7e to ae1ef56fc99b (1 revision)
(...)
2021-08-30 chromium-autoroll Roll Vulkan-ValidationLayers from a9124f216679 to f39b2452f1f4 (2 revisions)
2021-08-30 chromium-autoroll Roll Vulkan-Tools from 580510626634 to 6c444b2c9f7b (1 revision)
2021-08-30 chromium-autoroll Roll Vulkan-Loader from 39dd126e16c7 to 4e55fdb4d272 (1 revision)
2021-08-30 chromium-autoroll Roll SPIRV-Tools from b8fce5f9e6da to 702e6af3800b (1 revision)
2021-08-29 chromium-autoroll Roll Vulkan-Headers from c5b7a2fa1875 to 9e62d027636c (1 revision)
2021-08-27 chromium-autoroll Roll Vulkan-ValidationLayers from 7217507df70a to a9124f216679 (2 revisions)
2021-08-27 chromium-autoroll Roll SPIRV-Tools from ee30773650ec to b8fce5f9e6da (1 revision)
2021-08-27 chromium-autoroll Roll Vulkan-ValidationLayers from bbd74cacc96e to 7217507df70a (5 revisions)
2021-08-27 chromium-autoroll Roll Vulkan-ValidationLayers from 15f450dbbf6c to bbd74cacc96e (2 revisions)
2021-08-27 chromium-autoroll Roll Vulkan-ValidationLayers from 0a5b93050693 to 15f450dbbf6c (2 revisions)
2021-08-26 chromium-autoroll Roll Vulkan-ValidationLayers from 9f65d3f73cab to 0a5b93050693 (2 revisions)
2021-08-26 chromium-autoroll Roll Vulkan-ValidationLayers from e09fa25f18ae to 9f65d3f73cab (3 revisions)
2021-08-26 chromium-autoroll Roll SPIRV-Tools from 2a5cc342fb5a to ee30773650ec (1 revision)
2021-08-26 chromium-autoroll Roll Vulkan-Loader from d7c8139c370a to 39dd126e16c7 (1 revision)
2021-08-26 chromium-autoroll Roll Vulkan-Loader from 90fd66f60fa7 to d7c8139c370a (3 revisions)
2021-08-26 chromium-autoroll Roll Vulkan-ValidationLayers from b8705a01456b to e09fa25f18ae (4 revisions)
2021-08-25 chromium-autoroll Roll Vulkan-ValidationLayers from ce4817c22c81 to b8705a01456b (2 revisions)
2021-08-25 chromium-autoroll Roll Vulkan-ValidationLayers from c2c5bbe227fb to ce4817c22c81 (1 revision)
2021-08-25 chromium-autoroll Roll glslang from a4599ef7561a to 2fb89a0072ae (1 revision)
2021-08-25 chromium-autoroll Roll Vulkan-ValidationLayers from 6fa8d3cbb97b to c2c5bbe227fb (2 revisions)
2021-08-25 chromium-autoroll Roll Vulkan-ValidationLayers from 46eb54e6a0df to 6fa8d3cbb97b (3 revisions)
2021-08-25 chromium-autoroll Roll SPIRV-Tools from 3d4246b4aaa6 to 2a5cc342fb5a (2 revisions)
2021-08-24 chromium-autoroll Roll SPIRV-Tools from 88f9c15eaea47a20120d1ade2fb51ef79bfac6e7 to 3d4246b4aaa6 (1 revision)
2021-08-24 chromium-autoroll Roll SPIRV-Tools from a1d5d67aeb45 to 88f9c15eaea4 (1 revision)
2021-08-24 chromium-autoroll Roll Vulkan-ValidationLayers from dbb81cca542d to 46eb54e6a0df (1 revision)
2021-08-24 chromium-autoroll Roll Vulkan-ValidationLayers from 1b7bd5773b55 to dbb81cca542d (1 revision)
2021-08-23 chromium-autoroll Roll Vulkan-ValidationLayers from 828e59d0417f to 1b7bd5773b55 (2 revisions)
2021-08-23 chromium-autoroll Roll Vulkan-ValidationLayers from b6121706a4af to 828e59d0417f (1 revision)
2021-08-23 chromium-autoroll Roll SPIRV-Tools from 937227c761a9 to a1d5d67aeb45 (1 revision)
2021-08-23 chromium-autoroll Roll SPIRV-Tools from d699296b4d4e to 937227c761a9 (1 revision)
2021-08-23 chromium-autoroll Roll Vulkan-ValidationLayers from e6e56b607161 to b6121706a4af (2 revisions)
2021-08-23 chromium-autoroll Roll Vulkan-ValidationLayers from c9b8c134c113 to e6e56b607161 (2 revisions)
2021-08-23 chromium-autoroll Roll Vulkan-ValidationLayers from 931cff66d7b2 to c9b8c134c113 (4 revisions)
2021-08-23 chromium-autoroll Roll SPIRV-Cross from 840d4483bcb2 to 0e2880ab990e (1 revision)
2021-08-23 chromium-autoroll Roll SPIRV-Cross from c062b6b85272 to 840d4483bcb2 (1 revision)
2021-08-23 chromium-autoroll Roll SPIRV-Cross from fad15907867d to c062b6b85272 (1 revision)
2021-08-23 chromium-autoroll Roll SPIRV-Cross from 27e7abeab15e to fad15907867d (1 revision)
2021-08-23 chromium-autoroll Roll SPIRV-Cross from bab4e5911b1b to 27e7abeab15e (1 revision)
2021-08-22 chromium-autoroll Roll Vulkan-ValidationLayers from a5405505d5d1 to 931cff66d7b2 (2 revisions)
2021-08-22 chromium-autoroll Roll Vulkan-ValidationLayers from e1f91ba6c4bb to a5405505d5d1 (2 revisions)
2021-08-20 chromium-autoroll Roll Vulkan-ValidationLayers from 78d6199679ef to e1f91ba6c4bb (3 revisions)
2021-08-20 chromium-autoroll Roll Vulkan-ValidationLayers from b3f17dc51510 to 78d6199679ef (1 revision)
2021-08-19 chromium-autoroll Roll Vulkan-ValidationLayers from c481a49ce568 to b3f17dc51510 (5 revisions)
2021-08-19 chromium-autoroll Roll SPIRV-Tools from 1ad8b71359b2 to d699296b4d4e (1 revision)
2021-08-19 chromium-autoroll Roll Vulkan-ValidationLayers from f6bb4bbc6ca3 to c481a49ce568 (2 revisions)
2021-08-18 chromium-autoroll Roll Vulkan-ValidationLayers from e5fad63fc9a4 to f6bb4bbc6ca3 (1 revision)
2021-08-18 chromium-autoroll Roll SPIRV-Tools from a9ce5e07c627 to 1ad8b71359b2 (1 revision)
2021-08-18 chromium-autoroll Roll glslang from 7ca4dfa06158 to a4599ef7561a (1 revision)
2021-08-18 chromium-autoroll Roll Vulkan-ValidationLayers from cefa7fd82e22 to e5fad63fc9a4 (1 revision)
2021-08-18 chromium-autoroll Roll SPIRV-Tools from 926ff6d1bab0 to a9ce5e07c627 (2 revisions)

Created with:
  roll-dep third_party/vulkan-deps

Change-Id: I6d0cdd1450c612db8100b4347af9f00a45790a8e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/73780
Auto-Submit: Austin Eng <enga@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
2021-12-21 00:52:41 +00:00
Corentin Wallez 5bd9445127 Remove CubeReflection and the dependency on GLM
Bug: None
Change-Id: Ie0948a8c14751777754360d276ce212507b74642
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/72581
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: James Price <jrprice@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2021-12-14 08:42:36 +00:00
Stephen White 7cf3b28a87 GLSL writer: validate all entry points with glslang.
Generate and validate all entry points individually.
This is required since GLSL has separate shader files, and
can only have a single "main" entry point.

Bug: tint:1217
Change-Id: Ie5cb510aaef3b7c8a7573f5fa9446815284afecb
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/61920
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
2021-10-14 14:39:36 +00:00
Brandon Jones a04663c13d Added Abseil as a third-party dependency (Take 2)
Another attempt at https://dawn-review.googlesource.com/c/dawn/+/63780
Depends on https://skia-review.googlesource.com/c/skia/+/451638

This version of the CL fixes the Cmake and Skia compatibility issues
from the previous CL.

Bug: dawn:563
Change-Id: I41a7ee0aef1924df08a9be41e94effb7cd0025df
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/64600
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
2021-09-23 20:36:03 +00:00
Shrek Shao 2f8f2518e5 Revert "Added Abseil as a third-party dependency"
This reverts commit 020d69905e.

Reason for revert: Causing Dawn Skia roll build fails

https://task-scheduler.skia.org/job/AZXXBm9h9ozj3kKiRJM5

Original change's description:
> Added Abseil as a third-party dependency
>
> Using the version in the Chromium repo in order to make use of the .gn
> files it contains.
>
> Doing so also appears to require us to switch where we pull googletest
> from so that the directory structure matches what the Abseil build
> config expects. Fortunately this doesn't seem to cause issues in our
> tests.
>
> Bug: dawn:563
> Change-Id: I55831ad33f282b3d8b03b67826fd2776e5602d89
> Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/63780
> Reviewed-by: Austin Eng <enga@chromium.org>
> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
> Auto-Submit: Brandon Jones <bajones@chromium.org>

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: dawn:563
Change-Id: I0fc4e5fc73ab9b0887591135ec01adde990edd6f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/64361
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Shrek Shao <shrekshao@google.com>
2021-09-15 19:22:19 +00:00
Brandon Jones 020d69905e Added Abseil as a third-party dependency
Using the version in the Chromium repo in order to make use of the .gn
files it contains.

Doing so also appears to require us to switch where we pull googletest
from so that the directory structure matches what the Abseil build
config expects. Fortunately this doesn't seem to cause issues in our
tests.

Bug: dawn:563
Change-Id: I55831ad33f282b3d8b03b67826fd2776e5602d89
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/63780
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Brandon Jones <bajones@chromium.org>
2021-09-14 16:56:15 +00:00
Maksim Sisov 08949a3fe7 rename use_x11 to ozone_platform_x11
Ozone is default now in Chromium and non-Ozone/X11 (aka use_x11) is
deprecated. During the transition period use_x11 == ozone_platform_x11.

Bug: c/1096425
Change-Id: Iaec1bd171423936f5a1817fae08a72079faf16fc
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/63840
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
2021-09-10 06:08:41 +00:00
Corentin Wallez 220ff07ffd dawn_native: Add a force_wgsl_step toggle.
This makes SPIRV ingestion always go through a SPIRV->WGSL step first.
This will be used to make sure that path works correctly on existing
WebGPU SPIRV sites so we're confident the SPIRV->WGSL translation will
work when compiled to WASM.

Bug: dawn:960
Change-Id: I17efd8c64d9d60ff033ba89b8fff9295e66524ef
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/56080
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
2021-06-28 10:23:08 +00:00
Corentin Wallez 9e252c0536 Use .gn to set overrides for VulkanMemoryAllocator
Bug: tint:700
Bug: chromium:1195554
Change-Id: I937a1123ff677dfe1c40891d8cbd1c10d9def1e3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/46864
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2021-04-06 16:54:19 +00:00
Corentin Wallez e98e857a69 Add build_overrides/vulkan_memory_allocator.gni
After https://chromium-review.googlesource.com/c/external/github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator/+/2804453
the VulkanMemoryAllocator dependency will start including this config
file to get the position of the vulkan-headers.

Also factor common vulkan variables to vulkan_common.gni like is done
in Chromium.

Bug: tint:700
Bug: chromium:1195554

Change-Id: Idbb8b957c17b2cbdbd518c13706d02ef4d74e93f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/46862
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2021-04-06 12:01:58 +00:00
Corentin Wallez 9037669b2e Remove the dependency on shaderc and glslang.
With all tests converted to WGSL we only use shaderc to assemble SPIRV
assembly to binary. shaderc requires glslang but we don't use it at all.
By using SPIRV-Tools directly to assemble SPIR-V, we can remove both the
shaderc and glslang dependencies.

Bug: dawn:572
Bug: chromium:1150045
Change-Id: I1588428dfb9478e7b724478bec662d002ee920e0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/45765
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
2021-03-24 16:02:13 +00:00
Michael Achenbach 4a110c2726 Remove obsolete GN config
Bug: chromium:1164276
Change-Id: Ia5ec6f2d6d93d542e7f25b82ee04561958b7b4c8
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/38000
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Commit-Queue: dan sinclair <dsinclair@chromium.org>
2021-01-18 15:25:23 +00:00
Corentin Wallez 1457ecbcaf Remove obsolete build flag.
No longer necessarry: "linux_use_bundled_binutils_override"

Bug: chromium:1164276
Change-Id: Id5d27b427e91204e71a74da572f3f369630ae54b
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/37201
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
2021-01-11 18:27:52 +00:00
Stephen White 77fcdf7eaa Add ANGLE to Dawn build.
Bug: dawn:447, dawn:580
Change-Id: I77726651ca00d64768bddc0bb476fd920e11851f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/35081
Commit-Queue: Stephen White <senorblanco@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2021-01-11 15:52:12 +00:00
Stephen White f1fa60b912 Use Jamie's 7-layer burrito of Vulkan DEPS.
This allows us to roll all Vulkan- and SPIRV-related dependencies
simultaneously (which are often inter-dependent).

This change also implicitly rolls the dependencies to the revs in ANGLE.

Change-Id: I50a1e5b2ef706ffbfbc22f5783321820bb50ae96
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/36500
Commit-Queue: Stephen White <senorblanco@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2021-01-06 17:41:50 +00:00
Ryan Harrison da5828c06b Add Tint SPIRV->SPIRV to fuzzing code path
Since we are intending to ship using Tint for normalization, fuzzing
should include this transform.

BUG=dawn:531

Change-Id: Ica25c3bbdc6ff392d5e31361734de43fd1c12815
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/29180
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
2020-09-30 17:50:14 +00:00
Ryan Harrison b44ca92f1c Roll 4 dependencies
Roll third_party/shaderc/ b6c82a149..011139094 (5 commits)

b6c82a149e..011139094e

$ git log b6c82a149..011139094 --date=short --no-merges --format='%ad %ae %s'
2020-09-03 rharrison Adding back non-spvc BUILD.gn that I accidentally nuked ()
2020-09-03 rharrison Remove spvc ()
2020-09-02 rharrison Start SPIRV-Tools v2020.4
2020-09-02 rharrison Finalize SPIRV-Tools v2020.3
2020-09-01 rharrison Roll 3 dependencies and update expectations ()

Created with:
  roll-dep third_party/shaderc

Roll third_party/spirv-cross/ 685f86471..bad9dab8d (4 commits)

685f86471e..bad9dab8df

$ git log 685f86471..bad9dab8d --date=short --no-merges --format='%ad %ae %s'
2020-08-27 cdavis MSL: Support layered input attachments.
2020-09-02 post MSL: Fix OpCompositeInsert and OpVectorInsertDynamic.
2020-08-23 cdavis MSL: Don't set the layer for multiview if the device doesn't support it.
2020-08-07 cdavis MSL: Fix multiview view index calculation with a non-zero base instance.

Created with:
  roll-dep third_party/spirv-cross

Roll third_party/SPIRV-Tools/ 8a0ebd40f..fd05605be (8 commits)

8a0ebd40f8..fd05605bef

$ git log 8a0ebd40f..fd05605be --date=short --no-merges --format='%ad %ae %s'
2020-09-03 stefanomil spirv-fuzz: Transformation to convert OpSelect to conditional branch ()
2020-09-02 46493288+sfricke-samsung spirv-val: Add Vulkan VUID labels to BuiltIn ()
2020-09-02 vasniktel spirv-fuzz: Add support for BuiltIn decoration ()
2020-09-02 stefanomil spirv-fuzz: Fix GetIdEquivalenceClasses ()
2020-09-02 stefanomil spirv-fuzz: Replace id in OpPhi coming from a dead predecessor ()
2020-09-01 stefanomil spirv-fuzz: Transformation to replace the use of an irrelevant id ()
2020-09-01 vasniktel spirv-fuzz: TransformationMutatePointer ()
2020-09-01 stefanomil spirv-fuzz: Compute interprocedural loop nesting depth of blocks ()

Created with:
  roll-dep third_party/SPIRV-Tools

Roll third_party/tint/ 464928ed9..e7ec7f168 (17 commits)

https://dawn.googlesource.com/tint/+log/464928ed913b..e7ec7f16895a

$ git log 464928ed9..e7ec7f168 --date=short --no-merges --format='%ad %ae %s'
2020-09-03 dsinclair [wgsl-writer] Add GenerateEntryPoint
2020-09-03 dsinclair Stub out the method to generate individual entry points.
2020-09-03 dsinclair Add reset method to the generators.
2020-09-03 dsinclair Move generators to unique pointers.
2020-09-02 sarahmashay [validation] Add disabled tests for validating switch statements
2020-09-02 tommek [wgsl-reader] Parsing sampled texture type
2020-09-02 dsinclair [hlsl-writer] Simplify generated logical and/or expressions.
2020-09-02 dsinclair [hlsl-writer] Simplify logical and/or code.
2020-09-02 dsinclair [hlsl-writer] More logical and/or tests.
2020-09-02 dsinclair [hlsl-writer] Emit LogicalAnd and LogicalOr operations
2020-09-02 dsinclair [hlsl-writer] Support pre stream in if/else statements.
2020-09-02 dsinclair [hlsl-writer] Emit pre strings
2020-09-02 dsinclair [hlsl-writer] Update all expressions to take a pre stream.
2020-09-02 tommek [wgsl-reader] Parsing texture sampler types
2020-09-02 dsinclair Fixup doxygen comment
2020-09-02 tommek [wgsl-reader] Parsing depth texture type
2020-09-02 tommek [wgsl-reader] Parsing sampler type

Created with:
  roll-dep third_party/tint

Change-Id: I34e0e77b0f3d1b8050d465fa20e6846ef573c092
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/28140
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
2020-09-03 15:36:37 +00:00
Ryan Harrison c5cd8f5bd3 Remove binutils from DEPS and pull in changes to build.gni from Dawn
Change-Id: Id9855ccf133b50f406443c37b74f12ff1d9206fe
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/25560
Reviewed-by: dan sinclair <dsinclair@chromium.org>
2020-07-28 17:57:53 +00:00
Ryan Harrison 4f3811c064 Add Tint to BUILD.gn
Tint is behind a build flag, since Tint is not yet available in
chromium's third_party.

BUG=dawn:403

Change-Id: If5fa36b36216ef6965341b886c3bd70d27daf23a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/21300
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
2020-05-07 21:15:55 +00:00
Corentin Wallez 0925720ecb Add the Vulkan loader as an optional dependency and use it on Mac
On macOS we can't rely on having the Vulkan loader installed in the
system. So we add the Vulkan loader as an optional dependency of Dawn
and use it on macOS when building Dawn in standalone with Vulkan
support.

Usage of building our own loader might broaden if the loader gains
features that are useful on other OSes. For example the ability to pass
in the "root ICD" entrypoint to the loader so we can have both
Swiftshader and the system driver at the same time.

Bug: dawn:388

Change-Id: I7ade4961cce0463c66846ad17aebf95224f1afcc
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19723
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2020-04-17 08:22:25 +00:00
Corentin Wallez 955f8a37cc Rolling 2 dependencies
Also adds build_overrides for [vulkan_]use_x11 that are now needed for
these deps.

Roll third_party/vulkan-headers/ d287523f4..e01f13e1f (20 commits)

d287523f48..e01f13e1f7

$ git log d287523f4..e01f13e1f --date=short --no-merges --format='%ad %ae %s'
2020-04-07 oddhack Update for Vulkan-Docs 1.2.137
2020-04-06 devrel Update README.md with warning of pending header changes
2020-03-24 oddhack Update for Vulkan-Docs 1.2.136
2020-03-17 oddhack New include file with provisional extension interfaces (those interfaces not aliased by promoted-from APIs, at least).
2020-03-17 oddhack Update for Vulkan-Docs 1.2.135
2020-03-06 oddhack Update for Vulkan-Docs 1.2.134
2020-02-15 oddhack Update for Vulkan-Docs 1.2.133
2020-01-21 oddhack Update for Vulkan-Docs 1.2.132
2020-01-14 oddhack Update for Vulkan-Docs 1.2.131
2019-11-14 flibitijibibo GN: Make PLATFORM_XCB optional, based on a user-defined variable.
2019-12-09 oddhack Update for Vulkan-Docs 1.1.130
2019-11-25 oddhack Update for Vulkan-Docs 1.1.129
2019-11-21 mark build: Clarify Windows build instructions
2019-11-18 oddhack Update for Vulkan-Docs 1.1.128
2019-11-05 jmadill GN: Add support for Google Games Platform.
2019-10-25 8729214+jonahryandavis build: BUILD.gn missing defines for MacOS
2019-11-03 oddhack Update for Vulkan-Docs 1.1.127
2019-10-28 shannon vulkan: Fix typo for `operator==` in `vulkan.hpp`
2019-10-25 shannon vulkan: Update `vulkan.hpp` for VS2015 VT fix
2019-10-21 oddhack Update for Vulkan-Docs 1.1.126

Roll third_party/vulkan-validation-layers/ 237d818e8..1533266ea (553 commits)

237d818e81..1533266eac

$ git log 237d818e8..1533266ea --date=short --no-merges --format='%ad %ae %s'
2020-04-08 lionel.g.landwerlin Validate blending on color attachment without blending support
2020-03-03 mark scripts: Some validation-stats cleanup and update
2020-04-09 petr_kraus tests: Remove mock workarounds for vkAcquire
2020-04-09 s.fricke layers: Update AHB to Android Q and better logging
2020-04-14 mark test: Temporarily disable AHBCreateImageView test
2020-04-13 jzulauf layers: Add missing WaitSemaphores (KHR/not) entry
2020-04-13 petr_kraus layers: Add missing instance chassis locks
2020-04-06 s.fricke tests: Add support for VUID 02261 and 02262
2020-04-06 s.fricke layers: Add support for VUID 02261 and 02262
2020-04-06 s.fricke layers: Fix general external AHB tracking
2020-04-09 peter.griffin layers: Silence expected GCC warning
2020-04-09 rgarcia layers: Take separate stencil usage flags into account
2020-04-13 mark practices: Fix typo in message output
2020-04-10 mark practices: Avoid VertexInputState checks when using mesh shdrs
2020-04-10 mark tests: Revert "Remove MockICD workarounds in instanceless"
2020-04-10 charles docs: Suggest disabling validation with debug printf
2020-04-09 shannon build: Update known-good files for 1.2.137 header
2020-04-10 mark scripts: Allow clean-repo to work on empty directories
2020-04-10 mark tests: Fix rebasing error in multi-instance test
2020-04-09 mark corechecks: Stringstream can take strings natively
2020-04-09 mark layers: Removed redundant helper function
2020-04-09 mark corechecks: Normalize stringstream message output
2020-04-09 mark layers: Update FormatHandle to use stringstream
2020-04-09 mark corechecks: Fixed bad handle formats in descriptor_sets
2020-04-05 petr_kraus tests: Add multiple instance creation test
2020-04-08 petr_kraus tests: Remove MockICD workarounds in instanceless
2020-04-07 petr_kraus tests: Simplify device extension filtering
2020-04-07 petr_kraus tests: Expect VK_INCOMPLETE from pd enumeration
2020-04-04 petr_kraus tests: Remove commented code and issues
2020-03-31 petr_kraus tests: Add some instance checks
2020-04-02 petr_kraus tests: Refactor the test framework
2020-04-10 lionel.g.landwerlin Add validation for new performance query reset VUID 02863
2020-02-18 lionel.g.landwerlin Rework performance query validation
2020-02-18 lionel.g.landwerlin layers: record reset queries in state tracker
2020-04-10 lionel.g.landwerlin tests: fix incorrect/missing reset of performance queries
2020-04-09 mikes scripts: update_deps.py always pass -A on Windows
2020-04-09 mark scripts: Fix --clean-repo for read-only files
2020-04-07 mark build: Add blurb for using update_deps to change architectures
2020-04-08 s.fricke tests: Add disjoint bindImageMemory VUID
2020-04-08 s.fricke tests: Move tests to BindInvalidMemoryYcbcr
2020-04-08 s.fricke layers: Add disjoint bindImageMemory VUID
2020-04-09 s.fricke Add Documentation about writing tests
2020-04-09 mikes scripts: BP skip vkEnumerateInstanceVersion
2020-04-07 tony layers: Don't remove container contents during iteration
2020-04-07 mikes layers: Fix operator= recursion
2020-04-06 mikes layers: GCC -Wignored-qualifiers warning
2020-04-06 mikes layers: GCC -Wdeprecated-copy warning
2020-04-06 s.fricke tests: Add PhysicalDeviceFormatProperties2 for Device Profile API
2020-04-03 tony tests: Fix extraneous errors
2020-04-03 tony layers: Fix error message
(...)
2019-11-01 camden CMake: Add vklayertests_best_practices.cpp to CMake
2019-11-01 camden layers: Remove DrawCmd perf warning from Buf Val
2019-10-16 camden layers: Add DrawCmd perf warning to Best Practices
2019-11-12 mark tests: Verify reset/use of qpool in different command buffers
2019-11-13 mark corechecks: Enable querystate tracking across multiple submitInfos
2019-11-12 tony tests: Add mechanism to deal with duplicate errors
2019-11-11 mark tests: Add secondary CB VkSubmitInto validation check
2019-11-11 mark corechecks: Add secondary CB VU check
2019-11-11 mark corechecks: Fix propagation of skip in CB state validation
2019-11-12 mark build: Add VUID coverage text file to AppVeyor artifacts
2019-10-28 pdaniell tests: Add tests for VK_KHR_separate_depth_stencil_layouts
2019-10-16 PDANIELL layers: Add support for VK_KHR_separate_depth_stencil_layouts
2019-11-05 shannon build: Update known-good for 1.1.127 header
2019-11-04 jbolz layers: Update ValidateShaderStageInputOutputLimits to new spec rules
2019-11-01 mark cmake: Restore creation of standard validation json file
2019-08-21 jmacnak tests: Add RT shader group tests
2019-08-21 jmacnak layers: Add RT shader group validation
2019-10-30 mikes tests: Add macOS loader filename
2019-10-25 locke tests: Swapchain image layout
2019-10-28 locke layers: Swapchain pluarl bound_images
2019-09-27 tony gpu: Add more positive tests
2019-10-29 mark tests: Remove android limits workaround
2019-10-28 mark tests: Allow hw limits to override baked-in test GL limits
2019-10-28 bob Android: Make tests more reliable
2019-10-25 shannon build: Update known-good commits for SDK 126
2019-10-09 jeremy layers: Fix attachment unused false positive
2019-10-23 mark tests: Exclude GetomInputOutputComps limit test from Android
2019-10-23 mark tests: Fix filter key for shaderc failure messages
2019-10-16 camden layers: best_practices-Fix MemoryFree Exception
2019-10-16 camden layers: Initialize numMemObjects in BP
2019-08-16 jeremy layers: Validate specialization constants
2019-10-11 jeremy build: Update glslang
2019-10-24 mark layers: Removed obsolete layer-specific readme file
2019-10-24 mark docs: Add layer configuration doc, shared with the SDK
2019-10-23 jbolz tests: Add tests for externsync descriptorset updates
2019-10-23 jbolz layers: Relax UPDATE_AFTER_BIND externsync rules in ThreadSafety
2019-10-23 bob tests: Don't filter logcat messages
2019-10-21 shannon build: Update known-good for 1.1.126 header
2019-10-22 jbolz tests: Test CmdTraceRays with no descriptor set bound
2019-10-22 jbolz layers: Add PreCallValidateCmdTraceRaysNV
2019-10-07 locke tests: Catch the error in QueueSubmit
2019-09-30 locke layers: Check in QueueSubmit
2019-09-26 locke layers: Validate DescriptorSet Binding data
2019-10-20 jbolz tests: Add tests for ValidateEventStageMask
2019-10-20 jbolz layers: Move event/query Updates to PostCallRecordQueueSubmit
2019-09-26 jessehall layers: Check exts against required core versions
2019-09-25 jessehall layers: Add VK_KHR_spirv_1_4 validation
2019-10-17 mikes build: Add missing X11 option to GN overrides
2019-10-17 tobine build:Add VK_USE_PLATFORM_XLIB_KHR for x11
2019-10-03 emanuele.dallalonga corechecks: Fix ValidateImageBarrierAttachment resource search

Created with:
  roll-dep third_party/vulkan-headers third_party/vulkan-validation-layers

Bug: dawn:388

Change-Id: I5cefd0511af937897291644acb266f20efec66cc
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19721
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2020-04-16 17:24:16 +00:00
Ryan Harrison d1cf8a8ba5 Add support for SPIRV reading to BUILD.gn
BUG=dawn:16

Change-Id: I1da30fed82a310007674801e3b1e853b25d5b573
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/19640
Reviewed-by: dan sinclair <dsinclair@google.com>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
2020-04-15 20:35:38 +00:00
Corentin Wallez d11cc3961a Split third_party/BUILD.gn in per-project files.
Bug: chromium:1064305

Change-Id: I6fc2da97e20865b62ff34a9d1c3f42120ac90348
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/19202
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
2020-04-10 08:24:00 +00:00
Ryan Harrison 2962888b8c Add in basic BUILD.gn and additional DEPS
This is a minimal config that gets us building the tint binary from samples/

BUG=tint:2

Change-Id: Ifafa903e99a34f1c47177eb954df69ecbe70cb36
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/19106
Reviewed-by: dan sinclair <dsinclair@google.com>
2020-04-08 20:40:25 +00:00
Corentin Wallez 30ec4fc626 Fixes to be able to build Dawn inside Skia
Add a dawn_has_build override similarly to angle_has_build that makes
Dawn not depend on Chromium //build if it can avoid it. (this was
previously used for mac_sdk.gni).

Only load the Vulkan Validation Layers' gni if it is enable via
dawn_enable_vulkan_validation_layers.

Fix a GN build warning where the source of dawn_components would be
built twice: for example libdawn_native.MetalBackend.o would be built
once for libdawn_native static and once for libdawn_native shared. Fix
this by making libdawn_native as a static library libdawn_native_static.

Change-Id: Ib8fb72282435eb475d7a11dae0d5a9977572fd57
Bug: chromium:1064305
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/18963
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
2020-04-07 19:35:47 +00:00
Corentin Wallez ddc5cacc27 GN: Use the hermetic XCode if available.
This matches Chromium's logic and make it less likely to break developer
workflow in the subsequent roll of Chromium's buildtools.

Bug: dawn:339
Change-Id: Ic42553827be125985a3d16b4f5d003b6662ead39
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/16520
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2020-03-06 12:25:20 +00:00
Austin Eng 2cb76ab598 perf_tests: Manually serialize JSON and remove dependency on jsoncpp
jsoncpp causes some flaky failures because of inconsistencies in nested
DEPS. We barely use it for JSON serialization so the simplest solution
is to just manually write the serialization for perf test tracing data.

Bug: dawn:208
Change-Id: Ie5e4b5436e2c9e32e6817d64c6e95c774cb8751f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/14720
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
2019-12-20 19:39:10 +00:00
Ryan Harrison 2559fc0b84 Removing for_fuzzers target
Also update shaderc override to be the correct directory

BUG=dawn:285

Change-Id: I021755bbc8f50daa65b6964f3e42d395b51bb94a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/14080
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
2019-11-27 15:07:53 +00:00
Corentin Wallez 74cebd6879 Allow using swiftshader with the Vulkan backend
This adds swiftshader as a dependency of Dawn, and when it is present
dawn_use_swiftshader=true will force usage of it. (due to a Vulkan
loader limitation we can't have both regular drivers and swiftshader in
the same VkInstance).

BUG=dawn:283

Change-Id: Ib94f4dcca652eb380e994f007cdcfb145b1a5102
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/13440
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2019-11-26 18:21:51 +00:00
Ryan Harrison 80d71ecd12 Remove build rules for spvc support & spirv-cross fuzzers
Disabling this while refactoring how dependencies are set up to avoid
breaking various builds and rolls.

BUG=dawn:285

Change-Id: Iaca2614fb73277a1ea850f90a487693cd4c54fcb
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/14040
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
2019-11-26 17:42:51 +00:00
Li, Hao 0e1bef3251 Add Vulkan validation layers on Windows
Deploy self-built Vulkan validation layers instead of system installed
one. And it will reuse third_party/angle's Vulkan validation layers if
building with chromium.

Bug: dawn:150
Change-Id: I94e26f7a152fb2a1c39bcb102d60024f4d65eee6
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/11120
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-11-07 12:13:27 +00:00
Austin Eng 92a011a253 Record and dump trace events in the perf tests
Trace data can be used to build additional metrics which measure
validation costs, GPU time, etc. It will also be helpful to store in
the test output for later analysis.

This CL also adds jsoncpp as a DEP so we can dump trace file json
output.

Bug: dawn:208
Change-Id: Ia6c05ca90aecae308ee6a4fd11e5f43bb03b1dc9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/12080
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
2019-10-17 19:00:32 +00:00
Ryan Harrison 16d20837cc Roll ahead to fix and update .gni to unbreak shaderc
Roll third_party/spirv-cross/ 5431e1da2..e5d3a6655 (8 commits)

5431e1da2d..e5d3a6655e

$ git log 5431e1da2..e5d3a6655 --date=short --no-merges --format='%ad %ae %s'
2019-10-07 rharrison Update SPV_VERSION from 1.4 to 1.5
2019-10-07 post Workaround MSVC issue.
2019-10-07 post Do not consider aliased struct types if the master is not a block.
2019-10-07 post Run format_all.sh.
2019-10-04 post Do not value compare JSON files for regression purposes.
2019-10-04 post Reflect: Deal with workgroup size being specialization constants.
2019-10-03 frank.richter reference: Update to include workgroup_size
2019-10-03 frank.richter reflection: Write workgroup_size to JSON for compute shaders

Created with:
  roll-dep third_party/spirv-cross

Roll third_party/shaderc/ e849e6783..621605ce2 (10 commits)

$ git log e849e6783..621605ce2 --date=short --no-merges --format='%ad %ae %s'
2019-10-08 rharrison Fix various build issues for chromium & dawn ()
2019-10-08 stevenperron Use a better python idiom ()
2019-10-08 stevenperron Fix up use of private spirv-tools headers. ()
2019-10-07 rharrison Roll spirv-cross ahead and update known_failures to fix build breakage ()
2019-10-07 9856269+sarahM0 spvc: Add an empty opt pass ()
2019-10-07 9856269+sarahM0 spvc: Add known_invalid file ()
2019-10-04 dneto Add support for targeting SPIR-V 1.5 ()
2019-10-03 rharrison Revert "Add spvc compiler to returned result ()" ()
2019-10-03 rharrison Add spvc compiler to returned result ()
2019-10-02 rharrison Rolling 4 dependencies ()

Created with:
  roll-dep third_party/shaderc

Change-Id: I9e77d5c78eb647c1f117c356306e6dff7613722a
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/11963
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
2019-10-09 14:40:10 +00:00
Frank Henigman 8d7de591f4 Tell shaderc where to find SPIRV-Cross.
Set a variable in build_overrides that gives the location of shaderc's
new SPIRV-Cross dependency.  The variable will take a different value
for a chrome build.

BUG=chromium:915096

Change-Id: I92d29cee0bac4a968bffba5c2fd9bb02c040de52
Reviewed-on: https://dawn-review.googlesource.com/c/3301
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>
2018-12-14 20:33:50 +00:00
Corentin Wallez 16092faa16 Roll shaderc and glslang and use their BUILD.gn
This rolls glslang and shaderc to be able to use their BUILD.gn files,
and also rolls SPIRV-Tools and spirv-headers to have compatible
versions.

BUG=chromium:870747

Change-Id: I13c615f6f3d148c9b69f06547992bf5910e04e62
Reviewed-on: https://dawn-review.googlesource.com/c/1680
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-10-04 17:17:57 +00:00
Corentin Wallez 76664ed8d0 BUILD.gn: Make dawn_standalone default to false
BUG=chromium:870747

Change-Id: I9d80bb8a73227a9a9e5a7c466ac5b40a10fc0106
Reviewed-on: https://dawn-review.googlesource.com/1641
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2018-09-25 21:52:44 +00:00
Corentin Wallez ca81bd3481 GN: Use hermetic builds on Linux
This makes the Linux GN builds use the Chromium copy of binutils and
also makes all platforms use the "custom libcxx" which is libc++.

We do this so that the build doesn't depend on anything from the system
on Linux because our bots are still on trusty with very old libstdc++
and linkers.

Change-Id: I0570fb474f2945c3565e78a56aba66c1a2619afc
2018-09-05 05:18:10 -04:00
Corentin Wallez 3bb0bb940e Generator,BUILD.gn: add optional python path, use it for Jinja2
This makes the Jinja2 (and MarkupSafe) installation hermetic by
adding it to the DEPS and making the code generator add them in the
first spot of the python path.
2018-08-14 21:42:32 +02:00
Corentin Wallez 649e2feda4 Add GN build for tests and their third party deps. 2018-08-09 20:54:43 +02:00
Corentin Wallez 5aea8d15be BUILD.gn: Use idiomatic string substitution 2018-08-06 21:39:17 +02:00