David Neto
889b77a2a1
writer: avoid type breakage during AppendVector ...
When building a vector via tint::writer::AppendVector, and the
vector argument is already a vector constructor, expand that
vector constructor into its components only when those components
are all scalars. This avoids a type breakage which can occur with cases
like this:
vector argument is:
vec2<i32>(vec2<u32>(0u,1u))
scalar argument is:
2
Before this fix, the result was:
vec2<i32>(0u, 1u, 2);
But should be this instead:
vec3<i32>(vec2<u32>(0u,1u),2)
This was noticed in SPIR-V writer output when forming a coordinate
vector from a an unsigned WGSL coordinate vector with a signed array
vector.
Fixed: tint:1048
Change-Id: Id46665739cc23da0ca58b9baabf7b4531b86350b
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/60040
Auto-Submit: David Neto <dneto@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: David Neto <dneto@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
2021-07-28 16:31:36 +00:00
2021-07-13 16:41:56 +00:00
2021-07-13 16:41:56 +00:00
2021-07-13 16:41:56 +00:00
2021-07-13 16:41:56 +00:00
2021-07-13 16:41:56 +00:00
2021-06-29 18:39:44 +00:00
2021-06-16 09:19:36 +00:00
2021-06-21 08:49:27 +00:00
2021-06-10 17:34:44 +00:00
2021-07-26 22:11:58 +00:00
2021-06-16 09:50:11 +00:00
2021-06-16 09:50:11 +00:00
2021-06-16 09:50:11 +00:00
2021-06-16 09:50:11 +00:00
2021-06-16 09:50:11 +00:00
2021-07-06 10:20:19 +00:00
2021-06-16 09:19:36 +00:00
2021-06-30 16:01:40 +00:00
2021-06-16 09:19:36 +00:00
2021-06-16 09:19:36 +00:00
2021-07-08 12:00:31 +00:00
2021-07-08 12:00:31 +00:00
2021-07-08 12:00:31 +00:00
2021-07-08 12:00:31 +00:00
2021-07-08 12:00:31 +00:00
2021-07-06 10:20:19 +00:00
2021-07-16 19:47:44 +00:00
2021-06-10 18:49:14 +00:00
2021-06-23 17:35:42 +00:00
2021-06-23 17:35:42 +00:00
2021-06-10 18:49:14 +00:00
2021-07-26 11:46:47 +00:00
2021-07-26 11:46:47 +00:00
2021-07-26 11:46:47 +00:00
2021-07-26 11:46:47 +00:00
2021-06-29 18:39:44 +00:00
2021-07-26 11:46:47 +00:00
2021-07-26 11:46:47 +00:00
2021-07-26 11:46:47 +00:00
2021-07-26 11:46:47 +00:00
2021-06-29 18:39:44 +00:00
2021-06-16 09:19:36 +00:00
2021-06-18 09:47:23 +00:00
2021-06-10 17:34:44 +00:00
2021-07-26 22:11:58 +00:00
2021-06-29 22:07:44 +00:00
2021-07-14 18:43:51 +00:00
2021-07-08 21:23:33 +00:00
2021-06-30 15:06:00 +00:00
2021-07-08 21:23:33 +00:00
2021-06-04 20:41:47 +00:00
2021-07-13 12:18:13 +00:00
2021-07-08 21:23:33 +00:00
2021-06-04 22:17:37 +00:00
2021-07-08 21:23:33 +00:00
2021-05-17 21:01:37 +00:00
2021-07-13 12:18:13 +00:00
2021-06-29 14:38:56 +00:00
2021-06-29 14:38:56 +00:00
2021-06-29 14:38:56 +00:00
2021-06-29 18:39:44 +00:00
2021-07-28 16:31:36 +00:00
2021-07-08 21:23:33 +00:00
2021-07-28 16:31:36 +00:00
2021-07-08 21:23:33 +00:00
2021-06-10 18:49:14 +00:00
2021-06-16 09:19:36 +00:00
2021-06-10 18:49:14 +00:00
2021-06-10 18:49:14 +00:00
2021-06-10 18:49:14 +00:00
2021-05-17 21:01:37 +00:00
2021-07-05 15:20:57 +00:00
2021-06-16 09:19:36 +00:00
2021-05-18 09:24:18 +00:00
2021-05-18 09:24:18 +00:00
2021-06-10 18:49:14 +00:00
2021-06-10 18:49:14 +00:00
2021-06-10 18:49:14 +00:00
2021-06-10 18:49:14 +00:00
2021-06-10 18:49:14 +00:00
2021-06-10 18:49:14 +00:00
2021-06-10 18:49:14 +00:00
2021-06-10 18:49:14 +00:00
2021-06-10 18:49:14 +00:00
2021-06-10 18:49:14 +00:00
2021-06-16 17:42:53 +00:00
2021-07-05 15:20:57 +00:00
2021-06-16 17:42:53 +00:00
2021-06-16 17:42:53 +00:00
2021-06-16 17:42:53 +00:00
2021-06-16 17:42:53 +00:00
2021-06-16 17:42:53 +00:00
2021-06-16 17:42:53 +00:00
2021-06-16 17:42:53 +00:00
2021-06-16 17:42:53 +00:00
2021-06-29 18:39:44 +00:00
2021-06-30 08:51:36 +00:00
2021-06-17 09:10:04 +00:00
2021-06-16 09:19:36 +00:00
2021-06-29 18:39:44 +00:00
2021-06-16 09:50:11 +00:00
2021-07-16 19:47:44 +00:00
2021-06-17 09:10:04 +00:00
2021-06-17 09:10:04 +00:00
2021-06-17 09:10:04 +00:00
2021-06-19 08:18:50 +00:00
2021-07-28 16:31:36 +00:00
2021-06-28 15:30:57 +00:00
2021-06-19 08:18:50 +00:00
2021-06-19 08:18:50 +00:00
2021-06-19 17:34:35 +00:00
2021-07-13 12:18:13 +00:00
2021-07-08 21:23:33 +00:00
2021-06-19 17:34:35 +00:00
2021-07-08 21:23:33 +00:00
2021-06-29 10:23:26 +00:00
2021-07-16 19:47:44 +00:00
2021-06-29 10:23:26 +00:00
2021-06-29 10:23:26 +00:00
2021-06-29 10:23:26 +00:00
2021-06-29 18:39:44 +00:00
2021-07-09 16:50:14 +00:00
2021-07-05 15:56:32 +00:00
2021-06-24 19:01:06 +00:00
2021-06-29 18:39:44 +00:00
2021-07-05 17:18:16 +00:00
2021-07-13 12:18:13 +00:00
2021-07-08 21:23:33 +00:00
2021-07-05 17:18:16 +00:00
2021-07-08 21:23:33 +00:00
2021-07-02 22:17:25 +00:00
2021-07-13 12:18:13 +00:00
2021-07-06 09:43:49 +00:00
2021-07-02 22:17:25 +00:00
2021-07-02 22:17:25 +00:00
2021-07-02 22:17:25 +00:00
2021-07-13 12:18:13 +00:00
2021-07-21 14:11:01 +00:00
2021-07-21 14:11:01 +00:00
2021-07-02 22:17:25 +00:00
2021-07-02 22:17:25 +00:00
2021-07-13 12:18:13 +00:00
2021-07-02 22:17:25 +00:00
2021-07-02 22:17:25 +00:00
2021-07-02 22:17:25 +00:00
2021-07-06 09:43:49 +00:00
2021-07-13 12:18:13 +00:00
2021-07-06 09:43:49 +00:00
2021-07-06 09:43:49 +00:00
2021-07-06 09:43:49 +00:00
2021-07-15 22:36:44 +00:00
2021-07-21 14:11:01 +00:00
2021-07-21 14:11:01 +00:00
2021-07-21 14:11:01 +00:00
2021-07-21 14:11:01 +00:00
2021-07-14 18:01:36 +00:00
2021-07-14 18:01:36 +00:00
2021-07-14 18:01:36 +00:00
2021-07-14 18:01:36 +00:00
2021-07-14 18:01:36 +00:00
2021-07-14 18:43:51 +00:00
2021-07-14 18:43:51 +00:00
2021-07-14 18:43:51 +00:00
2021-07-14 18:43:51 +00:00
2021-07-14 18:43:51 +00:00
2021-07-15 22:20:29 +00:00
2021-07-15 22:20:29 +00:00
2021-07-15 22:20:29 +00:00
2021-07-15 22:20:29 +00:00
2021-07-15 22:20:29 +00:00
2021-07-18 15:41:25 +00:00
2021-07-18 15:41:25 +00:00
2021-07-18 15:41:25 +00:00
2021-07-18 15:41:25 +00:00
2021-07-18 15:41:25 +00:00
2021-07-15 20:29:09 +00:00
2021-07-15 20:29:09 +00:00
2021-07-15 20:29:09 +00:00
2021-07-15 20:29:09 +00:00
2021-07-15 20:29:09 +00:00
2021-07-15 20:29:09 +00:00
2021-07-26 11:46:47 +00:00
2021-07-15 20:29:09 +00:00
2021-07-15 20:29:09 +00:00
2021-07-15 20:29:09 +00:00
889b77a2a1