This way the string will take into the account the total size of the
string view instead of effectively running strlen() over the pointer,
allowing non-null-terminated strings to properly work.
This way we don't have a case where incorrect values are implicitly
converted to the error value of zero (i.e. we shouldn't even accept
bogus strings like "0xzzz")
Not the most ideal UX, but this is still better than not doing anything
about it.
Previously the resource browser required you to double click on
everything in order to interact with it (going into directories, or
launching handlers for particular files, etc).
This is kinda stinky workflow-wise long-term when flipping between
assets; so we can make the interface a little less mouse-centric by
allowing the use of the enter keys to also perform the same behavior.
In addition to API improvements and security fixes, this also makes zlib
buildable using CMake 4.0+, since it removes backwards compatibility for
older CMake versions.
Migrate over to Qt 6 so that we can keep the UI toolkit pegged at the
current major version.
Unfortunately this also means we have to gut a small feature in the
progress dialogs, since the extras module doesn't exist in Qt6 anymore.
Few things of note:
QVector<> is internally an alias of QList now, so any changeover is due
to that to make the semantics a little clearer.
QtConcurrent requires arguments to be swapped on some invocations, and
discarding instances need to use the global thread pool instead.
fromStdList(), etc can be replaced with range constructors.
--no-angle and other commands are removed from newer versions of
windeployqt
QVariant::Invalid (and other type IDs) are deprecated and also break
existing functionality. Instead we can return default constructed
QVariants where applicable, which restores functionality that would be
broken if left as is (e.g. many list would straight up not populate or
have wonky size hinting).
The reason for this is that the QVariant(QVariant::Type) constructor
models a unique kind of internal QVariant state where it's considered
to be in an invalid state, but accessing the (supposedly) invalid state
will instead return a default constructed value of the internal type.
This kinda sucks because this means genuinely invalid states that would
warrant an assertion or other type of error would be silently ignored
and execution would continue on as normal, so this also enforces
correctness a little bit (on top of, well, fixing all the broken UI
controls).